[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Feb 19 13:08:52 CET 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692
Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is a bit too minimal for what I was thinking.. we should test the failure
case.. in the Koha::Account case the 'new' routine requires the patron_id to be
passed and croaks on failure (really we should probably switch this to a
Koha::Error object, but that's another story)..
So, for tests I would hope to see a mini subtest which tests for two cases for
now.. using Test::Warn to catch the croak in the no patron_id passed case and a
positive outcome if patron_id is passed.. in reality 'new' should also fail if
patron_id is incorrect, but again, that's a future piece.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list