[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Josef Moravec from comment #36)
> I am sorry, but the tests are still not passing:
> 
> t/db_dependent/Koha/Patrons.t .. 10/33 DBD::mysql::st execute failed: Field
> 'type' doesn't have a default value [for Statement "INSERT INTO
> `account_offsets` ( `amount`, `debit_id`) VALUES ( ?, ? )" with ParamValues:
> 0=5.000000, 1='68'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
>     # No tests run!
> 
> #   Failed test 'No tests run for subtest "add_enrolment_fee_if_needed"'
> #   at t/db_dependent/Koha/Patrons.t line 473.
> 
> t/db_dependent/Koha/Holds.t .. DBD::mysql::st execute failed: Cannot add or
> update a child row: a foreign key constraint fails
> (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t`
> FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE
> CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` (
> `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=42,
> 1='69', 2='Hold Expired'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
> 1832.
>         # Looks like you planned 4 tests but ran 3.
> 
>     #   Failed test 'charge_cancel_fee parameter'
>     #   at t/db_dependent/Koha/Holds.t line 134.
> 
> 
> I think that some new values should be added to account_offset_types...

The tests pass for me - I wonder what the difference could be? Just applied,
reset_all and ran them. The only issue I see is lots of warnings in
Circulation.t, but I tihnk there was another bug for those.

-- 
You are receiving this mail because:
You are watching all bug changes.