[Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 22 18:38:47 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
This seems to have improved things - If I copy an order from a basket where
effective create items is 'ordering' then a new item is created.

However

If I copy from a basket that did create items to a new basket that where
effective create items is 'cataloging' an item is created, though it should not
be.

I think the correct condition might be
if ( (!$self->subscriptionid) && ($self->basket->effective_create_items eq
'ordering') ) { 
# Do copy items if not a serial AND if items are created on ordering in this
basket

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list