[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #99 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 85697
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85697
Bug 20750: Allow logging of arbitrary actions

Review of attachment 85697:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20750&attachment=85697)
-----------------------------------------------------------------

::: Koha/Illrequest/Logger.pm
@@ +110,5 @@
> +
> +sub log_status_change {
> +    my ( $self, $req, $new_status ) = @_;
> +
> +    $self->set_data({

I do not like to use 'data' variable to send data to logger. What happens when
log_something is called accidentaly?

::: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ +443,5 @@
> +                                <div class="modal-body">
> +                                [% IF request.logs.size > 0 %]
> +                                    [% FOREACH log IN request.logs %]
> +                                        [% tpl = log.template %]
> +                                        [% INCLUDE $tpl %]

I would call it with param log, to be sure what is rendered

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
@@ +54,5 @@
>  [%        CASE 'CHANGE PASS' %]Change password
>  [%        CASE 'ADDCIRCMESSAGE' %]Add circulation message
>  [%        CASE 'DELCIRCMESSAGE' %]Delete circulation message
> +[%        CASE 'STATUS_CHANGE'  %]Change ILL request status
> +[%        CASE 'BLDSS_STATUS_CHECK'  %]Check ILL request status with BLDSS

Why do you add BLDSS_STATUS_CHECK action? Koha can't be awared of all existing
backends... it should instead be get from installed backends, maybe easier to
do it after switch backend to regular Koha plugins?

-- 
You are receiving this mail because:
You are watching all bug changes.