[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #105 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Josef Moravec from comment #99)
> Comment on attachment 85697 [details] [review]
> Bug 20750: Allow logging of arbitrary actions
> 
> Review of attachment 85697 [details] [review]:
> -----------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
> @@ +54,5 @@
> >  [%        CASE 'CHANGE PASS' %]Change password
> >  [%        CASE 'ADDCIRCMESSAGE' %]Add circulation message
> >  [%        CASE 'DELCIRCMESSAGE' %]Delete circulation message
> > +[%        CASE 'STATUS_CHANGE'  %]Change ILL request status
> > +[%        CASE 'BLDSS_STATUS_CHECK'  %]Check ILL request status with BLDSS
> 
> Why do you add BLDSS_STATUS_CHECK action? Koha can't be awared of all
> existing backends... it should instead be get from installed backends, maybe
> easier to do it after switch backend to regular Koha plugins?

You're absolutely right, we shouldn't be hard coding to particular backends.
Ideally we'd have some method, probably in Illrequests.pm, which something like
viewlog.pl could call to poll all the available backends and see if they have
anything it needs to include. That would require some thought to make sure we
do it right. And I think you're right, it's probably something that would be
made easier once backends are plugins.

I'm happy to remove this specific binding to the BLDSS backend here, if you
agree?

-- 
You are receiving this mail because:
You are watching all bug changes.