[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Jan 4 20:33:22 CET 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049
Charles Farmer <charles.farmer at inlibro.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83627|0 |1
is obsolete| |
--- Comment #11 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 83656
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83656&action=edit
Bug 22049: (follow-up) Remove leftover variable
The $circControlBranch variable was originally set to be used to pick
the right dropbox branch. It was only used in MarkIssueReturned, to get
the right Koha::Calendar object. As this responsability was moved top to
the AddReturn caller, and the fact that _GetCircControlBranch is
actually used for fines rules, there's no use for it in this context.
And it was left on the previous patch as a mistake.
To test:
- Make sure the variable is not actually used:
$ git grep '$circControlBranch'
=> SUCCESS: removed variable is not actually used.
- Sign off :-D
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list