[Koha-bugs] [Bug 21559] Rules for automatic framework codes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Paxed, some first QA notes:

1) There is a fail from the QA tools:

 FAIL   t/Biblio/AutoFrameworkcode.t
   FAIL   critic
                "return" statement with explicit "undef" at line 47, column 9.
See page 199 of PBP.

2) I think the system preference description would be more helpful with some a
hint at documentation. I was wondering if a link to the manual would work, but
maintaining the link to always link to the current manual would not be so nice.
Maybe adding some more hints to the preference description for now?  

I am a bit concerned that this adds a lot of code in the "old style" to
C4::Biblio. Specifically: GetAutoFrameworkCode,_matchRecordFieldspec. Not sure
how much we have in place yet in Koha for dealing with records.

-- 
You are receiving this mail because:
You are watching all bug changes.