[Koha-bugs] [Bug 20447] Add support for MARC holdings records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Failed QA
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

--- Comment #74 from Josef Moravec <josef.moravec at gmail.com> ---
So, started the first QA run ;)

First of all, I really like this enhancement and would to see it in Koha.

But this need some more work I think, first some not critical and easy to fix:
- System preference SummaryHoldings is missing in db updates
- Holdings marc framework is missing from db update
- Schema files should be attached in its own patch
- I do not like using subfield "V" as default for linking item to holding,
uppercase letters for subfields are not possible in marc21 standard

But, the main problem I see here is C4::Holdings module - C4 namespace is
deprecated, and should not be used for new modules, you always should add the
new modules into Koha namespace and use objects if possible and if it does make
sense, of course. You already have Koha::Holdings and
Koha::Holdings::Metadatas, so you should add new routines here (in the
Koha::Objects(s) manner).

See also bug 22144, that's the way the holdings, holding::metadatas and its
marc record object should be linked together too.

-- 
You are receiving this mail because:
You are watching all bug changes.