[Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |george at nekls.org

--- Comment #2 from George Williams (NEKLS) <george at nekls.org> ---
It passes most of the test plan for me, but there's a problem if you have two
patrons using the same SMS alert number.  On a second test of SMS numbers I
entered 5 patrons with the same SMS number in order to see how the patch would
handle a situation like this (we have lots of patrons where a parent will use
their SMS number form their own account + for the accounts of their children)
and if the SMS numbers are not unique, only the first patron that is using that
SMS number appears in the batch patron modification tool - and their data is
repeated 1 line per SMS number.

The other thing I'd add is that I don't like the separate interfaces for "Use a
file of cardnumbers" and "Use a file of cardnumbers" or the seperate "Or list
cardnumbers one by one" and "Or list SMS numbers one by one."  I think it would
be better to have the interface look like the Batch item modification tool
where the first option is "Use a file" and then there are radio buttons to
indicate whether its a "Barcode file" or "Item number file."  If you had a
similar option for "Enter patrons one by one" and then had a radio button for
"cardnumbers" and "SMS numbers" and had the radio buttons default to cardnumber
it would make the UI better.

-- 
You are receiving this mail because:
You are watching all bug changes.