[Koha-bugs] [Bug 23064] Cannot add edit subscription with strict SQL modes turned on

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have lost too much time with the argument list! They differ from
NewSubscription for no good reasons, it's insane.

This patch is not ready for 2 reasons:
- The returned value is not correct ($modified is not correctly named) and is a
change in the behavior (not sure it matters are it is never checked). However
the tests is wrong as it does not test anything.

- There is a warning:
Argument "" isn't numeric in numeric eq (==) at
/usr/share/perl5/DBIx/Class/Row.pm line 1018.

I think it's related to bug 21761, that need to be fixed ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.