[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> Comment on attachment 90388 [details] [review]
> Bug 23057: Update do_checkin
> 
> Review of attachment 90388 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Circulation.pm
> @@ +1945,4 @@
> >      }
> >  
> >      if ( $item->itemlost and C4::Context->preference("BlockReturnOfLostItems") ) {
> > +        $messages->{'ReturnOfLostItemBlocked'};
> 
> Should we handle it from returns.pl as well?

So, implementing this turned out to be way more complicated than I expected.
The logic in AddReturn for lost items is "messy" to put it kindly. You can find
this patch in the obsolete patches on this bug.

As an alternative solution with far fewer changes to the code, I've added a
different followup that removes the new ReturnOfLostItemBlocked and follows the
existing pattern implemented by returns.pl where the logic is implemented
outside AddReturn.

I find this to be technically inferior, but re-implementing the
ReturnOfLostItemBlocked message properly is far outside the scope of a SIP bug
report. The now obsoleted patch could definitely be re-used on a bug dedicated
to this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.