[Koha-bugs] [Bug 23217] Batch patron modification shows database errors when no Attribute provided

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23217

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #1)
> Another would be to update UpdateBorrowerAttribute() to look up the
> borrower_attribute_type/code before trying to do an insert, although that
> could have performance impacts on batch operations.

Oh actually in tools/modborrower.pl, we're already doing the following:

my $attr_type = C4::Members::AttributeTypes->fetch( $_ );

We should just do some better validations there. 

Oh... $attr_type should be null, but then we do the following:

++$i and next if $attr_type->{category_code} and $attr_type->{category_code} ne
$borrower_categorycode;

That doesn't make any errors, so I wonder if that's an autovivification
issue... I'll take a quick look...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.