[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

--- Comment #46 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 80256
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256
Bug 15529: Altered logic for lockfile creation

Review of attachment 80256:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15529&attachment=80256)
-----------------------------------------------------------------

::: misc/cronjobs/process_message_queue.pl
@@ +89,5 @@
> +foreach (
> +        C4::Context->config("cron_lockdir"),
> +        '/var/lock/cron_' . C4::Context->config('database'),
> +        '/tmp/cron_' . C4::Context->config('database')
> +) {

This seems excessive and process_message_queue.pl doesn't seem like the place
you'd want to do it anyway. This seems pretty generic and like it could be used
by other scripts.

@@ +98,5 @@
> +if( !defined $LockFH ) {
> +        print "WARNING: Could not create lock file $lockfile: $!\n";
> +        print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n";
> +        print "Verify file permissions for it too.\n";
> +        $use_flock = 0; # we disable file locking now and will continue

Yeah, I'd say mandate that locks must be used.

-- 
You are receiving this mail because:
You are watching all bug changes.