[Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461

Oliver Behnke <oliver.behnke at aei.mpg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #8 from Oliver Behnke <oliver.behnke at aei.mpg.de> ---
Almost:

"Global symbol "%data" requires explicit package name (did you forget to
declare "my %data"?) at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 228"

The original indeed declares that at [5] and adding that line right above "my
@columns" does work for me. But I'm no perl expert, so I have to leave the fix
to you.

That aside, it seems the patch isn't yet complete as I get the following error
when replicating a new user from LDAP:

"{UNKNOWN}: DBIC result _type  isn't of the _type Category at
/usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at
/usr/share/koha/lib/Koha/Patron.pm line 288"

Cheers


FWIW, I propose to remove line 449 at [6] (or replace it with a more suitable
comment) as we now know that, yes, that check is indeed vital :-)

[5]
https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd3838e29c3ce/C4/Members.pm#L396

[6]
https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd3838e29c3ce/C4/Members.pm#L449

-- 
You are receiving this mail because:
You are watching all bug changes.