[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #24)
>Is it really useful to check for the others PayXX (in the updatedatabase entry)?

(In reply to Jonathan Druart from comment #25)
> Why not switch the sip_type (00, 01, 02) to something meaningful?

The types come directly from the SIP messages. That's part of the point of
doing this, it allows for SIP extensions and types we are not currently
handling by allowing users to add them as authorized values of the for SIPXX
where the XX is the code they've found to be in use. It allows them to add a
meaningful description of the type of payment. (For example, if 3M decided to
have a unit that accepted paypal and assigned if 05 arbitrarily).

> 
> Also, we are loosing the translation...

Yup, I was sort of hoping no-one would mind this at the moment (none of the
payment_types are translatable as it stands). This was meant to be a step
towards bug 17702 (or perhaps I'll add another step between this and that bug)
where I intend to make split accounttypes into credit and debit types and also
move payment_types out of the authorized value system and into their own
specialised table.  I intend to make all of that translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.