[Koha-bugs] [Bug 23586] Issuing rules failing in 19.05

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586

Andreas Jonsson <andreas.jonsson at kreablo.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
I think that any library that have branch specific issuing rules will be
affected by this, but the problem will be visible on any Koha-installation.

I propose two test plans:

1. By code inspection:

* Review commit 7d71d9507202ff667776bf9cb6de0bf2603ad0dd and note that it
changes the parameter "$branch" passed to CalcDateDue from the return value of
_GetCircControlBranch, which is a branchcode, to $circ_library, which is a
library object.
* Note that CalcDateDue will eventually call CalcHardDueDate with the library
object as parameter, and that CalcHardDueDate expects a branchcode which it
will pass as parameter to the database query.

2. By inspecting the query log in MySQL:

- Enable query-logging in MySQL by editing /etc/mysql/my.cnf and restarting the
mysql server:

general_log_file        = /var/log/mysql/mysql.log
general_log             = 1

- Perform an issue and grep for 'Koha::Library=HASH(' in
/var/log/mysql/mysql.log
- Apply patch
- sudo truncate --size=0 /var/log/mysql/mysql.log
- Perform an issue and grep for 'Koha::Library=HASH(' in
/var/log/mysql/mysql.log

-- 
You are receiving this mail because:
You are watching all bug changes.