[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #211 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some doubts here:

1) Koha vs. C4

This adds quite some new code to the C4 namespace:
AddHoldGroup
DeleteHoldGroup
GetHoldGroupHolds
GetReserveCount

We already have started to move to Hold.pm and Holds.pm in the Koha namespace.

I feel like the new things (*HoldGroup*) at least should be started in the new
namespace... someone else might weigh in here.

Also uses lots of SQL.

2) Database changes

The database update looks quite complicated, because you try to catch that the
holds_groups could already exist. I feel it could be simplified.

The holds groups table only consists of a PK column?

I think the charset is not correct, should be:

3) Had the same question looking at the new method added:
+        # TODO: Should be: $reserve_cnt = $patron->holds->count;
+        $reserve_cnt = GetReserveCount( $borrowernumber );

4) Rename test file (must have missed the global renaming :) )

5) How does this feature affect limits on holds? (total and daily limits). Will
every hold be counted as before?

-- 
You are receiving this mail because:
You are watching all bug changes.