[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #6)
> I am not sure about these fallbacks in the code - can you please explain?
> 
> +            # we should use the unitprice if included
> +            my $cost_tax_included = $order->{unitprice_tax_included} ||
> $order->{ecost_tax_included};
> +            my $cost_tax_excluded = $order->{unitprice_tax_excluded} ||
> $order->{ecost_tax_excluded};
> +            $order->{tax_value_on_ordering} = (
> get_rounded_price($cost_tax_included) -
> get_rounded_price($cost_tax_excluded) ) * $order->{quantity};

This only affects the 'tax_value_on_ordering' field
  -if you have entered an actual cost, then those values are used to determine
the tax
  -if you have not, we use the ecost as we did previously (fallback to original
behvaiour)

-- 
You are receiving this mail because:
You are watching all bug changes.