[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 94284
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94284
Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued

Review of attachment 94284:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23382&attachment=94284)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +707,4 @@
>      unless ( $duedate ) {
>          my $issuedate = $now->clone();
>  
> +        $duedate = CalcDateDue( $issuedate, $effective_itemtype, $circ_library->branchcode, $patron_unblessed );

Updating $branch to $circ_library->branchcode here was the change corrected the
main issue in this bug report.

@@ +1006,4 @@
>          my ($rentalCharge) = GetIssuingCharges( $item_object->itemnumber, $patron->borrowernumber );
> +
> +        my $itemtype_object = Koha::ItemTypes->find( $item_object->effective_itemtype );
> +        if ($itemtype_object) {

I only added this check to be consistent with other area's where we are testing
for such cases. As you suggest, I'd love to see these checks disappear, but
likely as a self-contained bug that catches all cases.

-- 
You are receiving this mail because:
You are watching all bug changes.