[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Apr 13 19:25:39 CEST 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #99878|0 |1
is obsolete| |
--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 102874
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102874&action=edit
Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent
There are 2 subroutines from C4::Acquisition that could be removed:
- GetLastOrderReceivedFromSubscriptionid
- GetLastOrderNotReceivedFromSubscriptionid
After bug 20726 only GetLastOrderReceivedFromSubscriptionid will be used
(from acqui/neworderempty.pl) and this call could be replaced easily with
Koha::Acquisition::Orders
The code (+ tests) related to these 2 subroutines could then be removed.
The parameters for the search is basic and does no really deserve its own
subroutine.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list