[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Feb 4 15:19:45 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I gave a try to this, wrote the test then try to fix it.
But my understanding of the code leads me to abandon. I do not understand why
there are 3 calls to ReturnLostItem:
Koha/Account.pm: C4::Circulation::ReturnLostItem(
$self->{patron_id}, $fine->itemnumber ) unless $checkout;
Koha/Account.pm: C4::Circulation::ReturnLostItem(
$self->{patron_id}, $fine->itemnumber ) unless $checkout;
Koha/Account/Line.pm: C4::Circulation::ReturnLostItem(
$self->borrowernumber, $debit->itemnumber );
That seems wrong to me.
So I guess my test will not cover all the cases. Hope it could help as a start
anyway.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list