[Koha-bugs] [Bug 23571] fines.pl may block server
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Feb 19 18:03:27 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571
--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 99264
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99264
Bug 23571: Add flock to fines.pl
Review of attachment 99264:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23571&attachment=99264)
-----------------------------------------------------------------
So, this generally looks pretty good to me.. However... I'd love to see the
locking mechanisms factored out into the Koha::Script base class so we could
share the common code between command-line scripts and make adding flocking
elsewhere a simple pattern to follow.
Would you be willing to have a go at that Agustin?
::: misc/cronjobs/fines.pl
@@ +82,5 @@
> cronlogaction();
>
> +my ($lockfile, $LockFH);
> +foreach (
> + '/var/lock/koha',
How did you come up with these locations?
I note in the equivalent in rebuild_zebra.pl we use a config variable, followed
by a fallback order... I actually like the idea of using /var/lock/koha but
I'm not sure I understand where if came from?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list