[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Haha, I agree.. I would have preferred not to add a new dependancy...
especially as it doesn't appear to be packaged for Jessie (having said that..
we are dropping supoprt for Jessie with 20.05 and this is an enhancement so
that shouldn't be a problem).

However.. I am wondering a little about the code having had a little read.

You seem to do an array_diff and then two more iterations to catch where the
diffs came from.. couldn't you have just done two array_minus calls (from the
same module) to directly get the two different types of problem and saved
yourself a loop and a few lines of code?

-- 
You are receiving this mail because:
You are watching all bug changes.