[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Mar 2 11:46:05 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 99878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99878&action=edit
Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent

There are 2 subroutines from C4::Acquisition that could be removed:
- GetLastOrderReceivedFromSubscriptionid
- GetLastOrderNotReceivedFromSubscriptionid

After bug 20726 only GetLastOrderReceivedFromSubscriptionid will be used
(from acqui/neworderempty.pl) and this call could be replaced easily with
Koha::Acquisition::Orders

The code (+ tests) related to these 2 subroutines could then be removed.

The parameters for the search is basic and does no really deserve its own
subroutine.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list