[Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 4 09:56:10 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #112 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #109)
> (In reply to Tomás Cohen Arazi from comment #98)
> > Created attachment 100014 [details] [review] [review]
> > Bug 23355: Split tests for Line vs Lines
> > 
> > This patch simply splits the existing tests for accountlines into two
> > test files, one for the singular object and one for the set.
> 
> Did we really decided that? I do not see the point to multiplicate the
> number of test files.

Personally.. I find it much clearer to have a test file per class.. we made the
decision to not go the DBIx::Class by splitting our result classes in two.. one
for plural one for singular.. we should do the exact same thing in the tests
otherwise it gets difficult to find where a function is tested.

Also, from a debugging and code reading perspective, I find it hard to find a
test in a really really really long single test file.. it's much easier to find
the relevant test in a shorted file ;)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list