[Koha-bugs] [Bug 15400] Display patron age in useful places

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 4 14:55:02 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #57)
> +        [%- IF ( patron.get_age ) %] ([% patron.get_age | html %] years)
> +        [%- ELSIF ( patron.age ) %] ([% patron.age | html %] years)[% END
> -%]
> 
> That smells.
> You should either test for the type of patron, or pass another variable
>   patron_object vs patron
> or
>   patron vs borrower (that reads wrong but it is what is usually done in
> controllers)

Sorry, I was reading the patch and not the final change. I added a follow-up.

However I still think it's lot of info that could be considered not needed by
some.
Especially in the circ autocomplete.

Letting someone else adding the QA stamp.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list