[Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98921|0                           |1
        is obsolete|                            |

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 100147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100147&action=edit
Bug 24662: Remove global variables MSG_* from datatables.inc

Now that bug 21156 is pushed, we don't need to have global variables in
.inc or .tt files for translation in .js file. We can simply declare our
translatable strings where they are used.

This patch removes all global variables used in DataTables configuration

Test plan:
1. cd misc/translator && ./translate update fr-FR
2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
3. cd misc/translator && ./translate install fr-FR
4. Go to the staff interface, in english, and check that DataTables
tables are still working. You should check at least the following pages:
    - catalogue/detail.pl
    - circ/circulation.pl
    - tools/quotes.pl
    - tools/letter.pl
5. Switch to french and check again DataTables tables, and verify that
   strings are translated

This patch depends on bug 24661

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested using es-ES or de-DE (build compendium, update, translate, install)
cd misc/translator
msgcat --use-first -o de.po po/de-DE-*.po
./translate update de-DE
msgmerge de.po po/de-DE-messages-js.po -o - | msgattrib --no-obsolete -o
po/de-DE-messages-js.po
./translate install de-DE

DataTables works, and are translated.
There are some messages from qa-tools.

-- 
You are receiving this mail because:
You are watching all bug changes.