[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #50)
> This generally seems to work.. but I'm no SIP expert and the code is hard to
> follow at the best of times.
> 
> I would love to see the actually logging statements look more like elsewhere
> in Koha... this will be the third form for calling a Koha::Logger based log
> and is more confusing by the fact it keeps the 'syslog' name so if someone
> is keen to add more statements they may go looking for Sys::Syslog
> documentation and get mislead.

I would be happy to change the subroutine name. We kept it up to this point
just to make fewer cuts and reduce merge conflicts!

-- 
You are receiving this mail because:
You are watching all bug changes.