[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #92 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Almost there - thx for the work on the notice.

1) I think this slipped in from another feature in the tree (22784):

+                            <label for="archived" style="display:
inline;">Include archived:</label>
+                            <input type="checkbox" id="archived"
name="filter_archived" value="archived" title="Include archived suggestions in
the search" />
+                      </li>
+                      <li>

2) From comment#91

> > 1) When I change the manager, the lastmodification* are not updated.
> 
> That was expected (I think). The field lastmodification* are only updated
> when the suggestion is edited via the edit form. If we want to update it
> whenever the table is updated, the change must be moved to ModSuggestion.
> 
> Séverine, can you confirm the behavior you expect?

Still waiting for an answer here, but I think we could fix that on a follow-up
if needed. The change will be minor compared to the work needed to keep this
patchset up-to-date with master.
--

This one is confusing to me and I keep wondering if this should have been more
than one bug :) So at the moment, in suggestions we got:

  `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update
CURRENT_TIMESTAMP,  -- date and time the suggestion was updated

   lastmodificationby INT(11) default NULL, -- borrowernumber for the librarian
who edit the suggestion for the last time
   lastmodificationdate date default NULL, -- date of the last modification

So date is actually always updated and should probably be renamed 'datetime' or
similar. What is the use case for the additional lastmodificationdate?
>From the description it's not clear to me. Do we really need it if we have
date?

Please feel free to get others to look at this - 1) should be a quick fix, 2)
is a bit puzzling to me right now!

-- 
You are receiving this mail because:
You are watching all bug changes.