[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 20 15:52:03 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #102 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 101188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101188&action=edit
Bug 23463: (follow-up) Fix timestamp default value

For discussion, this patch revert the changes made previously.

This line exists in Koha::Item->store as it is the translation of:
    if (exists $item->{'timestamp'}) {
        delete $item->{'timestamp'};
    }
that was coming from _do_column_fixes_for_mod (called from ModItem)

To preserve existing behavior I would be in favor of keeping it like that to
avoid regression, and deal with it separately if we want to improve/remove it.

So basically here we are setting it to undef in Koha::Item->store to make it
handle correctly by the parent Koha::Object->store. I agree that's kind of
weird
and must be improved.

Signed-off-by: Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list