[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Mar 24 16:10:57 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185
Fridolin SOMERS <fridolin.somers at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101357|0 |1
is obsolete| |
--- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 101609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101609&action=edit
Bug 24185: Make holds page faster: preparatory refactoring
This is just refactoring. extracting logically independent code
to separate sub + tests update. No logic change yet.
Searching for "any_available" item among all biblionumber items was done
inside of "elsif on_shelf_holds == 2", and it is logically very independent
piece of code (this "@items" loop), it needs just biblionumber and patron
as parameters so it can be extracted into separate subroutine, and
later also called/reused from somewhere else.
This ability to call from another place also made for future patch
to remove O(n^2) problem with nested loops.
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list