[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Mar 29 09:37:45 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101743|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 102048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102048&action=edit
Bug 12187: (follow-up) Reindent new include file

This patch re-indents the new include file so that it is consistent with
coding guidelines. Taking this opportunity to add a full test plan:

Instead of duplicating the code for serial statuses in multiple
files, move all of them into single include file, and use that.

To test, apply the patch and go to Serials.

 - Search for a subscription which has multiple issues.
   - On the subscription detail page, open the "Issues" tab.
     - Statuses in the "Status" column should display correctly.
   - Click the "Serial collection" link in the sidebar.
     - In the table of issues, the "Status" colunn should display the
       correct information.
   - Select some isues and click the "Edit serials" button.
     - In the "Status" column, the options should display correctly.
     - Test setting various statuses and saving. The statuses should
       save correctly.
   - Click "Claims" in the sidebar menu and select a vendor.
     - In the list of missing issues the "Status" column should show the
       correct information.
  - In the catalog, locate the bibliographic record for a subscription
    with issues.
    - Under the "Subscriptions" tab check the "Status" column. Status
      information should be displayed correctly.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list