[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104064|0                           |1
        is obsolete|                            |

--- Comment #4 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 104850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104850&action=edit
Bug 25339: Validate biblionumber on opac-basket.pl and opac-review.pl

This patch runs biblionumber through the int() function before
using it in the application.

Test Plan:
1) Apply patch
2) Go to
/cgi-bin/koha/opac-basket.pl?bib_list=1/abcdefghi'-alert(1)-'j&verbose=1
3) Note that you can't find abcdefghi in the HTML. You only see biblionumber 1.
4) Go to
/cgi-bin/koha/opac-review.pl?biblionumber=1'-alert(1)-'abcdefghi&reviewid=1&review=
5) Note that you can't find abcdefghi in the HTML. You only see biblionumber 1.

Signed-off-by: David Roberts <david at koha-ptfs.co.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.