[Koha-bugs] [Bug 25493] New: Unhandled exceptions cause an exception

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493

            Bug ID: 25493
           Summary: Unhandled exceptions cause an exception
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

We rushed into using Koha::Logger as a Mojo::Log implementation, but there are
some differences that need to be addressed before that can actually happen.

This is not *that* problematic for production sites, but some things like
hitting an undefined route will raise weird errors we need to avoid:

GET http://kohadev.myDNSname.org:8081/api/v1/hola

The application raised the following error:

  Can't use an undefined value as an ARRAY reference at template
mojo/debug.html.ep line 311.
306:             %= $kv->(Time => scalar localtime(time))
307:           </table>
308:         </div>
309:         <div class="tap">tap for more</div>
310:       </div>
311:       % if (@{app->log->history}) {
312:         <div id="log" class="box infobox spaced">
313:           <table>
314:             % for my $msg (@{app->log->history}) {
315:               <tr>
316:                 <td class="striped value wide">

and the StackTrace middleware couldn't catch its stack trace, possibly because
your application overrides $SIG{__DIE__} by itself, preventing the middleware
from working correctly. Remove the offending code or module that does it: known
examples are CGI::Carp and Carp::Always.

<<<<<

We need to move back to using plain Koha::Logger, and rethink the proposal from
bug 18205 to use MojoX::Log::Log4perl. That certainly belongs to another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.