[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    $biblionumber = int($biblionumber);

I think we have a few places where we do that. And it is really ugly imo.
If you dont pass a valid biblionumber, you should not get a valid response.

Furthermore int does not like strings. We will have warnings like:
Argument "3abc" isn't numeric in int 

I would rather get rid of the other places..

Changing status: ID or FQA ?

-- 
You are receiving this mail because:
You are watching all bug changes.