[Koha-bugs] [Bug 25556] Holds blocked when empty holdallowed value present in circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556

--- Comment #6 from Andrew Nugged <nugged at gmail.com> ---
> And I am not blocked from placing holds. On which screen do you see this limitation? Are you running master?

this happens when onboarding creates default rules, so it's a coincidence of a
few fields I suspect, after onboarding.pl I have in circulation_rules contents
like these:

1.  (clean "reset_all" db)
2. TRUNTACED circulation_rules

3.
INSERT INTO `circulation_rules` (`id`, `branchcode`, `categorycode`,
`itemtype`, `ccode`, `shelving_location`, `rule_name`, `rule_value`)
VALUES
 (1, NULL, NULL, NULL, NULL, NULL, 'hardduedate', ''),
 (2, NULL, NULL, NULL, NULL, NULL, 'rentaldiscount', '0'),
 (3, NULL, NULL, NULL, NULL, NULL, 'article_requests', 'no'),
 (4, NULL, NULL, NULL, NULL, NULL, 'firstremind', '0'),
 (5, NULL, NULL, NULL, NULL, NULL, 'issuelength', '14'),
 (6, NULL, NULL, NULL, NULL, NULL, 'maxsuspensiondays', ''),
 (7, NULL, NULL, NULL, NULL, NULL, 'no_auto_renewal_after', ''),
 (8, NULL, NULL, NULL, NULL, NULL, 'cap_fine_to_replacement_price', '0'),
 (9, NULL, NULL, NULL, NULL, NULL, 'auto_renew', '0'),
 (10, NULL, NULL, NULL, NULL, NULL, 'chargeperiod', '0'),
 (11, NULL, NULL, NULL, NULL, NULL, 'fine', '0'),
 (12, NULL, NULL, NULL, NULL, NULL, 'lengthunit', 'days'),
 (13, NULL, NULL, NULL, NULL, NULL, 'holds_per_day', '10'),
 (14, NULL, NULL, NULL, NULL, NULL, 'maxissueqty', '50'),
 (15, NULL, NULL, NULL, NULL, NULL, 'reservesallowed', '10'),
 (16, NULL, NULL, NULL, NULL, NULL, 'overduefinescap', ''),
 (17, NULL, NULL, NULL, NULL, NULL, 'opacitemholds', 'N'),
 (18, NULL, NULL, NULL, NULL, NULL, 'renewalperiod', '14'),
 (19, NULL, NULL, NULL, NULL, NULL, 'norenewalbefore', ''),
 (20, NULL, NULL, NULL, NULL, NULL, 'holds_per_record', '1'),
 (21, NULL, NULL, NULL, NULL, NULL, 'onshelfholds', '1'),
 (22, NULL, NULL, NULL, NULL, NULL, 'finedays', '0'),
 (23, NULL, NULL, NULL, NULL, NULL, 'renewalsallowed', '10'),
 (24, NULL, NULL, NULL, NULL, NULL, 'chargeperiod_charge_at', '0'),
 (25, NULL, NULL, NULL, NULL, NULL, 'hardduedatecompare', '-1'),
 (26, NULL, NULL, NULL, NULL, NULL, 'maxonsiteissueqty', ''),
 (27, NULL, NULL, NULL, NULL, NULL, 'no_auto_renewal_after_hard_limit', ''),
 (28, NULL, NULL, NULL, NULL, NULL, 'patron_maxonsiteissueqty', ''),
 (29, NULL, NULL, NULL, NULL, NULL, 'max_holds', ''),
 (30, NULL, NULL, NULL, NULL, NULL, 'patron_maxissueqty', ''),
 (31, NULL, NULL, NULL, NULL, NULL, 'returnbranch', ''),
 (32, NULL, NULL, NULL, NULL, NULL, 'holdallowed', ''),
 (33, NULL, NULL, NULL, NULL, NULL, 'hold_fulfillment_policy', '');


and it doesn't allow to have holds:

/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1

but if to remove:

 (32, NULL, NULL, NULL, NULL, NULL, 'holdallowed', ''),

from DB, it allows by the same link.

-- 
You are receiving this mail because:
You are watching all bug changes.