[Koha-bugs] [Bug 20447] Add support for MARC holdings records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #194 from Ere Maijala <ere.maijala at helsinki.fi> ---
I've now addressed Josef's comments apart from the ones listed below (for a
reason):

> ::: C4/Search.pm
> @@ +2242,5 @@
> >          }
> >  
> > +        # Fetch summary holdings
> > +        if (C4::Context->preference('SummaryHoldings')) {
> > +            $summary_holdings = Koha::Holdings->search({ biblionumber => $oldbiblio->{biblionumber}, deleted_on => undef });
> 
> Maybe something like $biblio->holdings?

I didn't change this since it would require fetching the biblio record for each
result, and since we don't currently do that, it would have been extra work
required just to get the holdings. I added a comment noting that.

> ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addholding.tt
> @@ +6,5 @@
> > +[% INCLUDE 'doc-head-close.inc' %]
> > +[% Asset.js("lib/hc-sticky.js") | $raw %]
> > +[% Asset.js("js/cataloging.js") | $raw %]
> > +[% INCLUDE 'strings.inc' %]
> > +[% Asset.js("js/browser.js") | $raw %]
> 
> Even javascript included by Asset plugin should be at end of template
> 
> And you need to set variable footerjs, like: [% SET footerjs = 1 %] (And
> macro block - see bellow)

addholding.tt mirrors addbiblio.tt, and addbiblio.tt uses js plugins that don't
support footerjs. I updated addholding.tt according to changes in addbiblio.tt,
but I left the structure intact so that it's easier to compare and update the
files. It might be possible in a follow-up to merge some parts of the separate
templates.

-- 
You are receiving this mail because:
You are watching all bug changes.