[Koha-bugs] [Bug 25556] Holds blocked when empty holdallowed value present in circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Checking the code

* max_holds, C4/Reserves.pm
 474     if ( $rule && defined( $rule->rule_value ) && $rule->rule_value ne ''
) {

=> No rule or '' mean unlimited

* patron_maxissueqty, C4/Circulation.pm
 509     if (defined($branch_borrower_circ_rule->{patron_maxissueqty}) and
$branch_borrower_circ_rule->{patron_maxissueqty} ne '') {

=> No rule or '' mean unlimited

* Same for patron_maxonsiteissueqty

* hold_fulfillment_policy, C4/Circulation.pm
1768     $rules->{hold_fulfillment_policy} = defined
$hold_fulfillment_policy_rule
1769         ? $hold_fulfillment_policy_rule->rule_value
1770         : 'any';

=> Should not be "" (must be fixed, but later). Must be fixed at onboarding
step.

* Same for holdallowed and returnbranch

I am just adding noise here.

tl;dr; yes, remove them!

-- 
You are receiving this mail because:
You are watching all bug changes.