From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 01:00:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2020 23:00:33 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #10 from David Cook --- (In reply to Fridolin SOMERS from comment #9) > Looks like this rewite is disabled in koha-httpd.conf since Koha 3.12 ^^ I think that you and I were the ones who did that one back in the day! Heh. And thanks for the sign off and follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 01:02:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2020 23:02:54 +0000 Subject: [Koha-bugs] [Bug 26585] Cataloguing interface throws JS errors on load In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26585 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- (In reply to Alex Buckley from comment #2) > Hi Katrin, thank you very much for noting that - I wasn't aware that > decision had been made. It does make a lot of sense to stop supporting IE at > this point, given Microsoft is. > > I think I'll close this ticket off. Just because we believe if libraries do > want to continue using Koha in IE then any fixes to do so should really be > customisations rather than asking the community to maintain them. > > Thanks again > Alex Sounds good! At some point, I'm going to finish off Bug 26305, which might help make the collective understanding of not supporting IE anymore more consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 02:00:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 00:00:38 +0000 Subject: [Koha-bugs] [Bug 26586] New: Koha should return a SIP2 64 response to a 63 request for fee items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26586 Bug ID: 26586 Summary: Koha should return a SIP2 64 response to a 63 request for fee items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com At the moment, we're supporting SIP 2.0 for the 63 Patron Information Request, but the 3M SIP2 Protocol Extensions outlines a 7th position "fee items". If a SIP2 client sents a Y in that position, Koha will close the connection. At the very least, it should just return a 64 response and just not send any fee item info back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 02:08:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 00:08:01 +0000 Subject: [Koha-bugs] [Bug 26586] Koha should return a SIP2 64 response to a 63 request for fee items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26586 --- Comment #1 from David Cook --- Created attachment 111011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111011&action=edit SIP2 Protocol Extensions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 04:32:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 02:32:00 +0000 Subject: [Koha-bugs] [Bug 26586] Koha should return a SIP2 64 response to a 63 request for fee items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26586 --- Comment #2 from David Cook --- After a bit more review, it looks like Koha is silently getting a fatal error, and then closes the connection. While we don't need to support the SIP2 Protocol Extension, I think we should continue to work. Looking at the SIP2 server code, it's just badly written code, which makes too many assumptions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 04:32:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 02:32:07 +0000 Subject: [Koha-bugs] [Bug 26586] Koha should return a SIP2 64 response to a 63 request for fee items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 04:56:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 02:56:22 +0000 Subject: [Koha-bugs] [Bug 26587] New: detail.pl is very slow for records with many items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Bug ID: 26587 Summary: detail.pl is very slow for records with many items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Using Plack Koha, it took about 10 seconds to load detail.pl for a page with 350 items. Looking at the code, we loop through order, subscriptions, and items. I haven't done any benchmarking, but my guess would be the slowdown comes when looping through the items, as there are lots of database calls made in that loop. I think optimizations come down to the following (which are not mutually exclusive): 1. Get the full count of items but only lookup/render a subset using an AJAX call 2. Use fewer database calls in the loop by fetching all the data needed from the database and then processing it as necessary in the loop 3. Use fewer external cache lookups by doing things like C4::Context->preference('UseCourseReserves') outside of the loop rather than inside the loop -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 04:57:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 02:57:50 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #1 from David Cook --- This is an issue that I (rather than a sponsor) noted, so I'm probably not going to work on it any time soon. But logging it anyway and maybe someone else will use my ideas to improve the detail.pl performance. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 05:04:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 03:04:34 +0000 Subject: [Koha-bugs] [Bug 26588] New: additem.pl is slow to load when record has many items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26588 Bug ID: 26588 Summary: additem.pl is slow to load when record has many items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Loading additem.pl is slow when loading a record with 350+ items. With Plack Koha, it's taking about 8.5 seconds at the moment. I haven't really investigated yet, but it's not immediately obvious why it's slow. My guess is probably C4::Biblio::EmbedItemsInMarcBiblio, but I haven't delved into the depths. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 05:04:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 03:04:58 +0000 Subject: [Koha-bugs] [Bug 26588] additem.pl is slow to load when record has many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26588 --- Comment #1 from David Cook --- While I've noticed this, I don't have a sponsor for this work, so I'm probably not going to work on it. Just noting it here as a problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 06:42:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 04:42:34 +0000 Subject: [Koha-bugs] [Bug 26589] New: t/db_dependent/OAI/Sets.t unit test fails due to OAI-PMH:AutoUpdateSets syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26589 Bug ID: 26589 Summary: t/db_dependent/OAI/Sets.t unit test fails due to OAI-PMH:AutoUpdateSets syspref Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org When the OAI-PMH:AutoUpdateSets syspref is disabled the t/db_dependent/OAI/Sets.t unit tests all pass successfully. But when the syspref is enabled then the unit test fail with this error: t/db_dependent/OAI/Sets.t .. 1/147 C4::OAI::Sets::AddOAISetsBiblios(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '39-46' for key 'PRIMARY' [for Statement " INSERT INTO oai_sets_biblios (set_id, biblionumber) VALUES (?,?) " with ParamValues: 0='46', 1=39] at t/db_dependent/OAI/Sets.t line 372 # Looks like your test exited with 255 just after 100. t/db_dependent/OAI/Sets.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 47/147 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:07 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104176|0 |1 is obsolete| | --- Comment #67 from Josef Moravec --- Created attachment 111012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111012&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:15 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104177|0 |1 is obsolete| | --- Comment #68 from Josef Moravec --- Created attachment 111013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111013&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:22 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104178|0 |1 is obsolete| | --- Comment #69 from Josef Moravec --- Created attachment 111014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111014&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:30 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104179|0 |1 is obsolete| | --- Comment #70 from Josef Moravec --- Created attachment 111015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111015&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:36 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104180|0 |1 is obsolete| | --- Comment #71 from Josef Moravec --- Created attachment 111016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111016&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:45 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104181|0 |1 is obsolete| | --- Comment #72 from Josef Moravec --- Created attachment 111017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111017&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:51 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104182|0 |1 is obsolete| | --- Comment #73 from Josef Moravec --- Created attachment 111018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111018&action=edit Bug 22544: Add tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:12:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:12:57 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104183|0 |1 is obsolete| | --- Comment #74 from Josef Moravec --- Created attachment 111019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111019&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:13:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:13:04 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104184|0 |1 is obsolete| | --- Comment #75 from Josef Moravec --- Created attachment 111020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111020&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:13:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:13:13 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #76 from Josef Moravec --- Created attachment 111021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111021&action=edit Bug 22544: Update to current codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:13:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:13:20 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #77 from Josef Moravec --- Created attachment 111022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111022&action=edit Bug 22544: Update search_for_display to be able to take more types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:19:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:19:02 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #78 from Josef Moravec --- (In reply to Martin Renvoize from comment #65) > I've looked at this a fair bit the past couple of days, and it certainly > does move us from C4 to Koha.. and does an amount of tidying.. > > However, I'm torn as I feel we could afford to go a fair bit further. The > field names are out right confusing and the logic is somewhat weird. > > Are you intending on treating this as a first step Josef or was this as far > as you intended going? > > I think we've missed 20.05 now I'm afraid, but as we're moving lots of > preferences over to this area perhaps it's time to focus on it more and > further clean and improve both the db structure and logic early next > release.? I rebased and fixed patchset on top of current master There was a change in db structure that removed timestamp column and added updated_on and published_on columns, which is definitely great move... The main problem now is the weird logic on 'lang' column... it is also used for location and language combinations... I would like to change this and add the new 'location' column - this could simplify the logic of searching for new and add more flexibility (we could differentiate between languages in news for slips based on patrons preferred language in the future... for example) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 07:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 05:39:55 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #79 from Josef Moravec --- Created attachment 111023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111023&action=edit Bug 22544: Fix filtering by location on tools -> news management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 08:42:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 06:42:18 +0000 Subject: [Koha-bugs] [Bug 26590] New: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26590 Bug ID: 26590 Summary: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org I get the following warning message in plack-error.log: > Use of uninitialized value $low in numeric lt (<) at /usr/share/koha/lib/Koha/Patron.pm line 1109. This seems to happen because in /cgi-bin/koha/admin/categories.pl you can set "Age required" field to be empty and then in the is_valid_age subroutine in Patron.pm we compare patroncategory->dateofbirthrequired to numeric value and empty string or undef is not numeric. We should either add input validation to categories.pl or convert dateofbirthrequired to numeric value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:31:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 07:31:40 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- If you want to fix that you should follow what is done in C4::Circulation::SendCirculationAlert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:31:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 07:31:54 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:05:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:05:59 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 --- Comment #1 from Martin Renvoize --- Created attachment 111024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111024&action=edit Bug 21898: Add aqbasket to available tables for AQORDER -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:06:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:06:36 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:06:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:06:50 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:12:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:12:28 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 --- Comment #2 from Martin Renvoize --- I really wish we'd bite the bullet and work through all notices converting them to TT and then deprecate the old syntax.. It's really challenging to maintain both and features are not carrying across between the two. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:17:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:17:06 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111024|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 111025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111025&action=edit Bug 21898: Add aqbasket to available tables for AQORDER This patch should allow <> replacements to work in both email subject and email content fields for notices. Test plan 1/ Add <> into the AQORDER notice (In the subject line and content box) 2/ Trigger said notice to send (before applying the patch) 3/ Note that the replacements have not taken place.. <> is present as is. 4/ Apply patch 5/ Trigger the notice again 6/ Note that the replacements are now made. 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:27:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:27:40 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #184 from Jonathan Druart --- Found a 500: Apply patches, updatedatabase, nothing else. Send a basket (OPAC): Invalid 'from' parameter: root at localhost at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:28:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:28:49 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #185 from Jonathan Druart --- Found another one: Replace KohaAdminEmailAddress with root at example.org Send a basket (use '❤' in biblio title and "comment" of the email) Wide character in subroutine entry at /usr/share/perl5/Email/MIME/Encodings.pm line 55 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:35:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:35:35 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #30 from Koha Team University Lyon 3 --- Hello, I have just dicovered this BZ and I'm really surprised and not agree this this choice. In our library, we want to prevent users who are using the selfcheckout system to checkout an item they have just check-in. They didn't really matter the warning and they can keep a book for all the time. For some title, there's a real pressure becaus they are recommanded by the teachers and we can't have one for all the students. We should have the choice to prevent or warn the check out at the selfchekout sytem and it's not the cas here if I have well understood. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:49:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 08:49:21 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #31 from Jonathan Druart --- So I guess we need a pref to control that. Sonia, can you open a new bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:03:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:03:03 +0000 Subject: [Koha-bugs] [Bug 26591] New: Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Bug ID: 26591 Summary: Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Since BZ19457, the checkout is allowed at the selfcheckout system if if we use the system preference CheckPrevCheckout. It can be useful for some libraries but not for the others. For example, in my libray, we want to prevent users who are using the selfcheckout system to checkout an item they have just check-in. They didn't really matter the warning and they can keep a book for all the time. For some title, there's a real pressure becaus they are recommanded by the teachers and we can't have one for all the students. The behaviour should be configurable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:03:23 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19457 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:03:23 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26591 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:05:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:05:04 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:05:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:05:08 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #32 from Koha Team University Lyon 3 --- Done : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:17:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:17:29 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19457 | Depends on| |19457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:17:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:17:29 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26591 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26591 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:40:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:40:18 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #208 from Jonathan Druart --- Created attachment 111027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111027&action=edit Bug 25261: Prevent tests to fail if CircConfirmItemParts is on Setting items.materials to NULL at TestBuilder level will (certainly) prevent some tests to fail if the pref is on In t/db_dependent/selenium/basic_workflow.t we set 952$3 to an empty string. The tests will pass even if the pref is turned on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:40:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:40:47 +0000 Subject: [Koha-bugs] [Bug 26540] Issue Credit with Cash Registers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:40:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:40:47 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 [Bug 26540] Issue Credit with Cash Registers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:43:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:43:59 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:01 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #29 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:03 +0000 Subject: [Koha-bugs] [Bug 19322] Typo in UNIMARC field 140 plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19322 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:05 +0000 Subject: [Koha-bugs] [Bug 19322] Typo in UNIMARC field 140 plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19322 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:08 +0000 Subject: [Koha-bugs] [Bug 19327] Typo in UNIMARC field 128a plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:10 +0000 Subject: [Koha-bugs] [Bug 19327] Typo in UNIMARC field 128a plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19327 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:13 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:15 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 --- Comment #16 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:17 +0000 Subject: [Koha-bugs] [Bug 23114] Inventory: allow to scan barcodes into input field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:20 +0000 Subject: [Koha-bugs] [Bug 23114] Inventory: allow to scan barcodes into input field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:23 +0000 Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:26 +0000 Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #35 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:28 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:31 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #15 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:32 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:35 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #22 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:37 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:40 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #209 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:45 +0000 Subject: [Koha-bugs] [Bug 25771] Allow the user to sort checkouts by the renew column in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:48 +0000 Subject: [Koha-bugs] [Bug 25771] Allow the user to sort checkouts by the renew column in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25771 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:50 +0000 Subject: [Koha-bugs] [Bug 25776] Add last updated date for notices and slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25776 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:53 +0000 Subject: [Koha-bugs] [Bug 25776] Add last updated date for notices and slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25776 --- Comment #22 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:55 +0000 Subject: [Koha-bugs] [Bug 26089] Add acquisitions-related reports to acquisitions sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26089 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:57 +0000 Subject: [Koha-bugs] [Bug 26089] Add acquisitions-related reports to acquisitions sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26089 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:44:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:44:59 +0000 Subject: [Koha-bugs] [Bug 26207] Compare values of system preference log entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:01 +0000 Subject: [Koha-bugs] [Bug 26207] Compare values of system preference log entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 --- Comment #16 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:04 +0000 Subject: [Koha-bugs] [Bug 26266] Add jQuery validator to opac-password-recovery.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:08 +0000 Subject: [Koha-bugs] [Bug 26266] Add jQuery validator to opac-password-recovery.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 --- Comment #12 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:10 +0000 Subject: [Koha-bugs] [Bug 26268] Remove items.paid for once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:14 +0000 Subject: [Koha-bugs] [Bug 26268] Remove items.paid for once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #44 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:17 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:19 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:21 +0000 Subject: [Koha-bugs] [Bug 26325] Add primary_key_exists function to Installer.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26325 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:25 +0000 Subject: [Koha-bugs] [Bug 26325] Add primary_key_exists function to Installer.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26325 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:28 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:31 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 --- Comment #12 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:33 +0000 Subject: [Koha-bugs] [Bug 26425] Fix history.txt once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:37 +0000 Subject: [Koha-bugs] [Bug 26425] Fix history.txt once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:41 +0000 Subject: [Koha-bugs] [Bug 26432] Remove unused ModZebrations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26432 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:46 +0000 Subject: [Koha-bugs] [Bug 26432] Remove unused ModZebrations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26432 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:48 +0000 Subject: [Koha-bugs] [Bug 26454] Add system preference to set meta description for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:50 +0000 Subject: [Koha-bugs] [Bug 26454] Add system preference to set meta description for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26454 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:54 +0000 Subject: [Koha-bugs] [Bug 26458] Get item details using only itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:45:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:45:57 +0000 Subject: [Koha-bugs] [Bug 26458] Get item details using only itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26458 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:00 +0000 Subject: [Koha-bugs] [Bug 26462] t/db_dependent/Holds.t tests delete data unnecessarily In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:02 +0000 Subject: [Koha-bugs] [Bug 26462] t/db_dependent/Holds.t tests delete data unnecessarily In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:04 +0000 Subject: [Koha-bugs] [Bug 26473] Get items for editing using only itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:07 +0000 Subject: [Koha-bugs] [Bug 26473] Get items for editing using only itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26473 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:10 +0000 Subject: [Koha-bugs] [Bug 26484] Add serials-related reports to serials sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:12 +0000 Subject: [Koha-bugs] [Bug 26484] Add serials-related reports to serials sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26484 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:14 +0000 Subject: [Koha-bugs] [Bug 26501] Article requests: Add datatables to requests form in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:16 +0000 Subject: [Koha-bugs] [Bug 26501] Article requests: Add datatables to requests form in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26501 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:18 +0000 Subject: [Koha-bugs] [Bug 26524] Add Koha::Acquisition::Basket->orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:20 +0000 Subject: [Koha-bugs] [Bug 26524] Add Koha::Acquisition::Basket->orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26524 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:22 +0000 Subject: [Koha-bugs] [Bug 26530] Use patron card number as checkbox label during patron merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:46:24 +0000 Subject: [Koha-bugs] [Bug 26530] Use patron card number as checkbox label during patron merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26530 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:47:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:47:44 +0000 Subject: [Koha-bugs] [Bug 26485] Simplify itemnumber handling in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26485 --- Comment #6 from Martin Renvoize --- (In reply to Fridolin SOMERS from comment #5) > OMG we also need to manage $item object : > > grep 'Koha::Items->find' circ/returns.pl > my $item = Koha::Items->find( $itemnumber ); > my $item = Koha::Items->find({ barcode => $barcode }); > my $item = Koha::Items->find( $itemnumber ); > my $item = Koha::Items->find({ barcode => $bar_code }); > my $item_from_barcode = Koha::Items->find({barcode => $barcode }); # How > many times do we fetch this item?!? Yowsers!.. Lets do this.. perhaps in a new bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:48:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:48:58 +0000 Subject: [Koha-bugs] [Bug 26485] Simplify itemnumber handling in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110999|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 111028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111028&action=edit Bug 26485: Simplify itemnumber handling in returns.pl This is a follow-up for bug 25969. The way we handle itemnumber is too complicated and error prone. Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:50:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:50:24 +0000 Subject: [Koha-bugs] [Bug 26485] Simplify itemnumber handling in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26485 --- Comment #8 from Jonathan Druart --- (In reply to Martin Renvoize from comment #6) > (In reply to Fridolin SOMERS from comment #5) > > OMG we also need to manage $item object : > > > > grep 'Koha::Items->find' circ/returns.pl > > my $item = Koha::Items->find( $itemnumber ); > > my $item = Koha::Items->find({ barcode => $barcode }); > > my $item = Koha::Items->find( $itemnumber ); > > my $item = Koha::Items->find({ barcode => $bar_code }); > > my $item_from_barcode = Koha::Items->find({barcode => $barcode }); # How > > many times do we fetch this item?!? > > Yowsers!.. Lets do this.. perhaps in a new bug I think there is one already (without patch), but cannot find it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:57:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 09:57:55 +0000 Subject: [Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #17 from Joonas Kylmälä --- The patch "Bug 25969: Don't set itemnumber as reserve->itemnumber" here breaks printing hold slip in returns.pl page if you try to print it more than once. So if you return the hold first once, it prints the slip fine and goes to waiting state, then if you check in the item another time and try to print the slip the Internal server error comes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:04:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:04:24 +0000 Subject: [Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #18 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #17) > The patch "Bug 25969: Don't set itemnumber as reserve->itemnumber" here > breaks printing hold slip in returns.pl page if you try to print it more > than once. So if you return the hold first once, it prints the slip fine and > goes to waiting state, then if you check in the item another time and try to > print the slip the Internal server error comes. Nick or Kyle, can you have a look at this ASAP please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:17:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:17:25 +0000 Subject: [Koha-bugs] [Bug 26485] Simplify itemnumber handling in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111028|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 111029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111029&action=edit Bug 26485: Simplify itemnumber handling in returns.pl This is a follow-up for bug 25969. The way we handle itemnumber is too complicated and error prone. Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:19:08 +0000 Subject: [Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > (In reply to Nick Clemens from comment #5) > > (In reply to Jonathan Druart from comment #4) > > > (In reply to Jonathan Druart from comment #3) > > > > Shouldn't actually do the reverse and index on demand? > > > > > > *we* > > > > > > Well, it's just a thought, I haven't investigated it! > > > > Can you explain a bit more? Are you suggesting 'index_record' and don't > > index unless passed? > > Yes I am not opposed to the idea, however, it would mean redoing a lot of the code which was just done in bug 25265 and other places. I suspect it would not eliminate code, but just change the basic idea. Here we could possibly eliminate some of the storage calls, to reduce the number we have to 'skip' butlarger refactoring is needed overall so this was a start -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:20:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:20:18 +0000 Subject: [Koha-bugs] [Bug 26485] Simplify itemnumber handling in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26485 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Sooo much clearer! Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:29:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:29:17 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #19 from Andrew Isherwood --- Hi Jonathan - After creating the patches to use JSON rather than zero padded strings, I remembered the reason I went for zero padded strings rather than another format. Since the content of the logged data needs to be used in SQL reports, I need it to be in a format that can be parsed using SQL. JSON is the obvious choice, however JSON support doesn't exist on the older versions of MySQL that Koha supports (e.g. 5.5), so that is not a viable option. The only method I could come up with for storing arbitrary data was in padded strings, then using the SUBSTRING operator to extract the data in a report. > And why 10? rrp_tax_excluded is decimal(28,6) for instance OK, I'd not appreciated that. I can increase the padding to a much larger value if we're allowing values with precision of 28 to be stored... I wanted the padding to be sufficient, 10 seemed to be enough, but apparently not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:36:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:36:00 +0000 Subject: [Koha-bugs] [Bug 26583] Unnecessary code in AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20912, 16272 --- Comment #2 from Nick Clemens --- Ah, switch on site checkout, will remove the removal for #2 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 [Bug 16272] Transform checkout from on-site checkout to regular checkout https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 [Bug 20912] Rental fees based on time period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:36:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:36:00 +0000 Subject: [Koha-bugs] [Bug 16272] Transform checkout from on-site checkout to regular checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16272 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 [Bug 26583] Unnecessary code in AddIssue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:36:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:36:00 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 [Bug 26583] Unnecessary code in AddIssue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:43:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:43:24 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #20 from Andrew Isherwood --- I gather you've spoken with Martin, I'm going to proceed with storing in JSON -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:51:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 10:51:50 +0000 Subject: [Koha-bugs] [Bug 26583] Unnecessary code in AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111008|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 111030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111030&action=edit Bug 26583: Remove unneccessary code in AddIssue The lines to calc due date are doubled ModDateLastSeen is not needed as we set the item not lost and we can set the date as we do for date last borrowed and save a DB store Largely this is reading the code and confirming the changes make sense To test: 1 - Apply patch 2 - Check out items, confirm it works as before 3 - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:14:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:14:39 +0000 Subject: [Koha-bugs] [Bug 26593] New: Rental discounts are applied in wrong precedence order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593 Bug ID: 26593 Summary: Rental discounts are applied in wrong precedence order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org GetIssuingCharges uses its own private sub to choose the correct rental discount rule, specifying the rules returned in order: 1 - same library, same category, same itemtype 2 - all libraries, same category, same itemtype 3 - same library, same category, all itemtypes 4 - all libraries, same category, all itemtypes It doesn't match what the circ rules page says, and is missing several options: same library, same patron category, same item type same library, same patron category, all item types same library, all patron categories, same item type same library, all patron categories, all item types default (all libraries), same patron category, same item type default (all libraries), same patron category, all item types default (all libraries), all patron categories, same item type default (all libraries), all patron categories, all item types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:25:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:25:16 +0000 Subject: [Koha-bugs] [Bug 26515] Add Koha::Acquisition::Order->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26515 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110992|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 111031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111031&action=edit Bug 26515: (follow-up) Do not count self when checking orders Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:26:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:26:01 +0000 Subject: [Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111003|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 111032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111032&action=edit Bug 26582: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:26:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:26:08 +0000 Subject: [Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111004|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 111033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111033&action=edit Bug 26582: Add Koha::Acquisition::Basket->close This patch adds two methods to Koha::Acquisition::Basket: - 'closed': that tells if the basket is closed - 'close': that closes the basket It inherits the behaviour from CloseBasket (as it actually makes sense). It improves CloseBasket by wrapping the action inside a transaction. It uses the $orders->update call with no_trigger as there's no trigger to trigger and the update can be done on a single DB call. A new exceptions file is added for basket-related exceptions. The only specific exception that gets added is Koha::Exceptions::Acquisition::Basket::AlreadyClosed To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:26:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:26:45 +0000 Subject: [Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Works as expected, tests pass.. QA Script throws a false failure (POD). Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:29:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:29:53 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Martin Renvoize --- Sorry dude.. sha1 error on application.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:33:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:33:02 +0000 Subject: [Koha-bugs] [Bug 26232] undefined fine grace period kills koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 didier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108434|0 |1 is obsolete| | --- Comment #5 from didier --- Created attachment 111034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111034&action=edit Bug 26232: Empty smart rule fine grace period Staff can create smart rules with empty (undefined) fine grace period. In Overdues.pm undefined firstremind means 0, do the same in Circulation.pm. To test: 1. Apply these patches 2. Run: kshell prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:41:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:41:10 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 --- Comment #3 from Tomás Cohen Arazi --- Will revisit the dependency tree -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:42:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:42:18 +0000 Subject: [Koha-bugs] [Bug 26577] Make basket.pl and cancelorder.pl use $order->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26577 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110993|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 111035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111035&action=edit Bug 26577: Make basket.pl and cancelorder.pl use ->cancel This patch makes the mentioned controller scripts use the new $order->cancel method instead of DelOrder. To test: 1. Apply this patches 2. Have a basket with some orders 3. Play with cancelling orders and removing baskets => SUCCESS: No behaviour change! => SUCCESS: No errors! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:42:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 11:42:50 +0000 Subject: [Koha-bugs] [Bug 26577] Make basket.pl and cancelorder.pl use $order->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26577 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- It's great to see this scripts getting tidied up.. works as expected. Signing off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:10:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:10:43 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:12:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:12:37 +0000 Subject: [Koha-bugs] [Bug 26594] New: Patrons merge problem with restriction Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Bug ID: 26594 Summary: Patrons merge problem with restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:12:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:12:51 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:12:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:12:58 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 [Bug 9302] Add ability to merge patron records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:12:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:12:58 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 [Bug 26594] Patrons merge problem with restriction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:19:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:19:58 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:20:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:20:03 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #1 from Fridolin SOMERS --- Created attachment 111036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111036&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:21:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:21:55 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #2 from Fridolin SOMERS --- I'm working on a unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:34:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:34:43 +0000 Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #91 from Andrew Fuerste-Henry --- With bug 26577 and all its dependencies applied, I created a new bib and item by adding a new title to a cart. I deleted the item and then the bib without cancelling the order, reloaded the basket page, and clicked "Cancel order." I got this error: Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/cancelorder.pl line 60. at /usr/share/perl/5.24/Carp.pm line 167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:36:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:36:54 +0000 Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #36 from Jonathan Druart --- We have a failure, can you have a look please? t/db_dependent/www/search_utf8.t .. 24/99 # Failed test 'Base is like "(?^u:opac-search.pl\?(idx=&)?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"' # at t/db_dependent/www/search_utf8.t line 300. # got: "http://koha:8080/cgi-bin/koha/opac-search.pl?weigh"... # length: 93 # doesn't match '(?^u:opac-search.pl\?(idx=&)?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)' t/db_dependent/www/search_utf8.t .. 57/99 # Failed test 'Base is like "(?^u:opac-search.pl\?(idx=&)?q=Ram%C3%B2n)"' # at t/db_dependent/www/search_utf8.t line 300. # got: "http://koha:8080/cgi-bin/koha/opac-search.pl?weigh"... # length: 73 # doesn't match '(?^u:opac-search.pl\?(idx=&)?q=Ram%C3%B2n)' t/db_dependent/www/search_utf8.t .. 89/99 # Failed test 'Base is like "(?^u:opac-search.pl\?(idx=&)?q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)"' # at t/db_dependent/www/search_utf8.t line 300. # got: "http://koha:8080/cgi-bin/koha/opac-search.pl?weigh"... # length: 95 # doesn't match '(?^u:opac-search.pl\?(idx=&)?q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:45:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:45:12 +0000 Subject: [Koha-bugs] [Bug 26577] Make basket.pl and cancelorder.pl use $order->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10869 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:45:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:45:12 +0000 Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:50:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:50:40 +0000 Subject: [Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- Does no longer apply, please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:55:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:55:44 +0000 Subject: [Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #27 from Jonathan Druart --- The pref is still used % git grep -i AllowPurchaseSuggestionBranchChoice **/*.pm **/*.pl **/*.t C4/UsageStats.pm: AllowPurchaseSuggestionBranchChoice installer/data/mysql/updatedatabase.pl: $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('AllowPurchaseSuggestionBranchChoice', 0, 'Allow user to choose branch when making a purchase suggestion','1','YesNo')"); opac/opac-suggestions.pl:if ( C4::Context->preference("AllowPurchaseSuggestionBranchChoice") ) { t/db_dependent/UsageStats.t: AllowPurchaseSuggestionBranchChoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:59:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 12:59:41 +0000 Subject: [Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #5 from Martin Renvoize --- Created attachment 111037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111037&action=edit Bug 21883: Pass the item to the template This patch update the controller to pass a full item object to the template instead of a subset of item fields and updates the template to utilise the object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:00:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:00:05 +0000 Subject: [Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 --- Comment #6 from Martin Renvoize --- Created attachment 111038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111038&action=edit Bug 21883: AddShow authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value Description during check-in. This patch adds this display. Add for easier translation. Also adds class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item is withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item is withdrawn' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:00:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:00:44 +0000 Subject: [Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82810|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:01:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:01:05 +0000 Subject: [Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Martin Renvoize --- Adopted.. Patche reworked as requested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:01:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:01:12 +0000 Subject: [Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |martin.renvoize at ptfs-europe |m |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:06:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:06:48 +0000 Subject: [Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #37 from Jonathan Druart --- Created attachment 111039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111039&action=edit Bug 24155: Fix parameter order to fix search_utf8.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:11:00 +0000 Subject: [Koha-bugs] [Bug 26579] Remove unused C4::Acquisition::DelOrder function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26579 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:11:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:11:06 +0000 Subject: [Koha-bugs] [Bug 26579] Remove unused C4::Acquisition::DelOrder function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26579 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110996|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 111040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111040&action=edit Bug 26579: Remove unused C4::Acquisition::DelOrder function This patch removes an unused function, its tests, and adjusts other test files that relied on it by replacing it with $order->cancel calls. To test: 1. Run: $ kshell k$ prove t/db_dependent/Acquisition.t \ t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t \ t/db_dependent/Acquisition/close_reopen_basket.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:15:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:15:23 +0000 Subject: [Koha-bugs] [Bug 18170] Show damaged status on check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110705|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 111041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111041&action=edit Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:15:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:15:34 +0000 Subject: [Koha-bugs] [Bug 18170] Show damaged status on check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #14 from Martin Renvoize --- Created attachment 111042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111042&action=edit Bug 18170: Use GetDescriptionByKohaField -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:16:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:16:04 +0000 Subject: [Koha-bugs] [Bug 18170] Show damaged status on check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:17:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:17:41 +0000 Subject: [Koha-bugs] [Bug 26580] Remove unused C4::Acquisition::DelBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26580 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:17:47 +0000 Subject: [Koha-bugs] [Bug 26580] Remove unused C4::Acquisition::DelBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26580 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110997|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 111043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111043&action=edit Bug 26580: Remove unused C4::Acquisition::DelBasket function Bug 26577 removed the only use of it. To test: 1. Apply this patch 2. Run: $ git grep DelBasket => SUCCESS: Only finds references to DelBasketGroup 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:32:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:32:47 +0000 Subject: [Koha-bugs] [Bug 26576] Subfield descriptions on authority detail view are cut off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:32:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:32:54 +0000 Subject: [Koha-bugs] [Bug 26576] Subfield descriptions on authority detail view are cut off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111000|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 111044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111044&action=edit Bug 26576: Subfield descriptions on authority detail view are cut off This patch corrects the authority detail view on the staff interface so that subfield descriptions are not longer output as truncated strings. For instance, before this patch the subfield description for 035$a would be "System control numbe" After the patch it should be "System control number." Based on the assumption that the subfield descriptions were truncated at some point for readability reasons I've also made some style changes intended to improve the readability of the page. To test, apply the patch and go to Authorities. - Search for and view the details for an authority. - On the authority detail page, confirm that subfield descriptions are shown in full. - Confirm that the style changes look good and make the data more readable. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:34:58 +0000 Subject: [Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110581|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 111045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111045&action=edit Bug 26506: Fix Koha::Account::pay if called when no user is logged-in Currently, Koha::Account::pay will fail if no user is logged-in when it is called. In this case, this patch will use undef instead of 0 for $manager_id in order to comply with the foreign key constraint on manager_id. Signed-off-by: Magnus Enger Biblibre and Libriotech have created a OPAC payment plugin that was having problems because of this bug. Applying the fix in this patch to a live server solved the problem. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:35:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:35:06 +0000 Subject: [Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #10 from Martin Renvoize --- Created attachment 111046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111046&action=edit Bug 26506: (QA follow-up) Add Unit Test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:35:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:35:19 +0000 Subject: [Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:35:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:35:54 +0000 Subject: [Koha-bugs] [Bug 26576] Subfield descriptions on authority detail view are cut off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I like the visual improvements. My only minor quibble (and I don't have any suggestions) is that the italic text in blue - people may think it is a link. Everywhere else in the staff interface, such as the catalog, thinks you can click on such as the subjects or authors are in blue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:42:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:42:55 +0000 Subject: [Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 --- Comment #7 from Martin Renvoize --- Dont' suppose you fancied testing/signing off on bug 24786 did you Kelly? It's a dependency here so you effectively tested it whilst testing this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:46:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:46:50 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #64 from Martin Renvoize --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:58:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:58:44 +0000 Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging plugin scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:58:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2020 13:58:51 +0000 Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging plugin scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109857|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 111047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111047&action=edit Bug 25354: Clean up JavaScript markup in cataloging plugin scripts This patch makes some minor changes to the JavaScript generated by the cataloging plugins: