[Koha-bugs] [Bug 22818] ILL should be able to send notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

--- Comment #103 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think I spotted a rebase issue ( :( ) in Illrequest.pm:

In the last iteration pushed by Martin we had:
-        my $from = $branch->branchillemail || $branch->branchemail;
-        my $replyto = $branch->branchreplyto || $from;
+        my $from = $branch->branchemail;
+        my $replyto = $branch->inbound_ill_address;

But now it reads:
-        my $from = $library->branchemail;
-        my $reply_to = $library->branchreplyto || $from;
+        my $from = $branch->branchillemail || $branch->branchemail;
+        my $replyto = $branch->branchreplyto || $from;


I feel the first one is correct as it will work for libraries using a mail
server outside their domain and thus allow wider use of the feature. It looks
like the very last patch changed it back.

-- 
You are receiving this mail because:
You are watching all bug changes.