From bugzilla-daemon at bugs.koha-community.org Sun Aug 1 16:03:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Aug 2021 14:03:48 +0000
Subject: [Koha-bugs] [Bug 28789] New: add ability to show branch groups
before branches in dropdown menu
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28789
Bug ID: 28789
Summary: add ability to show branch groups before branches in
dropdown menu
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: mathsabypro at gmail.com
QA Contact: testopia at bugs.koha-community.org
If opac_search_limit is activated the dropdown menu shows individual branches
before branch groups.
For some libraries (most of them?) it would be preferable to show the groups
before the individual branches. It should be a syspref or an option in branch
group configuration page.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Aug 1 16:14:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Aug 2021 14:14:04 +0000
Subject: [Koha-bugs] [Bug 28790] New: add ability to use branch groups codes
instead of id
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28790
Bug ID: 28790
Summary: add ability to use branch groups codes instead of id
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: mathsabypro at gmail.com
QA Contact: testopia at bugs.koha-community.org
If opac_search_limit is activated you can filter a search by library group ,
but the URL uses the id of the group (ex :
"branch_group_limit=multibranchlimit-34).
This id is not visible in library group configuration page.
It should be possible to use the code of the group, for example
"branch_group_limit=multibranchlimit-MYGROUP"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 00:21:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Aug 2021 22:21:30 +0000
Subject: [Koha-bugs] [Bug 20463] Create an index for LDR,
pos 19 - Multipart resource record level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463
Hayley Pelham changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 00:21:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Aug 2021 22:21:33 +0000
Subject: [Koha-bugs] [Bug 20463] Create an index for LDR,
pos 19 - Multipart resource record level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463
Hayley Pelham changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123238|0 |1
is obsolete| |
--- Comment #3 from Hayley Pelham ---
Created attachment 123355
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123355&action=edit
Bug 20463: Adding index for Leader 19 Multipart resource record level
Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 09:04:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 07:04:20 +0000
Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent
biblionumber gives internal server error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779
Andrew Nugged changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nugged at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 10:44:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 08:44:42 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods
overlap with existing holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
--- Comment #97 from Fridolin Somers ---
In CanBookBeRenewed(), $date_due is computed even if system preference
PreventCheckoutOnSameReservePeriod is off.
This has an impact on performance.
We may add if PreventCheckoutOnSameReservePeriod earlier.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:09:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:09:52 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #93 from Jonathan Druart ---
As it, we are moving the atomic updates to the db_rev directory. Is it the
behaviour we want?
Should we 1. support both syntaxes (.perl and .pl) in
installer/data/mysql/atomicupdate or 2. keep this directory for the old syntax
and new atomic updates will be expected in installer/data/mysql/db_revs?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:11:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:11:53 +0000
Subject: [Koha-bugs] [Bug 28791] New: make a distinction between public
lists in OPAC and staff interface
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28791
Bug ID: 28791
Summary: make a distinction between public lists in OPAC and
staff interface
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: mathsabypro at gmail.com
QA Contact: testopia at bugs.koha-community.org
Lists of records can be created for internal needs or for the users. But
currently a "public" list is visible in OPAC and staff interface.
There should be a way to make a list visible for all librarians in staff
interface but not in OPAC.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:13:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:13:33 +0000
Subject: [Koha-bugs] [Bug 28791] make a distinction between public lists in
OPAC and staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28791
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun
| |ity.org
CC| |m.de.rooy at rijksmuseum.nl
Component|OPAC |Lists
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:22:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:22:49 +0000
Subject: [Koha-bugs] [Bug 28792] New: select all the results after a search
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28792
Bug ID: 28792
Summary: select all the results after a search
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching
Assignee: koha-bugs at lists.koha-community.org
Reporter: mathsabypro at gmail.com
QA Contact: testopia at bugs.koha-community.org
After a search in staff interface, the "Select all" link only select the
results displayed on the current page.
There should be a way to really select all results, for example to put them in
a list or to export them.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:25:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:25:51 +0000
Subject: [Koha-bugs] [Bug 28793] New: ability to download and send results
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28793
Bug ID: 28793
Summary: ability to download and send results
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching
Assignee: koha-bugs at lists.koha-community.org
Reporter: mathsabypro at gmail.com
QA Contact: testopia at bugs.koha-community.org
After a search, you need to create a cart or a list to download the results or
send them by email.
It is not intuitive, and it should be possible directly from the result page.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:31:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:31:07 +0000
Subject: [Koha-bugs] [Bug 28794] New: ability to make a list visible for a
specific period
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28794
Bug ID: 28794
Summary: ability to make a list visible for a specific period
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Lists
Assignee: koha-bugs at lists.koha-community.org
Reporter: mathsabypro at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
It would be nice if the visibility of a list could be programmed in advanced,
for example if the list is created to support a specific event like an
exhibition, or a school program.
For example a list created the 1 jan 2021 could be programmed to be visible
from the 1 fev 2021 to the 1 june 2021
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:33:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:33:31 +0000
Subject: [Koha-bugs] [Bug 28795] New: ability to add metadata to lists
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28795
Bug ID: 28795
Summary: ability to add metadata to lists
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Lists
Assignee: koha-bugs at lists.koha-community.org
Reporter: mathsabypro at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
It could be useful to add metadata to lists, for sorting and managing them. For
example a subject field, or some generic fields customisable by the libray,
like in patron records
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:39:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 09:39:10 +0000
Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734
--- Comment #7 from mathieu saby ---
This is still needed...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:15:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:15:59 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #94 from Jonathan Druart ---
Created attachment 123356
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123356&action=edit
Bug 25078: Keep atomic updates in "atomicupdate" dir
The atomicupdate directory will contain all the atomic update files (old
and new version).
That will ease job for the RM and RMaints, no file (except skeletons)
must be in this directory before push.
This patch also fixes an inconsistency we had: the atomic update was run
before the other db revs on the UI but after when the CLI script was
used.
Now we make sure that the CLI does not deal with the atomic update files
when called from the installer (UI)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:17:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:17:48 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123356|0 |1
is obsolete| |
--- Comment #95 from Jonathan Druart ---
Created attachment 123357
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123357&action=edit
Bug 25078: Keep atomic updates in "atomicupdate" dir
The atomicupdate directory will contain all the atomic update files (old
and new version).
That will ease job for the RM and RMaints, no file (except skeletons)
must be in this directory before push.
This patch also fixes an inconsistency we had: the atomic update was run
before the other db revs on the UI but after when the CLI script was
used.
Now we make sure that the CLI does not deal with the atomic update files
when called from the installer (UI)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:19:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:19:25 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #96 from Jonathan Druart ---
https://snipboard.io/W7skMG.jpg
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:29:31 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122665|0 |1
is obsolete| |
--- Comment #97 from Jonathan Druart ---
Created attachment 123358
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123358&action=edit
Bug 25078: Put db revs into different files to handle them better
This patch suggests to stop using updatedatabase.pl to add new DB revs.
Each DB rev will be in a separate pl files (installer/data/mysql/db_revs).
The switch should ideally be done from 21.06.00.000.
Each DBrev is executed in a try block and a transaction. If something
went wrong, the whole DB rev is rolled back.
Why do /var/log/koha/kohadev/updatedatabase_*.log (not -error) contain
Status: 500
Content-type: text/html
Software error:
etc.
Test plan:
- git checkout c4b4db21d25 (master on 2021-07-08)
- Set the version syspref to 21.0500000:
> update systempreferences set value="21.0500000" where variable="version";
- Apply "Bug 25078: [DO NOT PUSH] DB revs for testing" (restart_all)
- Read the different DBrevs created as examples
- Make sure the different use cases are covered
- execute the updatedatabase script (CLI)
- Set the version syspref to 21.0500000
- Update the DB from the UI
- Set the version syspref to 21.0500000
- execute the updatedatabase script with the --force parameter (for
testing purpose)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:29:37 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122666|0 |1
is obsolete| |
--- Comment #98 from Jonathan Druart ---
Created attachment 123359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123359&action=edit
Bug 25078: [DO NOT PUSH] DB revs for testing
Use with the --force flag:
% updatedatabase --force
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:29:43 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122667|0 |1
is obsolete| |
--- Comment #99 from Jonathan Druart ---
Created attachment 123360
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123360&action=edit
Bug 25078: Re-introduce NewVersion
This is ugly, we re-add the code we removed in the previous patch.
We need to continue supporting "old" versions.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:29:49 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122668|0 |1
is obsolete| |
--- Comment #100 from Jonathan Druart ---
Created attachment 123361
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123361&action=edit
Bug 25078: Separate update "report" from its description
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:29:54 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122669|0 |1
is obsolete| |
--- Comment #101 from Jonathan Druart ---
Created attachment 123362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123362&action=edit
Bug 25078: (follow-up) Update 'NewVersion' for output_version changes
This patch updates the NewVersion compatability method to add arrayref
description handling to split it into description + report.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:30:00 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #102 from Jonathan Druart ---
Created attachment 123363
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123363&action=edit
Bug 25078: Move DB revs up to 21.06.00.011
Updated on 2021-08-02 for 21.06.00.011
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:30:05 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122679|0 |1
is obsolete| |
--- Comment #103 from Jonathan Druart ---
Created attachment 123364
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123364&action=edit
Bug 25078: Close open filehandle
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:30:10 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122680|0 |1
is obsolete| |
--- Comment #104 from Jonathan Druart ---
Created attachment 123365
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123365&action=edit
Bug 25078: Fix encoding issue with db_revs output
>From `perldoc -f open`:
The scalars for in-memory files are treated as octet strings: unless the
file is being opened with truncation the scalar may not contain any code
points over 0xFF.
So $out need to be decoded first in order to be used in other Perl
strings
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:30:16 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122875|0 |1
is obsolete| |
--- Comment #105 from Jonathan Druart ---
Created attachment 123366
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123366&action=edit
Bug 25078: Fix 'Wide character' from CLI
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:30:21 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123357|0 |1
is obsolete| |
--- Comment #106 from Jonathan Druart ---
Created attachment 123367
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123367&action=edit
Bug 25078: Keep atomic updates in "atomicupdate" dir
The atomicupdate directory will contain all the atomic update files (old
and new version).
That will ease job for the RM and RMaints, no file (except skeletons)
must be in this directory before push.
This patch also fixes an inconsistency we had: the atomic update was run
before the other db revs on the UI but after when the CLI script was
used.
Now we make sure that the CLI does not deal with the atomic update files
when called from the installer (UI)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 10:30:45 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
a transaction and better error handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #107 from Jonathan Druart ---
Patches (and remote branch) rebased on top of master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:04:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:04:40 +0000
Subject: [Koha-bugs] [Bug 28796] New: wrong number of parameters in
new_from_xml call
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796
Bug ID: 28796
Summary: wrong number of parameters in new_from_xml call
Change sponsored?: ---
Product: Koha
Version: 20.11
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: MARC Bibliographic record staging/import
Assignee: koha-bugs at lists.koha-community.org
Reporter: didier.gautheron at biblibre.com
QA Contact: testopia at bugs.koha-community.org
Hi,
It seems to me that
C4/ImportBatch.pm: my $old_marc =
MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8',
$rowref->{'encoding'}, $marc_type);
Is calling MARC::Record->new_from_xml with the wrong number of parameters and
$marc_type is ignored it should be either:
MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $marc_type);
or:
MARC::Record->new_from_xml(StripNonXmlChars($oldxml),$rowref->{'encoding'} ,
$marc_type);
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:21:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:21:32 +0000
Subject: [Koha-bugs] [Bug 28792] select all the results after a search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28792
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #1 from Owen Leonard ---
*** This bug has been marked as a duplicate of bug 7010 ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:21:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:21:32 +0000
Subject: [Koha-bugs] [Bug 7010] Select all records from search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathsabypro at gmail.com
--- Comment #6 from Owen Leonard ---
*** Bug 28792 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:29:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:29:33 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:29:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:29:37 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626
--- Comment #1 from Nick Clemens ---
Created attachment 123368
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123368&action=edit
Bug 26626: Add 'Ignore' option to confirmed holds modal
This patch adds 'Ignore' to the 'Hold already waiting' modal
To test:
To recreate:
1 - Place a hold for pickup at library A
2 - Checkin the item at Library A
3 - Note the modal has 'Ignore' option
4 - Click it, nothing happens
5 - Check in the item again, same modal
6 - Click 'Confirm'
7 - Check in the item again
8 - Now 'Ignore' is replaced by 'Cancel'
9 - Click 'Confirm' to dismiss modal
10 - Apply patch
11 - Check the item in again
12 - Note 'Ignore' button before 'Cancel' button with '-' icon
13 - Go to biblio holds page
14 - Revert waiting status
15 - Check item in again
16 - Note ignore now has '-' (minus) icon
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:29:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:29:45 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:37:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:37:12 +0000
Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build
resumption token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741
--- Comment #4 from Tomás Cohen Arazi ---
Created attachment 123369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123369&action=edit
Bug 28741: Regression tests
This patch adds regression tests for the behavior.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:42:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:42:28 +0000
Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent
biblionumber gives internal server error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779
Peter Vashchuk changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123330|0 |1
is obsolete| |
Attachment #123331|0 |1
is obsolete| |
--- Comment #10 from Peter Vashchuk ---
Created attachment 123370
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123370&action=edit
Bug 28779: Skip processing of non-existent biblios
Just checking with a regex that whether an input looks like a biblionumber
is not enough, we need to also verify there is a biblio really existing
in the database and skip processing of hold request for non-existent
biblionumbers.
To test:
1) Go to page /cgi-bin/koha/reserve/request.pl?biblionumbers=XXXXX
where XXXXX is non-existent biblionumber, notice internal server error
2) Apply patch
3) Repeat step 1 and notice we cannot place a hold
Signed-off-by: Owen Leonard
Signed-off-by: Nick Clemens
Signed-off-by: Petro Vashchuk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:42:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:42:32 +0000
Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent
biblionumber gives internal server error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779
--- Comment #11 from Peter Vashchuk ---
Created attachment 123371
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123371&action=edit
Bug 28779: (QA follow-up) More specific message and soem cleanup
Signed-off-by: Nick Clemens
Signed-off-by: Petro Vashchuk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:47:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:47:38 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #80 from Jonathan Druart ---
Created attachment 123372
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123372&action=edit
Bug 27526: Add tests for columns_to_str and host_items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:48:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:48:14 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #81 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #79)
> I will provide the missing tests next week. Thanks for the reminder!
Done!
And I found a bug, so tests++ :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:52:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:52:49 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626
--- Comment #2 from Owen Leonard ---
Created attachment 123373
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123373&action=edit
Dialog with revised icons
I think the minus symbol isn't very understandable. What about using the
"trash" icon (which we use in other situations for "delete") for the cancel
operation? See the attached mockup.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:58:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:58:52 +0000
Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:58:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 12:58:55 +0000
Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #119626|0 |1
is obsolete| |
--- Comment #2 from Andrew Fuerste-Henry ---
Created attachment 123374
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123374&action=edit
Bug 28153: Add 'Hold reminder' messaging preference
This adds a new preference for patrons to choose how they wish to receive
'Hold reminder' notices.
The notice is always digested per branch
To test:
1 - Apply patches
2 - Update database
3 - Ensure EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC
are enabled
4 - View a patron and note new messaging preference
5 - Confirm same on the opac for a patron account
6 - All transports should be disabled by default
7 - Place a hold for the patron and check it in to confirm
8 - Run hold reminder script
perl misc/cronjobs/holds_reminder.pl -v -c
9 - No message should be queued for patron
10 - Enable the message in a transport for which 'HOLD_REMINDER' notice has
content for the patron
11 - Run the script
12 - Patron should have a message queued
13 - Ensure a different transport has content for the notice
14 - Run the script forcing a transport
perl misc/cronjobs/holds_reminder.pl -v -c -mtt=print
15 - The patron should have a message queued in the forced transport
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:03:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:03:31 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626
--- Comment #3 from Andrew Fuerste-Henry ---
I like the idea of promoting icon consistency. I'm happy to defer to Owen on
questions of minuses and garbage cans :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:05:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:05:19 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626
--- Comment #4 from Nick Clemens ---
(In reply to Owen Leonard from comment #2)
> Created attachment 123373 [details]
> Dialog with revised icons
>
> I think the minus symbol isn't very understandable. What about using the
> "trash" icon (which we use in other situations for "delete") for the cancel
> operation? See the attached mockup.
That sounds good to me! Did you code it already, or shall I attempt?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:11:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:11:29 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:12:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:12:25 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Text to go in the| |Sponsored-by: Orex Digital
release notes| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:14:15 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #1 from Jonathan Druart ---
Created attachment 123375
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123375&action=edit
Bug 28786: Add new syspref TwoFactorAuthentication
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:14:19 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #2 from Jonathan Druart ---
Created attachment 123376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123376&action=edit
Bug 28786: Add new DB column borrowers.secret
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:14:22 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #3 from Jonathan Druart ---
Created attachment 123377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123377&action=edit
Bug 28786: Add new DB column borrowers.auth_method
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:14:26 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #4 from Jonathan Druart ---
Created attachment 123378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123378&action=edit
Bug 28786: Add controller script and template
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:14:30 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #5 from Jonathan Druart ---
Created attachment 123379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123379&action=edit
Bug 28786: Two-factor authentication for staff client - TOTP
This patchset introduces the Two-factor authentication (2FA) idea in
Koha.
It is far for complete, and only implement one way of doing it, but at
least it's a first step.
The idea here is to offer the librarian user the ability to
enable/disable 2FA when logging in to Koha.
It will use time-based, one-time passwords (TOTP) as the second factor,
an application to handle that will be required.
https://en.wikipedia.org/wiki/Time-based_One-Time_Password
More developements are possible on top of this:
* Send a notice (sms or email) with the code
* Force 2FA for librarians
* Implementation for OPAC
* WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/
Test plan:
0.
a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all
b. To test this you will need an app to generate the TOTP token, you can
use FreeOTP that is open source and easy to use.
1. Turn on TwoFactorAuthentication
2. Go to your account, click 'More' > 'Manage Two-Factor authentication'
3. Click Enable, scan the QR code with the app, insert the pin code and
register
4. Your account now requires 2FA to login!
5. Notice that you can browse until you logout
6. Logout
7. Enter the credential and the pincode provided by the app
8. Logout
9. Enter the credential, no pincode
10. Confirm that you are stuck on the second auth form (ie. you cannot
access other Koha pages)
11. Click logout => First login form
12. Enter the credential and the pincode provided by the app
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:14:34 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #6 from Jonathan Druart ---
Created attachment 123380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123380&action=edit
Bug 28786: Improve readability in C4::Auth::checkauth
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:14:38 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #7 from Jonathan Druart ---
Created attachment 123381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123381&action=edit
Bug 28786: DBIC schema changes
Sponsored-by: Orex Digital
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:16:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:16:10 +0000
Subject: [Koha-bugs] [Bug 28797] New: Hold reminder email should use All
Libraries notice
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28797
Bug ID: 28797
Summary: Hold reminder email should use All Libraries notice
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Command-line Utilities
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: robin at catalyst.net.nz
Depends on: 15986
Bug 15986 introduces a hold reminder email. It only knows how to use
branch-specific notices and will fail if your only HOLD_REMINDER notice is for
All Libraries.
To confirm:
- have a patron with a valid email address and Hold notices set to go out via
email in their messaging prefs
- place a hold for your patron, get it to Waiting status
- confirm that you have the default HOLD_REMINDER email notice for All
Libraries but no library-specific HOLD_REMINDER notice
- perl misc/cronjobs/holds/holds_reminder.pl -c -v to run the holds reminder
cron
- get "Message 'HOLD_REMINDER' content not found for [your branch]"
- create the notice for your branch
- re-run the cron
- patron gets notice
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
[Bug 15986] Add a script for sending hold waiting reminder notices
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:16:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:16:10 +0000
Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting
reminder notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28797
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28797
[Bug 28797] Hold reminder email should use All Libraries notice
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:18:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:18:40 +0000
Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build
resumption token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:18:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:18:43 +0000
Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build
resumption token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123369|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:18:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:18:45 +0000
Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build
resumption token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123066|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:19:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:19:35 +0000
Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build
resumption token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741
--- Comment #5 from Tomás Cohen Arazi ---
Created attachment 123382
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123382&action=edit
Bug 28741: Regression tests
This patch adds regression tests for the behavior.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:19:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:19:39 +0000
Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build
resumption token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741
--- Comment #6 from Tomás Cohen Arazi ---
Created attachment 123383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123383&action=edit
Bug 28741: Fix use of resumption token params
TO test:
1 - Enable OAI-PMH server in Koha
2 - Set OAI-PMH:MaxCount to 5
3 - Define 6 sets in Admin->OAI sets configuration
Can setSpec and setName to 1,2,3....
4 - Browse to:
http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListSets
5 - Click 'Show more'
6 - Keep seeing the same 5 - note the page says 'Results fetched -4-0'
7 - Apply patch
8 - Restart all the things
9 - Reload the ListSets URL above
10 - Click 'Show more'
11 - See the 6th set and note no 'Show more'
12 - Set OAI-PMH:MaxCount to 1
13 - Go to the base ListSets url again
14 - Confirm you can 'Show more' until you reach the end
Signed-off-by: David Nind
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:19:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:19:44 +0000
Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build
resumption token
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741
--- Comment #7 from Tomás Cohen Arazi ---
Created attachment 123384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123384&action=edit
Bug 28741: (follow-up) Silence warning
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:34:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:34:15 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator
- Patron Search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|cnighswonger at foundations.ed |michael.hafen at washk12.org
|u |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:34:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:34:21 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator
- Patron Search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:47:31 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:47:35 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122040|0 |1
is obsolete| |
Attachment #122041|0 |1
is obsolete| |
Attachment #122042|0 |1
is obsolete| |
Attachment #122043|0 |1
is obsolete| |
Attachment #122044|0 |1
is obsolete| |
Attachment #122045|0 |1
is obsolete| |
--- Comment #56 from Nick Clemens ---
Created attachment 123385
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123385&action=edit
Bug 24190: Add acquisition logging
Signed-off-by: Maura Stephens
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:47:40 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #57 from Nick Clemens ---
Created attachment 123386
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123386&action=edit
Bug 24190: (follow-up) Cancel order del item bug
If an order is cancelled but the associated bib / items are unable to be
removed, we go into error handling. We still need to log the
cancellation though. So this fix moves the logging to just after the
cancellation, so it will be logged regardless of the outcome with
associated things.
Signed-off-by: Maura Stephens
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:47:44 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #58 from Nick Clemens ---
Created attachment 123387
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123387&action=edit
Bug 24190: (follow-up) Respond to QA feedback
This commit makes changes in response to Jonathan's feedback in comment
- Moved from using zero padded strings to store log data to a JSON
object
- Stopped storing formatted dates in logged data
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:47:49 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #59 from Nick Clemens ---
Created attachment 123388
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123388&action=edit
Bug 24190: (follow-up) Add tests
In response to Jonathan's request for tests, I have now added additional
tests for the methods in C4/Budgets.pm that do logging
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:47:53 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #60 from Nick Clemens ---
Created attachment 123389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123389&action=edit
Bug 24190: (follow-up) Modify order of logging
Basket creation involves two steps in Koha, creating the basket then
modifying its header. We were logging these two steps in the wrong
order. This commit fixes that.
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:47:57 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #61 from Nick Clemens ---
Created attachment 123390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123390&action=edit
Bug 24190: (follow-up) Rename AcqLog
As requested in comment #49, renamed uses of AcqLog to AcquisitionLog
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:48:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:48:01 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #62 from Nick Clemens ---
Created attachment 123391
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123391&action=edit
Bug 24190: (QA follow-up) record unchanged bookfund and fix typo
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:49:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:49:29 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #63 from Nick Clemens ---
Slight rebase and small follow-up to record when fund is not changed upon
receipt.
While I would like to see fuller logging of objects these patches add more
information and will help track acquisitions so I think further enhancements
can be on follow up bugs.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:55:44 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:55:47 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123320|0 |1
is obsolete| |
Attachment #123321|0 |1
is obsolete| |
Attachment #123322|0 |1
is obsolete| |
Attachment #123323|0 |1
is obsolete| |
--- Comment #10 from Owen Leonard ---
Created attachment 123392
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123392&action=edit
Bug 28785: Centralize cookie auth check in check_cookie_auth
This code is duplicated in 3 different places, we must call
check_cookie_auth instead.
It makes check_cookie_auth returns a 'restricted' when
SessionRestrictionByIP is set and the IP changed.
It also returns a third parameters contained the old and new IP, to fill
the "info" hash in checkauth but apparently the oldip and newip
variables are not even used from the template. We may want to remove it
completely.
No change is expected with this patch, the different authentication
methods should still work as before.
Test plan:
Log in the staff and OPAC interfaces, logout.
Log in and call script that call the 3 different subroutines modified by
this patch. For instance you can list checkouts (that is using
check_cookie_auth) and display a patron's image (using check_api_auth).
QA with good knowledge of the C4::Auth module and the different
authentication methods is required.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:55:51 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785
--- Comment #11 from Owen Leonard ---
Created attachment 123393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123393&action=edit
Bug 28785: Adjust check_cookie_auth calls
The previous patch makes check_cookie_auth return the session instead of
$sessionID, so we are adjusting the different calls to prevent
confusion.
However they are mainly used to check the authentication status and
don't care about this second variable.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:55:55 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785
--- Comment #12 from Owen Leonard ---
Created attachment 123394
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123394&action=edit
Bug 28785: Add skip_version_check for checkauth
We could have this patch but we also could decide to skip it. The idea
is to avoid 2 checks of the version when we are coming from checkauth.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 13:55:59 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785
--- Comment #13 from Owen Leonard ---
Created attachment 123395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123395&action=edit
Bug 28785: Don't send SessionRestrictionByIP to template
It's not used.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 16:10:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 14:10:17 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626
--- Comment #5 from Owen Leonard ---
I don't have a patch, so please attempt!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 18:29:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 16:29:36 +0000
Subject: [Koha-bugs] [Bug 28798] New: Allow ability to make OPAC hold
pick-up location mandatory
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798
Bug ID: 28798
Summary: Allow ability to make OPAC hold pick-up location
mandatory
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Currently, when placing a hold on the OPAC the pickup location defaults to
users branch, unless OPACHoldsIfAvailableAtPickup is set to 'don't allow'.
Many libraries like to force the user to make a branch selection and make this
field required. This can be done with JS but it would be nice if it was a
system preference.
I'd like to see a system preference like 'OPACHoldBranchMandatory' which would
add an empty value like: and upon
submission check to make sure something besides the empty value is selected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 19:07:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 17:07:30 +0000
Subject: [Koha-bugs] [Bug 28799] New: Action logs should capture lost items
found
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799
Bug ID: 28799
Summary: Action logs should capture lost items found
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Transaction logs
Assignee: koha-bugs at lists.koha-community.org
Reporter: hebah at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
*Mark item lost
*Check action log for item to show lost status change
*Check item back in
*Action log doesn't update with lost status change
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 19:16:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 17:16:52 +0000
Subject: [Koha-bugs] [Bug 28800] New: Libabry list at
/cgi-bin/koha/admin/branches.pl appears empty
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800
Bug ID: 28800
Summary: Libabry list at /cgi-bin/koha/admin/branches.pl
appears empty
Change sponsored?: ---
Product: Koha
Version: 21.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: System Administration
Assignee: koha-bugs at lists.koha-community.org
Reporter: egpetridis at yahoo.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
I've noticed that the list of libraries comes up empty, although libraries have
been defined.
When trying to create a new library with the same code as an existing one, the
expected error message appears, however one is left unable to manage the
existing libarries.
Video recording (54MB) available at
https://emedgroupgr-my.sharepoint.com/:v:/g/personal/mpetridis_emedgroup_gr/EcSNYW0Y_YxPoWnr2wkohWMBFABMw6-X2wbVyvXcV0o0KA?e=Cvnchg
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 19:23:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 17:23:12 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:19:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 18:19:49 +0000
Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up
location mandatory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798
--- Comment #1 from Owen Leonard ---
I'm curious, what is the motivation for forcing patrons to select a library?
Under what circumstances is the user's home library not an appropriate default?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:24:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 18:24:06 +0000
Subject: [Koha-bugs] [Bug 28800] Libabry list at
/cgi-bin/koha/admin/branches.pl appears empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800
--- Comment #1 from Owen Leonard ---
Can you check the browser console to see if there are JavaScript errors on the
page? It seems likely that an error is preventing the API from passing the
information to the DataTable.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:32:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 18:32:46 +0000
Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a
new 'holds' table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260
--- Comment #94 from Tomás Cohen Arazi ---
Created attachment 123396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123396&action=edit
Bug 25260: Fix pendingreserves.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:33:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 18:33:10 +0000
Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a
new 'holds' table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:46:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 18:46:40 +0000
Subject: [Koha-bugs] [Bug 28800] Libabry list at
/cgi-bin/koha/admin/branches.pl appears empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800
--- Comment #2 from Manos PETRIDIS ---
Errors in console are:
jquery-2.2.3.min_21.0501003.js:4 GET
http://192.168.1.148:8081/api/v1/libraries?_page=1&_per_page=20&q=%5B%5D&_match=contains&_order_by=%2Bme.name
404 (Not Found)
send @ jquery-2.2.3.min_21.0501003.js:4
ajax @ jquery-2.2.3.min_21.0501003.js:4
sa @ datatables.min_21.0501003.js:75
lb @ datatables.min_21.0501003.js:75
P @ datatables.min_21.0501003.js:67
T @ datatables.min_21.0501003.js:69
ha @ datatables.min_21.0501003.js:86
e @ datatables.min_21.0501003.js:131
(anonymous) @ datatables.min_21.0501003.js:131
each @ jquery-2.2.3.min_21.0501003.js:2
each @ jquery-2.2.3.min_21.0501003.js:2
n @ datatables.min_21.0501003.js:121
$.fn.api @ datatables_21.0501003.js:774
(anonymous) @ branches.pl:29830
i @ jquery-2.2.3.min_21.0501003.js:2
fireWith @ jquery-2.2.3.min_21.0501003.js:2
ready @ jquery-2.2.3.min_21.0501003.js:2
J @ jquery-2.2.3.min_21.0501003.js:2
and
datatables_21.0501003.js:515 DataTables warning: table id=libraries - Ajax
error. For more information about this error, please see
http://datatables.net/tn/7
jQuery.fn.dataTable.ext.errMode @ datatables_21.0501003.js:515
K @ datatables.min_21.0501003.js:113
error @ datatables.min_21.0501003.js:74
i @ jquery-2.2.3.min_21.0501003.js:2
fireWith @ jquery-2.2.3.min_21.0501003.js:2
z @ jquery-2.2.3.min_21.0501003.js:4
(anonymous) @ jquery-2.2.3.min_21.0501003.js:4
load (async)
send @ jquery-2.2.3.min_21.0501003.js:4
ajax @ jquery-2.2.3.min_21.0501003.js:4
sa @ datatables.min_21.0501003.js:75
lb @ datatables.min_21.0501003.js:75
P @ datatables.min_21.0501003.js:67
T @ datatables.min_21.0501003.js:69
ha @ datatables.min_21.0501003.js:86
e @ datatables.min_21.0501003.js:131
(anonymous) @ datatables.min_21.0501003.js:131
each @ jquery-2.2.3.min_21.0501003.js:2
each @ jquery-2.2.3.min_21.0501003.js:2
n @ datatables.min_21.0501003.js:121
$.fn.api @ datatables_21.0501003.js:774
(anonymous) @ branches.pl:29830
i @ jquery-2.2.3.min_21.0501003.js:2
fireWith @ jquery-2.2.3.min_21.0501003.js:2
ready @ jquery-2.2.3.min_21.0501003.js:2
J @ jquery-2.2.3.min_21.0501003.js:2
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:24:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:24:46 +0000
Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up
location mandatory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798
--- Comment #2 from Lucas Gass ---
(In reply to Owen Leonard from comment #1)
> I'm curious, what is the motivation for forcing patrons to select a library?
> Under what circumstances is the user's home library not an appropriate
> default?
Some librarians in multi-branch systems want users to consciously make a
decision about where they will pickup the hold.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:47:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:47:50 +0000
Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616
--- Comment #9 from Fridolin Somers ---
(In reply to Katrin Fischer from comment #8)
> (In reply to Fridolin Somers from comment #7)
> > For 20.11 waiting for Bug 28220
>
> Hi Frido, was this pushed to 20.11.x now?
Sorry no, Bug 28220 does not apply on 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:00 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:05 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123375|0 |1
is obsolete| |
--- Comment #8 from David Nind ---
Created attachment 123397
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123397&action=edit
Bug 28786: Add new syspref TwoFactorAuthentication
Sponsored-by: Orex Digital
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:09 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123376|0 |1
is obsolete| |
--- Comment #9 from David Nind ---
Created attachment 123398
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123398&action=edit
Bug 28786: Add new DB column borrowers.secret
Sponsored-by: Orex Digital
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:14 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123377|0 |1
is obsolete| |
--- Comment #10 from David Nind ---
Created attachment 123399
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123399&action=edit
Bug 28786: Add new DB column borrowers.auth_method
Sponsored-by: Orex Digital
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:20 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123378|0 |1
is obsolete| |
--- Comment #11 from David Nind ---
Created attachment 123400
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123400&action=edit
Bug 28786: Add controller script and template
Sponsored-by: Orex Digital
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:25 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123379|0 |1
is obsolete| |
--- Comment #12 from David Nind ---
Created attachment 123401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123401&action=edit
Bug 28786: Two-factor authentication for staff client - TOTP
This patchset introduces the Two-factor authentication (2FA) idea in
Koha.
It is far for complete, and only implement one way of doing it, but at
least it's a first step.
The idea here is to offer the librarian user the ability to
enable/disable 2FA when logging in to Koha.
It will use time-based, one-time passwords (TOTP) as the second factor,
an application to handle that will be required.
https://en.wikipedia.org/wiki/Time-based_One-Time_Password
More developements are possible on top of this:
* Send a notice (sms or email) with the code
* Force 2FA for librarians
* Implementation for OPAC
* WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/
Test plan:
0.
a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all
b. To test this you will need an app to generate the TOTP token, you can
use FreeOTP that is open source and easy to use.
1. Turn on TwoFactorAuthentication
2. Go to your account, click 'More' > 'Manage Two-Factor authentication'
3. Click Enable, scan the QR code with the app, insert the pin code and
register
4. Your account now requires 2FA to login!
5. Notice that you can browse until you logout
6. Logout
7. Enter the credential and the pincode provided by the app
8. Logout
9. Enter the credential, no pincode
10. Confirm that you are stuck on the second auth form (ie. you cannot
access other Koha pages)
11. Click logout => First login form
12. Enter the credential and the pincode provided by the app
Sponsored-by: Orex Digital
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:30 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123380|0 |1
is obsolete| |
--- Comment #13 from David Nind ---
Created attachment 123402
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123402&action=edit
Bug 28786: Improve readability in C4::Auth::checkauth
Sponsored-by: Orex Digital
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:53:35 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123381|0 |1
is obsolete| |
--- Comment #14 from David Nind ---
Created attachment 123403
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123403&action=edit
Bug 28786: DBIC schema changes
Sponsored-by: Orex Digital
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:58:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:58:12 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #15 from David Nind ---
Testing notes (koha-testing-docker):
- Tested with Google Authenticator app
- Tested with andOTP app (https://github.com/andOTP/andOTP)
- Everything work as per the test plan
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:58:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 19:58:43 +0000
Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in
/etc/default/koha-common
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #14 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:02:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:02:23 +0000
Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register
statistics wizard report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #8 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:04:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:04:31 +0000
Subject: [Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a
password check
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #22 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:06:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:06:03 +0000
Subject: [Koha-bugs] [Bug 27498] Add a link for the hold ratios to
acquisitions home page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #25 from Fridolin Somers ---
I prefer not impact display on oldstable 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:09:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:09:30 +0000
Subject: [Koha-bugs] [Bug 28418] Show template_id of MARC modification
templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28418
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #9 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:11:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:11:35 +0000
Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and
legends to tables and forms
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #9 from Fridolin Somers ---
Missing dependancies, not pushed to 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:12:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:12:43 +0000
Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log
debug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to stable |Pushed to oldstable
--- Comment #7 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:13:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:13:35 +0000
Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a
production server will NOT create duplicate fines and we should remove the
syspref warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #6 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:15:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:15:26 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
- TOTP
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Text to go in the| |This enhancement adds an
release notes| |initial optional
| |implementation of
| |two-factor authentication
| |(2FA) to improve security
| |when logging into the staff
| |interface.
| |
| |This
| |implementation uses
| |time-based, one-time
| |passwords (TOTP) as the
| |second factor, letting
| |librarians use an
| |application to handle it
| |and provide them the code
| |they need when logging in.
| |
| |It is enabled using the new
| |system preference
| |"TwoFactorAuthentication".
| |
| |Librarians can then enable
| |2FA for their account from
| |More > Manage Two-Factor
| |authentication. To setup:
| |1) Scan the QR code with an
| |authenticator app. 2) Enter
| |the one time code
| |generated. For future
| |logins, librarians are
| |prompted to enter the
| |authenticator code after
| |entering their normal login
| |credentials.
| |
| |Any
| |authenticator app, such as
| |Google Authenticator,
| |andOTP, and many others can
| |be used. Applications that
| |enable backup of their 2FA
| |accounts (either
| |cloud-based or automatic)
| |are recommended.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:17:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:17:50 +0000
Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #7 from Fridolin Somers ---
I see it is in 21.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:18:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:18:18 +0000
Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
--- Comment #8 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:21:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:21:02 +0000
Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up
location mandatory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew at bywatersolutions.com
--- Comment #3 from Andrew Fuerste-Henry ---
I can see the utility of forcing a choice. As Lucas says, I've talked to
libraries that want this.
If we're creating a new syspref and monkeying with this field, could we go a
step further and make the syspref something like OPACHoldPickupDefault with the
options (Patron home library / Item home library / Item holding library / Force
a choice).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:23:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:23:03 +0000
Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up
location mandatory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798
--- Comment #4 from Lucas Gass ---
(In reply to Andrew Fuerste-Henry from comment #3)
> I can see the utility of forcing a choice. As Lucas says, I've talked to
> libraries that want this.
>
> If we're creating a new syspref and monkeying with this field, could we go a
> step further and make the syspref something like OPACHoldPickupDefault with
> the options (Patron home library / Item home library / Item holding library
> / Force a choice).
+1, I like this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:23:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:23:31 +0000
Subject: [Koha-bugs] [Bug 26205] News changes aren't logged
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=14233
CC| |fridolin.somers at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:23:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:23:31 +0000
Subject: [Koha-bugs] [Bug 14233] Add logging support to notices and slips
management
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=26205
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:24:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:24:04 +0000
Subject: [Koha-bugs] [Bug 26205] News changes aren't logged
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205
--- Comment #32 from Fridolin Somers ---
Does not apply on 20.11.x , mainly because of Bug 14233.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:25:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:25:03 +0000
Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses
inbound_email_address incorrectly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #40 from Fridolin Somers ---
Depends on Bug 15986 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:25:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:25:59 +0000
Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the
spec
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #12 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:32:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:32:31 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #10 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:34:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:34:59 +0000
Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on
circulation-home
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |27846
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #6 from Fridolin Somers ---
Introduced by Bug 27846
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846
[Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:34:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:34:59 +0000
Subject: [Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs
should be more accessible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28601
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601
[Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:35:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:35:20 +0000
Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on
circulation-home
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Fridolin Somers ---
Depends on Bug 27846 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:36:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:36:30 +0000
Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must
be removed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Resolution|--- |FIXED
Status|Pushed to stable |RESOLVED
--- Comment #6 from Fridolin Somers ---
I think we should not impact olders versions
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:38:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:38:33 +0000
Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the
translator tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #22 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:39:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:39:32 +0000
Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working in OPAC lists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299
--- Comment #29 from Fridolin Somers ---
Depends on Bug 18989 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:48:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:48:59 +0000
Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #9 from Fridolin Somers ---
It is a big visual change on items editor.
I propose not to impact older versions.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:55:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:55:12 +0000
Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to
understand the syntax of the search query
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:55:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:55:17 +0000
Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to
understand the syntax of the search query
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123181|0 |1
is obsolete| |
--- Comment #3 from David Nind ---
Created attachment 123404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123404&action=edit
Bug 28736: fix requirements for the correct error message to show up
There is existing error message in the code stating:
"Unable to understand your search query, please rephrase and try again."
which fits perfectly but because it looks for "ParseException" in the
warning output it doesn't show up on this page as it's actually
"parse_exception".
This patch makes that it's also checked if "parse_exception" is present
in the warning output.
To reproduce:
1) using ES search for something like "// ^ ! { } [ ] .. , <>" that
will for sure break the syntax of ES.
2) after the search query fails note that the error is
"Unable to perform your search. Please try again."
3) apply the patch
4) search for the same thing again
5) error message should be "Unable to understand your search query,
please rephrase and try again." now.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:56:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:56:10 +0000
Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we
should update 'lastseen' field on checkouts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #16 from Fridolin Somers ---
In this case i my opinion we should rename Koha::Patron::track_login into
track_activity, same for C4::Auth::track_login_daily.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:56:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 20:56:46 +0000
Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we
should update 'lastseen' field on checkouts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #17 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:08:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:08:50 +0000
Subject: [Koha-bugs] [Bug 28597] OPAC suggestions do not display news for
logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |26630
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #8 from Fridolin Somers ---
Depends on Bug 26630
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630
[Bug 26630] Allow custom text for each library on the purchase suggestion page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:08:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:08:50 +0000
Subject: [Koha-bugs] [Bug 26630] Allow custom text for each library on the
purchase suggestion page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28597
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
[Bug 28597] OPAC suggestions do not display news for logged in branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:09:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:09:24 +0000
Subject: [Koha-bugs] [Bug 28597] OPAC suggestions do not display news for
logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Fridolin Somers ---
Depends on Bug 26630 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:12:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:12:02 +0000
Subject: [Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already
in a transaction'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #10 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:13:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:13:49 +0000
Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to
properly collapse has_many results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
--- Comment #15 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:34:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:34:18 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
undefined value at C4/Reserves.pm line 607
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to stable |Pushed to oldstable
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
--- Comment #6 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:35:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:35:44 +0000
Subject: [Koha-bugs] [Bug 26760] Redirect to paycollect.pl when clicking on
"Save and pay"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #12 from Fridolin Somers ---
I propose we do not impact older versions behavior.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:37:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:37:12 +0000
Subject: [Koha-bugs] [Bug 27906] Add support for circulation status 9 (
waiting to be re-shelved )
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27906
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to stable |Pushed to oldstable
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
--- Comment #11 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:38:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:38:05 +0000
Subject: [Koha-bugs] [Bug 27907] Add support for circulation status 2 ( on
order )
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27907
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #10 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:38:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:38:50 +0000
Subject: [Koha-bugs] [Bug 27908] Add support for circulation status 1 (
other ) for damaged items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27908
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09
released in| |
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to stable |Pushed to oldstable
--- Comment #11 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:41:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:41:48 +0000
Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #11 from Fridolin Somers ---
Enhancement not pushed to 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:42:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:42:37 +0000
Subject: [Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to stable |RESOLVED
Resolution|--- |FIXED
--- Comment #11 from Fridolin Somers ---
Depends on Bug 21260 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:42:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:42:38 +0000
Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515
Bug 25515 depends on bug 28483, which changed state.
Bug 28483 Summary: Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:43:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:43:39 +0000
Subject: [Koha-bugs] [Bug 28660] Self checkout is not automatically logging
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #30 from Fridolin Somers ---
Depends on Bug 21325 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:44:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:44:35 +0000
Subject: [Koha-bugs] [Bug 28745] Batch item modifications no longer
displayed modified items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28745
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #7 from Fridolin Somers ---
Depends on Bug 28158 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:48:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 21:48:47 +0000
Subject: [Koha-bugs] [Bug 28631] Holds History title link returns "not
found" error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #6 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
> This patch also corrects the breadcrumb markup which didn't conform to the new Bootstrap 4 pattern.
I did not include this change, only fixed the href.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 01:40:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 23:40:59 +0000
Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes
plugin_upload to try to write to the opac-tmpl folder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303
--- Comment #3 from Michael Hafen ---
Test plan:
1. edit a koha instance's koha-conf.xml to set enable_plugins to 1
1.a restart memcached service as necessary
2. upload plugin in Administration -> Manage plugins -> Upload plugin
3. plugin will be listed in the Manage plugins page
4. create a directory, for example `mkdir -p /var/lib/koha-common/plugins`
5. edit koha-conf.xml to add a pluginsdir tag pointing to the directory created
in step 4
5.a restart memcached service as necessary
6. uninstall plugin
7. try to upload plugin again. Observe error message to verify that the Apache
user can write to the plugins directory.
8. apply patch
9. try to upload plugin again. It should succeed.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 01:46:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 23:46:45 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
needs refactoring
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 01:47:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Aug 2021 23:47:25 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator
- Patron Search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #3 from Michael Hafen ---
Test plan:
1. start a new batch in the patron card creator (Tools -> Patron card creator
-> New -> card batch)
2. click the Add patron(s) button. Observe that Category and Library are the
only options.
3. Close search for patron window.
4. Apply patch.
5. click the Add patron(s) button. Observe that you can now search for patrons
by their sort1 and sort2 values.
6. perform a search and observe the 'Select all | Clear all | Add selected
patrons' links and button.
7. use the Select all link to select all the patrons found by the search.
8. use the Add selected patrons button to add the selected patrons to the card
batch's Add by borrowernumber(s) text input field.
9. close the search for patron window.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:26:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 01:26:45 +0000
Subject: [Koha-bugs] [Bug 28679] Unable to click "Log in to your account"
when GoogleOpenIDConnect is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #11 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:35:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 01:35:59 +0000
Subject: [Koha-bugs] [Bug 28747] Clarify wording on RestrictionBlockRenewing
syspref
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09
released in| |
Status|Pushed to stable |Pushed to oldstable
--- Comment #7 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:45:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 01:45:24 +0000
Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of
date-of-publication
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09
released in| |
--- Comment #20 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
Viva Elasticsearch ^^
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:51:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 01:51:34 +0000
Subject: [Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to
adv search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Depends on| |23271
--- Comment #17 from Fridolin Somers ---
Depends on Bug 23271 which added do_not_select_my_library param
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271
[Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:51:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 01:51:34 +0000
Subject: [Koha-bugs] [Bug 23271] Koha::Patron::Category should use
Koha::Object::Limit::Library
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28622
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622
[Bug 28622] Selected branchcode incorrectly passed to adv search
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:53:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 01:53:39 +0000
Subject: [Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to
adv search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622
--- Comment #18 from Fridolin Somers ---
Depends on Bug 23271 not in 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:57:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 01:57:17 +0000
Subject: [Koha-bugs] [Bug 28801] New: OpacSuppression prevents retrieval of
non-suppressed titles that contain punctuation
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801
Bug ID: 28801
Summary: OpacSuppression prevents retrieval of non-suppressed
titles that contain punctuation
Change sponsored?: ---
Product: Koha
Version: 20.11
Hardware: Other
OS: Linux
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: tasha.keagan at gmail.com
QA Contact: testopia at bugs.koha-community.org
Overview: OpacSuppression toggled to "hide" reliably prevents results from
being retrieved in the OPAC when titles (245$a) contain punctuation (in my
catalog, these are mostly hyphens/dashes and parentheses). Punctuated titles
are retrievable until I toggle OpacSuppression to "hide", despite having their
942$n set to "n Suppress in OPAC No" (Titles that do have 942$n set to "yes"
are suppressed as expected and labelled as such in the intranet).
Steps to Reproduce:
Note: I was working in a clean Koha install, with no MARC records, where the
only Global System Preference toggled was SearchEngine (to use Elasticsearch).
1. I created a record using the Fast Add framework, with title "Test punctuated
(TST-123) title", and only required fields populated
2. In the OPAC, I searched for and successfully retrieved the title using the
"Library catalog" search option
3. I toggled OpacSuppression to "Hide", then used Ctrl+F5 to refresh the
browser
4. In the OPAC, I repeated the "Library catalog" search
Actual Results:
"No results found!
No results found for that in catalog."
Expected Results:
I expected the title to be retrieved.
Build Date & Hardware:
I believe you're looking for this info: Linux 5.4.17-2011.6.2.el7uek.x86_64 #2
SMP Thu Sep 3 14:09:14 PDT 2020 x86_64
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:22:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 02:22:37 +0000
Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of
non-suppressed titles that contain punctuation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #1 from David Cook ---
Did you put "No" as a value in the 942$n?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:25:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 02:25:31 +0000
Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the
spec
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.02,20.11.09 |21.11.00,21.05.02
released in| |
Status|Pushed to oldstable |ASSIGNED
--- Comment #13 from Fridolin Somers ---
Arf breaks test suite :
t/db_dependent/api/v1/patrons.t ..
# Failed test 'exact match for JSON Pointer "/0/cardnumber"'
# at t/db_dependent/api/v1/patrons.t line 66.
# got: '1'
# expected: 'O_HBrhYpvfsZOtvfyC'
# Looks like you failed 1 test of 16.
# Failed test 'librarian access tests'
# at t/db_dependent/api/v1/patrons.t line 84.
# Looks like you failed 1 test of 2.
t/db_dependent/api/v1/patrons.t .. 1/7
# Failed test 'list() tests'
# at t/db_dependent/api/v1/patrons.t line 85.
t/db_dependent/api/v1/patrons.t .. 5/7 # Looks like you failed 1 test of 7.
t/db_dependent/api/v1/patrons.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests
Test Summary Report
-------------------
t/db_dependent/api/v1/patrons.t (Wstat: 256 Tests: 7 Failed: 1)
Failed test: 1
Non-zero exit status: 1
Files=1, Tests=7, 7 wallclock secs ( 0.03 usr 0.00 sys + 6.59 cusr 0.54
csys = 7.16 CPU)
Result: FAIL
So I revert from 20.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:25:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 02:25:50 +0000
Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the
spec
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:25:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 02:25:58 +0000
Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the
spec
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to stable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:38:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 02:38:33 +0000
Subject: [Koha-bugs] [Bug 27885] Populate biblionumbers parameter when
placing hold on single title
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09
released in| |
--- Comment #14 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:42:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 02:42:36 +0000
Subject: [Koha-bugs] [Bug 28336] Cannot change matching rules for authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09
released in| |
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to stable |Pushed to oldstable
--- Comment #8 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:45:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 04:45:35 +0000
Subject: [Koha-bugs] [Bug 28408] Last modification date for suggestions is
wrong
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09
released in| |
--- Comment #9 from Fridolin Somers ---
Pushed to 20.11.x for 20.11.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:48:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Aug 2021 04:48:19 +0000
Subject: [Koha-bugs] [Bug 28662] Not possible to log out of patron account
in OPAC with JavaScript disabled
In-Reply-To: