From bugzilla-daemon at bugs.koha-community.org Sun Aug 1 16:03:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Aug 2021 14:03:48 +0000 Subject: [Koha-bugs] [Bug 28789] New: add ability to show branch groups before branches in dropdown menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28789 Bug ID: 28789 Summary: add ability to show branch groups before branches in dropdown menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org If opac_search_limit is activated the dropdown menu shows individual branches before branch groups. For some libraries (most of them?) it would be preferable to show the groups before the individual branches. It should be a syspref or an option in branch group configuration page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 1 16:14:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Aug 2021 14:14:04 +0000 Subject: [Koha-bugs] [Bug 28790] New: add ability to use branch groups codes instead of id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28790 Bug ID: 28790 Summary: add ability to use branch groups codes instead of id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org If opac_search_limit is activated you can filter a search by library group , but the URL uses the id of the group (ex : "branch_group_limit=multibranchlimit-34). This id is not visible in library group configuration page. It should be possible to use the code of the group, for example "branch_group_limit=multibranchlimit-MYGROUP" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 00:21:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Aug 2021 22:21:30 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 00:21:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Aug 2021 22:21:33 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123238|0 |1 is obsolete| | --- Comment #3 from Hayley Pelham --- Created attachment 123355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123355&action=edit Bug 20463: Adding index for Leader 19 Multipart resource record level Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 09:04:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 07:04:20 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 10:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 08:44:42 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #97 from Fridolin Somers --- In CanBookBeRenewed(), $date_due is computed even if system preference PreventCheckoutOnSameReservePeriod is off. This has an impact on performance. We may add if PreventCheckoutOnSameReservePeriod earlier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:09:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:09:52 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #93 from Jonathan Druart --- As it, we are moving the atomic updates to the db_rev directory. Is it the behaviour we want? Should we 1. support both syntaxes (.perl and .pl) in installer/data/mysql/atomicupdate or 2. keep this directory for the old syntax and new atomic updates will be expected in installer/data/mysql/db_revs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:11:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:11:53 +0000 Subject: [Koha-bugs] [Bug 28791] New: make a distinction between public lists in OPAC and staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28791 Bug ID: 28791 Summary: make a distinction between public lists in OPAC and staff interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org Lists of records can be created for internal needs or for the users. But currently a "public" list is visible in OPAC and staff interface. There should be a way to make a list visible for all librarians in staff interface but not in OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:13:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:13:33 +0000 Subject: [Koha-bugs] [Bug 28791] make a distinction between public lists in OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28791 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org CC| |m.de.rooy at rijksmuseum.nl Component|OPAC |Lists -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:22:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:22:49 +0000 Subject: [Koha-bugs] [Bug 28792] New: select all the results after a search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28792 Bug ID: 28792 Summary: select all the results after a search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org After a search in staff interface, the "Select all" link only select the results displayed on the current page. There should be a way to really select all results, for example to put them in a list or to export them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:25:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:25:51 +0000 Subject: [Koha-bugs] [Bug 28793] New: ability to download and send results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28793 Bug ID: 28793 Summary: ability to download and send results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org After a search, you need to create a cart or a list to download the results or send them by email. It is not intuitive, and it should be possible directly from the result page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:31:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:31:07 +0000 Subject: [Koha-bugs] [Bug 28794] New: ability to make a list visible for a specific period Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28794 Bug ID: 28794 Summary: ability to make a list visible for a specific period Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be nice if the visibility of a list could be programmed in advanced, for example if the list is created to support a specific event like an exhibition, or a school program. For example a list created the 1 jan 2021 could be programmed to be visible from the 1 fev 2021 to the 1 june 2021 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:33:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:33:31 +0000 Subject: [Koha-bugs] [Bug 28795] New: ability to add metadata to lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28795 Bug ID: 28795 Summary: ability to add metadata to lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It could be useful to add metadata to lists, for sorting and managing them. For example a subject field, or some generic fields customisable by the libray, like in patron records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 11:39:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 09:39:10 +0000 Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 --- Comment #7 from mathieu saby --- This is still needed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:15:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:15:59 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #94 from Jonathan Druart --- Created attachment 123356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123356&action=edit Bug 25078: Keep atomic updates in "atomicupdate" dir The atomicupdate directory will contain all the atomic update files (old and new version). That will ease job for the RM and RMaints, no file (except skeletons) must be in this directory before push. This patch also fixes an inconsistency we had: the atomic update was run before the other db revs on the UI but after when the CLI script was used. Now we make sure that the CLI does not deal with the atomic update files when called from the installer (UI) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:17:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:17:48 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123356|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart --- Created attachment 123357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123357&action=edit Bug 25078: Keep atomic updates in "atomicupdate" dir The atomicupdate directory will contain all the atomic update files (old and new version). That will ease job for the RM and RMaints, no file (except skeletons) must be in this directory before push. This patch also fixes an inconsistency we had: the atomic update was run before the other db revs on the UI but after when the CLI script was used. Now we make sure that the CLI does not deal with the atomic update files when called from the installer (UI) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:19:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:19:25 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #96 from Jonathan Druart --- https://snipboard.io/W7skMG.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:29:31 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122665|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart --- Created attachment 123358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123358&action=edit Bug 25078: Put db revs into different files to handle them better This patch suggests to stop using updatedatabase.pl to add new DB revs. Each DB rev will be in a separate pl files (installer/data/mysql/db_revs). The switch should ideally be done from 21.06.00.000. Each DBrev is executed in a try block and a transaction. If something went wrong, the whole DB rev is rolled back. Why do /var/log/koha/kohadev/updatedatabase_*.log (not -error) contain Status: 500 Content-type: text/html

Software error:

etc. Test plan: - git checkout c4b4db21d25 (master on 2021-07-08) - Set the version syspref to 21.0500000: > update systempreferences set value="21.0500000" where variable="version"; - Apply "Bug 25078: [DO NOT PUSH] DB revs for testing" (restart_all) - Read the different DBrevs created as examples - Make sure the different use cases are covered - execute the updatedatabase script (CLI) - Set the version syspref to 21.0500000 - Update the DB from the UI - Set the version syspref to 21.0500000 - execute the updatedatabase script with the --force parameter (for testing purpose) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:29:37 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122666|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart --- Created attachment 123359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123359&action=edit Bug 25078: [DO NOT PUSH] DB revs for testing Use with the --force flag: % updatedatabase --force Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:29:43 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122667|0 |1 is obsolete| | --- Comment #99 from Jonathan Druart --- Created attachment 123360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123360&action=edit Bug 25078: Re-introduce NewVersion This is ugly, we re-add the code we removed in the previous patch. We need to continue supporting "old" versions. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:29:49 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122668|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart --- Created attachment 123361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123361&action=edit Bug 25078: Separate update "report" from its description Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:29:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:29:54 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122669|0 |1 is obsolete| | --- Comment #101 from Jonathan Druart --- Created attachment 123362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123362&action=edit Bug 25078: (follow-up) Update 'NewVersion' for output_version changes This patch updates the NewVersion compatability method to add arrayref description handling to split it into description + report. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:30:00 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #102 from Jonathan Druart --- Created attachment 123363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123363&action=edit Bug 25078: Move DB revs up to 21.06.00.011 Updated on 2021-08-02 for 21.06.00.011 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:30:05 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122679|0 |1 is obsolete| | --- Comment #103 from Jonathan Druart --- Created attachment 123364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123364&action=edit Bug 25078: Close open filehandle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:30:10 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122680|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart --- Created attachment 123365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123365&action=edit Bug 25078: Fix encoding issue with db_revs output >From `perldoc -f open`: The scalars for in-memory files are treated as octet strings: unless the file is being opened with truncation the scalar may not contain any code points over 0xFF. So $out need to be decoded first in order to be used in other Perl strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:30:16 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122875|0 |1 is obsolete| | --- Comment #105 from Jonathan Druart --- Created attachment 123366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123366&action=edit Bug 25078: Fix 'Wide character' from CLI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:30:21 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123357|0 |1 is obsolete| | --- Comment #106 from Jonathan Druart --- Created attachment 123367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123367&action=edit Bug 25078: Keep atomic updates in "atomicupdate" dir The atomicupdate directory will contain all the atomic update files (old and new version). That will ease job for the RM and RMaints, no file (except skeletons) must be in this directory before push. This patch also fixes an inconsistency we had: the atomic update was run before the other db revs on the UI but after when the CLI script was used. Now we make sure that the CLI does not deal with the atomic update files when called from the installer (UI) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 12:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 10:30:45 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #107 from Jonathan Druart --- Patches (and remote branch) rebased on top of master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:04:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:04:40 +0000 Subject: [Koha-bugs] [Bug 28796] New: wrong number of parameters in new_from_xml call Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Bug ID: 28796 Summary: wrong number of parameters in new_from_xml call Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org Hi, It seems to me that C4/ImportBatch.pm: my $old_marc = MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $rowref->{'encoding'}, $marc_type); Is calling MARC::Record->new_from_xml with the wrong number of parameters and $marc_type is ignored it should be either: MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $marc_type); or: MARC::Record->new_from_xml(StripNonXmlChars($oldxml),$rowref->{'encoding'} , $marc_type); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:21:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:21:32 +0000 Subject: [Koha-bugs] [Bug 28792] select all the results after a search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28792 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 7010 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:21:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:21:32 +0000 Subject: [Koha-bugs] [Bug 7010] Select all records from search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #6 from Owen Leonard --- *** Bug 28792 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:29:33 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:29:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:29:37 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #1 from Nick Clemens --- Created attachment 123368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123368&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:29:45 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:37:12 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 123369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123369&action=edit Bug 28741: Regression tests This patch adds regression tests for the behavior. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:42:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:42:28 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123330|0 |1 is obsolete| | Attachment #123331|0 |1 is obsolete| | --- Comment #10 from Peter Vashchuk --- Created attachment 123370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123370&action=edit Bug 28779: Skip processing of non-existent biblios Just checking with a regex that whether an input looks like a biblionumber is not enough, we need to also verify there is a biblio really existing in the database and skip processing of hold request for non-existent biblionumbers. To test: 1) Go to page /cgi-bin/koha/reserve/request.pl?biblionumbers=XXXXX where XXXXX is non-existent biblionumber, notice internal server error 2) Apply patch 3) Repeat step 1 and notice we cannot place a hold Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:42:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:42:32 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 --- Comment #11 from Peter Vashchuk --- Created attachment 123371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123371&action=edit Bug 28779: (QA follow-up) More specific message and soem cleanup Signed-off-by: Nick Clemens Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:47:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:47:38 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #80 from Jonathan Druart --- Created attachment 123372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123372&action=edit Bug 27526: Add tests for columns_to_str and host_items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:48:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:48:14 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #81 from Jonathan Druart --- (In reply to Jonathan Druart from comment #79) > I will provide the missing tests next week. Thanks for the reminder! Done! And I found a bug, so tests++ :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:52:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:52:49 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #2 from Owen Leonard --- Created attachment 123373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123373&action=edit Dialog with revised icons I think the minus symbol isn't very understandable. What about using the "trash" icon (which we use in other situations for "delete") for the cancel operation? See the attached mockup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:58:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:58:52 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 14:58:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 12:58:55 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119626|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123374&action=edit Bug 28153: Add 'Hold reminder' messaging preference This adds a new preference for patrons to choose how they wish to receive 'Hold reminder' notices. The notice is always digested per branch To test: 1 - Apply patches 2 - Update database 3 - Ensure EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC are enabled 4 - View a patron and note new messaging preference 5 - Confirm same on the opac for a patron account 6 - All transports should be disabled by default 7 - Place a hold for the patron and check it in to confirm 8 - Run hold reminder script perl misc/cronjobs/holds_reminder.pl -v -c 9 - No message should be queued for patron 10 - Enable the message in a transport for which 'HOLD_REMINDER' notice has content for the patron 11 - Run the script 12 - Patron should have a message queued 13 - Ensure a different transport has content for the notice 14 - Run the script forcing a transport perl misc/cronjobs/holds_reminder.pl -v -c -mtt=print 15 - The patron should have a message queued in the forced transport Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:03:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:03:31 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #3 from Andrew Fuerste-Henry --- I like the idea of promoting icon consistency. I'm happy to defer to Owen on questions of minuses and garbage cans :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:05:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:05:19 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #4 from Nick Clemens --- (In reply to Owen Leonard from comment #2) > Created attachment 123373 [details] > Dialog with revised icons > > I think the minus symbol isn't very understandable. What about using the > "trash" icon (which we use in other situations for "delete") for the cancel > operation? See the attached mockup. That sounds good to me! Did you code it already, or shall I attempt? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:11:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:11:29 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:12:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:12:25 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored-by: Orex Digital release notes| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:14:15 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #1 from Jonathan Druart --- Created attachment 123375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123375&action=edit Bug 28786: Add new syspref TwoFactorAuthentication Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:14:19 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #2 from Jonathan Druart --- Created attachment 123376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123376&action=edit Bug 28786: Add new DB column borrowers.secret Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:14:22 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #3 from Jonathan Druart --- Created attachment 123377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123377&action=edit Bug 28786: Add new DB column borrowers.auth_method Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:14:26 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #4 from Jonathan Druart --- Created attachment 123378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123378&action=edit Bug 28786: Add controller script and template Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:14:30 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #5 from Jonathan Druart --- Created attachment 123379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123379&action=edit Bug 28786: Two-factor authentication for staff client - TOTP This patchset introduces the Two-factor authentication (2FA) idea in Koha. It is far for complete, and only implement one way of doing it, but at least it's a first step. The idea here is to offer the librarian user the ability to enable/disable 2FA when logging in to Koha. It will use time-based, one-time passwords (TOTP) as the second factor, an application to handle that will be required. https://en.wikipedia.org/wiki/Time-based_One-Time_Password More developements are possible on top of this: * Send a notice (sms or email) with the code * Force 2FA for librarians * Implementation for OPAC * WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/ Test plan: 0. a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all b. To test this you will need an app to generate the TOTP token, you can use FreeOTP that is open source and easy to use. 1. Turn on TwoFactorAuthentication 2. Go to your account, click 'More' > 'Manage Two-Factor authentication' 3. Click Enable, scan the QR code with the app, insert the pin code and register 4. Your account now requires 2FA to login! 5. Notice that you can browse until you logout 6. Logout 7. Enter the credential and the pincode provided by the app 8. Logout 9. Enter the credential, no pincode 10. Confirm that you are stuck on the second auth form (ie. you cannot access other Koha pages) 11. Click logout => First login form 12. Enter the credential and the pincode provided by the app Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:14:34 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #6 from Jonathan Druart --- Created attachment 123380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123380&action=edit Bug 28786: Improve readability in C4::Auth::checkauth Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:14:38 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #7 from Jonathan Druart --- Created attachment 123381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123381&action=edit Bug 28786: DBIC schema changes Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:16:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:16:10 +0000 Subject: [Koha-bugs] [Bug 28797] New: Hold reminder email should use All Libraries notice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28797 Bug ID: 28797 Summary: Hold reminder email should use All Libraries notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Depends on: 15986 Bug 15986 introduces a hold reminder email. It only knows how to use branch-specific notices and will fail if your only HOLD_REMINDER notice is for All Libraries. To confirm: - have a patron with a valid email address and Hold notices set to go out via email in their messaging prefs - place a hold for your patron, get it to Waiting status - confirm that you have the default HOLD_REMINDER email notice for All Libraries but no library-specific HOLD_REMINDER notice - perl misc/cronjobs/holds/holds_reminder.pl -c -v to run the holds reminder cron - get "Message 'HOLD_REMINDER' content not found for [your branch]" - create the notice for your branch - re-run the cron - patron gets notice Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 [Bug 15986] Add a script for sending hold waiting reminder notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:16:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:16:10 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28797 [Bug 28797] Hold reminder email should use All Libraries notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:18:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:18:40 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:18:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:18:43 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:18:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:18:45 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:19:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:19:35 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 123382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123382&action=edit Bug 28741: Regression tests This patch adds regression tests for the behavior. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:19:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:19:39 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 123383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123383&action=edit Bug 28741: Fix use of resumption token params TO test: 1 - Enable OAI-PMH server in Koha 2 - Set OAI-PMH:MaxCount to 5 3 - Define 6 sets in Admin->OAI sets configuration Can setSpec and setName to 1,2,3.... 4 - Browse to: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListSets 5 - Click 'Show more' 6 - Keep seeing the same 5 - note the page says 'Results fetched -4-0' 7 - Apply patch 8 - Restart all the things 9 - Reload the ListSets URL above 10 - Click 'Show more' 11 - See the 6th set and note no 'Show more' 12 - Set OAI-PMH:MaxCount to 1 13 - Go to the base ListSets url again 14 - Confirm you can 'Show more' until you reach the end Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:19:44 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 123384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123384&action=edit Bug 28741: (follow-up) Silence warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:34:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:34:15 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator - Patron Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |michael.hafen at washk12.org |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:34:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:34:21 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator - Patron Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:47:31 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:47:35 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122040|0 |1 is obsolete| | Attachment #122041|0 |1 is obsolete| | Attachment #122042|0 |1 is obsolete| | Attachment #122043|0 |1 is obsolete| | Attachment #122044|0 |1 is obsolete| | Attachment #122045|0 |1 is obsolete| | --- Comment #56 from Nick Clemens --- Created attachment 123385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123385&action=edit Bug 24190: Add acquisition logging Signed-off-by: Maura Stephens Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:47:40 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #57 from Nick Clemens --- Created attachment 123386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123386&action=edit Bug 24190: (follow-up) Cancel order del item bug If an order is cancelled but the associated bib / items are unable to be removed, we go into error handling. We still need to log the cancellation though. So this fix moves the logging to just after the cancellation, so it will be logged regardless of the outcome with associated things. Signed-off-by: Maura Stephens Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:47:44 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #58 from Nick Clemens --- Created attachment 123387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123387&action=edit Bug 24190: (follow-up) Respond to QA feedback This commit makes changes in response to Jonathan's feedback in comment - Moved from using zero padded strings to store log data to a JSON object - Stopped storing formatted dates in logged data Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:47:49 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #59 from Nick Clemens --- Created attachment 123388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123388&action=edit Bug 24190: (follow-up) Add tests In response to Jonathan's request for tests, I have now added additional tests for the methods in C4/Budgets.pm that do logging Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:47:53 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #60 from Nick Clemens --- Created attachment 123389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123389&action=edit Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in Koha, creating the basket then modifying its header. We were logging these two steps in the wrong order. This commit fixes that. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:47:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:47:57 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #61 from Nick Clemens --- Created attachment 123390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123390&action=edit Bug 24190: (follow-up) Rename AcqLog As requested in comment #49, renamed uses of AcqLog to AcquisitionLog Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:48:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:48:01 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #62 from Nick Clemens --- Created attachment 123391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123391&action=edit Bug 24190: (QA follow-up) record unchanged bookfund and fix typo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:49:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:49:29 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #63 from Nick Clemens --- Slight rebase and small follow-up to record when fund is not changed upon receipt. While I would like to see fuller logging of objects these patches add more information and will help track acquisitions so I think further enhancements can be on follow up bugs. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:55:44 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:55:47 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123320|0 |1 is obsolete| | Attachment #123321|0 |1 is obsolete| | Attachment #123322|0 |1 is obsolete| | Attachment #123323|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 123392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123392&action=edit Bug 28785: Centralize cookie auth check in check_cookie_auth This code is duplicated in 3 different places, we must call check_cookie_auth instead. It makes check_cookie_auth returns a 'restricted' when SessionRestrictionByIP is set and the IP changed. It also returns a third parameters contained the old and new IP, to fill the "info" hash in checkauth but apparently the oldip and newip variables are not even used from the template. We may want to remove it completely. No change is expected with this patch, the different authentication methods should still work as before. Test plan: Log in the staff and OPAC interfaces, logout. Log in and call script that call the 3 different subroutines modified by this patch. For instance you can list checkouts (that is using check_cookie_auth) and display a patron's image (using check_api_auth). QA with good knowledge of the C4::Auth module and the different authentication methods is required. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:55:51 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 --- Comment #11 from Owen Leonard --- Created attachment 123393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123393&action=edit Bug 28785: Adjust check_cookie_auth calls The previous patch makes check_cookie_auth return the session instead of $sessionID, so we are adjusting the different calls to prevent confusion. However they are mainly used to check the authentication status and don't care about this second variable. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:55:55 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 --- Comment #12 from Owen Leonard --- Created attachment 123394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123394&action=edit Bug 28785: Add skip_version_check for checkauth We could have this patch but we also could decide to skip it. The idea is to avoid 2 checks of the version when we are coming from checkauth. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 15:55:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 13:55:59 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 --- Comment #13 from Owen Leonard --- Created attachment 123395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123395&action=edit Bug 28785: Don't send SessionRestrictionByIP to template It's not used. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 16:10:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 14:10:17 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #5 from Owen Leonard --- I don't have a patch, so please attempt! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 18:29:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 16:29:36 +0000 Subject: [Koha-bugs] [Bug 28798] New: Allow ability to make OPAC hold pick-up location mandatory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798 Bug ID: 28798 Summary: Allow ability to make OPAC hold pick-up location mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently, when placing a hold on the OPAC the pickup location defaults to users branch, unless OPACHoldsIfAvailableAtPickup is set to 'don't allow'. Many libraries like to force the user to make a branch selection and make this field required. This can be done with JS but it would be nice if it was a system preference. I'd like to see a system preference like 'OPACHoldBranchMandatory' which would add an empty value like: and upon submission check to make sure something besides the empty value is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 19:07:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 17:07:30 +0000 Subject: [Koha-bugs] [Bug 28799] New: Action logs should capture lost items found Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Bug ID: 28799 Summary: Action logs should capture lost items found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org *Mark item lost *Check action log for item to show lost status change *Check item back in *Action log doesn't update with lost status change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 19:16:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 17:16:52 +0000 Subject: [Koha-bugs] [Bug 28800] New: Libabry list at /cgi-bin/koha/admin/branches.pl appears empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 Bug ID: 28800 Summary: Libabry list at /cgi-bin/koha/admin/branches.pl appears empty Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I've noticed that the list of libraries comes up empty, although libraries have been defined. When trying to create a new library with the same code as an existing one, the expected error message appears, however one is left unable to manage the existing libarries. Video recording (54MB) available at https://emedgroupgr-my.sharepoint.com/:v:/g/personal/mpetridis_emedgroup_gr/EcSNYW0Y_YxPoWnr2wkohWMBFABMw6-X2wbVyvXcV0o0KA?e=Cvnchg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 19:23:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 17:23:12 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:19:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 18:19:49 +0000 Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798 --- Comment #1 from Owen Leonard --- I'm curious, what is the motivation for forcing patrons to select a library? Under what circumstances is the user's home library not an appropriate default? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 18:24:06 +0000 Subject: [Koha-bugs] [Bug 28800] Libabry list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #1 from Owen Leonard --- Can you check the browser console to see if there are JavaScript errors on the page? It seems likely that an error is preventing the API from passing the information to the DataTable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:32:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 18:32:46 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #94 from Tomás Cohen Arazi --- Created attachment 123396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123396&action=edit Bug 25260: Fix pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 18:33:10 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 20:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 18:46:40 +0000 Subject: [Koha-bugs] [Bug 28800] Libabry list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #2 from Manos PETRIDIS --- Errors in console are: jquery-2.2.3.min_21.0501003.js:4 GET http://192.168.1.148:8081/api/v1/libraries?_page=1&_per_page=20&q=%5B%5D&_match=contains&_order_by=%2Bme.name 404 (Not Found) send @ jquery-2.2.3.min_21.0501003.js:4 ajax @ jquery-2.2.3.min_21.0501003.js:4 sa @ datatables.min_21.0501003.js:75 lb @ datatables.min_21.0501003.js:75 P @ datatables.min_21.0501003.js:67 T @ datatables.min_21.0501003.js:69 ha @ datatables.min_21.0501003.js:86 e @ datatables.min_21.0501003.js:131 (anonymous) @ datatables.min_21.0501003.js:131 each @ jquery-2.2.3.min_21.0501003.js:2 each @ jquery-2.2.3.min_21.0501003.js:2 n @ datatables.min_21.0501003.js:121 $.fn.api @ datatables_21.0501003.js:774 (anonymous) @ branches.pl:29830 i @ jquery-2.2.3.min_21.0501003.js:2 fireWith @ jquery-2.2.3.min_21.0501003.js:2 ready @ jquery-2.2.3.min_21.0501003.js:2 J @ jquery-2.2.3.min_21.0501003.js:2 and datatables_21.0501003.js:515 DataTables warning: table id=libraries - Ajax error. For more information about this error, please see http://datatables.net/tn/7 jQuery.fn.dataTable.ext.errMode @ datatables_21.0501003.js:515 K @ datatables.min_21.0501003.js:113 error @ datatables.min_21.0501003.js:74 i @ jquery-2.2.3.min_21.0501003.js:2 fireWith @ jquery-2.2.3.min_21.0501003.js:2 z @ jquery-2.2.3.min_21.0501003.js:4 (anonymous) @ jquery-2.2.3.min_21.0501003.js:4 load (async) send @ jquery-2.2.3.min_21.0501003.js:4 ajax @ jquery-2.2.3.min_21.0501003.js:4 sa @ datatables.min_21.0501003.js:75 lb @ datatables.min_21.0501003.js:75 P @ datatables.min_21.0501003.js:67 T @ datatables.min_21.0501003.js:69 ha @ datatables.min_21.0501003.js:86 e @ datatables.min_21.0501003.js:131 (anonymous) @ datatables.min_21.0501003.js:131 each @ jquery-2.2.3.min_21.0501003.js:2 each @ jquery-2.2.3.min_21.0501003.js:2 n @ datatables.min_21.0501003.js:121 $.fn.api @ datatables_21.0501003.js:774 (anonymous) @ branches.pl:29830 i @ jquery-2.2.3.min_21.0501003.js:2 fireWith @ jquery-2.2.3.min_21.0501003.js:2 ready @ jquery-2.2.3.min_21.0501003.js:2 J @ jquery-2.2.3.min_21.0501003.js:2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:24:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:24:46 +0000 Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798 --- Comment #2 from Lucas Gass --- (In reply to Owen Leonard from comment #1) > I'm curious, what is the motivation for forcing patrons to select a library? > Under what circumstances is the user's home library not an appropriate > default? Some librarians in multi-branch systems want users to consciously make a decision about where they will pickup the hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:47:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:47:50 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 --- Comment #9 from Fridolin Somers --- (In reply to Katrin Fischer from comment #8) > (In reply to Fridolin Somers from comment #7) > > For 20.11 waiting for Bug 28220 > > Hi Frido, was this pushed to 20.11.x now? Sorry no, Bug 28220 does not apply on 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:00 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:05 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123375|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 123397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123397&action=edit Bug 28786: Add new syspref TwoFactorAuthentication Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:09 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123376|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 123398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123398&action=edit Bug 28786: Add new DB column borrowers.secret Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:14 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123377|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 123399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123399&action=edit Bug 28786: Add new DB column borrowers.auth_method Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:20 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123378|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 123400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123400&action=edit Bug 28786: Add controller script and template Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:25 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123379|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 123401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123401&action=edit Bug 28786: Two-factor authentication for staff client - TOTP This patchset introduces the Two-factor authentication (2FA) idea in Koha. It is far for complete, and only implement one way of doing it, but at least it's a first step. The idea here is to offer the librarian user the ability to enable/disable 2FA when logging in to Koha. It will use time-based, one-time passwords (TOTP) as the second factor, an application to handle that will be required. https://en.wikipedia.org/wiki/Time-based_One-Time_Password More developements are possible on top of this: * Send a notice (sms or email) with the code * Force 2FA for librarians * Implementation for OPAC * WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/ Test plan: 0. a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all b. To test this you will need an app to generate the TOTP token, you can use FreeOTP that is open source and easy to use. 1. Turn on TwoFactorAuthentication 2. Go to your account, click 'More' > 'Manage Two-Factor authentication' 3. Click Enable, scan the QR code with the app, insert the pin code and register 4. Your account now requires 2FA to login! 5. Notice that you can browse until you logout 6. Logout 7. Enter the credential and the pincode provided by the app 8. Logout 9. Enter the credential, no pincode 10. Confirm that you are stuck on the second auth form (ie. you cannot access other Koha pages) 11. Click logout => First login form 12. Enter the credential and the pincode provided by the app Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:30 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123380|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 123402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123402&action=edit Bug 28786: Improve readability in C4::Auth::checkauth Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:53:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:53:35 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123381|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 123403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123403&action=edit Bug 28786: DBIC schema changes Sponsored-by: Orex Digital Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:58:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:58:12 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #15 from David Nind --- Testing notes (koha-testing-docker): - Tested with Google Authenticator app - Tested with andOTP app (https://github.com/andOTP/andOTP) - Everything work as per the test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 21:58:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 19:58:43 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:02:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:02:23 +0000 Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register statistics wizard report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:04:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:04:31 +0000 Subject: [Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #22 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:06:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:06:03 +0000 Subject: [Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #25 from Fridolin Somers --- I prefer not impact display on oldstable 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:09:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:09:30 +0000 Subject: [Koha-bugs] [Bug 28418] Show template_id of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28418 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:11:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:11:35 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Missing dependancies, not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:12:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:12:43 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:13:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:13:35 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:15:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:15:26 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |initial optional | |implementation of | |two-factor authentication | |(2FA) to improve security | |when logging into the staff | |interface. | | | |This | |implementation uses | |time-based, one-time | |passwords (TOTP) as the | |second factor, letting | |librarians use an | |application to handle it | |and provide them the code | |they need when logging in. | | | |It is enabled using the new | |system preference | |"TwoFactorAuthentication". | | | |Librarians can then enable | |2FA for their account from | |More > Manage Two-Factor | |authentication. To setup: | |1) Scan the QR code with an | |authenticator app. 2) Enter | |the one time code | |generated. For future | |logins, librarians are | |prompted to enter the | |authenticator code after | |entering their normal login | |credentials. | | | |Any | |authenticator app, such as | |Google Authenticator, | |andOTP, and many others can | |be used. Applications that | |enable backup of their 2FA | |accounts (either | |cloud-based or automatic) | |are recommended. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:17:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:17:50 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00 |21.11.00,21.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- I see it is in 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:18:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:18:18 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:21:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:21:02 +0000 Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- I can see the utility of forcing a choice. As Lucas says, I've talked to libraries that want this. If we're creating a new syspref and monkeying with this field, could we go a step further and make the syspref something like OPACHoldPickupDefault with the options (Patron home library / Item home library / Item holding library / Force a choice). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:23:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:23:03 +0000 Subject: [Koha-bugs] [Bug 28798] Allow ability to make OPAC hold pick-up location mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28798 --- Comment #4 from Lucas Gass --- (In reply to Andrew Fuerste-Henry from comment #3) > I can see the utility of forcing a choice. As Lucas says, I've talked to > libraries that want this. > > If we're creating a new syspref and monkeying with this field, could we go a > step further and make the syspref something like OPACHoldPickupDefault with > the options (Patron home library / Item home library / Item holding library > / Force a choice). +1, I like this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:23:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:23:31 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14233 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:23:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:23:31 +0000 Subject: [Koha-bugs] [Bug 14233] Add logging support to notices and slips management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26205 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:24:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:24:04 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #32 from Fridolin Somers --- Does not apply on 20.11.x , mainly because of Bug 14233. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:25:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:25:03 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #40 from Fridolin Somers --- Depends on Bug 15986 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:25:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:25:59 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:32:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:32:31 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:34:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:34:59 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27846 CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Introduced by Bug 27846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:34:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:34:59 +0000 Subject: [Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:35:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:35:20 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Fridolin Somers --- Depends on Bug 27846 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:36:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:36:30 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Fridolin Somers --- I think we should not impact olders versions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:38:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:38:33 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #22 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:39:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:39:32 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working in OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #29 from Fridolin Somers --- Depends on Bug 18989 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:48:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:48:59 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- It is a big visual change on items editor. I propose not to impact older versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:55:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:55:12 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:55:17 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123181|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 123404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123404&action=edit Bug 28736: fix requirements for the correct error message to show up There is existing error message in the code stating: "Unable to understand your search query, please rephrase and try again." which fits perfectly but because it looks for "ParseException" in the warning output it doesn't show up on this page as it's actually "parse_exception". This patch makes that it's also checked if "parse_exception" is present in the warning output. To reproduce: 1) using ES search for something like "// ^ ! { } [ ] .. , <>" that will for sure break the syntax of ES. 2) after the search query fails note that the error is "Unable to perform your search. Please try again." 3) apply the patch 4) search for the same thing again 5) error message should be "Unable to understand your search query, please rephrase and try again." now. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:56:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:56:10 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin Somers --- In this case i my opinion we should rename Koha::Patron::track_login into track_activity, same for C4::Auth::track_login_daily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 22:56:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 20:56:46 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:08:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:08:50 +0000 Subject: [Koha-bugs] [Bug 28597] OPAC suggestions do not display news for logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26630 CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Depends on Bug 26630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 [Bug 26630] Allow custom text for each library on the purchase suggestion page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:08:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:08:50 +0000 Subject: [Koha-bugs] [Bug 26630] Allow custom text for each library on the purchase suggestion page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 [Bug 28597] OPAC suggestions do not display news for logged in branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:09:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:09:24 +0000 Subject: [Koha-bugs] [Bug 28597] OPAC suggestions do not display news for logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Fridolin Somers --- Depends on Bug 26630 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:12:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:12:02 +0000 Subject: [Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:13:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:13:49 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:34:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:34:18 +0000 Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an undefined value at C4/Reserves.pm line 607 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:35:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:35:44 +0000 Subject: [Koha-bugs] [Bug 26760] Redirect to paycollect.pl when clicking on "Save and pay" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- I propose we do not impact older versions behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:37:12 +0000 Subject: [Koha-bugs] [Bug 27906] Add support for circulation status 9 ( waiting to be re-shelved ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27906 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:38:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:38:05 +0000 Subject: [Koha-bugs] [Bug 27907] Add support for circulation status 2 ( on order ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27907 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:38:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:38:50 +0000 Subject: [Koha-bugs] [Bug 27908] Add support for circulation status 1 ( other ) for damaged items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27908 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:41:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:41:48 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:42:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:42:37 +0000 Subject: [Koha-bugs] [Bug 28483] Warnings from Search.t must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin Somers --- Depends on Bug 21260 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:42:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:42:38 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Bug 25515 depends on bug 28483, which changed state. Bug 28483 Summary: Warnings from Search.t must be removed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:43:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:43:39 +0000 Subject: [Koha-bugs] [Bug 28660] Self checkout is not automatically logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #30 from Fridolin Somers --- Depends on Bug 21325 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:44:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:44:35 +0000 Subject: [Koha-bugs] [Bug 28745] Batch item modifications no longer displayed modified items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28745 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Depends on Bug 28158 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 2 23:48:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 21:48:47 +0000 Subject: [Koha-bugs] [Bug 28631] Holds History title link returns "not found" error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 > This patch also corrects the breadcrumb markup which didn't conform to the new Bootstrap 4 pattern. I did not include this change, only fixed the href. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 01:40:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 23:40:59 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 --- Comment #3 from Michael Hafen --- Test plan: 1. edit a koha instance's koha-conf.xml to set enable_plugins to 1 1.a restart memcached service as necessary 2. upload plugin in Administration -> Manage plugins -> Upload plugin 3. plugin will be listed in the Manage plugins page 4. create a directory, for example `mkdir -p /var/lib/koha-common/plugins` 5. edit koha-conf.xml to add a pluginsdir tag pointing to the directory created in step 4 5.a restart memcached service as necessary 6. uninstall plugin 7. try to upload plugin again. Observe error message to verify that the Apache user can write to the plugins directory. 8. apply patch 9. try to upload plugin again. It should succeed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 01:46:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 23:46:45 +0000 Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 01:47:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Aug 2021 23:47:25 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator - Patron Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #3 from Michael Hafen --- Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:26:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 01:26:45 +0000 Subject: [Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:35:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 01:35:59 +0000 Subject: [Koha-bugs] [Bug 28747] Clarify wording on RestrictionBlockRenewing syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:45:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 01:45:24 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #20 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 Viva Elasticsearch ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:51:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 01:51:34 +0000 Subject: [Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to adv search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |23271 --- Comment #17 from Fridolin Somers --- Depends on Bug 23271 which added do_not_select_my_library param Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:51:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 01:51:34 +0000 Subject: [Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 [Bug 28622] Selected branchcode incorrectly passed to adv search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:53:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 01:53:39 +0000 Subject: [Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to adv search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 --- Comment #18 from Fridolin Somers --- Depends on Bug 23271 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 03:57:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 01:57:17 +0000 Subject: [Koha-bugs] [Bug 28801] New: OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 Bug ID: 28801 Summary: OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation Change sponsored?: --- Product: Koha Version: 20.11 Hardware: Other OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: tasha.keagan at gmail.com QA Contact: testopia at bugs.koha-community.org Overview: OpacSuppression toggled to "hide" reliably prevents results from being retrieved in the OPAC when titles (245$a) contain punctuation (in my catalog, these are mostly hyphens/dashes and parentheses). Punctuated titles are retrievable until I toggle OpacSuppression to "hide", despite having their 942$n set to "n Suppress in OPAC No" (Titles that do have 942$n set to "yes" are suppressed as expected and labelled as such in the intranet). Steps to Reproduce: Note: I was working in a clean Koha install, with no MARC records, where the only Global System Preference toggled was SearchEngine (to use Elasticsearch). 1. I created a record using the Fast Add framework, with title "Test punctuated (TST-123) title", and only required fields populated 2. In the OPAC, I searched for and successfully retrieved the title using the "Library catalog" search option 3. I toggled OpacSuppression to "Hide", then used Ctrl+F5 to refresh the browser 4. In the OPAC, I repeated the "Library catalog" search Actual Results: "No results found! No results found for that in catalog." Expected Results: I expected the title to be retrieved. Build Date & Hardware: I believe you're looking for this info: Linux 5.4.17-2011.6.2.el7uek.x86_64 #2 SMP Thu Sep 3 14:09:14 PDT 2020 x86_64 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:22:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 02:22:37 +0000 Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Did you put "No" as a value in the 942$n? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:25:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 02:25:31 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02,20.11.09 |21.11.00,21.05.02 released in| | Status|Pushed to oldstable |ASSIGNED --- Comment #13 from Fridolin Somers --- Arf breaks test suite : t/db_dependent/api/v1/patrons.t .. # Failed test 'exact match for JSON Pointer "/0/cardnumber"' # at t/db_dependent/api/v1/patrons.t line 66. # got: '1' # expected: 'O_HBrhYpvfsZOtvfyC' # Looks like you failed 1 test of 16. # Failed test 'librarian access tests' # at t/db_dependent/api/v1/patrons.t line 84. # Looks like you failed 1 test of 2. t/db_dependent/api/v1/patrons.t .. 1/7 # Failed test 'list() tests' # at t/db_dependent/api/v1/patrons.t line 85. t/db_dependent/api/v1/patrons.t .. 5/7 # Looks like you failed 1 test of 7. t/db_dependent/api/v1/patrons.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests Test Summary Report ------------------- t/db_dependent/api/v1/patrons.t (Wstat: 256 Tests: 7 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=7, 7 wallclock secs ( 0.03 usr 0.00 sys + 6.59 cusr 0.54 csys = 7.16 CPU) Result: FAIL So I revert from 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:25:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 02:25:50 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:25:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 02:25:58 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:38:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 02:38:33 +0000 Subject: [Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 04:42:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 02:42:36 +0000 Subject: [Koha-bugs] [Bug 28336] Cannot change matching rules for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 04:45:35 +0000 Subject: [Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:48:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 04:48:19 +0000 Subject: [Koha-bugs] [Bug 28662] Not possible to log out of patron account in OPAC with JavaScript disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Ah dependency Bug 27445 is not in 21.05.x but this one is. In any case I dont push to 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:50:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 04:50:12 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:50:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 04:50:45 +0000 Subject: [Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00 |21.11.00,21.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 04:56:09 +0000 Subject: [Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 06:59:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 04:59:03 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 08:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 06:45:37 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #98 from Fridolin Somers --- Created attachment 123405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123405&action=edit Bug 15261: Always check preference PreventCheckoutOnSameReservePeriod first Proposed patch (may not apply on current master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 09:10:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 07:10:30 +0000 Subject: [Koha-bugs] [Bug 28802] New: Untranslatable strings in browser.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Bug ID: 28802 Summary: Untranslatable strings in browser.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js We must move it to prog/js. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 09:30:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 07:30:44 +0000 Subject: [Koha-bugs] [Bug 8214] Create a bound with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- (In reply to Katrin Fischer from comment #8) > There is a difference: > > "Bound withs" are on item level. The library might have something twice, but > once it's bound with something else and once it's on its own. That can > happen especially in libraries with old and rare books. > > bug 11175 is talking about showing relationships between bibliographic > records, so it's on a different level. For example in Germany for a multi > volume work you'd usually have a 'set record' that represents the whole work > and then a record for each volume. They are tied together using 7xx and 8xx. > The goal of bug 11175 would then be to show the volume records on the set > record. Oh, I wasn't thinking of this at the item level.. so does this really need the Holdings level MARC support before it can be implemented then? i.e. should it depend on bug 20447 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 09:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 07:30:53 +0000 Subject: [Koha-bugs] [Bug 8214] Create a bound with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20447 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 [Bug 20447] Add support for MARC holdings records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 09:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 07:30:53 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214 [Bug 8214] Create a bound with function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 09:46:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 07:46:37 +0000 Subject: [Koha-bugs] [Bug 28220] Exception not caught when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #40 from Jonathan Druart --- (In reply to Fridolin Somers from comment #39) > Does not apply on 20.11.x. > Fails because t/db_dependent/Koha/Patron/Attribute.t does not exists. > This file as been added by Bug 27858. Is it a dependance ? Yes, you certainly need bug 27858 and bug 27833 as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 10:04:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 08:04:54 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #165 from Martin Renvoize --- Created attachment 123406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123406&action=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 10:33:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 08:33:34 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25321 CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Caused by: commit 5fa99d7d59ffe65a3533c79a637b50f04e904736 Bug 25321: Move translatable strings out of strings.inc into the corresponding JavaScript Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 10:33:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 08:33:34 +0000 Subject: [Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 [Bug 28802] Untranslatable strings in browser.js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 10:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 08:46:43 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 10:47:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 08:47:02 +0000 Subject: [Koha-bugs] [Bug 28796] wrong number of parameters in new_from_xml call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Yes, that's wrong, it must be $rowref->{'encoding'} , $marc_type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 10:47:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 08:47:09 +0000 Subject: [Koha-bugs] [Bug 28796] wrong number of parameters in new_from_xml call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 10:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 08:58:45 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28784 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 11:07:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 09:07:00 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 11:07:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 09:07:04 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 --- Comment #2 from Fridolin Somers --- Created attachment 123408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123408&action=edit Bug 28802: Untranslatable strings in browser.js File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js We must move it to prog/js. Test plan : 1) Perform a search on staff interface 2) Click on a result 3) Check you see records browser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 11:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 09:22:38 +0000 Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- I don't recreate what you describe (tested on master and 20.11.x), the title is always displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 11:46:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 09:46:09 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- In master there is no action log when the item is checked in. On which version did you test? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 12:04:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 10:04:42 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #16 from Jonathan Druart --- Why aren't we going further here? IMO we should completely remove the code related to biblioitemnumber. This comment: 405 ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers 406 ## this is important when we have analytic items which may be on another record It implies that we must use biblioitemnumber to be correct, but we actually should use biblionumber. Is this correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 12:17:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 10:17:21 +0000 Subject: [Koha-bugs] [Bug 28803] New: process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Bug ID: 28803 Summary: process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: hagud at orex.es, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org We try hard to catch bad email addresses on entry, but we don't always succeed for cases like patron imports. However, with the introduction of exceptions in Koha::Email->create on invalid addresses we now die upon meeting such a case in the database. We should instead wrap this in a try/catch block and report the failure in the database and then move on to the next message in the queue instead of exploding. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 12:17:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 10:17:31 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 12:17:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 10:17:45 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC|koha-bugs at lists.koha-commun | |ity.org, | |testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 12:18:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 10:18:41 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 12:26:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 10:26:38 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #166 from Martin Renvoize --- Created attachment 123410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123410&action=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 12:52:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 10:52:27 +0000 Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 13:06:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 11:06:54 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 13:06:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 11:06:57 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123408|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 123411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123411&action=edit Bug 28802: Untranslatable strings in browser.js File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js We must move it to prog/js. Test plan : 1) Perform a search on staff interface 2) Click on a result 3) Check you see records browser Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 13:12:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 11:12:18 +0000 Subject: [Koha-bugs] [Bug 27987] Canceling an order / deleting item will result in warning even though there was no problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27987 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Kyle M Hall --- Bug was resolved when DelOrder was replaced with Koha::Acquisition::Order::cancel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 13:16:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 11:16:17 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Maura Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens at gmit.ie --- Comment #6 from Maura Stephens --- For us, the order date needs to be set and not amendable. Many institutions will have vendor agreements in place with follow up timeframes and reports need to display the initial date the order was sent to the vendor. We had a report in place in 19.11 that could bypass the reopening of a basket for amending a price or switching a fund, but this is no longer the case in 20.11 and this causes major issues now with vendor follow up. Can we please get this bug resolved as a matter of priority. Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 13:48:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 11:48:39 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #167 from Martin Renvoize --- QA Question Should 'Analytics: Show analytics' still display even when the syspref is enabled to display them inline? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 13:58:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 11:58:48 +0000 Subject: [Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #9 from Andrew Fuerste-Henry --- (In reply to Jonathan Druart from comment #8) > Pushed to master for 21.11, thanks to everybody involved! Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:01:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:01:22 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 jjennings at ait.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jjennings at ait.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:26:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:26:52 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #168 from Martin Renvoize --- OK, having dug a bit further I'm a little less sure about this patch set.. I love it in theory.. but I feel we're perhaps duplicating code a bit.. The code that governs the 'show analytics' link display already does a similar search but does it within the two -details' controller files.. I feel we should move to using the Util function and XSLT method from here for both cases.. and likely take some notice of UseControlNumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:30:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:30:34 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123372|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart --- Created attachment 123415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123415&action=edit Bug 27526: Add tests for columns_to_str and host_items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:30:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:30:51 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #83 from Jonathan Druart --- txn_begin was missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:32:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:32:46 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #17 from Nick Clemens --- (In reply to Jonathan Druart from comment #16) > Why aren't we going further here? > > IMO we should completely remove the code related to biblioitemnumber. > > This comment: > 405 ## Here we go backwards again to create hash of biblioitemnumber to > itemnumbers > 406 ## this is important when we have analytic items which may be on > another record > > It implies that we must use biblioitemnumber to be correct, but we actually > should use biblionumber. > > Is this correct? The comment is meant to describe what we are doing so that we can fix it in the future I don't go further to keep this small for backporting, but I agree, we should rewrite much of this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:36:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:36:31 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #131 from Jonathan Druart --- Created attachment 123417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123417&action=edit Bug 17600: Fix GetTagsLabels imports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:37:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:37:02 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #132 from Jonathan Druart --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:40:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:40:44 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #169 from Martin Renvoize --- Comment on attachment 123087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123087 Bug 11175: Limit the amount of component parts returned Review of attachment 123087: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11175&attachment=123087) ----------------------------------------------------------------- ::: Koha/Util/Search.pm @@ +34,5 @@ > +=cut > + > +sub get_component_part_query { > + my ($biblionumber) = @_; > + I think perhaps we should be taking UseControlNumber into account here... See opac-details.pl and details.pl controllers for a near the same case. my $cleaned_title = $biblio->title; $cleaned_title =~ tr|/||; my $query = ( C4::Context->preference('UseControlNumber') and $record->field('001') ) ? 'rcn:'. $record->field('001')->data . ' AND (bib-level:a OR bib-level:b)' : "Host-item:($cleaned_title)"; We should really utilise something similar here I feel.. and even better.. start using this in those two locations too.. or rather.. move that handling into XSLT.pm as you have done for the overall show parts code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:47:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:47:23 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #133 from Jonathan Druart --- Created attachment 123418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123418&action=edit Bug 17600: Add missing imports in authorities/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:48:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:48:33 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #18 from Jonathan Druart --- (In reply to Nick Clemens from comment #17) > I don't go further to keep this small for backporting, but I agree, we > should rewrite much of this I am willing to do it, can I count on you for test or QA? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:51:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:51:34 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123418|0 |1 is obsolete| | --- Comment #134 from Jonathan Druart --- Created attachment 123419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123419&action=edit Bug 17600: Add missing imports in authorities/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:54:43 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123419|0 |1 is obsolete| | --- Comment #135 from Nick Clemens --- Created attachment 123420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123420&action=edit Bug 17600: Add missing imports in authorities/ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:55:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:55:35 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #60 from Peter Vashchuk --- Victor, please check this ticket: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 it will make sense why search queries like this one "+ - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ /" fail :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:56:01 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #136 from Jonathan Druart --- (In reply to Nick Clemens from comment #135) > Created attachment 123420 [details] [review] > Bug 17600: Add missing imports in authorities/ > > Signed-off-by: Nick Clemens Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:56:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:56:03 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #19 from Nick Clemens --- (In reply to Jonathan Druart from comment #18) > (In reply to Nick Clemens from comment #17) > > I don't go further to keep this small for backporting, but I agree, we > > should rewrite much of this > > I am willing to do it, can I count on you for test or QA? :) Yes, but another bug report please :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 14:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 12:56:57 +0000 Subject: [Koha-bugs] [Bug 28804] New: 500 Error when running report with bad syntax Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Bug ID: 28804 Summary: 500 Error when running report with bad syntax Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: jstallings at tsas.org QA Contact: testopia at bugs.koha-community.org In previous versions, running an SQL report with an error (typo, bad syntax) would yield an error page with the problem syntax highlighted. 21.05 returns only a 500 error. Excerpt from plack-intranet-error.log here: https://pastebin.com/0UCYkU46 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:08:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:08:26 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:08:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:08:29 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122885|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 123421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123421&action=edit Bug 28142: Accessibility: OPAC cart/basket checkboxes are not labelled This patch adds labels to the checkboxes on the "Your cart" page to improve accessibility for users of screen readers. The labels are hidden from display because the item titles provide enough visual context. Test Plan: 1. Go to the OPAC 2. Search for some items and add them to your cart 3. Inspect the page html and confirm the checkboxes are not labelled 4. Select the "More Details" page and confirm these labels are missing too 5. Apply the patch 6. Inspect the checkboxes on the "Brief display" and "more details" views 7. Confirm that the checkboxes have meaningful labels and that the visual display of the pages has not changed. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:10:43 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:11:00 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #64 from Nick Clemens --- Error in : installer/data/mysql/atomicupdate/bug_27378_add_CookieConsentPopup_syspref.perl (shoudl quote with q{} so the | doesn't break it) In testing I was never able to get the cookies to set - can you provide some values in the test plan that work on koha testing docker - I got complaints of bad domain for cookies Question: Should you be able to keep using the site before clicking 'Accept' on the necessary cookies? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:16:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:16:13 +0000 Subject: [Koha-bugs] [Bug 28805] New: Batch checkout shoudl have on-site checkout option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Bug ID: 28805 Summary: Batch checkout shoudl have on-site checkout option Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The batch checkout is very useful, but currently doesn't support all advanced options of the normal search page. It's missing the "on-site checkout" functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:16:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:16:24 +0000 Subject: [Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch checkout shoudl have |Batch checkout should have |on-site checkout option |on-site checkout option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:36:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:36:20 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121187|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 123422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123422&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 15:36:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 13:36:36 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:01:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:01:29 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |20.05 --- Comment #2 from hebah at bywatersolutions.com --- (In reply to Jonathan Druart from comment #1) > In master there is no action log when the item is checked in. > > On which version did you test? 20.05. I've updated ticket to reflect that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:06:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:06:36 +0000 Subject: [Koha-bugs] [Bug 28806] New: Labels exported as PDF create zero sized PDF files. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 Bug ID: 28806 Summary: Labels exported as PDF create zero sized PDF files. Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org In my first tries to create biblio labels, I see that export to PDF creates zero sized PDF files, in both individual/single and batch modes. Coult it be due to non-latin characters (Greek) appearing in the label contents? Export to CSV does produce files with the expected number of rows, albeit with non-usable characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:00 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122899|0 |1 is obsolete| | --- Comment #196 from Martin Renvoize --- Created attachment 123423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123423&action=edit Bug 22435: Update CREATE offset types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:06 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122900|0 |1 is obsolete| | --- Comment #197 from Martin Renvoize --- Created attachment 123424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123424&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account This patch updates the Koha::Account methods for adding debits and credits to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:12 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122901|0 |1 is obsolete| | --- Comment #198 from Martin Renvoize --- Created attachment 123425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123425&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account::Line This patch updates the Koha::Account::Line methods that result in new account lines to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:17 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122902|0 |1 is obsolete| | --- Comment #199 from Martin Renvoize --- Created attachment 123426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123426&action=edit Bug 22435: Add 'APPLY' to account_offset_types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:23 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122903|0 |1 is obsolete| | --- Comment #200 from Martin Renvoize --- Created attachment 123427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123427&action=edit Bug 22435: ->apply() should always use 'APPLY' for offset_type Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:29 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122904|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize --- Created attachment 123428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123428&action=edit Bug 22435: Update unit tests This patch updates the unit tests to reflect the changes we have made to offset types. We do two things: 1) Clean up calls to 'apply' to drop passing offset_type 2) Update test code to look for APPLY and CREATE instead of specific offset types. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:35 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122905|0 |1 is obsolete| | --- Comment #202 from Martin Renvoize --- Created attachment 123429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123429&action=edit Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:41 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122906|0 |1 is obsolete| | --- Comment #203 from Martin Renvoize --- Created attachment 123430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123430&action=edit Bug 22435: Fix _set_found_trigger The _set_found_trigger utilised the 'Writeoff' offset type to distinguish between the application of a writeoff and any other form of offset application. This patch updates the trigger to use the full link through from offset to account credit line to get the credit type being offset. Test plan 1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch, but passes after applying this patch. 2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:47 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122907|0 |1 is obsolete| | --- Comment #204 from Martin Renvoize --- Created attachment 123431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123431&action=edit Bug 22435: Update for bug 27049 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:53 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122908|0 |1 is obsolete| | --- Comment #205 from Martin Renvoize --- Created attachment 123432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123432&action=edit Bug 22435: Update accountline-details page to show all history The accountline-details page took a simplistic approach to displaying the history of an accountline. This patch drops the now defunct offset_type_description template block from it's respective include files, and then updates the accountline-details template and controller to show the full history of what's happend to the accountline passed. This includes the creation, any increments/decrements (for fines), and finally any offsets against the total (payments, cancellations, voids). Test plan 1/ Create some credits and debits and apply them to each other in various combinations. 2/ View the 'Details' page for some of the debit/credits 3/ Compare before patch and after for the Details page. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:33:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:33:58 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122909|0 |1 is obsolete| | --- Comment #206 from Martin Renvoize --- Created attachment 123433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123433&action=edit Bug 22435: Improve database update Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:04 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122910|0 |1 is obsolete| | --- Comment #207 from Martin Renvoize --- Created attachment 123434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123434&action=edit Bug 22435: (QA follow-up) Fix test file and adjust test Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:10 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122911|0 |1 is obsolete| | --- Comment #208 from Martin Renvoize --- Created attachment 123435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123435&action=edit Bug 22435: (follow-up) Update POS for reduced offset types This patch updates the Koha::Charges::Sales class to use the 'CREATE' and 'APPLY' offset types. Test plan 1/ Run t/db_dependent/Koha/Charges/Sales.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:15 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122912|0 |1 is obsolete| | --- Comment #209 from Martin Renvoize --- Created attachment 123436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123436&action=edit Bug 22435: (follow-up) Drop account_offset_types table This patch drops the now defunkt account_offset_types table and ensure the type field in account_offsets is instead an enum type column. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:21 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122913|0 |1 is obsolete| | --- Comment #210 from Martin Renvoize --- Created attachment 123437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123437&action=edit Bug 22435: (QA follow-up) Add missing test for manager relation Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:27 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122914|0 |1 is obsolete| | --- Comment #211 from Martin Renvoize --- Created attachment 123438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123438&action=edit Bug 22435: (QA follow-up) Fix test for offset total This patch updates the test for the offset total method to adhere to the new restricted set of offset types available. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:33 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122915|0 |1 is obsolete| | --- Comment #212 from Martin Renvoize --- Created attachment 123439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123439&action=edit Bug 22435: Update DBIC Schema's Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:39 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122916|0 |1 is obsolete| | --- Comment #213 from Martin Renvoize --- Created attachment 123440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123440&action=edit Bug 22435: (QA follow-up) Fix returned offsets in moredetail This patch updates the offsets query for lost item returns displayed in the catalogue/moredetail controller. Test plan (Same as bug 19919) Test plan: 1) Pay off a LOST item 2) Check for the associated display of 'Paidfor?:' on the itemdetails page 3) Writeoff a LOST item 4) Check that a 'Paidfor?:' is not displayed on the itemdetails page. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:45 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122917|0 |1 is obsolete| | --- Comment #214 from Martin Renvoize --- Created attachment 123441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123441&action=edit Bug 22435: (QA follow-up) More test updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:34:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:34:51 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122937|0 |1 is obsolete| | --- Comment #215 from Martin Renvoize --- Created attachment 123442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123442&action=edit Bug 22435: (follow-up) Set CREATE offset for credits to positive The history view of an accountline shows increases and decreases in the amount outstanding from the perspective of the credit/debit line you are inspecting. Apply creates a negative offset amount which acts to 'reduce' both the outstanding 'debt' for the debit line and the outstanding 'credit' for the credit line. Starting with a negative offset for the credit thus makes this nonsenical. Void creates positive offset amounts which act to 'restore' both the outstanding 'debt' for the debit line and the outstanding 'credit' for the credit line. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:39:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:39:33 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123442|0 |1 is obsolete| | --- Comment #216 from Martin Renvoize --- Created attachment 123443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123443&action=edit Bug 22435: (follow-up) Set CREATE offset for credits to positive The history view of an accountline shows increases and decreases in the amount outstanding from the perspective of the credit/debit line you are inspecting. Apply creates a negative offset amount which acts to 'reduce' both the outstanding 'debt' for the debit line and the outstanding 'credit' for the credit line. Starting with a negative offset for the credit thus makes this nonsenical. Void creates positive offset amounts which act to 'restore' both the outstanding 'debt' for the debit line and the outstanding 'credit' for the credit line. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 16:40:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 14:40:30 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #217 from Martin Renvoize --- Yup, I neglected to add the fix for that test to my final commit the first time around! All fixed now.. and rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 19:14:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 17:14:26 +0000 Subject: [Koha-bugs] [Bug 28800] Libabry list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 19:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 17:30:27 +0000 Subject: [Koha-bugs] [Bug 28807] New: Item search should search repeated subfields sequentially Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28807 Bug ID: 28807 Summary: Item search should search repeated subfields sequentially Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Say we have a bib with two 650$a tags, "cheese" and "corn." If we set the 650$a up as a searchable field in item search, our search terms will be compared to the string "cheese corn." That means we end up having to wildcard our search terms in both directions to account for the possibility that they might have a term on either side in the record ("%cheese%" and "%corn%"). This would work better if we compared our search term to each value individually, rather than to the concatenated string of all values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 19:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 17:40:26 +0000 Subject: [Koha-bugs] [Bug 28808] New: Item search should allow wildcard in subfield when setting up custom search option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28808 Bug ID: 28808 Summary: Item search should allow wildcard in subfield when setting up custom search option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When querying a MARC record via SQL directly, one can wildcard the subfield to search an entire MARC tag -- like "ExtractValue(metadata,'//datafield[@tag="650"]/*')" to look at the whole 650 without specifying a subfield. It would be nice to be able to select "*" for one's subfield when setting up a custom item search field. As is, you have to either leave it blank (which will break all searches) or pick a specific value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 20:08:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 18:08:03 +0000 Subject: [Koha-bugs] [Bug 28808] Item search should allow wildcard in subfield when setting up custom search option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28808 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- Currently the code is something like: ExtractValue(metadata,'//record/datafield[@tag="XXX"]/subfield[@code="Y"]') LIKE 'TERM' If we defaulted to a contains search we could implement as: SELECT ExtractValue(metadata,'//datafield[@tag="XXX"]/subfield[@code="Y" AND contains(.,"TERM")]') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 21:34:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 19:34:46 +0000 Subject: [Koha-bugs] [Bug 28809] New: Patron age calculated incorrectly after changing dateformat syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28809 Bug ID: 28809 Summary: Patron age calculated incorrectly after changing dateformat syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: - change the dateformat syspref (I was on MM/DD/YYYY and changed to YYYY-MM-DD) - click to edit a patron record - select yesterday for patron's date of birth - note the text that appears under DOB to tell you the patron's age is something entirely wrong This is only an issue with the age as it appears on the edit page. Koha calculates the age correctly on save and correctly enforces category age limits. Dateformat is getting cached somewhere. I was able to correct it by restarting memcached and plack, but that shouldn't be needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 21:36:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 19:36:08 +0000 Subject: [Koha-bugs] [Bug 28809] Patron age calculated incorrectly after changing dateformat syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28809 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- dateformat_pref is a global variable and does not seem to clear until a restart_all -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 22:04:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 20:04:01 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 22:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 20:04:18 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 --- Comment #4 from David Nind --- Created attachment 123444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123444&action=edit Bug 28303 - Fix plugins system with multiple pluginsdir settings C4/Templates::badtemplatecheck mucks with the config('pluginsdir') array ref. This makes sure it operates on a copy of the array. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 22:06:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 20:06:30 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120722|0 |1 is obsolete| | --- Comment #5 from David Nind --- Comment on attachment 120722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120722 Proposed fix Not sure what happened here - obsoleting patch so there is only one (the signed off one). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 22:20:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 20:20:27 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 --- Comment #6 from David Nind --- Thanks Michael for the test plan! I have now tested and signed off. Testing notes (using koha-testing-docker): - Step 7: . I didn't see an error (maybe because I changed the user/group for the new directory to match the koha instance) . The plugin looked okay (I used ByWaterSolutions' dev-koha-plugin-kitchen-sink) but there were errors when i tried to do anything with it - it looks like it was uploaded to koha-tmpl/opac-tmpl - After applying the patch and restarting the plugin showed as having errors. After reinstalling the plugin everything was back to working as expected and i could install other plugins. Manually deleted the plugin files added to koha-tmpl/opac-tmpl/Koha/ David -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 22:23:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 20:23:13 +0000 Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 --- Comment #3 from T. Keagan --- (In reply to David Cook from comment #1) > Did you put "No" as a value in the 942$n? Hi David. The display value is "No". The authorized value is "0", populated by the Fast Add Framework, which has the YES_NO authorized values linked to it by default. The suppression that is happening is not "normal", meaning that the label, "Suppressed in OPAC", isn't being applied to the record when viewed in the intranet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 22:28:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 20:28:03 +0000 Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 --- Comment #4 from T. Keagan --- (In reply to Jonathan Druart from comment #2) > I don't recreate what you describe (tested on master and 20.11.x), the title > is always displayed. Thank you Jonathan. Perhaps this is particular to our tech stack. We're using Oracle Linux and Percona SQL Server. Maybe something is up with Perl. We've duplicated this issue on multiple machines. Since I'm working in a new instance with only four MARC records in it, it seems like the only variable is toggling OpacSuppression. I see nothing useful in the logs, although I get the warnings below regardless of whether OpacSuppression is toggled: [2021/08/03 09:26:45] [WARN] Use of uninitialized value $f in pattern match (m//) at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 725. [2021/08/03 09:26:45] [WARN] Use of uninitialized value $f in exists at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 729. Perhaps I will just need to set this aside until I have time to go through the code. I am mystified. Thanks for your time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 22:46:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 20:46:54 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 --- Comment #6 from David Nind --- Hi Owen. I've finally had another go at this one. For some reason the forward button no longer works (after using the back button). I tested this in Firefox and Google Chrome (latest versions on Ubuntu 18.04). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 23:22:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 21:22:48 +0000 Subject: [Koha-bugs] [Bug 28810] New: Housebound details should be textarea not text inputs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Bug ID: 28810 Summary: Housebound details should be textarea not text inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the housebound module when filling out the housebound details there are some fields that could potentially contain a lot of information. There fields are Preferred materials, Subjects, Authors, Referrals, and notes. Librarians may wish to enter many subjects/authors/notes/etc and perhaps add line breaks to separate subjects/authors/notes/etc. We should replace the input's with textarea and when viewing those housebound details we should preserve those lines breaks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 23:22:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 21:22:54 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 23:33:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 21:33:46 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 23:33:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 21:33:49 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 --- Comment #1 from Lucas Gass --- Created attachment 123445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123445&action=edit Bug 28810: replace housebould detail inputs with textarea To test: 1. apply patch 2. enable housebound module 3. go to a patron and look at the housebound tab 4. Edit the detials. 5. The preferred materials, subjects, authors, referral, and note inputs should be replace with much larger textareas. 6. You should now be able to added line breaks, so fill out each of the fields adding some line breaks. I added something like: Fiction authors: Frank Herbert Non-fiction authors: Malcolm Gladwell 7. Save changes 8. Now when you look at the housebound details those line breaks should be preserved and much easier to read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 23:34:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 21:34:18 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 3 23:53:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Aug 2021 21:53:40 +0000 Subject: [Koha-bugs] [Bug 26544] Housebound module should show delivery preferences when scheduling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26544 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 02:00:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 00:00:34 +0000 Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 --- Comment #5 from David Cook --- Since you're using an atypical stack and folk here can't reproduce it, it sounds like this might be more of a support request than a bug report. I don't use Elasticsearch with Koha, so I'm probably not much help there. However, are you able to reproduce the same problem when using Zebra instead of Elasticsearch for your SearchEngine? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 05:05:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 03:05:49 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #46 from David Cook --- Thanks for working on this, Nick. This is a feature I've long wanted in Koha. I've just taken a quick peek at the code, so just going to ask for some clarification. At a glance, it looks like a 001 will be assigned for original cataloguing or copy cataloguing using the Cataloguing UI (even if it already has a 001), is that right? That sounds good to me. I wonder about Staged MARC Imports though. At a glance, I think those will retain their original 001 and won't get updated. I think that might be problematic. Same goes for the APIs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 08:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 06:36:14 +0000 Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801 --- Comment #6 from Jonathan Druart --- Try on one sandbox https://wiki.koha-community.org/wiki/Sandboxes If you recreate the problem there, then provide us the step-by-step plan to reproduce it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 08:39:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 06:39:03 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Jonathan Druart --- Should we remove the log then? Is the behaviour in master correct? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:01:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:01:26 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_05_candidate Version|21.05 |unspecified Severity|normal |major Depends on| |25026 Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com --- Comment #1 from Jonathan Druart --- Certainly caused by bug 25026. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 [Bug 25026] RaiseError must be set for the UI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:01:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:01:26 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 [Bug 28804] 500 Error when running report with bad syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:04:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:04:53 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:04:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:04:56 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 --- Comment #2 from Jonathan Druart --- Created attachment 123446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123446&action=edit Bug 28804: (bug 25026 follow-up) Handle SQL errors in reports Since bug 25026 DBMS errors are raised, but the report module is not dealing correctly with the errors. If an error occurred in execute_query, next queries will fail as well, we should skip them. Test plan: 1. Create report from SQL queries, containing errors (invalid syntax, etc.) 'SELECT id FROM borrowers' can do it 2. Execute the query => Without this patch you get a 500 => With this patch applied you see that the error raised at DBMS level is propagated to the UI 3. Confirm that there is no regression on valid queries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:14:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:14:45 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:27:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:27:48 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |21466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:27:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:27:48 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:30:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:30:26 +0000 Subject: [Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:30:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:30:39 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:30:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:30:43 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121424|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 123447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123447&action=edit Bug 28352: Only check authorised values mapped to DB fields The errors reported seem to be caused by authorised values mapped to MARC fields but not mapped to a koha field. We should additionally make sure to check the Default framework Also, adding comment to indicate we only check records with items, because we do TO test: 1 - In a framework that is not the default map a MARC field to an authorised value, but not a koha field 2 - In SQL, force the kohafield to NULL for the mapping you just make UPDATE marc_subfield_structure SET kohafield = NULL WHERE frameworkcode='BKS' and authorised_value='HINGS_AS' 3 - perl misc/maintenance/search_for_data_inconsistencies.pl 4 - get the following errors: Use of uninitialized value $tmp_kohafield in pattern match (m//) at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 151. Use of uninitialized value $tmp_kohafield in substitution (s///) at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 154. Can't call method "get_column" on an undefined value at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 157. 5 - Apply patch 6 - Repeat 7 - No more errors Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:31:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:31:49 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 --- Comment #3 from Fridolin Somers --- I was just about to open the same issue ;) Thanks a lot Nick :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:40:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:40:31 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In opac-suggestions.pl |In opac-suggestions.pl user |preselect user library |library is not preselected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:41:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:41:52 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from Fridolin Somers --- Done, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:49:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:49:28 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Personally.. I think if this is backported then bug 28390 should be too in quick succession as it fixes a bug with this implimentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:55:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:55:06 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 09:57:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 07:57:02 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart+koha at gmail. | |com --- Comment #16 from Jonathan Druart --- There is a conflict on the last patch, Martin can you have a look please? Should be easy for a native English speaker :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:02:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:02:42 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119809|0 |1 is obsolete| | --- Comment #9 from Fridolin Somers --- Comment on attachment 119809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119809 Bug 28127: Add transaction timestamp to register details tables Patch with "add" was pushed to master so I obsolete patch with "Add". It will be missing "Signed-off-by: Katrin Fischer" but we know it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:03:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:03:26 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119447|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:04:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:04:45 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 --- Comment #10 from Fridolin Somers --- OK so we wait on Bug 28390 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:09:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:09:57 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122544|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 123448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123448&action=edit Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:10:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:10:01 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122545|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 123449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123449&action=edit Bug 28630: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:10:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:10:05 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122546|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 123450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123450&action=edit Bug 28630: (follow-up) Update wording of syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:10:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:10:18 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:13:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:13:17 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:13:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:13:21 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #9 from Fridolin Somers --- Created attachment 123451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123451&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:15:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:15:27 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 --- Comment #6 from Fridolin Somers --- Can this be backported to 21.05.x please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:16:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:16:57 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- Why this limitation? I would exclude a list of special characters but not to anything that is not a-Z0-9, "❤" is a valid branchcode and is known (by me, at least) to work perfectly. It will certainly be considered as a regression by users not using Latin alphabet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:23:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:23:43 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to define |Move |expiredpickup charge for |ExpireReservesMaxPickUpDela |patron category and item |yCharge to the circulation |type |rules CC| |jonathan.druart+koha at gmail. | |com Version|20.05 |unspecified Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:23:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:23:50 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:23:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:23:50 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:33:12 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #28 from Jonathan Druart --- Created attachment 123452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123452&action=edit Bug 25711: Wording 'use global' > 'Default' We use 'Default' for useDaysMode already -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:39:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:39:51 +0000 Subject: [Koha-bugs] [Bug 28811] New: Cant receive orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811 Bug ID: 28811 Summary: Cant receive orders Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mbarham at birzeit.edu QA Contact: testopia at bugs.koha-community.org Created attachment 123453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123453&action=edit no listing order to receive Dears, Im on debian 9 koha 21.05 I have a problem with receiving orders, I have closed basket, with a lot of orders inside, check picture attached , if I try to receive any order, nothing appear on the receiving page , check next photo. logs from server ==> /var/log/koha/koha/plack.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /intranet/acqui/parcel.pl?invoiceid=22 HTTP/1.1" 200 41592 "https://koha-intra.birzeit.edu/cgi-bin/koha/acqui/parcels.pl?booksellerid=309" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36" ==> /var/log/koha/koha/intranet-access.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /cgi-bin/koha/acqui/parcel.pl?invoiceid=22 HTTP/1.1" 200 7952 ==> /var/log/koha/koha/plack.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /api/v1/app.pl/api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&_match=contains&_order_by=%2Bbasket.name HTTP/1.1" 404 - "https://koha-intra.birzeit.edu/cgi-bin/koha/acqui/parcel.pl?invoiceid=22" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36" ==> /var/log/koha/koha/intranet-access.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&_match=contains&_order_by=%2Bbasket.name HTTP/1.1" 404 1046 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:42:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:42:38 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Jonathan Druart --- 1. Tiny wording change suggestion, do you agree with the last patch? 2. You need a new method in Koha::CirculationRules to retrieve the effective value of the new rule (have a look at 'sub get_effective_*') 3. - } else if ( i == 5 || i == 6 || i == 26 || i == 27 || i == 28 ) { + } else if ( i == 5 || i == 6 || i == 17 || i == 27 || i == 28 || i == 29 ) { I think there is something wrong here. Why did you remove 26? Do you understand what this part of the code does? It's displaying "Unlimited" for integer without value. But you want "use global/Default" to be displayed if the rule is empty. I am not sure we need this line to change. 4. (not blocker) Not a bit deal but in tests you can use $builder->build_object instead of ->build, to return a Koha::Object-based object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 10:52:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 08:52:47 +0000 Subject: [Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #9 from Jonathan Druart --- (not related to this patch but we have .hold_location_select and .pickup_location_dropdown) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:01:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:01:14 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #30 from Andrew Nugged --- I think we lost part of the logic after changes (as I remember it was tricky): The goal was: when we calling "get_effective_rule" for "expire_reserves_charge" we expect to have any number _including_ zero as value for real charge value, and in case we have '' (blank) in the rule, we get "ExpireReservesMaxPickUpDelayCharge" instead, as default. Look for commit description test/check scenario: ... 10) But in case if matching rule has zero ("0") as a value - that allows to have no-fee smart-rule results, as a feature. but now: there is the replacement in patch 123328: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123328&action=diff#a/Koha/Hold.pm_sec1 This: my $rule_value = $rule && $rule->rule_value // ''; $charge = $rule_value ne '' ? $rule_value : C4::Context->preference("ExpireReservesMaxPickUpDelayCharge"); is replaced by: $charge = $rule ? $rule->rule_value : C4::Context->preference("ExpireReservesMaxPickUpDelayCharge"); and the new version goes only for "Perl truth" so it doesn't differentiate between 0 and '' (under as well) and all goes then to "Default", but we should have 0 instead of Default if we have zero in $rule->rule_value. Petro, let's check why tests are passing :)... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:01:45 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27852 CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- Highlighed by bug 27852. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:01:45 +0000 Subject: [Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:02:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:02:20 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 --- Comment #5 from Jonathan Druart --- My fix was 143 next unless $kohafield and $av; But yours is better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:04:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:04:40 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #31 from Andrew Nugged --- > 1. Tiny wording change suggestion, do you agree with the last patch? yes, "Default" is good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:05:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:05:36 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|Passed QA |In Discussion --- Comment #20 from Jonathan Druart --- Can we squash and clarify in the commit message what's happening here? It seems that the icons were part of Koha (bug 5640) but have been removed (inadvertently) and so we are adding them back? But with a modified version because we didn't know what was the license? Aleisha, do you remember the origin of this bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:11:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:11:33 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #32 from Peter Vashchuk --- (In reply to Jonathan Druart from comment #29) > 3. > - } else if ( i == 5 || i == 6 || i == 26 || i == 27 > || i == 28 ) { > + } else if ( i == 5 || i == 6 || i == 17 || i == 27 > || i == 28 || i == 29 ) { > > I think there is something wrong here. Why did you remove 26?... A new 17th column was added, so the number of columns increased, and relative numbers for the next ones shifted, in short, 26th column wasn't removed, it just became 27th, so 26 27 28 are 27 28 29 accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:13:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:13:35 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #20 from Jonathan Druart --- Created attachment 123454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123454&action=edit Bug 28630: Improve date comparisons in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:22:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:22:36 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #33 from Andrew Nugged --- > 4. (not blocker) > Not a bit deal but in tests you can use $builder->build_object instead of > ->build, to return a Koha::Object-based object. and, as I figured out too, seems tests needed to protect numerical zero in rule value not to be overlapped with default: 10) But in case if matching rule has zero ("0") as a value - that allows to have no-fee smart-rule results, as a feature. ... and this is not covered by tests now. So, Petro, you can update tests also taking into account this JD's p4 advice. As well as I see roll-back for this https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123328&action=diff#a/Koha/Hold.pm_sec1 needed to restore this "no-fee (0) for particular items when the default is not zero" feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 11:32:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 09:32:26 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #28 from Jonathan Druart --- About the warns in the db rev, don't we actually want to explode instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 12:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 10:40:26 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #34 from Andrew Nugged --- We tested once more with Petro: Nick's update works, so it's ok, I was confused that we might overlap 0 in "$rule ? $rule->rule_value : C4::Context->preference..." but we before "?" checking for RULE as _object_, not rule value (my confusion :) ), so even if rule_value is 0, object anyway will be truth, so zero returned, and logic works. And in the "Default" case in rule, we store "undef", which leads to full rule absence in DB, so again: checking for the rule as object fails and we falling back to Default. All ok with logic, yeah. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 13:18:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 11:18:15 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 13:18:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 11:18:22 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 13:18:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 11:18:52 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 13:19:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 11:19:24 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 13:56:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 11:56:33 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 13:56:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 11:56:36 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123445|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123455&action=edit Bug 28810: replace housebould detail inputs with textarea To test: 1. apply patch 2. enable housebound module 3. go to a patron and look at the housebound tab 4. Edit the detials. 5. The preferred materials, subjects, authors, referral, and note inputs should be replace with much larger textareas. 6. You should now be able to added line breaks, so fill out each of the fields adding some line breaks. I added something like: Fiction authors: Frank Herbert Non-fiction authors: Malcolm Gladwell 7. Save changes 8. Now when you look at the housebound details those line breaks should be preserved and much easier to read. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:00:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:00:34 +0000 Subject: [Koha-bugs] [Bug 18425] Housebound module needs to accomodate branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18425 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +!, makes sense! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:00:51 +0000 Subject: [Koha-bugs] [Bug 27367] Housebound and CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27367 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:03:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:03:23 +0000 Subject: [Koha-bugs] [Bug 28752] Add 'sort fields' to Housebound module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28752 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- I like this idea generally, but I'd prefer a method to define fields as desired, rather than a set number of fields -- something more like a patron attribute rather than something like sort1/sort2. In fact, could we make this an option on patron attributes? A checkbox in attribute setup for something like "Show in housebound." If that's checked, this attribute shows in the housebound module rather than in the usual place? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:36 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:39 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #29 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:43 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:46 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #218 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:49 +0000 Subject: [Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle and 245p part subfields in the default title index mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:51 +0000 Subject: [Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle and 245p part subfields in the default title index mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:54 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:56 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:05:59 +0000 Subject: [Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:02 +0000 Subject: [Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:05 +0000 Subject: [Koha-bugs] [Bug 28391] Elasticsearch - Add 264b to publisher index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:06 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #30 from Jonathan Druart --- (In reply to Jonathan Druart from comment #28) > About the warns in the db rev, don't we actually want to explode instead? DB rev adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:08 +0000 Subject: [Koha-bugs] [Bug 28391] Elasticsearch - Add 264b to publisher index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28391 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:11 +0000 Subject: [Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:13 +0000 Subject: [Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:16 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:19 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #21 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:21 +0000 Subject: [Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:06:24 +0000 Subject: [Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:10:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:10:56 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:20:40 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:20:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:20:45 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #35 from Peter Vashchuk --- Created attachment 123456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123456&action=edit Bug 25711: fix existing tests and add new one Add a new test with circulation rule for library_C_code that has set expire_reserves_charge which is 0. In this case 0 should be used as the charge. Also use build_object instead of build to build the koha object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 14:56:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 12:56:21 +0000 Subject: [Koha-bugs] [Bug 28549] Add a system preference to duplicate --frombranch flag in overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28549 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 15:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 13:09:23 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #36 from Andrew Nugged --- Petro, regarding this from JD: > 2. You need a new method in Koha::CirculationRules to retrieve the effective value of the new rule (have a look at 'sub get_effective_*') Let's create +1 more patch and move get_effective_expire_reserves_charge as for example get_effective_daysmode created and move "default detection" logic there, so it will be the proper place for re-usable code. (JD: thanks for the explanation!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 15:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 13:09:39 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 15:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 13:52:19 +0000 Subject: [Koha-bugs] [Bug 28752] Add 'sort fields' to Housebound module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28752 --- Comment #2 from Rhonda Kuiper --- Interesting idea. This will work for some of the information we want to associate with our housebound patrons but there are other bits of information that we aren't saving anywhere else like the quadrant of the city the person lives in. For these extra things we would like a few fields that we can define as we need. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 16:25:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 14:25:27 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 16:25:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 14:25:31 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123164|0 |1 is obsolete| | Attachment #123165|0 |1 is obsolete| | Attachment #123166|0 |1 is obsolete| | --- Comment #21 from Owen Leonard --- Created attachment 123457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123457&action=edit Bug 27522: Adding new itemtype info image to carredart This patch adds an "info" icon to the carredart icon set. It was created from scratch for Koha based on an earlier patch by Victoria Faafia. Test Plan: 1. Go to Administration > Item Types > Modify Item Type 2. Under carredart you should see an "info" item type icon. Assign it to an item type. 3. Go to Administration -> System preferences and make sure that OpacAdvSearchOptions and AdvancedSearchTypes have item type searches enabled. 4. In the OPAC and staff interface, view the advanced search page and confirm that the new icon appears. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 16:51:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 14:51:42 +0000 Subject: [Koha-bugs] [Bug 28812] New: Authority tag editor only copy $a Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Bug ID: 28812 Summary: Authority tag editor only copy $a Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 7882 Steps to reproduce: 1- Create a notice with a 700$a and 700$d 2- Click on Tag Editor 3- Only 700$a is copied Expect result: same as 19.11 all other subfields should be copied. There's now one more level in HTML tree and koha-tmpl/intranet-tmpl/prog/js/cataloging.js:openAuth() selects the wrong node. To check: still working in authorities/authorities.pl ==== diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js index f126c86de2..35cbe499ae 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js @@ -43,8 +43,8 @@ function openAuth(tagsubfieldid,authtype,source) { var elementsubfcode=getSubfieldCode(element.name); var mainmainstring=element.value; var mainstring = new Array(); - var inputs = element.parentNode.parentNode.getElementsByTagName("input"); + var inputs = element.parentNode.parentNode.parentNode.getElementsByTagName("input"); for (var myindex =0; myindex References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 [Bug 28812] Authority tag editor only copy $a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 16:53:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 14:53:04 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authority tag editor only |Authority tag editor only |copy $a |copies $a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 18:07:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 16:07:52 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 18:07:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 16:07:55 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123355|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123458&action=edit Bug 20463: Adding index for Leader 19 Multipart resource record level Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 18:07:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 16:07:59 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 --- Comment #5 from Katrin Fischer --- Created attachment 123459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123459&action=edit Bug 20463: (follow-up) Configure short name mrl for Multipart-resource-level index This adds mrl as appreviation of Multipart-resource-level to the Zebra configuration and Search.pm so it can be used when searching. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 18:08:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 16:08:03 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 --- Comment #6 from Katrin Fischer --- Created attachment 123460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123460&action=edit Bug 20463: (follow-up) Remove option from search templates Using this search option in the GUI would require the user to enter the codes from MARC, LDR 19, see: https://www.loc.gov/marc/bibliographic/bdleader.html So I think it's better to leave this out for the moment. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 18:58:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 16:58:23 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 18:58:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 16:58:27 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123446|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 123461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123461&action=edit Bug 28804: (bug 25026 follow-up) Handle SQL errors in reports Since bug 25026 DBMS errors are raised, but the report module is not dealing correctly with the errors. If an error occurred in execute_query, next queries will fail as well, we should skip them. Test plan: 1. Create report from SQL queries, containing errors (invalid syntax, etc.) 'SELECT id FROM borrowers' can do it 2. Execute the query => Without this patch you get a 500 => With this patch applied you see that the error raised at DBMS level is propagated to the UI 3. Confirm that there is no regression on valid queries Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 19:06:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 17:06:36 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #5 from Andrew Fuerste-Henry --- Following through (In reply to Andrew Fuerste-Henry from comment #4) > Hi folks! I'm reopening this one. It was not actually a duplicate of bug > 23767. > 23767 was about the total at the bottom of the table on Acq Home. This is > about the amount shown in each parent fund's line directly. Which means really this is an enhancement rather than a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 19:08:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 17:08:29 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123368|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 123462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123462&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 19:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 17:09:18 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123368|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 19:09:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 17:09:44 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #7 from Owen Leonard --- (In reply to Owen Leonard from comment #5) > I don't have a patch, so please attempt! Never mind I did a patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 20:48:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 18:48:08 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick what information displays on the 'Libraries' pages. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- +1 Some customers ask to hide some libraries that are not a "real" place. A "public" or "show in OPAC" flag would be great. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 20:48:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 18:48:40 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 21:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 19:45:35 +0000 Subject: [Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123068|0 |1 is obsolete| | --- Comment #3 from Michael Hafen --- Comment on attachment 123068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123068 Proposed fix Found a bug in the patch. Will replace the patch shortly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 21:46:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 19:46:14 +0000 Subject: [Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #4 from Michael Hafen --- Created attachment 123463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123463&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 21:49:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 19:49:36 +0000 Subject: [Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #5 from Michael Hafen --- (In reply to David Cook from comment #2) > The title of this report doesn't make sense. Bibliographic records don't > belong to library branches. > > Also, blocking based on homebranch of items that belong to the record > doesn't make sense. You'd block modifications of bib records as soon as an > item is added for another branch. Branch A might add the bib record, but > then if Branch B adds an item, Branch A won't be able to edit the bib record > that they added. I could see that being frustrating. > > But I can also see it being frustrating to have a different branch change a > bib record that you're using. Hmm... This is a pit-fall with IndependantBranches. As you observe it is frustrating to not be able to change a record, but also frustrating to have someone else change a record you are using. I have a little fork (patch submitted on another enhancement) that hides items from other libraries, so we don't even know when someone else is using a record. Our solution was this; since we can't see when a record is shared we will block changes to those records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 22:55:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 20:55:41 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #22 from Aleisha Amohia --- These icons were designed by a Catalyst Academy student (Victoria, who opened the bug report), and she designed them as part of her contribution to the Academy. They are free to use for Koha's image sets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 23:13:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 21:13:11 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 23:13:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 21:13:14 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121935|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 123464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123464&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 23:13:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 21:13:19 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121936|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 123465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123465&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 4 23:13:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 21:13:23 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123451|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 123466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123466&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 00:33:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 22:33:35 +0000 Subject: [Koha-bugs] [Bug 27287] Make note fields from orders searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleypelham at catalyst.net.n |ity.org |z CC| |hayleypelham at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 00:33:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Aug 2021 22:33:44 +0000 Subject: [Koha-bugs] [Bug 27287] Make note fields from orders searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 03:21:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 01:21:22 +0000 Subject: [Koha-bugs] [Bug 27367] Housebound and CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27367 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Donna --- Since the functionality to set this by patron category is available, I will close this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:34:44 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #60 from Martin Renvoize --- Ouch.. there's stuff missing here. We don't update kohastructure at all and we don't do a DB update to add the error_code field to the database either. Finally, we don't add error_code to the _set_message_status routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:40:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:40:28 +0000 Subject: [Koha-bugs] [Bug 28813] New: Delivery notes feature was pushed prior to it's completion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Bug ID: 28813 Summary: Delivery notes feature was pushed prior to it's completion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 14723 Bug 14723 somehow made it through QA with some fields missing from the database and some functions missing corresponding updates (for translation handling). We all make mistakes.. oops. This bug will serve to add the correct DB update and changes to kohastructure and update the relevant function. See bug 14723 comment 60 for further details. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:40:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:40:28 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 [Bug 28813] Delivery notes feature was pushed prior to it's completion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:40:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:40:36 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:40:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:40:47 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:49:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:49:19 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #1 from Martin Renvoize --- Created attachment 123469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123469&action=edit Bug 28803: Add unit tests This patch updates Letters.t to confirm that invalid email addresses in the message_queue should not throw an exception when sending mail but instead set the status to failed and pass error details to the end user. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:49:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:49:22 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #2 from Martin Renvoize --- Created attachment 123470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123470&action=edit Bug 28803: Add invalid email handling in _send_message_by_email This patch adds a try/catch block around the call to Koha::Email->create to catch and handle invalid emails being passed in the parameters. The message is marked as 'failed' with an error_code of 'INVALID_EMAIL' and the exception message being recorded in the delivery_note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:50:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:50:10 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 [Bug 28813] Delivery notes feature was pushed prior to it's completion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:50:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:50:10 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:51:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:51:19 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 09:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 07:52:12 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #3 from Martin Renvoize --- Whilst writing tests for this, I found some issues with bug 14723 and have hence added a dependency on bug 28813 which I will use to fix those issues and add more comprehensive tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:07:50 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #23 from Jonathan Druart --- So now we have 2 versions, the one from Victoria and the one from Owen. Do we need both? Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré d'Art" (museum) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:25:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:25:47 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #1 from Martin Renvoize --- Created attachment 123471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123471&action=edit Bug 28813: Update database field name Update the database field name from 'delivery_note' to 'failure_code' to more accurately denote it's use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:25:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:25:50 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #2 from Martin Renvoize --- Created attachment 123472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123472&action=edit Bug 28813: DBIC Schema Update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:25:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:25:54 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #3 from Martin Renvoize --- Created attachment 123473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123473&action=edit Bug 28813: Update unit tests This patch updates the unit tests to check for failure_code instead of delivery_note and catches a missing case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:25:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:25:57 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #4 from Martin Renvoize --- Created attachment 123474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123474&action=edit Bug 28813: Rename delivery_note to failure_code We now use the codes from the half implimented error_code in place of the plain text that was being added to the delivery_note field. As part of that we rename the field to failure_code to clarify it's intended content. Test plan 1/ Confirm t/db_dependent/Letters.t passes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:26:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:26:14 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:26:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:26:43 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:35:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:35:08 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123469|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 123475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123475&action=edit Bug 28803: Add unit tests This patch updates Letters.t to confirm that invalid email addresses in the message_queue should not throw an exception when sending mail but instead set the status to failed and pass error details to the end user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:35:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:35:12 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123470|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 123476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123476&action=edit Bug 28803: Add invalid email handling in _send_message_by_email This patch adds a try/catch block around the call to Koha::Email->create to catch and handle invalid emails being passed in the parameters. The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:35:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:35:31 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:36:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:36:41 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #6 from Martin Renvoize --- Rebased on top of bug 28813. I'd have liked to have enhanced the failure_code handling so we could continue to pass in which email parameter failed validation as the first version of this patch did but I felt that was out of scope here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:36:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:36:47 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:51:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:51:02 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Action buttons should have |Action buttons should have |unique classes |a class per action type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 11:51:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 09:51:35 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Martin Renvoize --- (In reply to Katrin Fischer from comment #14) > Just wondering: if they are supposed to be and remain unique, should they > not be ids? I've reworded the bug title.. I didn't mean ID's.. I meant Classes, one per action type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:03:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:03:52 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #61 from Andrew Nugged --- (In reply to Victor Grousset/tuxayo from comment #51) Victor, please can you again give-this-a-go? i.e. Re-Sign-off this ticket again according to that so we now might have proper "error messages" for the wrong syntax in ES requests (bug 28736), if that comforts you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:32:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:32:11 +0000 Subject: [Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121189|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 123477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123477&action=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:33:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:33:13 +0000 Subject: [Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #5) > [%- PROCESS account_type_description > account=debit.credit -%] > [%- IF debit.credit.description %][% > debit.credit.description | html %][%- END -%] > [%- IF ( debit.credit.itemnumber ) -%] > ([% debit.credit.item.biblio.title | html > %])[%- END -%] > [% debit.credit.amount | $Price %] > > This does not look good to me at first glance. > You remove and move data outside data tags? > Please explain/correct. Good catch, my brain was clearly on a go slow there. I've rebased the patch, added a more details test plan and fixed an additional error with regards the historical transactions table not adding this field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:35:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:35:43 +0000 Subject: [Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:35:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:35:43 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 [Bug 28389] One should be able to see details for refunds on the register summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:35:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:35:59 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:35:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:35:59 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28390 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:43:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:43:07 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123422|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 123478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123478&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:44:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:44:00 +0000 Subject: [Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123477|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 123479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123479&action=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 12:44:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 10:44:20 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #7 from Martin Renvoize --- Another minor rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 13:10:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 11:10:39 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 13:11:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 11:11:35 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123165|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 13:11:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 11:11:37 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123164|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 13:15:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 11:15:33 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #24 from Owen Leonard --- I've removed my patch and returned the old ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:22:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:22:49 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:22:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:22:52 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 --- Comment #4 from Nick Clemens --- Created attachment 123480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123480&action=edit Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:12 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123029|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize --- Created attachment 123481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123481&action=edit Bug 22690: Refactor merging of records to improve performance (Elasticsearch) This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Biblio.t prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Koha/SearchEngine/Indexer.t Signed-off-by: Michal Denar Rebased-by: Joonas Kylmälä Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:19 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123030|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize --- Created attachment 123482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123482&action=edit Bug 22690: Add more tests - Tests for adopt_items_from_biblio - Tests for the relationship between items and acquisition orders - Tests for indexer calls in adopt_items_from_biblio Signed-off-by: Michal Denar Rebased-by: Joonas Kylmälä Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:25 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123031|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize --- Created attachment 123483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123483&action=edit Bug 22690: (QA follow-up) Silence manually generated warnings In our test setup we mock the index_records() to produce warnings like this: Koha::Item at t/db_dependent/Koha/SearchEngine/Indexer.t line 93. By wrapping all our item creations to warnings_are{} we can silence them. Signed-off-by: Joonas Kylmälä Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:30 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123032|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize --- Created attachment 123484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123484&action=edit Bug 22690: (QA follow-up) Index also source biblio when calling move_to_biblio() We need to update the search index record for the old biblio where the item was moved from to keep the item info in search index up-to-date. To test: 1) $ prove t/db_dependent/Koha/SearchEngine/Indexer.t Signed-off-by: Joonas Kylmälä Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:36 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123033|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize --- Created attachment 123485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123485&action=edit Bug 22690: (QA follow-up) Make bib-level hold object actually bib-level We need to pass undef itemnumber to build_object() to actually have a hold without an item tied to it. Otherwise build_object() will create automatically an item for us (thus making it an item-level hold) To test: $ prove t/db_dependent/Koha/Item.t Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:42 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123034|0 |1 is obsolete| | --- Comment #181 from Martin Renvoize --- Created attachment 123486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123486&action=edit Bug 22690: Add missing txn_begin in subtest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:47 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123035|0 |1 is obsolete| | --- Comment #182 from Martin Renvoize --- Created attachment 123487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123487&action=edit Bug 22690: Remove MoveItemFromBiblio import Added in the meanwhile by bug 17600. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:53 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123036|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize --- Created attachment 123488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123488&action=edit Bug 22690: (QA follow-up) Rename 'item_orders' to 'orders' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:28:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:28:59 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123037|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize --- Created attachment 123489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123489&action=edit Bug 22690: (QA follow-up) Improve negation syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:04 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123038|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize --- Created attachment 123490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123490&action=edit Bug 22690: (QA follow-up) Move adopt_items_from_biblios to Koha::Items This patch moves the Koha::Biblio->adopt_items_from_biblio method to the Koha::Items set class and updates all calls from Biblio2->adopt_items_from_biblio(Biblio1) to Biblio->items->move_to_biblio(Biblio2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:10 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123039|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize --- Created attachment 123491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123491&action=edit Bug 22690: (QA follow-up) Clarify uses of DBIC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:16 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123040|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize --- Created attachment 123492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123492&action=edit Bug 22690: (QA follow-up) Add relationships to linktracker Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:21 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123041|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize --- Created attachment 123493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123493&action=edit Bug 22690: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:27 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123042|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize --- Created attachment 123494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123494&action=edit Bug 22690: (QA follow-up) Use relationship accessor With the addition of foreign key relationships to the linktracker table we now get a DBIC relationship accessor we can use. This clarifies the code slightly by using the _result->relationship form to get the DBIC resultset. We should still introduce a Koha::Object based class for this table at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:33 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123044|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize --- Created attachment 123495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123495&action=edit Bug 22690: (QA follow-up) Add TrackedLink classes and use them This patch adds Koha::TrackedLink(s) classes based on Koha::Object(s) and then adds the relationship accessor to Koha::Item and uses it within the move_to_biblio method. Tests for new relationship also added to t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:39 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123062|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize --- Created attachment 123496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123496&action=edit Bug 22690: (QA follow-up) Correct variable name The $from_biblio variable name doesn't exists after a refactoring that happened. Here we need to re-index both the $self biblio and $to_biblio biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:29:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:29:44 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #192 from Martin Renvoize --- Created attachment 123497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123497&action=edit Bug 22690: (QA follow-up) Fix indexing for Items sets This patch adds tests and handling for calling move_to_biblio on a Koha::Items set that contains items from more than one source biblio. Test plan 1/ Inspect the changes to t/db_dependent/Koha/SearchEngine/Indexer.t 2/ Run t/db_dependent/Koha/SearchEngine/Indexer.t and confirm it passes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:30:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:30:52 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #193 from Martin Renvoize --- Fixes made in followup, test suit re-run against everything and all passing. I think it was a good move adding the Koha:: classes, it makes the code cleaner and shows the path for future work. Setting back to PQA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:38:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:38:16 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 15:38:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 13:38:20 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #37 from Peter Vashchuk --- Created attachment 123498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123498&action=edit Bug 25711: move get_effective_expire_charge to Koha::CirculationRules Move get_effective_expire_reserves_charge as a new method in Koha::CirculationRules to retrieve the effective value of the rule. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:20:40 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:20:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:20:44 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122462|0 |1 is obsolete| | Attachment #122463|0 |1 is obsolete| | Attachment #122464|0 |1 is obsolete| | Attachment #122465|0 |1 is obsolete| | Attachment #122466|0 |1 is obsolete| | Attachment #122487|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 123499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123499&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:20:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:20:48 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #32 from Marcel de Rooy --- Created attachment 123500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123500&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:20:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:20:52 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #33 from Marcel de Rooy --- Created attachment 123501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123501&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:20:56 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #34 from Marcel de Rooy --- Created attachment 123502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123502&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:23:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:23:32 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #35 from Marcel de Rooy --- .../en/xslt/MARC21slim2OPACResults.xsl | 383 +++++++----------- 1 file changed, 144 insertions(+), 239 deletions(-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:24:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:24:45 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #36 from Marcel de Rooy --- David, would you mind to test this change again? Hopefully, Nick could pick it up after that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:28:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:28:51 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #37 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #28) > (In reply to David Nind from comment #24) > > 1. Should the call number be repeated if it is the same? That is, should > > only distinct call numbers be displayed for items available by library > > branch or not available categories? > > This is far from trivially adding a distinct keyword. We are relying here on > the output of the xslt key function. Making this change would require a bit > more than we are doing here now to control the number displayed. Looking back, I must have misinterpreted this comment. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:39:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:39:49 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #38 from Jonathan Druart --- + return $expire_reserves_charge_rule ? $expire_reserves_charge_rule->rule_value : C4::Context->preference("ExpireReservesMaxPickUpDelayCharge"); Is this correct if the rule is "0"? Note that it won't pass QA because of missing tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:50:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:50:36 +0000 Subject: [Koha-bugs] [Bug 28814] New: Messaging preference for renewals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28814 Bug ID: 28814 Summary: Messaging preference for renewals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In bug 18532 we add a messaging preference for the auto_renew notice. It would be good to do the same for the regular renewal notice. Right now, patrons get a renewal notice if the RenewalSendNotice syspref is on and the patron is signed up for CHECKOUT notices, with RENEWAL just following the CHECKOUT preference. That assumption -- that if one wants a CHECKOUT notice one must also want a RENEWAL notice -- is both spurious and largely undocumented. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:55:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:55:15 +0000 Subject: [Koha-bugs] [Bug 28814] Messaging preference for renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28814 --- Comment #1 from Andrew Fuerste-Henry --- Sorry, I need to walk back a bit of my snark here -- I forgot that we have updated that messaging preference so that it says "Checkout and renewal" in the preference. So at least we're telling people there what it means. But I'd still prefer a separate preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 16:57:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 14:57:27 +0000 Subject: [Koha-bugs] [Bug 28815] New: Item Circulation Alert settings for checkouts also cover renewals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28815 Bug ID: 28815 Summary: Item Circulation Alert settings for checkouts also cover renewals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In item circulation alerts (cgi-bin/koha/admin/item_circulation_alerts.pl), disabling checkout alerts also disables renewal alerts. Best case scenario, we'd create a mechanism to differentiate the two notice types. At the least, we should add some text here making it clear that renewals are also covered by checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:08:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:08:33 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org --- Comment #11 from Chris Slone --- We've just run into some issues with the expiration date not reverting when an awaiting copy was checked out to a different patron... Definitely would be better if the expiration date was cleared/reset than for it to hang on to the expiration date set when the first item was confirmed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:29:45 +0000 Subject: [Koha-bugs] [Bug 28816] New: Improve the display of multiple holds during hold process Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Bug ID: 28816 Summary: Improve the display of multiple holds during hold process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I think the display of holds during the multi-hold process is confusing and hard to read. I'd like to suggest a revised version. Here's what it looks like now with HoldsSplitQueue set to "nothing": https://snipboard.io/eEXLaR.jpg Here is the what I'm working on: https://snipboard.io/YtbNMs.jpg Here's the current version with HoldsSplitQueue set to "pickup library and item type": https://snipboard.io/vpQjDF.jpg Here is the new version: https://snipboard.io/BvRCwJ.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:35:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:35:23 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:35:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:35:27 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122529|0 |1 is obsolete| | Attachment #122530|0 |1 is obsolete| | Attachment #122531|0 |1 is obsolete| | Attachment #122532|0 |1 is obsolete| | Attachment #122552|0 |1 is obsolete| | --- Comment #33 from Agustín Moyano --- Created attachment 123503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123503&action=edit Bug 27946: Add tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:35:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:35:32 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #34 from Agustín Moyano --- Created attachment 123504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123504&action=edit Bug 27946: Add article_request_fee to categories table and ARTICLE_REQUEST account debit type Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:35:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:35:37 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #35 from Agustín Moyano --- Created attachment 123505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123505&action=edit Bug 27946: Add article request fee feature This patch adds the ability to charge a fee for article scan requests. To test: 1. apply patches 2. updatedatabase 3. restart_all 4. enable ArticleRequest in preferences 5. grab a patron category and set a fee for article requests 6. grab a patron of that category (patron a) and another fron different category (patron b) 7. place an article request for both patrons SUCCESS => only for patron a, a warning is displayed saying a fee will be charged 8. check the account for both patrons SUCCESS => only for patron a there is a debit of type ARTICLE_REQUEST 9. cancel the article request for patron a SUCCESS => the debit for patron a gets canceled 10. repeat step 7 only for patron a 11. change article request fee for the patron a's category 12. repeat step 10 13. check account for patron a SUCCESS => there are 2 debits with different amount of typ ARTICLE_REQUEST 14. cancel only one article request SUCCESS => only the corresponding debit gets canceled 15. prove t/db_dependent/ArticleRequests.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:35:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:35:42 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #36 from Agustín Moyano --- Created attachment 123506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123506&action=edit Bug 27946: [DO NOT PUSH] Update DBIx schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:35:46 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #37 from Agustín Moyano --- Created attachment 123507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123507&action=edit Bug 27946: (follow-up) Use bug 28656 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:37:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:37:20 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:40:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:40:10 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:40:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:40:17 +0000 Subject: [Koha-bugs] [Bug 24500] Cancelling a hold at the same time produces internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24500 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 28779 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:40:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:40:17 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #12 from Owen Leonard --- *** Bug 24500 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 17:44:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 15:44:14 +0000 Subject: [Koha-bugs] [Bug 26532] Error when cancelling a hold from check-in page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26532 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This appears to have been either a temporary glitch or has been fixed. I can't reproduce the problem now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:01:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:01:43 +0000 Subject: [Koha-bugs] [Bug 23815] Cancel hold confirmation should display specific information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 23479 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:01:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:01:43 +0000 Subject: [Koha-bugs] [Bug 23479] Hold cancellation confirmation too generic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #1 from Owen Leonard --- *** Bug 23815 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:02:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:02:40 +0000 Subject: [Koha-bugs] [Bug 24557] Cancel Hold on check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24557 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 19685 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:02:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:02:40 +0000 Subject: [Koha-bugs] [Bug 19685] Canceling a hold from the Hold Found popup does not alert librarian about next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Owen Leonard --- *** Bug 24557 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:07:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:07:58 +0000 Subject: [Koha-bugs] [Bug 28817] New: It should be possible to configure the reply_address for various notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28817 Bug ID: 28817 Summary: It should be possible to configure the reply_address for various notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently except for messages originating from the patron we do not set a reply_address when enqueuing letters, git grep reply_address If no reply address is specified when we are sending the messages we use the patron's library's address: 1325 sub _send_message_by_email { ... 1363 if ($patron) { 1364 $library = $patron->library; 1365 $branch_email = $library->from_email_address; 1366 $branch_replyto = $library->branchreplyto; 1367 $branch_returnpath = $library->branchreturnpath; 1368 } ... 1393 reply_to => $message->{'reply_address'} || $branch_replyto, This means that when an overdue is sent by the issuing library, replies go to the patron's branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:10:33 +0000 Subject: [Koha-bugs] [Bug 25925] In the alert box for unfilled important field in cataloging, the cancel button is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25925 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Caroline Cyr La Rose --- I confirm this is a browser pop-up, since it looks different in Firefox and Chromium... Sorry about that! Caroline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:19:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:19:52 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123081|0 |1 is obsolete| | --- Comment #170 from Martin Renvoize --- Created attachment 123508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123508&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:19:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:19:57 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123082|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize --- Created attachment 123509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123509&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:03 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123083|0 |1 is obsolete| | --- Comment #172 from Martin Renvoize --- Created attachment 123510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123510&action=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:09 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123084|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize --- Created attachment 123511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123511&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:14 +0000 Subject: [Koha-bugs] [Bug 17335] waitingreserves.pl cancel button needs simplification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17335 --- Comment #1 from Owen Leonard --- The check-in page shows a dialog telling the user that a transfer is required when checking in an item from another library. I think adding the same thing to this page would eliminate the need for a "Cancel and return to..." button label. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:15 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123085|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize --- Created attachment 123512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123512&action=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:21 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123086|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize --- Created attachment 123513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123513&action=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:27 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123087|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize --- Created attachment 123514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123514&action=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:33 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123088|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize --- Created attachment 123515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123515&action=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:39 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123089|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize --- Created attachment 123516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123516&action=edit Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:44 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123090|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize --- Created attachment 123517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123517&action=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:50 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123091|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize --- Created attachment 123518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123518&action=edit Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:20:56 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123092|0 |1 is obsolete| | --- Comment #181 from Martin Renvoize --- Created attachment 123519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123519&action=edit Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:21:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:21:02 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123093|0 |1 is obsolete| | --- Comment #182 from Martin Renvoize --- Created attachment 123520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123520&action=edit Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:21:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:21:08 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123406|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize --- Created attachment 123521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123521&action=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:21:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:21:13 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123410|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize --- Created attachment 123522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123522&action=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:21:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:21:19 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #185 from Martin Renvoize --- Created attachment 123523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123523&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:24:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:24:43 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123523|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize --- Created attachment 123524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123524&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:25:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:25:07 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:25:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:25:41 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #187 from Martin Renvoize --- t/Koha/Util/Search.t needs updating for that final patch.. one to attack tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:56:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:56:15 +0000 Subject: [Koha-bugs] [Bug 19685] Canceling a hold from the Hold Found popup does not alert librarian about next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685 --- Comment #3 from Christopher Brannon --- Hmmm...I thought maybe this had been addressed, maybe in another bug somewhere. Currently, in 20.05.13, if I check in an item that is a waiting hold, I can cancel the hold, and then it immediately triggers the next hold (asks for confirmation). Is this not a new feature? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 18:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 16:59:55 +0000 Subject: [Koha-bugs] [Bug 17335] waitingreserves.pl cancel button needs simplification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17335 --- Comment #2 from Christopher Brannon --- (In reply to Owen Leonard from comment #1) > The check-in page shows a dialog telling the user that a transfer is > required when checking in an item from another library. I think adding the > same thing to this page would eliminate the need for a "Cancel and return > to..." button label. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 19:22:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 17:22:39 +0000 Subject: [Koha-bugs] [Bug 28818] New: Patron Messaging Preferences including ILL Messaging Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28818 Bug ID: 28818 Summary: Patron Messaging Preferences including ILL Messaging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com As this table (Patron Messaging Preferences) on the Patron Detail page, is getting long on the Patron's account, is there a way a library could not see the 3 ILL Messaging preferences if they are not using the ILL module (so the Sys Pref for ILL is set to disable)? This would be similar to not displaying the Phone Column in Messaging Settings if the library does not use a Phone Service to call patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 20:16:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 18:16:02 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 20:16:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 18:16:05 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 --- Comment #1 from Owen Leonard --- Created attachment 123525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123525&action=edit Bug 28816: Improve the display of multiple holds during hold process This patch updates the appearance of the "confirm holds" page, shown during the process of placing a hold for someone in the staff interface. Most of the changes affect the appearance of the page when placing multiple holds on titles which have one or more holds on them already. The changes are intended to make the page clearer and easier to scan, especially when placing multiple holds at once. Also changed: The page heading when placing multiple holds now changes based on whether you've selected a patron or not. It says "Search patrons or clubs" when it's waiting for a patron/club selection. It says "Place holds" after the patron/club has been selected. This is instead of "Confirm holds" on both pages. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and set HoldsSplitQueue to "nothing." - Perform a search in the staff client catalog and place multiple holds titles from that result set on hold for a patron. - Perform the same search and select one or more of the titles you selected before in addition to one or more titles with no holds. - After clicking the "Place hold" button you should see a page with the heading "Search patrons or clubs" showing information about existing holds. This section of the page should be clear and readable, with clear distinction between each section of information about each hold. - Test this page again under each different option for the "HoldsSplitQueue" system preference by changing the preference and reloading the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 20:51:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 18:51:56 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 20:51:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 18:51:59 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123499|0 |1 is obsolete| | Attachment #123500|0 |1 is obsolete| | Attachment #123501|0 |1 is obsolete| | Attachment #123502|0 |1 is obsolete| | --- Comment #38 from Owen Leonard --- Created attachment 123526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123526&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 20:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 18:52:03 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #39 from Owen Leonard --- Created attachment 123527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123527&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 20:52:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 18:52:08 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #40 from Owen Leonard --- Created attachment 123528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123528&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 20:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 18:52:12 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #41 from Owen Leonard --- Created attachment 123529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123529&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 21:41:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 19:41:57 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 21:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 19:42:01 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123480|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 123530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123530&action=edit Bug 28799: Log when item was lost and now found In the subroutine ModDateLastSeen we unset an item's lost status when checked in. This routine passes a noi log parameter to the store request, this is to avoid spamming the cataloguing log on every checkin. When marking an item unlost we should record this change. To test: 1 - Enable cataloguing log 2 - Mark an item lost 3 - View the log and confirm this chagne was recorded 4 - Check the item in 5 - The message indicates item is now found, but logs have no new entry 6 - Apply patch, restart all 7 - Mark the item lost and verify it is logged 8 - Check the item in, reported found and log entry recorded Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 21:47:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 19:47:42 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123526|0 |1 is obsolete| | --- Comment #42 from David Nind --- Created attachment 123531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123531&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 21:47:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 19:47:47 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123527|0 |1 is obsolete| | --- Comment #43 from David Nind --- Created attachment 123532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123532&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 21:47:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 19:47:52 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123528|0 |1 is obsolete| | --- Comment #44 from David Nind --- Created attachment 123533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123533&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 21:47:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 19:47:58 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123529|0 |1 is obsolete| | --- Comment #45 from David Nind --- Created attachment 123534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123534&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 22:15:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 20:15:06 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 22:15:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 20:15:12 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123525|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123535&action=edit Bug 28816: Improve the display of multiple holds during hold process This patch updates the appearance of the "confirm holds" page, shown during the process of placing a hold for someone in the staff interface. Most of the changes affect the appearance of the page when placing multiple holds on titles which have one or more holds on them already. The changes are intended to make the page clearer and easier to scan, especially when placing multiple holds at once. Also changed: The page heading when placing multiple holds now changes based on whether you've selected a patron or not. It says "Search patrons or clubs" when it's waiting for a patron/club selection. It says "Place holds" after the patron/club has been selected. This is instead of "Confirm holds" on both pages. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and set HoldsSplitQueue to "nothing." - Perform a search in the staff client catalog and place multiple holds titles from that result set on hold for a patron. - Perform the same search and select one or more of the titles you selected before in addition to one or more titles with no holds. - After clicking the "Place hold" button you should see a page with the heading "Search patrons or clubs" showing information about existing holds. This section of the page should be clear and readable, with clear distinction between each section of information about each hold. - Test this page again under each different option for the "HoldsSplitQueue" system preference by changing the preference and reloading the page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 22:31:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 20:31:40 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #7 from David Nind --- Hi Agustín. There are errors when running the database update: root at kohadevbox:koha(bz27945)$ updatedatabase DEV atomic update: bug_27945.perl Atomic update generated errors: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column 'article_request_fee' in 'categories' [for Statement " ALTER TABLE `categories` ADD COLUMN `article_request_limit` tinyint(4) DEFAULT NULL COMMENT 'Limit article scan requests per day' AFTER `article_request_fee` "] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118. DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x55c0aed443e8), "DBI Exception: DBD::mysql::db do failed: Unknown column 'arti"...) called at /usr/share/perl5/DBIx/Class/Storage.pm line 113 DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x55c0b29ba4b0), "DBI Exception: DBD::mysql::db do failed: Unknown column 'arti"...) called at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501 DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed: Unknown column 'article_request_fee"..., DBI::db=HASH(0x55c0b4469f90), undef) called at (eval 1487) line 7 eval '$DBversion = \'XXX\'; # will be replaced by the RM if( CheckVersion( $DBversion ) ) { # you can use $dbh here like: # $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" ); # or perform some test and warn if( !column_exists( \'categories\', \'article_request_limit\' ) ) { $dbh->do(q{ ALTER TABLE `categories` ADD COLUMN `article_request_limit` tinyint(4) DEFAULT NULL COMMENT \'Limit article scan requests per day\' AFTER `article_request_fee` }); } # Always end with this (adjust the bug info) NewVersion( $DBversion, 27945, "Add article_request_limit to categories table"); } ' called at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 24596 DEV atomic update: bug_27946.perl Upgrade to XXX done [20:29:34]: Bug 27946 - Add article_request_fee to categories table, add debit_line_id column to article_requests table and add ARTICLE_REQUEST as a debit type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 22:59:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 20:59:44 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 22:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 20:59:48 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123471|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 123536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123536&action=edit Bug 28813: Update database field name Update the database field name from 'delivery_note' to 'failure_code' to more accurately denote it's use. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 22:59:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 20:59:53 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123472|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 123537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123537&action=edit Bug 28813: DBIC Schema Update Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 22:59:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 20:59:58 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123473|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 123538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123538&action=edit Bug 28813: Update unit tests This patch updates the unit tests to check for failure_code instead of delivery_note and catches a missing case. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 23:00:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 21:00:03 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123474|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 123539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123539&action=edit Bug 28813: Rename delivery_note to failure_code We now use the codes from the half implimented error_code in place of the plain text that was being added to the delivery_note field. As part of that we rename the field to failure_code to clarify it's intended content. Test plan 1/ Confirm t/db_dependent/Letters.t passes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 5 23:02:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 21:02:23 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Testing notes (koha-testing-docker): - prove t/db_dependent/Letters.t (before apply patches) - apply patches - updatedatabase + dbic - flush_memcached - restart_all - prove t/db_dependent/Letters.t (tests should pass) Hope that is sufficient for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 01:11:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 23:11:57 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Summary|Delivery notes feature was |Delivery notes feature was |pushed prior to it's |pushed prior to its |completion |completion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 01:13:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 23:13:44 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 01:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 23:20:40 +0000 Subject: [Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 --- Comment #88 from Agnes Rivers-Moore --- Created attachment 123540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123540&action=edit Picture of log showing successful SIP logins incrementing 'attempts' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 01:23:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Aug 2021 23:23:11 +0000 Subject: [Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 --- Comment #89 from Agnes Rivers-Moore --- Ah - there might be a problem with Koha counting SIP logins as 'failed' attempts. I could not see it before, but thanks to this enhancement I do see that the total of login attempts goes up by one when I log in to Overdrive Libby, and it is not reset to zero again - even though the login is successful. We had found more patrons complained of being locked out of the OPAC when they had not had 8 failed login attempts. If SIP login adds one every time, and does not clear back to zero, people using SIP products can come back to the Koha OPAC and find themselves locked out. I am on Koha 20.11 It may be this needs to be a separate new bug - anyone interested to describe what's not working as expected with SIP logins? (and possibly other kinds of external login too...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 03:14:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 01:14:46 +0000 Subject: [Koha-bugs] [Bug 28819] New: Add link to Item Search from mainpage.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Bug ID: 28819 Summary: Add link to Item Search from mainpage.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The only way to access item search is through the drop down Search link in the top bar. It would be helpful to have a "button" to the item search on the main page, like there is for Advanced Search. The item search is heavily used, and having a more prominent way to access it would be helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 03:15:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 01:15:52 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |kelly at bywatersolutions.com, | |lucas at bywatersolutions.com, | |sbrown at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 07:48:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 05:48:30 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #46 from Marcel de Rooy --- > Signed-off-by: Owen Leonard > > Signed-off-by: David Nind Great. Thx Owen and David ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 07:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 05:51:04 +0000 Subject: [Koha-bugs] [Bug 28656] Cancellations should be allowed on paid/partially paid debts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 --- Comment #24 from Marcel de Rooy --- Ping Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 08:27:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 06:27:30 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 --- Comment #5 from Martin Renvoize --- I've been doing some more work on bug 11175 and I think there might be a DRY solution to this we could use.. rather than using functions in the XSLT Utils I think we could/should be using the constructed query string from Koha::Util::Search, passing it as a variable as 11175 does for the inline view expansion over 300 records. I'll submit that patch later today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 08:42:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 06:42:37 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Account for 'MarcOrgCode' |useControlNumberIdentifier |preference in 'Enhanced |preference to allow |Analytics Workflow' |(003)001 constructions in | |$w links. | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 08:44:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 06:44:27 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 --- Comment #1 from Martin Renvoize --- With the introduction of the ability to search using 003 as part of the query for analytics, we should account for this in the cataloguing workflow. We should check for the presence of 'MarcOrgCode' being defined (at library or system level) and if it is being used we should copy the value of the 003 of the parent record into the constructed 773. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 08:44:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 06:44:34 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 08:44:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 06:44:53 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21469 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 08:44:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 06:44:53 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27507 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:07:42 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123524|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize --- Created attachment 123541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123541&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:12:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:12:25 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123508|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize --- Created attachment 123542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123542&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:12:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:12:31 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123509|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize --- Created attachment 123543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123543&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:12:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:12:37 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123510|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize --- Created attachment 123544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123544&action=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:12:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:12:43 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123511|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize --- Created attachment 123545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123545&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:12:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:12:49 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123512|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize --- Created attachment 123546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123546&action=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:12:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:12:55 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123513|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize --- Created attachment 123547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123547&action=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:01 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123514|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize --- Created attachment 123548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123548&action=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:07 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123515|0 |1 is obsolete| | --- Comment #196 from Martin Renvoize --- Created attachment 123549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123549&action=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:13 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123516|0 |1 is obsolete| | --- Comment #197 from Martin Renvoize --- Created attachment 123550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123550&action=edit Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:19 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123517|0 |1 is obsolete| | --- Comment #198 from Martin Renvoize --- Created attachment 123551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123551&action=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:25 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123518|0 |1 is obsolete| | --- Comment #199 from Martin Renvoize --- Created attachment 123552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123552&action=edit Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:31 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123519|0 |1 is obsolete| | --- Comment #200 from Martin Renvoize --- Created attachment 123553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123553&action=edit Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:38 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123520|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize --- Created attachment 123554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123554&action=edit Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:43 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123521|0 |1 is obsolete| | --- Comment #202 from Martin Renvoize --- Created attachment 123555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123555&action=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:49 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123522|0 |1 is obsolete| | --- Comment #203 from Martin Renvoize --- Created attachment 123556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123556&action=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:13:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:13:55 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123541|0 |1 is obsolete| | --- Comment #204 from Martin Renvoize --- Created attachment 123557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123557&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:16:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:16:20 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 09:17:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 07:17:46 +0000 Subject: [Koha-bugs] [Bug 28820] New: Problem in Searching Books Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28820 Bug ID: 28820 Summary: Problem in Searching Books Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mukhila at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When I search the books, I faced the issue Software error: Can't call method "data" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 1709. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 10:27:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 08:27:30 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #205 from Martin Renvoize --- Created attachment 123562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123562&action=edit Bug 11175: (follow-up) Missed line in previous commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:04:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:04:22 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 --- Comment #6 from Jonathan Druart --- I think you should take leave_item_lost into account. Also we need tests to cover the changes. Additional question, do we really want a cataloguing log when an item is modified outside of the cataloguing module? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:24:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:24:03 +0000 Subject: [Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 --- Comment #90 from Marcel de Rooy --- (In reply to Agnes Rivers-Moore from comment #89) > Ah - there might be a problem with Koha counting SIP logins as 'failed' > attempts. I could not see it before, but thanks to this enhancement I do see > that the total of login attempts goes up by one when I log in to Overdrive > Libby, and it is not reset to zero again - even though the login is > successful. We had found more patrons complained of being locked out of the > OPAC when they had not had 8 failed login attempts. If SIP login adds one > every time, and does not clear back to zero, people using SIP products can > come back to the Koha OPAC and find themselves locked out. I am on Koha 20.11 > It may be this needs to be a separate new bug - anyone interested to > describe what's not working as expected with SIP logins? (and possibly other > kinds of external login too...) Thx for reporting. This problem should go on its own. Will open a new report now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:25:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:25:50 +0000 Subject: [Koha-bugs] [Bug 28822] New: SIP logins add to login attempts? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822 Bug ID: 28822 Summary: SIP logins add to login attempts? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org >From Agnes Rivers-Moore on bug 21190: Ah - there might be a problem with Koha counting SIP logins as 'failed' attempts. I could not see it before, but thanks to this enhancement I do see that the total of login attempts goes up by one when I log in to Overdrive Libby, and it is not reset to zero again - even though the login is successful. We had found more patrons complained of being locked out of the OPAC when they had not had 8 failed login attempts. If SIP login adds one every time, and does not clear back to zero, people using SIP products can come back to the Koha OPAC and find themselves locked out. I am on Koha 20.11 It may be this needs to be a separate new bug - anyone interested to describe what's not working as expected with SIP logins? (and possibly other kinds of external login too...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:26:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:26:17 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #206 from Jonathan Druart --- 1. It needs more work, there is something broken (search does not return anything) 2. The UI is not the same as what is advertised in the screenshot, the component part records are display at the top (not on the right) 3. I don't think we need the overhead we introduced with the "show all" link. We call get_component_part_query from C4::XSLT (for that link) and Koha::Biblio (for the list we display). I would suggest to retrieve them all and have a expand/collapse link if we have "too many" element to display. We could then move the get_component_part_query into Koha::Biblio->get_marc_components (Koha::Biblio->get_marc_host is doing that already). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:26:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:26:40 +0000 Subject: [Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 --- Comment #91 from Marcel de Rooy --- See bug 28822 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:26:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:26:56 +0000 Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:28:40 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #207 from Martin Renvoize --- Created attachment 123564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123564&action=edit Bug 11175: (follow-up) More Fixes * Default to an empty arrayref from get_marc_components * Standardise search syntax in Koha::Util::Search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:42:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:42:06 +0000 Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822 --- Comment #1 from Marcel de Rooy --- ILS/Patron.pm:sub check_password { ILS/Patron.pod: $str = $patron->check_password($password); ILS/Patron.pod:=head2 C<$bool = $patron-Echeck_password($password);> Sip/MsgType.pm: $password_rc = $patron->check_password($patron_pwd); Sip/MsgType.pm: $resp .= add_field( FID_VALID_PATRON_PWD, sipbool( $patron->check_password( $fields->{ (FID_PATRON_PWD) } ) ), $server ); Sip/MsgType.pm: $password_rc = $patron->check_password($patron_pwd); Sip/MsgType.pm: if ( !defined($patron_pwd) || $patron->check_password($patron_pwd) ) { Sip/MsgType.pm: $resp .= add_field( FID_VALID_PATRON_PWD, sipbool( $patron->check_password($patron_pwd) ), $server ); build patron status handle checkout handle_patron_info handle_patron_enable CALLED twice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:46:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:46:00 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Didier, are you going to submit a patch with your proposed changes? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:46:50 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #208 from Martin Renvoize --- (In reply to Jonathan Druart from comment #206) > 1. It needs more work, there is something broken (search does not return > anything) OK, I've done more digging here.. in short, I think we need to make a distinction between "Analytics" and "Volumes of sets and traced series" akin to the change bug 7609 made way back. At least for the UseControlNumber case.. that's what the search results end up empty as I moved the query without fully understanding it. > 2. The UI is not the same as what is advertised in the screenshot, the > component part records are display at the top (not on the right) This is just a missing CSS build.. I feel down that hole too ;) > 3. I don't think we need the overhead we introduced with the "show all" > link. We call get_component_part_query from C4::XSLT (for that link) and > Koha::Biblio (for the list we display). I would suggest retrieving them all > and have a expand/collapse link if we have "too many" element to display. > We could then move the get_component_part_query into > Koha::Biblio->get_marc_components (Koha::Biblio->get_marc_host is doing that > already). I think in theory the reason wasn't to reduce display size but to reduce search return scope for performance. In reality, I'm not sure this is a real issue.. need to read the rest of the comments that asked for the reduction to be introduced.. it all feels very artificial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:48:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:48:29 +0000 Subject: [Koha-bugs] [Bug 28817] It should be possible to configure the reply_address for various notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Do you mean when editing a notice template? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:49:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:49:09 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #39 from Andrew Nugged --- (In reply to Jonathan Druart from comment #38) > + return $expire_reserves_charge_rule ? > $expire_reserves_charge_rule->rule_value : > C4::Context->preference("ExpireReservesMaxPickUpDelayCharge"); > > Is this correct if the rule is "0"? if the rule has 0 as a stored value but is found, then $expire_reserves_charge_rule is the object, in case we saving an empty line to form for that rule item, it transfers undef to DBIC so even no record is created, then there's not an object and all, "not found". (same as I misled myself above, and figured out here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711#c34 ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:49:31 +0000 Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27600 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:49:31 +0000 Subject: [Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28822 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:53:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:53:26 +0000 Subject: [Koha-bugs] [Bug 28817] It should be possible to configure the reply_address for various notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28817 --- Comment #2 from Nick Clemens --- (In reply to Jonathan Druart from comment #1) > Do you mean when editing a notice template? That would be interesting, I was thinking a system preference for using the patron library, or the notice branch as the default. Or adding an option to scripts that generate notices, i.e.: perl misc/cronjobs/overdue_notices.pl --reply_to item-homebranch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:56:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:56:10 +0000 Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Marcel de Rooy --- Kyle or Nick, Does 27600 address this? That one refers to renewal. I have the idea that this one might be more? Does it depend on Overdrive ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:56:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:56:28 +0000 Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:59:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:59:19 +0000 Subject: [Koha-bugs] [Bug 28811] Cant receive orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Hello Mohamad, Your problem is coming from: IP - - [04/Aug/2021:09:26:51 +0300] "GET /api/v1/app.pl/api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&_match=contains&_order_by=%2Bbasket.name HTTP/1.1" 404 You are getting a 404, the correct path is /api/v1/acquisition[...] but you have an extra "/api/v1/app.pl" before How did you install Koha? Is it a fresh install or you upgraded from an older version? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 11:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 09:59:59 +0000 Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822 --- Comment #3 from Nick Clemens --- (In reply to Marcel de Rooy from comment #2) > Kyle or Nick, > Does 27600 address this? That one refers to renewal. > I have the idea that this one might be more? > Does it depend on Overdrive ? It does not address this, just a related issue with the call to check_password -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:04:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:04:57 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #137 from Jonathan Druart --- Created attachment 123565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123565&action=edit Bug 17600: Fix missing imports from mappings.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:06:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:06:36 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #138 from Jonathan Druart --- (In reply to Jonathan Druart from comment #137) > Created attachment 123565 [details] [review] > Bug 17600: Fix missing imports from mappings.pl > > Signed-off-by: Jonathan Druart Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:14:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:14:44 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:14:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:14:47 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:14:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:14:50 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:14:53 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:14:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:14:55 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:14:58 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:15:00 +0000 Subject: [Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:15:03 +0000 Subject: [Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:27:35 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #40 from Jonathan Druart --- (In reply to Andrew Nugged from comment #39) > (In reply to Jonathan Druart from comment #38) > > + return $expire_reserves_charge_rule ? > > $expire_reserves_charge_rule->rule_value : > > C4::Context->preference("ExpireReservesMaxPickUpDelayCharge"); > > > > Is this correct if the rule is "0"? > > if the rule has 0 as a stored value but is found, > then $expire_reserves_charge_rule is the object, > > in case we saving an empty line to form for that rule item, > it transfers undef to DBIC so even no record is created, > then there's not an object and all, "not found". > > (same as I misled myself above, and figured out here: > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711#c34 ) Right, I misread! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:33:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:33:13 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #2 from Didier Gautheron --- Yes but I have to double check first it doesn't break in authorities/authorities.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:47:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:47:34 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:48:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:48:43 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:48:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:48:47 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121125|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123566&action=edit Bug 28339: Elasticsearch - Add 8XX to default title-series index mappings (MARC21) https://bugs.koha-community.org/show_bug.cgi?id=23853 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:50:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:50:00 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 --- Comment #3 from David Nind --- Something has gone a bit weird with the patch bug text! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:55:08 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |8XX (800$t, 810$t, 811$t, | |and 830$a) subfields to the | |default title-series index | |mappings for Elasticsearch. | |Currently for MARC21 only | |440$a and 490$a are | |included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:58:45 +0000 Subject: [Koha-bugs] [Bug 28823] New: Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 Bug ID: 28823 Summary: Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All URL: https://wiki.koha-community.org/wiki/Multipart_Bibliog raphics OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl, testopia at bugs.koha-community.org Depends on: 21469 If 'UseControlNumber' is enabled we add a 'Add child record' option from the 'New' menu in bib records. When one clicks this button we are taken to a new bib entry with the 773 pre-populated and a default LDR position 7 of 'a' for 'Monographic component part'. We should not assume we are always adding Monographic analytics, for Serials we should set the indicator to 'b' for 'Serial component part' Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:58:45 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 [Bug 28823] Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:59:38 +0000 Subject: [Koha-bugs] [Bug 28823] Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21469 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:59:38 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28823 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 [Bug 28823] Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:59:38 +0000 Subject: [Koha-bugs] [Bug 15851] Only display "Analytics: Show analytics" when records have linked analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28823 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 12:59:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 10:59:50 +0000 Subject: [Koha-bugs] [Bug 28823] Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:00:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:00:04 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15851 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:00:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:00:04 +0000 Subject: [Koha-bugs] [Bug 15851] Only display "Analytics: Show analytics" when records have linked analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21469 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:00:30 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28823 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:00:30 +0000 Subject: [Koha-bugs] [Bug 28823] Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21469 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:12:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:12:26 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #209 from Martin Renvoize --- (In reply to Martin Renvoize from comment #208) > (In reply to Jonathan Druart from comment #206) > > 1. It needs more work, there is something broken (search does not return > > anything) > > OK, I've done more digging here.. in short, I think we need to make a > distinction between "Analytics" and "Volumes of sets and traced series" akin > to the change bug 7609 made way back. At least for the UseControlNumber > case.. that's what the search results end up empty as I moved the query > without fully understanding it. Actually.. I think this is working as expected.. I just had other issues to resolve. > > 3. I don't think we need the overhead we introduced with the "show all" > > link. We call get_component_part_query from C4::XSLT (for that link) and > > Koha::Biblio (for the list we display). I would suggest retrieving them all > > and have a expand/collapse link if we have "too many" element to display. > > We could then move the get_component_part_query into > > Koha::Biblio->get_marc_components (Koha::Biblio->get_marc_host is doing that > > already). > > I think in theory the reason wasn't to reduce display size but to reduce > search return scope for performance. In reality, I'm not sure this is a real > issue.. need to read the rest of the comments that asked for the reduction > to be introduced.. it all feels very artificial. See comment 90. ES is hard coded to return 100 max unless passed a new max.. there's not option to pass 'all'.. Hense where we're all with passing a search string to get all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:14:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:14:24 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121126|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123567&action=edit Bug 28378: Elasticsearch - Add 264c to default copydate mappings (MARC21) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:15:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:15:38 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Signed Off --- Comment #3 from David Nind --- Not sure what I did again when signing off...patch description is not the same as in Bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:31:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:31:06 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Nick Clemens --- Overall this looks good, a few things: 1 - We should default the prefs to 1,0 to more closely mimic the behavior before 2 - Items with blank callnumbers now show: [Call number: ], before they only showed the count 3 - Not blocker: it would be nice to have a '-1' option for resultsMaxItemsUnavailable to preserve previous grouping - in large consortia I know they have not wanted to display individual NFL items Before: Availability: Items available for loan: Fairview (2) , Midway (1) , Union (1) Call number: J Qam. Items available for reference: Riverside Not For Loan (2) Call number: J Qam, .., Pleasant Valley Staff Collection (1) Call number: YA 615 Qam, Fairfield Not For Loan (1) Call number: FIC Qam. Not available: Ordered (3). Checked out (1). After: Availability: Items available for loan: Fairview (2)Call number: , . Midway (1)Call number: . Union (1)Call number: J Qam. Items available for reference: Fairfield: Not For Loan (1)Call number: FIC Qam. Pleasant Valley: Staff Collection (1)Call number: YA 615 Qam. Riverside: Not For Loan (2)Call number: J Qam, YA 667 Qam. Not available: Fairview: Checked out (1)Call number: . Franklin: Ordered (1)Call number: YA Qam. Midway: Ordered (1)Call number: J 301 Qam. Springfield: Ordered (1)Call number: FIC 354 Qam. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:37:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:37:32 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #41 from Peter Vashchuk --- Created attachment 123568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123568&action=edit Bug 25711: add comment to clarify how the method works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:45:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:45:58 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123557|0 |1 is obsolete| | --- Comment #210 from Martin Renvoize --- Created attachment 123569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123569&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:46:06 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #211 from Martin Renvoize --- Created attachment 123570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123570&action=edit Bug 11175: (QA follow-up) Move get_component_part_query This patch removes Koha::Util::Search in preference to embedding the search query builder in Koha::Biblio as get_analytics_query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:47:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:47:01 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:48:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:48:17 +0000 Subject: [Koha-bugs] [Bug 28749] All backups behave as if --without-db-name is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 13:59:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 11:59:05 +0000 Subject: [Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:10:43 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123556|0 |1 is obsolete| | --- Comment #212 from Martin Renvoize --- Created attachment 123571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123571&action=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:10:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:10:49 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123569|0 |1 is obsolete| | --- Comment #213 from Martin Renvoize --- Created attachment 123572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123572&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:10:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:10:57 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123570|0 |1 is obsolete| | --- Comment #214 from Martin Renvoize --- Created attachment 123573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123573&action=edit Bug 11175: (QA follow-up) Move get_component_part_query This patch removes Koha::Util::Search in preference to embedding the search query builder in Koha::Biblio as get_analytics_query. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:11:05 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #215 from Martin Renvoize --- Created attachment 123574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123574&action=edit Bug 11175: (QA follow-up) Only get biblio once Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:11:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:11:06 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123562|0 |1 is obsolete| | --- Comment #215 from Martin Renvoize --- Created attachment 123574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123574&action=edit Bug 11175: (QA follow-up) Only get biblio once Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:17:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:17:52 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #27 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:20:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:20:27 +0000 Subject: [Koha-bugs] [Bug 28689] Extra %s in alert message when saving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:35:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:35:10 +0000 Subject: [Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic parameters" on the sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:36:28 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |'ShowComponentParts' system | |preference. | | | |Upon enabling | |this preference, where a | |record has analytic records | |attached we will replace | |the 'Show analytics' link | |with a new box on the right | |of the display containing | |links to all the analytic | |records. | | | |The feature is | |set to display a maximum of | |300 attached records; if | |more records are found then | |a link to the 'Show | |analytics' search will | |appear at the bottom of the | |listed analytics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:36:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:36:45 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:36:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:36:54 +0000 Subject: [Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic parameters" on the sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:51:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:51:56 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #216 from Jonathan Druart --- -sub get_marc_components { +sub get_marc_analytics { Do we really want to use "analytics" here? It's not related to the EasyAnalytics feature, and "components" is used all over the place (perl and xslt variables, css classes, syspref, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 14:54:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 12:54:29 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #217 from Jonathan Druart --- On the other hand, "component" is confusing as well (at least for me). Doesn't an official wording (in the MARC world) exist? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:05:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:05:46 +0000 Subject: [Koha-bugs] [Bug 28800] Libabry list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- You are getting a 404 for /api/v1/libraries, that's not normal. How did you install Koha? Did you proceed to an upgrade recently? If so, from which version? Try restarting memcached, apache2 then koha-common. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:07:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:07:57 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:08:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:08:00 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52166|0 |1 is obsolete| | Attachment #52295|0 |1 is obsolete| | Attachment #52296|0 |1 is obsolete| | --- Comment #35 from Owen Leonard --- Created attachment 123575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123575&action=edit Bug 7703: Don't block bulk hold action on search results if some items can't be placed on hold If you select multiple titles on the search results page in order to place a bulk hold and some of those titles have no items you get a JavaScript alert warning you can some cannot be placed on hold. You are blocked from completing the action until you deselect the invalid hold. This is unnecessary because the bulk hold process will safely refuse to place a hold on these titles later in the process. This patch removes the check that prevents submitting a multi-hold if one or more records in the multi-hold have no items. Test plan: 1) Apply patch 2) On the staff interface, do a search 3) On the search results, select at least one record with items and one record with no items. 4) Click the 'Place hold' button. 5) You should be redirected to reserve/request.pl with the message "Cannot place hold: this record has no items attached." Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:08:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:08:04 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #36 from Owen Leonard --- Created attachment 123576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123576&action=edit Bug 7703: (QA follow-up) Revised test plan from Owen: This patch modifies the hold process so that if one of the titles in a multi-hold process has no items the process doesn't abort completely. To test, apply the patch and perform a search in the catalog which will return one or more records with no items attached. - Check checkboxes for multiple results, some of which have items and at least one of which has no items. - Click "Place hold." - You should be taken to the page for placing multiple holds, with a heading, "Cannot place hold on some items." - Note: You will not be able to complete the holds process without the next patch. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:08:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:08:08 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #37 from Owen Leonard --- Created attachment 123577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123577&action=edit Bug 7703: (follow-up) Treat no items like none available This patch modifies the holds template so that during the multi-hold process, titles with no items attached are treated the same way as titles with no items available (items exist but cannot be place don hold): - The row showing such a record will say "No items are available to be placed on hold." - The pickup location dropdown will be hidden. To test, follow the previous test plan and confirm that these change are reflected. Now that the pickup location field isn't present for titles without items you should be able to complete the holds process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:40:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:40:33 +0000 Subject: [Koha-bugs] [Bug 28704] Library MARCOrgCode field needs maxlength attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:42:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:42:46 +0000 Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced Cataloguing Editor |Use Advanced cataloguing |(Rancor) to edit authority |editor (Rancor) for |records? |authority records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:47:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:47:46 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 [Bug 21898] Add basket info available for ACQORDER -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:47:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:47:46 +0000 Subject: [Koha-bugs] [Bug 21898] Add basket info available for ACQORDER In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:49:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:49:22 +0000 Subject: [Koha-bugs] [Bug 28824] New: Errant variable declaration in C4::Letters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Bug ID: 28824 Summary: Errant variable declaration in C4::Letters Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The fix for bug 26935 actually broke the feature introduced with bug 21898... The fix is simple, drop the 'my'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:49:56 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:49:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:49:59 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:50:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:50:03 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #7 from Owen Leonard --- Created attachment 123578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123578&action=edit Bug 10902: (QA follow-up) Show library name instead of code This patch modifies the patron search autocomplete so that library name is shown instead of library code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:50:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:50:04 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 15:50:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 13:50:04 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 [Bug 28824] Errant variable declaration in C4::Letters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:08:48 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #1 from Martin Renvoize --- Created attachment 123579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123579&action=edit Bug 28824: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:08:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:08:51 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #2 from Martin Renvoize --- Created attachment 123580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123580&action=edit Bug 28824: Fix for variable declaration scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:09:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:09:31 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:09:39 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:10:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:10:17 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #3 from Martin Renvoize --- I'm confused.. I can't seem to get the unit test to fail.. but in real life testing it does fail without the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:10:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:10:29 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:27:54 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #218 from Katrin Fischer --- (In reply to Jonathan Druart from comment #217) > On the other hand, "component" is confusing as well (at least for me). > Doesn't an official wording (in the MARC world) exist? Component/component part appears in the LOC documentation, while analytics doesn't: LDR, pos. 7 https://www.loc.gov/marc/bibliographic/bdleader.html 773 https://www.loc.gov/marc/bibliographic/bd773.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:39:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:39:07 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 --- Comment #7 from Katrin Fischer --- Not a final solution, but there is now logging of closing the basket that would probably allow for a workaround in reports (AcquisitionLog). Maura, would you agree with the behavior Daphne suggested or did you have something else in mind? But please keep in mind that we can discuss a good solution and make that public, which will certainly help, but the development will probably still need funding to actually happen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:39:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:39:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #219 from Martin Renvoize --- Fair enough.. I renamed it to analytics as the query limits to bib-level:a + bib-level:b now which corresponds to analytics in my understanding.. if we want all components then we should probably drop that filtering. Katrin, I'd love your thoughts on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:57:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:57:50 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #21 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 16:58:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 14:58:05 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 --- Comment #8 from Maura Stephens --- Hi Katrin, What is needed is a reportable 'order date' and this needs to be the date the order is sent to the vendor. This cannot change. I need to be able to make adjustments to funds, and pricing subsequent to this, if updates come from the vendor, without it changing the initial 'order date'. I can't see why Koha developers do not prioritise financial functions in Acquisitions. Most libraries (both public and academic) use framework agreements which our purchasing must adhere to. The vendors have a set number of weeks to respond to our orders and this is a legal requirement. We have reports set up in Koha to compile all our transactions and 'order date' is key to many, if not all of these. We use EDIFACT ordering for all our orders. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 17:12:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 15:12:12 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 17:36:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 15:36:29 +0000 Subject: [Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 17:36:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 15:36:33 +0000 Subject: [Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116911|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 123581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123581&action=edit Bug 21225: Add Syndetics cover images to staff client. This patch adds support for Syndetics Cover Images to the staff client To test: 1 - Enable system preferences: SyndeticsEnabled SyndeticsCoverImages SyndeticsClientCode (you will need a valid code for testing) 2 - Perform a search on the staff client 3 - Check that results have images if upc,oclc number, or isbn existin record 4 - Confirm that dtails paeg displays same image 5 - Confirm size on details page follows syspref SyndeticsCoverImageSize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 17:36:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 15:36:54 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 17:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 15:39:04 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #220 from Martin Renvoize --- right.. back to FQA.. been testing with Katrin. We found the searches don't work fully yet. * rcn:003 001 - Works as expected * rcn:(003)001 - Is needed in addition to above * (rcn:001 AND cni:003) - Doesn't appear to be working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:02:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:02:10 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #221 from Martin Renvoize --- Created attachment 123582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123582&action=edit Bug 11175: (QA follow-up) Fix queries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:03:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:03:53 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #222 from Martin Renvoize --- OK, that fixes the query issue.. for Zebra at least.. we'll test Elastic next. However.. another issue we've spotted. This does not work well with RLT languages.. If you have a record with both LTR and RTL in then the component parts box will stick itself between the two. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:08:48 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Aha.. I think you might want Bug 28640 - Add EDI order status to basket details display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:09:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:09:12 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28640 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:09:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:09:12 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14083 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:10:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:10:42 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 --- Comment #10 from Katrin Fischer --- > What is needed is a reportable 'order date' and this needs to be the date > the order is sent to the vendor. This cannot change. I need to be able to > make adjustments to funds, and pricing subsequent to this, if updates come > from the vendor, without it changing the initial 'order date'. Yes, I understand. Daphne described a solution in comment#6 that would have us have an additional database field recording the first time the order was closed. And use this for the purpose you describe. > I can't see why Koha developers do not prioritise financial functions in > Acquisitions. Most libraries (both public and academic) use framework > agreements which our purchasing must adhere to. The vendors have a set > number of weeks to respond to our orders and this is a legal requirement. We > have reports set up in Koha to compile all our transactions and 'order date' > is key to many, if not all of these. > We use EDIFACT ordering for all our orders. I am not saying that your bug is not valid. I was only pointing out that most changes in Koha happen as funded developments. Some support companies might prioritize developments like this on demand of their customers or have hours for it included in support contracts, but I cannot tell about that. So far this bug is not assigned to anyone for development, so at the moment I don't see a fix coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:27:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:27:37 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #223 from Katrin Fischer --- Created attachment 123583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123583&action=edit Detail view of record with RTL and LTR script Adding a screenshot to explain the issue a little better. I believe usability of the scroll box might not be too well if you have really a lot of records, because it limits you to a relatively small "view". Also slightly worried about handling on mobile interfaces as it sticks to the 2 column layout and won't stack as other elements on smaller sizes. I haven't checked all the comments yet, but could we imagine a different placing? Maybe below or above the items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:47:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:47:55 +0000 Subject: [Koha-bugs] [Bug 28825] New: Can't edit local cover image for item from details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Bug ID: 28825 Summary: Can't edit local cover image for item from details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 28179 When viewing the details of a bibliographic record which has an item with a local cover image, clicking the image in the holdings table triggers a lightbox view of the cover. The footer of the lightbox modal contains a link: "Local cover image (edit)" This edit link does not work. It works correctly if you're viewing a local cover image attached at the bibliographic level. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 18:47:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 16:47:55 +0000 Subject: [Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 [Bug 28825] Can't edit local cover image for item from details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 19:18:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 17:18:29 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 19:18:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 17:18:32 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 --- Comment #1 from Owen Leonard --- Created attachment 123584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123584&action=edit Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 19:49:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 17:49:54 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 19:49:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 17:49:57 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123478|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 123585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123585&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:07:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:07:10 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:09:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:09:55 +0000 Subject: [Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:15:00 +0000 Subject: [Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #15 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:15:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:15:06 +0000 Subject: [Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:16:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:16:17 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:16:34 +0000 Subject: [Koha-bugs] [Bug 28391] Elasticsearch - Add 264b to publisher index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28391 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:16:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:16:51 +0000 Subject: [Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle and 245p part subfields in the default title index mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:19:44 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:20:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:20:04 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:20:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:20:05 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Bug 17735 depends on bug 22435, which changed state. Bug 22435 Summary: Clarify account_offset types by converting them to clear codes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:20:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:20:05 +0000 Subject: [Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Bug 28421 depends on bug 22435, which changed state. Bug 22435 Summary: Clarify account_offset types by converting them to clear codes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:20:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:20:06 +0000 Subject: [Koha-bugs] [Bug 28656] Cancellations should be allowed on paid/partially paid debts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 Bug 28656 depends on bug 22435, which changed state. Bug 22435 Summary: Clarify account_offset types by converting them to clear codes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:22:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:22:16 +0000 Subject: [Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:22:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:22:33 +0000 Subject: [Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:23:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:23:11 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:23:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:23:12 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Bug 15504 depends on bug 28630, which changed state. Bug 28630 Summary: ILSDI::AuthenticatePatron should set borrowers.lastseen https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:30:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:30:07 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:30:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:30:07 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Bug 15504 depends on bug 28630, which changed state. Bug 28630 Summary: ILSDI::AuthenticatePatron should set borrowers.lastseen https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:32:28 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:32:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:32:36 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:32:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:32:42 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:33:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:33:11 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable --- Comment #22 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 by request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:33:28 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:39:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:39:18 +0000 Subject: [Koha-bugs] [Bug 28826] New: Facet sort order differs between search engines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 Bug ID: 28826 Summary: Facet sort order differs between search engines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In Zebra we sort the facets alphabetically by default - they are built in count order In Elasticsearch we display them as built, in count order There should be a configuration and we should sort them according to that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:55:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:55:59 +0000 Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search engines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:56:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:56:02 +0000 Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search engines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 --- Comment #1 from Nick Clemens --- Created attachment 123586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123586&action=edit Bug 28826: Add FacetOrder system preference This bug adds a system preference to control ordering of facets and adds the control to both Zebra and Elasticsearch To test: 1 - Have a koha that can use both Zebra and ES 2 - Set 'displayFacetCount' to true 3 - Search in ES and Zebra 4 - Note facets in Zebra sorted alphabetically, ES by usage 5 - Apply patch, updatedatabase 6 - Search in ES and Zebra, facets are alphabetically sorted in both 7 - Find new syspref FacetOrder and set to 'by usage' 8 - Search in both engines, facets sorted by usage -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 20:56:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 18:56:31 +0000 Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search engines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 21:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 19:13:37 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #33 from Christopher Brannon --- (In reply to Andrew Fuerste-Henry from comment #32) > Bug 28455, signed off, adds checkouts to lastseen. So we're kinda working in > two different directions here. > > I'm in favor of a simple approach here: a single field with a datetime that > updates each time a patron does any of the listed actions (log in to OPAC, > SIP, ILSDI, API, checkout, checkin). > > The batch patron deletion tool already knows how to filter by both lastseen > and circ activity. The need I run into here relates to reports rather than > the deletion tool itself. We get regular requests for a report that will > give a column of the last date on which a patron either logged in to > something or checked something in or out. That's much messier SQL than it > needs to be with the current data structure. +1. I would add, if it is a need for anyone to define what triggers this field, a permission with checkboxes of actions that would trigger it would finish this off nicely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 21:19:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 19:19:31 +0000 Subject: [Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #6 from Barbara Johnson --- Cover images display fine in the results pages. However, sometimes they display on the detail pages and sometimes they don’t. It appears that even though the ISBN is present in the 020 tag, the images won’t display on detail pages unless they also have an OCLC # in the O35 tag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 22:03:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 20:03:25 +0000 Subject: [Koha-bugs] [Bug 28827] New: OpacHiddenItems should be marked in staff catalog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28827 Bug ID: 28827 Summary: OpacHiddenItems should be marked in staff catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org While I understand why the staff can see these hidden items, it is not always evident that these items are suppressed from the opac when viewed from the staff side. It would be great if the bib record indicated if a record was suppressed (hidden) on the opac on a particular holding. Maybe a red label in the status that says "Hidden in OPAC" or "Suppressed". Or maybe "Suppressed: [reason]" where reason is the particular thing that is causing it to be suppressed, whether it is a value in OpacHiddenItems, or 942n. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 22:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 20:30:17 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com --- Comment #1 from Esther Melander --- This bug popped up recently in 20.05.13. Our consortium wanted to block renewals for Long Overdue Lost items in the OPAC. We changed the ItemsDeniedRenewal setting so there are no custom rules, which somehow prevents Long Overdue Lost items from being renewed in the OPAC. However, this also blocked renewal in the staff client. All other combinations of patron and item categories appear to be able to renew. Only items with the item status of Long Overdue Lost is blocked - at least as far we can determine. For a staff account with superlibrarian permissions, or specifically the override blocked renewals permission the override returns an error. To test: - Use a staff account with permission to override blocked renewals - Remove custom rules for ItemsDeniedRenewal - Locate a patron with Long Overdue Lost items. - Check the box to override renewal restrictions - Select items that are Long Overdue Lost and click renew items. System will return : Renew failed: item_denied_renewal Koha should allow the renewal of items with the status of Long Overdue Lost with the override renewal function. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 22:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 20:41:15 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #2 from Esther Melander --- Our Consortium has two version of Lost - Lost and Long Overdue Lost. Both status's are not able to be overridden. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 23:40:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 21:40:27 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119057|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 123587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123587&action=edit Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Signed-off-by: David Nind Signed-off-by: Sally Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 23:41:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 21:41:21 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123578|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 123588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123588&action=edit Bug 10902: (QA follow-up) Show library name instead of code This patch modifies the patron search autocomplete so that library name is shown instead of library code. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 23:45:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 21:45:26 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #10 from David Nind --- Would it be asking too much for the follow up (using the full library name rather than the library code) to work on the "Search patrons" tab in the header when in the patrons module? I can create a separate bug if that would be preferable. It is such a nice enhancement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 23:48:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 21:48:12 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #3 from Esther Melander --- I need to revise the above steps. To test: - Use a staff account with permission to override blocked renewals - Add custom rule for ItemsDeniedRenewal, itemlost: [1,2] - Locate a patron with Long Overdue Lost items. - Check the box to override renewal restrictions - Select items that are Long Overdue Lost and click renew items. System will return : Renew failed: item_denied_renewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 23:57:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 21:57:41 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 6 23:57:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 21:57:48 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121127|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123589&action=edit Bug 28379: Elasticsearch - Add 710 to author-name-corporate index (MARC21) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 00:02:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 22:02:50 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement adds the release notes| |710 to the | |author-name-corporate index | |mappings for MARC21 in | |Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 00:03:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 22:03:00 +0000 Subject: [Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer --- Setting to Failed QA because of comment#6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 00:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 22:06:25 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 [Bug 15494] Block renewals by arbitrary item values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 00:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 22:06:25 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 [Bug 22866] ItemsDeniedRenewal cannot be overriden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 01:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 23:33:28 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #10 from Katrin Fischer --- The initial issue was with search here. If you have A-B and A as branch codes, limiting to A will also bring up A-B. Could be adding a hint that using _ space and - might lead to unexpected search results an alternative? That said, there _IS_ validation on the branchcode in the onboarding tool that is not reflected in the normal GUI - so instead of adding validation here, we could remove it there and add hints in both spots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 01:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 23:46:43 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #10 from Katrin Fischer --- I understand the argument, but the visual was already changed by the newer version of select2 that made the input fields too short in many cases. I have seen library pull downs only showing like 3 letters of the branch names :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 01:53:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Aug 2021 23:53:48 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #11 from Katrin Fischer --- Created attachment 123590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123590&action=edit Screenshot of item form pull downs in 20.11 (In reply to Katrin Fischer from comment #10) > I understand the argument, but the visual was already changed by the newer > version of select2 that made the input fields too short in many cases. I > have seen library pull downs only showing like 3 letters of the branch names > :( To explain a bit more, it means that currently you can't figure out the library actually selected, if you have some starting with the same letters. Also the X is too close to text, so I often have it happen that when I want to open the pull down, I actually empty the field. The screenshot shows the problematic classification source, home branch and holding branch selects on current 20.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 02:15:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 00:15:06 +0000 Subject: [Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer --- Hi Michael, as David pointed out, currently with IndependentBranches the records are shared and there are no limitations to editing them. A record doesn't belong to any library, everyone can edit. I think this is a too big change to existing behavior that will be unwanted by many, so it should be made strictly optional. I also believe we might not want to add a new concept like this on top of IndependentBranches. In my opinion it needs more hashing out and it would look better in the new library group settings that I hope will replace IndependentBranches at some point in the not too soon future. Also there are a lot of edge cases here I am not sure about: * If shared records cannot be edited by libraries using it, who can edit it to fix issues? * What about records for electronics, serials etc. that don't need to necessarily have items? * What about the Advanced cataloguing editor? There is also no test plan here, please add one to your commit message. Also take a look at how the subject etc. should look like: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 02:21:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 00:21:55 +0000 Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 --- Comment #7 from Katrin Fischer --- (In reply to Jonathan Druart from comment #6) > I think you should take leave_item_lost into account. > > Also we need tests to cover the changes. > > Additional question, do we really want a cataloguing log when an item is > modified outside of the cataloguing module? I think yes, if you decide to log changes to something, it should not matter where it is changed, you want to know when it changed and who did it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 02:27:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 00:27:46 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Libabry list at |Library list at |/cgi-bin/koha/admin/branche |/cgi-bin/koha/admin/branche |s.pl appears empty |s.pl appears empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:35:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:35:04 +0000 Subject: [Koha-bugs] [Bug 28828] New: (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Bug ID: 28828 Summary: (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:35:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:35:20 +0000 Subject: [Koha-bugs] [Bug 28828] (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22399 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:35:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:35:20 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 [Bug 28828] (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:43:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:43:34 +0000 Subject: [Koha-bugs] [Bug 28828] (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:43:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:43:38 +0000 Subject: [Koha-bugs] [Bug 28828] (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #1 from Fridolin Somers --- Created attachment 123591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123591&action=edit Bug 28828: (Bug 22399 follow-up) impact on value_builder/unimarc_field_4XX.tt Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan : 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:52:33 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(Bug 22399 follow-up) |Bug 22399 breaks |breaks |value_builder/unimarc_field |value_builder/unimarc_field |_4XX.tt |_4XX.tt | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:53:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:53:32 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123591|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 123592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123592&action=edit Bug 28828: Bug 22399 impact on value_builder/unimarc_field_4XX.tt Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan : 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:57:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:57:28 +0000 Subject: [Koha-bugs] [Bug 28829] New: Useless single quote escaping in value_builder/unimarc_field_4XX.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Bug ID: 28829 Summary: Useless single quote escaping in value_builder/unimarc_field_4XX.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:57:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:57:43 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:57:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:57:57 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 [Bug 23777] Text converted to html entity codes in cataloguing edit form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:57:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:57:57 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:58:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:58:18 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28828 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 03:58:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 01:58:18 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28829 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 04:05:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 02:05:54 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 04:05:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 02:05:57 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 --- Comment #1 from Fridolin Somers --- Created attachment 123593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123593&action=edit Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless. Test plan: 1) Use UNIMARC database 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a : L'avion 4) Create a record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch 463$t contains : L\'avion => With patch 463$t contains : L'avion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 09:22:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 07:22:14 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #12 from Fridolin Somers --- Oh crap, a real ergonomic bug then. I backport. The backport on 20.11 actually fails because there is on select tag the attribute size="1". This has been removed in 21.05.x by Bug 28066. Should we keep it or remove it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 13:47:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 11:47:44 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 13:47:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 11:47:51 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123592|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 123594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123594&action=edit Bug 28828: Bug 22399 impact on value_builder/unimarc_field_4XX.tt Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan : 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 14:28:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 12:28:08 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #45 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #18) > Last question before I really let this go: Should we actually allow includes > to do [% USE Biblio %] etc. or should we 'use' them already earlier in the > process, in other words at the top of the template files that call them? I tried removing the USE-es in biblio-view-menu.inc and this 'random' failure showed on all files that used it (which I changed by adding the USE). I noticed that the qa tools just try to load the template and I added a warn on /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm (which takes care of loading those USE): 206 $ok = eval { require "$file.pm" }; 207 use Data::Printer colored => 1; 208 p($@); The errors show up randomly (it was all green the first run :-/) but this is what $@ says: Can't locate Koha/Template/Plugin/String.pm in @INC (you may need to install the Koha::Template::Plugin::String module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1 /usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /kohadevbox/koha_plugin) at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. Can't locate Koha/Template/Plugin/JSON/Escape.pm in @INC (you may need to install the Koha::Template::Plugin::JSON::Escape module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1 /usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /kohadevbox/koha_plugin) at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. => This are upstream TT plugins that are looked up in the wrong place Can't locate Template/Plugin/Biblio.pm in @INC (you may need to install the Template::Plugin::Biblio module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1 /usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /kohadevbox/koha_plugin) at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. => This is a Koha plugin that is looked up in the wrong place Maybe a path problem baked into the QA tools? I don't think it is fair that this issue blocks this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 14:49:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 12:49:33 +0000 Subject: [Koha-bugs] [Bug 28814] Messaging preference for renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28814 --- Comment #2 from Katrin Fischer --- I agree it would be nicer to have them as separate options - changing the descriptions was just in shorter reach for the time being. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:18:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:18:23 +0000 Subject: [Koha-bugs] [Bug 28817] It should be possible to configure the reply_address for various notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28817 --- Comment #3 from Katrin Fischer --- Maybe we should consider the overdues one as a bug first? I think we should match the reply to to the address we are sending the notice from in this case and possible others as a default. I believe using a pref would not work for all notices. For example DUEDGST are always sent from the patron's library and can contain information about issues from multiple libraries, so any other setting makes no sense. I am also not sure we can fit a general solution in the notices tool well - maybe we should look at some more use cases first to see where we are going there. But I think fixing the overdues bug first would be most important. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:22:38 +0000 Subject: [Koha-bugs] [Bug 28818] Patron Messaging Preferences including ILL Messaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #1 from Katrin Fischer --- Hi Kelly, if you turn off the ILLModule system preference, the messaging preferences for ILL should vanish. They do in my 20.11 test installation on the patron account. Can you detail where you are testing and still seeing them with the ILL module off? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:24:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:24:38 +0000 Subject: [Koha-bugs] [Bug 28818] Patron Messaging Preferences including ILL Messaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Checked OPAC, patron categories in administration and patron account in staff and they all don't show the ILL preferences when the ILLModule is disabled. Closing WORKSFORME - please reopen if you still see the issue! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:24:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:24:56 +0000 Subject: [Koha-bugs] [Bug 28818] Patron Messaging Preferences including ILL Messaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28818 --- Comment #3 from Katrin Fischer --- Latest test done on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:35:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:35:59 +0000 Subject: [Koha-bugs] [Bug 28820] Problem in Searching Books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28820 --- Comment #1 from Katrin Fischer --- Hi, this is usually a problem related to data or setup. Without more information on your exact version, the way you installed and how you set things up, we won't be able to help fix the issue. I recommend asking on the mailing list with the information listed above: https://koha-community.org/support/koha-mailing-lists/ Or joining the Koha IRC chat: https://koha-community.org/get-involved/irc/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:51:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:51:41 +0000 Subject: [Koha-bugs] [Bug 28823] Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 --- Comment #1 from Katrin Fischer --- Actually I recently learned through a change in our union catalog export, that this doesn't work quite as I had assumed in the past and not like you would think from the subfield descriptions: https://www.loc.gov/marc/bibliographic/bdleader.html a - Monographic component part Monographic bibliographic unit that is physically attached to or contained in another unit such that the retrieval of the component part is dependent on the identification and location of the host item or container. Contains fields that describe the component part and data that identify the host, field 773 (Host Item Entry). Examples of monographic component parts with corresponding host items include an article in a single issue of a periodical, a chapter in a book, a band on a phonodisc, and a map on a single sheet that contains several maps. b - Serial component part Serial bibliographic unit that is physically attached to or contained in another unit such that the retrieval of the component part is dependent on the identification and location of the host item or container. Contains fields that describe the component part and data that identify the host, field 773 (Host Item Entry). Example of a serial component part with corresponding host item is a regularly appearing column or feature in a periodical. So the "serial" isn't about it being part of a serial, but actually about the way the child record is published. For most cases we use this feature for, "a" then appears as the correct default. Now it gets a bit more ugly: if you actually want to distinguish between serial and monograph, you need to encode this in 773$7 pos 3: https://www.loc.gov/marc/bibliographic/bd76x78x.html On the other hand, taking care of that automatically could be a real win... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:55:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:55:49 +0000 Subject: [Koha-bugs] [Bug 28827] OpacHiddenItems should be marked in staff catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 26861 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 15:55:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 13:55:49 +0000 Subject: [Koha-bugs] [Bug 26861] Indicate that a record is using OpacHiddenItems in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #5 from Katrin Fischer --- *** Bug 28827 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 16:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 14:01:33 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11175 --- Comment #2 from Katrin Fischer --- This makes sense, but I think we need a depends on for the bug adding the 003 index? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 16:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 14:01:33 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 16:07:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 14:07:30 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #13 from Katrin Fischer --- (In reply to Fridolin Somers from comment #12) > Oh crap, a real ergonomic bug then. I backport. > > The backport on 20.11 actually fails because there is on select tag the > attribute size="1". > This has been removed in 21.05.x by Bug 28066. > > Should we keep it or remove it ? I believe removing it would be ok, but leaving it in probably won't cause issues right away either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:15:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:15:48 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:15:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:15:53 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121128|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123595&action=edit Bug 28380: Elasticsearch - correct 024aa in mappings (MARC21) This patch corrects a typo in the mappings.yaml file To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for a standard number found in 024$a using the Standard number index in the advanced search Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:21:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:21:24 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Hi Caroline. For this one I think you are correct - 24aa is incorrect and this fixes it. Searching using identifier-other=XYZ (where XYZ = a value in 24$a) now works after the patch is applied. In the advanced search form I don't think identifier-other is included in the standard number index, so this didn't work for me (also, I don't really understand how this all works and ties together). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:25:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:25:31 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This corrects the MARC21 release notes| |mapping for 24$a when using | |Elasticsearch: | |identifier-other now maps | |to 24a rather than 24aa | |(which is a typo). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:31:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:31:10 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds 264$c release notes| |to the default mapping for | |the copydate index when | |using Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:51:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:51:44 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:51:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:51:48 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121135|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123596&action=edit Bug 28381: Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) This patch adds fields 710$a and 711$a to the default author mappings for elasticsearch indexing. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for an author name found only in 710 using the Author index in advanced search 4) Repeat search for an author name in 711 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 7 22:54:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Aug 2021 20:54:20 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement adds release notes| |fields 710$a and 711$a to | |the default author index | |mapping when using | |Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 12:39:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 10:39:27 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 12:39:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 10:39:31 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121188|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 123597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123597&action=edit Bug 28393: Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) This patch adds 050 $a to the mapping for the lc-call-number index. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex I'm not sure how to search specifically for an LC call number. You can confirm that 050 $a is displayed in the Search engine configuration page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 12:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 10:44:54 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- I managed to search us lc-call-number=X (where X - the either the 050$a or $050$b from a record - didn't work for 50$a before, but did after applying patch, resetting mapping, and reindexing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 12:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 10:49:05 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds 50$a release notes| |(Library of Congress | |classification number) to | |the lc-call-number index | |mapping when using | |Elasticsearch. | | | |These means | |that when searching using | |lc-call-number both 50$a | |and 50$b (Library of | |Congress item number) are | |now searchable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 13:26:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 11:26:35 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 13:26:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 11:26:39 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123593|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123598&action=edit Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless. Test plan: 1) Use UNIMARC database 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a : L'avion 4) Create a record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch 463$t contains : L\'avion => With patch 463$t contains : L'avion Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 19:46:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 17:46:47 +0000 Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search engines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 19:46:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 17:46:51 +0000 Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search engines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123586|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123599&action=edit Bug 28826: Add FacetOrder system preference This bug adds a system preference to control ordering of facets and adds the control to both Zebra and Elasticsearch To test: 1 - Have a koha that can use both Zebra and ES 2 - Set 'displayFacetCount' to true 3 - Search in ES and Zebra 4 - Note facets in Zebra sorted alphabetically, ES by usage 5 - Apply patch, updatedatabase 6 - Search in ES and Zebra, facets are alphabetically sorted in both 7 - Find new syspref FacetOrder and set to 'by usage' 8 - Search in both engines, facets sorted by usage Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 20:14:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 18:14:31 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 8 20:14:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 18:14:35 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123584|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123600&action=edit Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:13:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:13:10 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:13:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:13:18 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122801|0 |1 is obsolete| | Attachment #122802|0 |1 is obsolete| | Attachment #122803|0 |1 is obsolete| | Attachment #122804|0 |1 is obsolete| | Attachment #122805|0 |1 is obsolete| | Attachment #122806|0 |1 is obsolete| | --- Comment #62 from Alex Buckley --- Created attachment 123601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123601&action=edit Bug 28316: add tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:13:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:13:25 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #63 from Alex Buckley --- Created attachment 123602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123602&action=edit Bug 28316: screen unquoted semicolons and all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that remove the colons at the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:13:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:13:30 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #64 from Alex Buckley --- Created attachment 123603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123603&action=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning. To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:13:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:13:35 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #65 from Alex Buckley --- Created attachment 123604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123604&action=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:13:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:13:40 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #66 from Alex Buckley --- Created attachment 123605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123605&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:13:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:13:46 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #67 from Alex Buckley --- Created attachment 123606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123606&action=edit Bug 28316: escape ES ranges if QueryAutoTruncate is enabled if QueryAutoTruncate enabled we will have any special operators ruined for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]" so no reason to keep ranges when QueryAutoTruncate set to "enabled" 1) enable QueryAutoTruncate at your sysprefs. 2) perform a search using range, for example: "[1999 TO 2020]", it shouldn't work the way it's supposed to. 3) apply the patch. 4) perform the same search with range, ensure that it works correctly. Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:14:53 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #68 from Alex Buckley --- Followed patch test plans (and run unit test t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t) which work as described in devbox running Elasticsearch. So have signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:27:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:27:31 +0000 Subject: [Koha-bugs] [Bug 26861] Indicate that a record is using OpacHiddenItems in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:31:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:31:24 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:36:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:36:18 +0000 Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:36:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:36:24 +0000 Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123045|0 |1 is obsolete| | --- Comment #5 from Alex Buckley --- Created attachment 123607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123607&action=edit Bug 28484: ES clean title in biblio detail Test plan: - Create a biblio with title like "osteuropa:" or "osteuropa!" - Go the this biblio detail pages (cgi-bin/koha/catalogue/detail.pl) => Error - Apply bug 28316 and this one - test again Signed-off-by: Alex Buckley -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 01:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Aug 2021 23:36:56 +0000 Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #6 from Alex Buckley --- Followed test plan, patch worked as described in kohadevbox running Elasticsearch. So signed off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:20:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:20:03 +0000 Subject: [Koha-bugs] [Bug 28400] Add SMS provider's response to message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28400 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add SMS provider's message |Add SMS provider's response |id to message_queue table |to message_queue table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:22:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:22:51 +0000 Subject: [Koha-bugs] [Bug 28400] Add SMS provider's response to message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28400 --- Comment #1 from Johanna Räisä --- (In reply to Johanna Räisä from comment #0) > Some SMS providers give an id in response body which you can use to track > message status. Now message_queue table doesn't have any field where this > could be put. Probably saving the whole response body is the best thing to do since there can be more useful data than just id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:29:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:29:41 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #224 from Martin Renvoize --- I'm starting to ask myself if doing this within the XSLT is right at all... It feels like perhaps we should be placing these details inside a tab alongside holdings, description and friends. Right now, we're passing allot of data to the front end and then displaying very minimal details from it via XSLT. I'm thinking that perhaps we should either get selective about what fields of the component part records we pass and just display a nice table or we can continue to pass whole records, but split the xslt into it's own file (or re-use the results xslt perhaps) and use that for more of an embedded results display in this tab. Think I'm going to have to tag out of this for now, I need to get back to other things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:31:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:31:25 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #225 from Martin Renvoize --- Created attachment 123608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123608&action=edit WIP: Display components in own tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:56:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:56:51 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #226 from Martin Renvoize --- Created attachment 123609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123609&action=edit Bug 11175: (WIP) Display components in own tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:57:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:57:21 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:59:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:59:57 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 [Bug 27507] Search host record using control number identifier / organization code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 09:59:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 07:59:57 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 10:01:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 08:01:03 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123568|0 |1 is obsolete| | --- Comment #42 from Peter Vashchuk --- Created attachment 123610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123610&action=edit Bug 25711: add comment to clarify how the method works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 10:03:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 08:03:10 +0000 Subject: [Koha-bugs] [Bug 28823] Set LDR position 7 correctly for serial analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 --- Comment #2 from Martin Renvoize --- Interesting.. feel free to amend the bug title as it sounds like you've got a much better understanding of this than I do.. I actually think your change may be simpler than the one I was suggesting having looked at the code.. we only deal with the 773 in the child record at present. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 10:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 08:04:37 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21469 | --- Comment #6 from Martin Renvoize --- Waiting on some more cleaning up work being done on 11175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 10:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 08:04:37 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27507 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 [Bug 27507] Search host record using control number identifier / organization code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 10:09:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 08:09:10 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Clodagh Kerin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 11:26:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 09:26:31 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #46 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #45) Thx for giving it another try! My first qa tools run here again: Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. So unfortunately bug 17600 did not resolve this problem ;) Note the pbase array used in /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm looks like: $VAR1 = [ 'Koha::Template::Plugin', 'Template::Plugin' ]; This actually means that every upstream plugin is looked up in the wrong place first, but that should not be a problem: TT ignores the Can't locate file messages. When you saw the message "Can't locate Template/Plugin/Biblio.pm in @INC", TT already failed on Koha::Template::Plugin. Which is the actual problem. > Maybe a path problem baked into the QA tools? I don't think it is fair that > this issue blocks this bug. I agree. Half of the QA team already had a look and cant find the real source of the issue. But I am not sure if the issue is in QA tools, Template Toolkit or in a Koha dependency. The randomness of the failure does not make it easier ;) There seems to be a connection with the fact that the module is used in an INCLUDE of the template under consideration. But note also that Agustin still needs to respond to comment41. This is not fixed yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 11:34:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 09:34:48 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123609|0 |1 is obsolete| | --- Comment #227 from Martin Renvoize --- Created attachment 123611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123611&action=edit Bug 11175: (WIP) Display components in own tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 11:34:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 09:34:55 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #228 from Martin Renvoize --- Created attachment 123612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123612&action=edit Bug 11175: (WIP) Remove special XSLT handling for parts With the work to move this into it's own tab in the details display, we don't need the special handling in the XSLT display templates, utils or module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 11:38:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 09:38:33 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #229 from Martin Renvoize --- Created attachment 123613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123613&action=edit Alternative display option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 11:40:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 09:40:51 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 11:44:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 09:44:04 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #230 from Martin Renvoize --- All patches can be applied now, the final two are an alternative implementation based on the work that preceded. Test plan is as before, grab the test mrc records and import them, build the indexes then search for 'Easy piano'. Navigate to the host record and see what it looks like.. I new 'Components (200)' tab should appear and clicking on it should display a list of all the attached records. The big difference with this implementation is that we no longer embed the analytics in the records passed to the XSLT parser. Instead, we pass each record in an array to the template and them use the Results XSLT to format their output. It might be nice to have a simplified template for this display instead of using Results, but as a proof of concept I felt this was enough to showcase the alternative method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 11:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 09:45:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #231 from Martin Renvoize --- I'm also wondering about the need for 'ShowComponentParts' pref at all now.. We already do the search anyway to ascertain whether we should display the 'Show analytics' link or not so we're not really saving anything performance-wise by disabling the display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:08:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:08:38 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #232 from Martin Renvoize --- Created attachment 123614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123614&action=edit Bug 11175: (WIP) OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:16:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:16:02 +0000 Subject: [Koha-bugs] [Bug 21484] Show the parent record's component parts in the detailed views - Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21484 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- This actually ended up being folded into the dependency bug *** This bug has been marked as a duplicate of bug 11175 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:16:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:16:02 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #233 from Martin Renvoize --- *** Bug 21484 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:17:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:17:09 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #73 from Martin Renvoize --- Could you add release notes for this Marcel? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:18:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:18:31 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Use details from host record for article records placed on records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Article requests: Can we |Article requests: Use |redirect article records |details from host record |without items to host |for article records placed |record? |on records without items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:20:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:20:46 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature add the release notes| |`ArticleRequestsHostRedirec | |tion` system preference. | | | |When enabled, if a user | |attempts to place an | |article request from an | |analytic record the system | |will automatically populate | |some details in the request | |from using data from the | |host record. Summary|Article requests: Use |Article requests: Can we |details from host record |redirect article records |for article records placed |without items to host |on records without items |record? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:22:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:22:11 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #74 from Martin Renvoize --- Scratch that.. can you just varify my description is correct ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:23:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:23:12 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Use details from the host record when submitting an article request on an analytic record without attached items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Article requests: Can we |Article requests: Use |redirect article records |details from the host |without items to host |record when submitting an |record? |article request on an | |analytic record without | |attached items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:45:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:45:09 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #1 from Martin Renvoize --- Created attachment 123615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123615&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:45:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:45:31 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:45:37 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:45:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:45:56 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #2 from Martin Renvoize --- Built with inspiration based on bug 11175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 12:50:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 10:50:00 +0000 Subject: [Koha-bugs] [Bug 25090] Enable library approval of OPAC self registrations before a patron account is created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #26 from David Nind --- Patches no longer apply 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25090: OPAC Template changes Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 25090: OPAC Template changes hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-25090-OPAC-Template-changes-ueOCKF.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:02:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:02:22 +0000 Subject: [Koha-bugs] [Bug 28830] New: Add CNI (Control Number Identifier) search index Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Bug ID: 28830 Summary: Add CNI (Control Number Identifier) search index Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We ought to have a cni index to allow searching on the content of the 003 marc field for accurate linking using UseControlNumber type searches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:02:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:02:28 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:08:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:08:44 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 --- Comment #1 from Martin Renvoize --- Created attachment 123616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123616&action=edit Bug 28830: Add cni index for 003 This patch adds the cni/Control-number-identifier index to enable searches to use the 003 field. Test plan 1/ Apply patch 2/ Re-index using updated configurations 3/ Confirm cni:number searches yield the expected results 4/ Signoff Split-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:09:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:09:03 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:10:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:10:08 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Martin Renvoize --- This patch was split out of bug 11175 to allow it to be a dependanchy of other bugs without risking hold ups whilst 11175 makes it way through QA. Signoffs carried across from that bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:10:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:10:38 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:04 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123542|0 |1 is obsolete| | --- Comment #234 from Martin Renvoize --- Created attachment 123617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123617&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:10 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123543|0 |1 is obsolete| | --- Comment #235 from Martin Renvoize --- Created attachment 123618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123618&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:16 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123544|0 |1 is obsolete| | --- Comment #236 from Martin Renvoize --- Created attachment 123619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123619&action=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:23 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123545|0 |1 is obsolete| | --- Comment #237 from Martin Renvoize --- Created attachment 123620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123620&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:29 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123546|0 |1 is obsolete| | --- Comment #238 from Martin Renvoize --- Created attachment 123621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123621&action=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123547|0 |1 is obsolete| | --- Comment #239 from Martin Renvoize --- Created attachment 123622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123622&action=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:41 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123548|0 |1 is obsolete| | --- Comment #240 from Martin Renvoize --- Created attachment 123623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123623&action=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:47 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123549|0 |1 is obsolete| | --- Comment #241 from Martin Renvoize --- Created attachment 123624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123624&action=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:13:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:13:54 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123550|0 |1 is obsolete| | --- Comment #242 from Martin Renvoize --- Created attachment 123625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123625&action=edit Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:00 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123551|0 |1 is obsolete| | --- Comment #243 from Martin Renvoize --- Created attachment 123626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123626&action=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:06 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123552|0 |1 is obsolete| | --- Comment #244 from Martin Renvoize --- Created attachment 123627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123627&action=edit Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:13 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123553|0 |1 is obsolete| | --- Comment #245 from Martin Renvoize --- Created attachment 123628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123628&action=edit Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:19 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123554|0 |1 is obsolete| | --- Comment #246 from Martin Renvoize --- Created attachment 123629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123629&action=edit Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:25 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123555|0 |1 is obsolete| | --- Comment #247 from Martin Renvoize --- Created attachment 123630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123630&action=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:31 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123571|0 |1 is obsolete| | --- Comment #248 from Martin Renvoize --- Created attachment 123631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123631&action=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:38 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123572|0 |1 is obsolete| | --- Comment #249 from Martin Renvoize --- Created attachment 123632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123632&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:45 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123573|0 |1 is obsolete| | --- Comment #250 from Martin Renvoize --- Created attachment 123633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123633&action=edit Bug 11175: (QA follow-up) Move get_component_part_query This patch removes Koha::Util::Search in preference to embedding the search query builder in Koha::Biblio as get_analytics_query. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:51 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123574|0 |1 is obsolete| | --- Comment #251 from Martin Renvoize --- Created attachment 123634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123634&action=edit Bug 11175: (QA follow-up) Only get biblio once Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:14:58 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123582|0 |1 is obsolete| | --- Comment #252 from Martin Renvoize --- Created attachment 123635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123635&action=edit Bug 11175: (QA follow-up) Fix queries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:15:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:15:04 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123611|0 |1 is obsolete| | --- Comment #253 from Martin Renvoize --- Created attachment 123636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123636&action=edit Bug 11175: (WIP) Display components in own tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:15:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:15:11 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123612|0 |1 is obsolete| | --- Comment #254 from Martin Renvoize --- Created attachment 123637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123637&action=edit Bug 11175: (WIP) Remove special XSLT handling for parts With the work to move this into it's own tab in the details display, we don't need the special handling in the XSLT display templates, utils or module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:15:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:15:17 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123614|0 |1 is obsolete| | --- Comment #255 from Martin Renvoize --- Created attachment 123638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123638&action=edit Bug 11175: (WIP) OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:19:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:19:40 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 [Bug 28830] Add CNI (Control Number Identifier) search index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:19:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:19:40 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:22:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:22:45 +0000 Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11175 |28830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 [Bug 28830] Add CNI (Control Number Identifier) search index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:22:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:22:45 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21469 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:22:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:22:45 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469 [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:23:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:23:24 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 [Bug 28830] Add CNI (Control Number Identifier) search index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:23:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:23:24 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:24:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:24:37 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11175 |28830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 [Bug 28830] Add CNI (Control Number Identifier) search index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:24:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:24:37 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27507 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 [Bug 27507] Search host record using control number identifier / organization code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:24:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:24:37 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 [Bug 27507] Search host record using control number identifier / organization code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:24:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:24:47 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:24:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:24:47 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27507 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:36:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:36:46 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Use details from the host record when submitting an article request on an analytic record without attached items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #75 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #74) > Scratch that.. can you just varify my description is correct ;) It reads fine, Martin. Given that I am not so familiar with the word analytic, and it does not intuitively put my mind in the right direction ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 13:47:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 11:47:16 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #11 from Owen Leonard --- Created attachment 123639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123639&action=edit Bug 10902: (follow-up) Fix patron search autocomplete The circulation search autocomplete (e.g. from circulation.pl search header) was corrected in the previous patch to include library name instead of branchcode. This patch makes the same correction for patron search autocomplete (e.g. from members-home.pl search header). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:02:25 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:02:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:02:29 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #48 from Marcel de Rooy --- Created attachment 123640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123640&action=edit Bug 26302: (QA follow-up) Reset preference values Mimic current behavior. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:02:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:02:33 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #49 from Marcel de Rooy --- Created attachment 123641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123641&action=edit Bug 26302: (QA follow-up) Prevent empty call numbers This does not make the code easier, but here we go: Suppose resultsMaxItems == 2. If we would normally list two call numbers like: Liberty (2) [Call number: PERL F 1, PERL F 2]. If one call number would be empty, we now list: Liberty (2) [Call number: PERL F 1, ...]. And when both are empty, we only show a number: Liberty (2). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:04:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:04:56 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows |This enhancement allows release notes|customizing the number of |customizing the number of |call numbers displayed for |call numbers displayed for |OPAC search results for |OPAC search results for |items available and not |items available and not |available by changing two |available by changing two |new system preferences: |new system preferences: |- |- |resultsMaxItems: maximum |resultsMaxItems: maximum |number of available items |number of available items |displayed in search results |displayed in search results |(default = 2) |(default = 1) |- |- |resultsMaxItemsUnavailable |resultsMaxItemsUnavailable |- maximum number of |- maximum number of |unavailable items displayed |unavailable items displayed |in search results (such as |in search results (such as |when checked out and |when checked out and |damaged) (default = 1) |damaged) (default = 0) | | |This is useful when records |This is useful when records |have a large number of |have a large number of |items, for example larger |items, for example larger |libraries with many |libraries with many |branches, union catalogues, |branches, union catalogues, |and university libraries |and university libraries |with course text books. |with course text books. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:11:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:11:57 +0000 Subject: [Koha-bugs] [Bug 28831] New: Results XSLT: Allow unavailable item grouping on status only for large consortia Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831 Bug ID: 28831 Summary: Results XSLT: Allow unavailable item grouping on status only for large consortia Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 26302: > 3 - Not blocker: it would be nice to have a '-1' option for > resultsMaxItemsUnavailable to preserve previous grouping - in large > consortia I know they have not wanted to display individual NFL items. This follow-up would make it possible to group by (sub)status and not on branch level first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:12:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:12:12 +0000 Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item grouping on status only for large consortia In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26302 Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:12:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:12:12 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831 [Bug 28831] Results XSLT: Allow unavailable item grouping on status only for large consortia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:14:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:14:16 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #4 from Nick Clemens --- Created attachment 123642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123642&action=edit Bug 28828: (Alternate) find closest ul for valuebuilders Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan 1: 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Test plan 2: 1) Use a MARC_21 DB 2) Define plugin mnarc21_linking_section.pl on 773$t 3) Make sure 773$t and other subfields are visible in intranet/editor 4) Create a new record in basic cataloging editor 5) Click on value builder in 773$t 6) Search fro a record 7) Click on "Choose" => Without patch fields are not fileld => With patch subfields are correctly filled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:15:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:15:02 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- Looks like a second plugin is affected - I use 'closest' rather than several 'parentNode' as I think it makes the change clearer - what do you think Frido? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:16:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:16:09 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #50 from Marcel de Rooy --- (In reply to Nick Clemens from comment #47) Thx > 1 - We should default the prefs to 1,0 to more closely mimic the behavior > before Fixed in patch/follow-up 5 > 2 - Items with blank callnumbers now show: [Call number: ], before they only > showed the count Fixed in patch/follow-up 6 > 3 - Not blocker: it would be nice to have a '-1' option for > resultsMaxItemsUnavailable to preserve previous grouping - in large > consortia I know they have not wanted to display individual NFL items Yeah can imagine. Willing to add it on a new report. Not here anymore. Bug 28831 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:16:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:16:49 +0000 Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item grouping on status only for large consortia In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:24:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:24:37 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:49:05 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123641|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy --- Created attachment 123643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123643&action=edit Bug 26302: (QA follow-up) Prevent empty call numbers This does not make the code easier, but here we go: Suppose resultsMaxItems == 2. If we would normally list two call numbers like: Liberty (2) [Call number: PERL F 1, PERL F 2]. If one call number would be empty, we now list: Liberty (2) [Call number: PERL F 1, ...]. And when both are empty, we only show a number: Liberty (2). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:58:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:58:24 +0000 Subject: [Koha-bugs] [Bug 28823] Set 773$7 pos 3 for analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set LDR position 7 |Set 773$7 pos 3 for |correctly for serial |analytics using ''Enhanced |analytics using ''Enhanced |Analytics Workflow' |Analytics Workflow' | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 14:59:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 12:59:32 +0000 Subject: [Koha-bugs] [Bug 28823] Set 773$7 pos 3 for analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 --- Comment #3 from Katrin Fischer --- Done. MARC... the gift that keeps giving... :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:02:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:02:58 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:03:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:03:02 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123531|0 |1 is obsolete| | Attachment #123532|0 |1 is obsolete| | Attachment #123533|0 |1 is obsolete| | Attachment #123534|0 |1 is obsolete| | Attachment #123640|0 |1 is obsolete| | Attachment #123643|0 |1 is obsolete| | --- Comment #52 from Nick Clemens --- Created attachment 123644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123644&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:03:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:03:07 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #53 from Nick Clemens --- Created attachment 123645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123645&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:03:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:03:10 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #54 from Nick Clemens --- Created attachment 123646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123646&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:03:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:03:13 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #55 from Nick Clemens --- Created attachment 123647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123647&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:03:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:03:14 +0000 Subject: [Koha-bugs] [Bug 28823] Set 773$7 pos 3 for analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 --- Comment #4 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #3) > Done. > > MARC... the gift that keeps giving... :) Headaches ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:03:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:03:19 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #56 from Nick Clemens --- Created attachment 123648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123648&action=edit Bug 26302: (QA follow-up) Reset preference values Mimic current behavior. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:03:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:03:22 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #57 from Nick Clemens --- Created attachment 123649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123649&action=edit Bug 26302: (QA follow-up) Prevent empty call numbers This does not make the code easier, but here we go: Suppose resultsMaxItems == 2. If we would normally list two call numbers like: Liberty (2) [Call number: PERL F 1, PERL F 2]. If one call number would be empty, we now list: Liberty (2) [Call number: PERL F 1, ...]. And when both are empty, we only show a number: Liberty (2). Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:07:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:07:23 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #21 from David Nind --- Hi Aleisha. In step 4 of the test plan I get an error when refreshing the page Could not compile /kohadevbox/koha/tools/modborrowers.pl: Bareword "I" not allowed while "strict subs" in use at /kohadevbox/koha/tools/modborrowers.pl line 118. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/tools/modborrowers.pl line 489. at /usr/share/perl5/CGI/Compile.pm line 144 in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144 141: my $code = $self->_eval($eval); 142: my $exception = $@; 143: 144: die "Could not compile $script: $exception" if $exception; 145: 146: subname "${package}::$subname", sub { 147: my @args = @_; Show function arguments David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:11:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:11:51 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #16 from Nick Clemens --- While this is all technically correct according to MARC standards, I do think it will have an impact on library workflows. Some libraries use the 003 for determining the source of the record, automatically updating the field is going to be a change. perhaps a checkbox, checked by default, during import? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:18:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:18:07 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks value_builder/unimarc_field_4XX.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28738 --- Comment #6 from Katrin Fischer --- Bug 28738 is also affected - would love some help there simplifying the JS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:18:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:18:07 +0000 Subject: [Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28828 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:18:51 +0000 Subject: [Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:18:51 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:21:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:21:18 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #12 from David Nind --- Thanks Owen! That works brilliantly! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:23:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:23:21 +0000 Subject: [Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens --- I fix both on 22399 with my version 'closest' rather than several 'parentNode' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:26:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:26:46 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #17 from Marcel de Rooy --- I do not mind obsoleting this development, if it is just too hurtful :) We found a comfortable in-between solution: the Discussion status, hahaha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:44:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:44:44 +0000 Subject: [Koha-bugs] [Bug 28823] Set 773$7 pos 3 for analytics using ''Enhanced Analytics Workflow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28823 --- Comment #5 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #4) > (In reply to Katrin Fischer from comment #3) > > Done. > > > > MARC... the gift that keeps giving... :) > > Headaches ? Let's say... challenges. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:54:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:54:06 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:54:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:54:09 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123207|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 123650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123650&action=edit Bug 28764: Parse direction parameter in public list view This patch adds a check for a 'direction' paramter in list sorting. It maintains the existing syntax for sorting 'sortfield=field:direction' but adds support for the form used in paginations and more commonly thtoughout Koha' sortfield=field&direction=direction' To test: 1 - Create a public list 2 - Add enough items to generate two pages (40 worked for me) 3 - View the list and enforce sorting by date added descending: sortfield=dateadded:desc 4 - Note the titles shown 5 - Click to second page using the pagination bar 6 - Note the same titles are shown, in a reversed order 7 - Apply patch 8 - repeat 305 9 - Second page is sorted correctly! Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:54:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:54:12 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123297|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 123651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123651&action=edit Bug 28764: Alter sort dropdown to use direction parameter This code is odd -we build a select in the template, then turn it into a list of links using javascript This patch adds a direction data element and uses it while building the links Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 15:54:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 13:54:16 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #8 from Marcel de Rooy --- Created attachment 123652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123652&action=edit Bug 28764: (QA follow-up) Add comment, remove two defined's If we no longer offer the sortfield with :asc actively, we should probably write it somewhere too. Replaced a few defined tests by empty test. No need to split empty string or zero etc. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:00:06 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #18 from Katrin Fischer --- They can still determine the source using 035 - is that not enough? 001 and 003 are a couple. At the moment we risk that we generate "false" couples that might match real records in the original source - that could lead to issues on importing and matching for example. I really think this is a bug. And it should be possible to make a permanent change in that behaviour - a checkbox that might sometimes be forgotten is too dangerous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:14:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:14:43 +0000 Subject: [Koha-bugs] [Bug 26852] Subfield $e missing in X11 definition of MARC 21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 S. Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #5 from S. Brown --- I followed this and it worked as intended - sign-off through sandbox didn't work properly so am signing off here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:18:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:18:05 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #59 from Marcel de Rooy --- sub can_be_deleted { my ( $self, $borrowernumber ) = @_; return 0 unless $borrowernumber; return 1 if $self->owner == $borrowernumber; my $patron = Koha::Patrons->find( $borrowernumber ); return 1 if $self->is_public and haspermission( $patron->userid, { lists => 'delete_public_lists' } ); return 0; } This is still different from surrounding code as to testing Patrons::find. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:18:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:18:23 +0000 Subject: [Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 --- Comment #7 from Katrin Fischer --- (In reply to Nick Clemens from comment #6) > I fix both on 22399 with my version > > 'closest' rather than several 'parentNode' Sorry, not seeing it there - can you explain a bit more? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:23:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:23:29 +0000 Subject: [Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 --- Comment #8 from Nick Clemens --- (In reply to Katrin Fischer from comment #7) > (In reply to Nick Clemens from comment #6) > > I fix both on 22399 with my version > > > > 'closest' rather than several 'parentNode' > > Sorry, not seeing it there - can you explain a bit more? Oops, 28828 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:27:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:27:38 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #60 from Marcel de Rooy --- can_biblios_be_added if $borrowernumber and ( ( $self->owner == $borrowernumber && $self->allow_change_from_owner ) or ( $self->allow_change_from_staff && $patron->can_patron_change_staff_only_lists ) or $self->allow_change_from_others ); Isnt it actually strange that you could be the owner of a list, being a staff member, but without the staff_only_lists perm, and you cannot even add or remove one book to your own list ? Note that as owner you still can manage or delete the whole list! Do we need a more clear definition of what "staff only" actually means? I would think more of an extension to staff users.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:28:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:28:10 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #61 from Marcel de Rooy --- add_biblio my $patron = Koha::Patrons->find( $borrowernumber ) or return 0; return unless ( $self->owner == $borrowernumber && $self->allow_change_from_owner ) || ( $self->allow_change_from_staff && $patron->can_patron_change_staff_only_lists ) || $self->allow_change_from_others; Why return 0 on the first line and return undef on the second? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:30:50 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #62 from Marcel de Rooy --- (In reply to Alex Buckley from comment #58) > - When an un-authenticated user (i.e. not logged in) selects an item and > tries to see what lists they can add said item to then only "Anyone seeing > this list" public lists show as available. Anyone seeing this list is not really true. Anonymous cant add or delete entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:31:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:31:29 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #63 from Marcel de Rooy --- Hmm. I do fear that we still need another QA iteration step. Sorry for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:35:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:35:57 +0000 Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- In the meantime you can step around email validation on branches.tt by adding the following to your IntranetUserJS sys pref: //turn off email validation for branches.tt if ( $('#admin_branches').length && window.location.href.indexOf("op=add_form") > -1 ) { $('#branchemail').removeClass('email'); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:50:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:50:02 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #19 from Martin Renvoize --- (In reply to Katrin Fischer from comment #18) > They can still determine the source using 035 - is that not enough? > > 001 and 003 are a couple. > > At the moment we risk that we generate "false" couples that might match real > records in the original source - that could lead to issues on importing and > matching for example. > > I really think this is a bug. And it should be possible to make a permanent > change in that behaviour - a checkbox that might sometimes be forgotten is > too dangerous. I think the more "natural" pref for me would be to keep 001+003 or to change both. This is certainly my understanding of the specs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 16:57:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 14:57:52 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #43 from Peter Vashchuk --- Created attachment 123653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123653&action=edit Bug 25711: tests for get_effective_expire_reserves_charge method new tests that test logic of new get_effective_expire_reserves_charge method that was added to Koha::CirculationRules to retrieve the effective value of the rule. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 17:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 15:10:52 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #20 from Katrin Fischer --- I assumed we already moved to 035 earlier, but not sure now. Not sure when I get to test this out, does someone know? I think to be fully compliant it would be: Copy 001 and 003 as "(003)001" to 035. Update 001 to internal ID and 003 to MARCOrgCode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:02:25 +0000 Subject: [Koha-bugs] [Bug 28832] New: Batch modification always clears permanent_location if it is mapped in frameworks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Bug ID: 28832 Summary: Batch modification always clears permanent_location if it is mapped in frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On bug 27837 we ensured that the value for permanent_location was always passed through to the edit Unfortunately - when performing a batch mod the field is not set if we don't want to change it or clear it Forcing the pass through then means we clear the field on every update To recreate: 1 - In frameworks add a new subfield to 952, "C" - make it editable in items tab and visible in intranet/editor 2 - In mappings map that subfield to items.permanent_location 3 - Set an item to have differing shelving location and permanent_location 4 - This saves correctly for an individual item 5 - Edit the item using Tools->batch item modification, updating the note field 6 - Note the permanet_location is removed 7 - Check the DB, the field is set to NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:31:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:31:59 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |27837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:31:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:31:59 +0000 Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28832 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:32:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:32:03 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 --- Comment #1 from Nick Clemens --- Created attachment 123654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123654&action=edit Bug 28832: Don't batch modify fields that we don't update In bug 27837 we made sure to always pass through the permanent_location if it was passed in unlike other fields which are not passed if they have no value. During batch mod, however, fields that aren't editied have no value, so forcing permanent_location to pass through forces blanking it. This patch alters the script to only pass thgouhr for edit the fields that have been updated or cleared. To test: 1 - In frameworks add a new subfield to 952, "C" - make it editable in items tab and visible in intranet/editor 2 - In mappings map that subfield to items.permanent_location 3 - Set an item to have differing shelving location and permanent_location 4 - This saves correctly for an individual item 5 - Edit the item using Tools->batch item modification, updating the note field 6 - Note the permanet_location is removed 7 - Check the DB, the field is set to NULL 8 - Apply patch 9 - Repeat 10 - Permanent location is not cleared 11 - Verify that clearing fields works as before, including permanent_location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:32:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:32:40 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27526 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:32:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:32:40 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28832 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:44:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:44:09 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #1 from Lucas Gass --- Created attachment 123655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123655&action=edit Bug 28819: Add item search to intranet-main.tt To test: 1. Apply patch 2. Go to staff main page ( intranet-main.tt ) 3. Now you should see an 'Item search' button and icon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 18:44:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 16:44:36 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 19:21:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 17:21:25 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- (In reply to Jonathan Druart from comment #4) > Don't we need it for 21.05? Yes! I think this can be very useful for 21.05 and below. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 19:45:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 17:45:42 +0000 Subject: [Koha-bugs] [Bug 28833] New: Speed up holds queue builder via parallel processing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Bug ID: 28833 Summary: Speed up holds queue builder via parallel processing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 19:45:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 17:45:47 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 19:52:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 17:52:05 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #1 from Kyle M Hall --- Created attachment 123656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123656&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 19:52:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 17:52:50 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #2 from Kyle M Hall --- This patch provides a tremendous speedup for large numbers of holds. However, it causes HoldsQueue.t to fail spectacularly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 19:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 17:54:51 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123656|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 123657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123657&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 20:26:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 18:26:50 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 20:26:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 18:26:53 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123010|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 123658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123658&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferredname' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name now displays on patron details 6 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 7 - Sign in as patron to opac 8 - Confirm preferred name shows 9 - Edit account on opac and confirm field is present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 21:12:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 19:12:27 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123657|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 123659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123659&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 21:33:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 19:33:44 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 22:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 20:05:03 +0000 Subject: [Koha-bugs] [Bug 28834] New: Bad wording biblios/authorities in tools home Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Bug ID: 28834 Summary: Bad wording biblios/authorities in tools home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In tools home, we actually see 2 wordings : biblios/bibliographic authorities/authority Looks like bibliographic is more correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 22:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 20:05:26 +0000 Subject: [Koha-bugs] [Bug 28834] Bad wording biblios/authorities in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 22:11:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 20:11:36 +0000 Subject: [Koha-bugs] [Bug 28834] Bad wording biblios/authorities in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 22:11:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 20:11:40 +0000 Subject: [Koha-bugs] [Bug 28834] Bad wording biblios/authorities in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 --- Comment #1 from Fridolin Somers --- Created attachment 123660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123660&action=edit Bug 28834: Correct wording biblios/authorities in tools home In tools home, we actually see 2 wordings : biblios/bibliographic authorities/authority Looks like bibliographic is more correct. Test plan : 1) Apply patch and look at words in tools home /cgi-bin/koha/tools/tools-home.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 9 22:53:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 20:53:13 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- I'd like to sign this one but it does not apply anymore because of changes on breadcrumbs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 00:05:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 22:05:57 +0000 Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #30 from Victor Grousset/tuxayo --- > Can someone stress the feature with this patch? What do you mean? Is the patch name too vague? The first 3 steps of the test plan show the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 01:16:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Aug 2021 23:16:14 +0000 Subject: [Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)| |20.11.09 released in| | --- Comment #12 from Fridolin Somers --- Patch pushed to 20.11.x for 20.11.09 Thanks a lot to all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 07:52:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 05:52:08 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 09:27:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 07:27:29 +0000 Subject: [Koha-bugs] [Bug 28835] New: Ability to pass list contents to batch record modification broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Bug ID: 28835 Summary: Ability to pass list contents to batch record modification broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 12759 added the ability to pass list contents to batch record modification/deletion tools. Patch Bug 22417 [Restore the 'add to list' feature] removed the fetch of lists in batch_record_modification.pl I don't understand why. It still exists in batch_delete_records.pl. Note that this is needed when first form is displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 09:28:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 07:28:34 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 10:42:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 08:42:02 +0000 Subject: [Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123498|0 |1 is obsolete| | Attachment #123610|0 |1 is obsolete| | Attachment #123653|0 |1 is obsolete| | --- Comment #44 from Peter Vashchuk --- Created attachment 123661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123661&action=edit Bug 25711: move get_effective_expire_charge to Koha::CirculationRules Move get_effective_expire_reserves_charge as a new method in Koha::CirculationRules to retrieve the effective value of the rule, which means it will get the value from existing circulation rule and if it doesn't exist or set to undefined it will get the default value from the preferences. Also added tests for this logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 10:54:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 08:54:26 +0000 Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #30) > > Can someone stress the feature with this patch? > > What do you mean? Is the patch name too vague? > The first 3 steps of the test plan show the issue. I've explained it: "Like search with your favourite weird terms and click the last records from the page, then next, previous." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 11:35:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 09:35:30 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 11:35:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 09:35:34 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 --- Comment #1 from Fridolin Somers --- Created attachment 123662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123662&action=edit Bug 28835: Fix ability to pass list contents to batch record modification Bug 12759 added the ability to pass list contents to batch record modification/deletion tools. Patch Bug 22417 [Restore the 'add to list' feature] removed the fetch of lists in batch_record_modification.pl I don't understand why. It still exists in batch_delete_records.pl. Note that this is needed when first form is displayed. Test plan : 1) Create a private and a public list of records 2) Open Tools > Batch record modification 3) Check you can use the lists 4) Open Tools > Batch record deletion 5) Check you can use the lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 11:38:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 09:38:32 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- This appears to work really well now! Before passing just one more suggestion to discuss: Could we imagine not displaying this information for single branch libraries by default? I think it would help to keep their display a little cleaner without the highlighting and repeated information. I believe we do have a global variable that could be used for this check: singleBranchMode from C4:Auth.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 11:41:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 09:41:36 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement highlights |This enhancement highlights release notes|the branch when searching |the branch when searching |for patrons from the |for patrons from the |currently-logged-in |currently-logged-in |library. |library. | | |This includes: |This includes: |- |- |The "Check out" tab in the |The "Check out" tab in the |staff interface header: |staff interface header: | | |. autocomplete results now |. autocomplete results now |show the branch code, and |show the library name. It's |patrons from the |highlighted in green for |currently-logged-in library |patrons from the currently |are highlighted in green |logged-in library | | . after |. after submitting a |submitting a partial name, |partial name, the branch |the library name for |name for patrons from the |patrons from the currently |currently-logged-in library |logged-in library is also |are highlighted in green |highlighted in green |- |- |Browsing for patrons: the |Browsing for patrons: the |branch code for patrons |library name for patrons |from the |from the currently |currently-logged-in library |logged-in library is |is highlighted in green. |highlighted in green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 11:46:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 09:46:48 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 11:46:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 09:46:52 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123600|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 123663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123663&action=edit Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 11:48:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 09:48:36 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123663|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123664&action=edit Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:15:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:15:46 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:17:07 +0000 Subject: [Koha-bugs] [Bug 26852] Subfield $e missing in X11 definition of MARC 21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:17:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:17:11 +0000 Subject: [Koha-bugs] [Bug 26852] Subfield $e missing in X11 definition of MARC 21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #6 from Katrin Fischer --- Created attachment 123665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123665&action=edit Bug 26852: subfield $e missing in X11 definition of MARC21 headings This patch adds $e to 111 and 611, but removes it from 100 and 110 as it's used for the relator term there and should not be copied. Same for 111$j. Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. Repeat testing in similar fashion for authorities: 9. 100/110 $e 10. 111 $j NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml Signed-off-by: S. Brown Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:19:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:19:48 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subfield $e missing in X11 |Add missing X11$e and |definition of MARC 21 |remove relator term |headings |subfields from MARC21 | |headings --- Comment #7 from Katrin Fischer --- I've added a sign-off line for "S. Brown" manually using the email address from the bugzilla account. Also amended the test plan and commit message a bit to reflect the additional fixes for $e/$j relator terms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:24:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:24:32 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 22399 breaks |Bug 22399 breaks |value_builder/unimarc_field |unimarc_field_4XX.tt and |_4XX.tt |marc21_linking_section.tt | |value builders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:25:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:25:15 +0000 Subject: [Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from Katrin Fischer --- Nick provided a fix on bug 28828. *** This bug has been marked as a duplicate of bug 22399 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:25:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:25:15 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #25 from Katrin Fischer --- *** Bug 28738 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:26:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:26:16 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:27:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:27:30 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:29:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:29:29 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Katrin Fischer --- This reads quite similar to bug 28738 - maybe a similar fix would work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:34:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:34:41 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123594|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:39:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:39:09 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:41:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:41:28 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123642|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 123666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123666&action=edit Bug 28828: Fix unimarc_field_4XX.tt and marc21_linking_section.tt value builders Find closest ul for value builders. Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong: var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); Test plan 1: 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Test plan 2: 1) Use a MARC_21 DB 2) Define plugin marc21_linking_section.pl on 773$t 3) Make sure 773$t and other subfields are visible in intranet/editor 4) Create a new record in basic cataloging editor 5) Click on value builder in 773$t 6) Search fro a record 7) Click on "Choose" => Without patch fields are not fileld => With patch subfields are correctly filled Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:42:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:42:42 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #8 from Katrin Fischer --- Hi Frido or David, could one of you have a final look here? I've chosen Nick's alternate and changed the bug title to reflect that this now fixes 2 different value builders. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:47:07 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #4 from Katrin Fischer --- I can't reproduce this issue on master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 12:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 10:52:03 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #5 from Katrin Fischer --- Maybe I am testing the wrong thing. Do you mean copying a repeatable field or are we talking about the authority linker? Authority editor or editing bibliographic records? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:03:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:03:54 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:03:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:03:59 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123536|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 123667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123667&action=edit Bug 28813: Update database field name Update the database field name from 'delivery_note' to 'failure_code' to more accurately denote it's use. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:04:03 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123537|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 123668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123668&action=edit Bug 28813: DBIC Schema Update Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:04:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:04:08 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123538|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 123669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123669&action=edit Bug 28813: Update unit tests This patch updates the unit tests to check for failure_code instead of delivery_note and catches a missing case. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:04:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:04:12 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123539|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 123670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123670&action=edit Bug 28813: Rename delivery_note to failure_code We now use the codes from the half implimented error_code in place of the plain text that was being added to the delivery_note field. As part of that we rename the field to failure_code to clarify it's intended content. Test plan 1/ Confirm t/db_dependent/Letters.t passes Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:05:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:05:32 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #14 from Katrin Fischer --- Tested similarly as David, additionally updated failure_code in my database to check the display on the notices tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:05:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:05:49 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:05:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:05:52 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123659|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 123671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123671&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. Test Plan: 1) Generate a huge number of holds ( a few thousand at the minimum ) 2) Run the holds queue builder, use the `time` utility to track how much time it took to run 3) Set HoldsQueueParallelLoopsCount to 10 4) Repeat step 2, note the improvement in speed 5) Experiment with other values for HoldsQueueParallelLoopsCount 6) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:06:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:06:43 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #15 from Katrin Fischer --- Maybe we could update the bug description a bit, keeping release notes in mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:11:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:11:35 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:11:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:11:39 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119597|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 123672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123672&action=edit Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:16:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:16:36 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:16:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:16:58 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #4 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:17:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:17:39 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:17:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:17:43 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123567|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123673&action=edit Bug 28378: Elasticsearch - Add 264c to default copydate mappings (MARC21) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:20:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:20:54 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:21:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:21:58 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:22:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:22:02 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123595|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123674&action=edit Bug 28380: Elasticsearch - correct 024aa in mappings (MARC21) This patch corrects a typo in the mappings.yaml file To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for a standard number found in 024$a using the Standard number index in the advanced search Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:24:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:24:17 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - Correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - correct |Elasticsearch - Correct |024aa in mappings (MARC21) |024aa in mappings (MARC21) Text to go in the|This corrects the MARC21 |This corrects the MARC21 release notes|mapping for 24$a when using |mapping for 024$a when |Elasticsearch: |using Elasticsearch: |identifier-other now maps |identifier-other now maps |to 24a rather than 24aa |to 024a rather than 024aa |(which is a typo). |(which is a typo). Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:24:25 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - Correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:26:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:26:57 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds 50$a |This enhancement adds 050$a release notes|(Library of Congress |(Library of Congress |classification number) to |classification number) to |the lc-call-number index |the lc-call-number index |mapping when using |mapping when using |Elasticsearch. |Elasticsearch. | | |These means |These means |that when searching using |that when searching using |lc-call-number both 50$a |lc-call-number both 050$a |and 50$b (Library of |and 050$b (Library of |Congress item number) are |Congress item number) are |now searchable. |now searchable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:29:04 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:29:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:29:08 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123597|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 123675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123675&action=edit Bug 28393: Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) This patch adds 050 $a to the mapping for the lc-call-number index. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex I'm not sure how to search specifically for an LC call number. You can confirm that 050 $a is displayed in the Search engine configuration page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:29:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:29:44 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #5 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #3) > I'm confused.. I can't seem to get the unit test to fail.. but in real life > testing it does fail without the fix. The assignment on L413 should affect the call of GetPreparedLetter on L467. But only when the notice actually uses data from aqbasket. It seems to me that we should assign $basketno = $externalid right at the start of the else block (L366) ? Using one variable for different types of id's appears to be a bad idea ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:37:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:37:47 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 --- Comment #3 from Katrin Fischer --- I wonder if $a is really enough when it comes to corporates and meetings. Thinking of: https://www.loc.gov/marc/bibliographic/bd710.html 710ab https://www.loc.gov/marc/bibliographic/bd711.html 711ae But I think this is for a later patch as it would also require changing the indexing of the 1xx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:38:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:38:15 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:38:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:38:19 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123596|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123676&action=edit Bug 28381: Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) This patch adds fields 710$a and 711$a to the default author mappings for elasticsearch indexing. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for an author name found only in 710 using the Author index in advanced search 4) Repeat search for an author name in 711 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:46:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:46:16 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:46:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:46:20 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123566|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123677&action=edit Bug 28339: Elasticsearch - Add 8XX to default title-series index mappings (MARC21) This patch adds series added entries titles (800 $t, 810 $t, 811 $t, and 830 $a) in the default title-series index mappings. To test: 1) Apply patch 2) Reindex using rebuildelasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration and click "Reset mappings" and confirm 2b) Then reindex 3) Search for a series title found only in and added entry field Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:46:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:46:31 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #6 from Marcel de Rooy --- And this one might change the game under Plack: unless ($sth = C4::Context->dbh->prepare($query)) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:48:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:48:18 +0000 Subject: [Koha-bugs] [Bug 28836] New: Duplicated import in template plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28836 Bug ID: 28836 Summary: Duplicated import in template plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org In template plugins, we often find double importing of the parent library: use Template::Plugin; use base qw( Template::Plugin ); Some of the plugins use 'base' [1] like this, and others use 'parent' (that seems to be what we should be using in this cases, as we are not ) [2]. [1] https://perldoc.perl.org/base [2] https://perldoc.perl.org/parent#HISTORY -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:48:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:48:36 +0000 Subject: [Koha-bugs] [Bug 28836] Duplicated import in template plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28836 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27944 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:48:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:48:36 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28836 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:49:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:49:07 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 --- Comment #3 from Katrin Fischer --- Hi Caroline, be careful - you cannot add a commit message with git bz attach, you need to do it with git commit or git commit --amend, otherwise it won't become part of the patch file, but only displays on bugzilla. Fixed here and on another patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:49:47 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:49:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:49:51 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123589|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123678&action=edit Bug 28379: Elasticsearch - Add 710 to author-name-corporate index (MARC21) This patch adds 710 to the default author-name-corporate index mappings for elasticsearch. To test: 1) Apply patch 2) Reindex using rebuild_elasticsearch.pl -r If you don't have access to a terminal (in a sandbox for example) 2a) Go to Administration > Search engine configuration, click "Reset mappings" and confirm 2b) Then reindex 3) Search for an author name found only in 710 using the Author (Corporate name) index in advanced search Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:53:05 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add CNI (Control Number |Add CNI (Control Number |Identifier) search index |Identifier) search index | |(MARC21) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:53:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:53:24 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123671|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 123679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123679&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. Test Plan: 0) Install the Perl library Parallel::Loops 1) Generate a huge number of holds ( a few thousand at the minimum ) 2) Run the holds queue builder, use the `time` utility to track how much time it took to run 3) Set HoldsQueueParallelLoopsCount to 10 4) Repeat step 2, note the improvement in speed 5) Experiment with other values for HoldsQueueParallelLoopsCount 6) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 13:53:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 11:53:57 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 --- Comment #3 from Katrin Fischer --- Kind of wondering, why it took us THAT long to add this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:02:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:02:41 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- I checked the LOC documentation, but it appears there is no standard attribute for 003, so using 9014 is fine (https://www.loc.gov/z3950/agency/bib1.html) Martin, could you please add the indexing changes for Elasticsearch in a follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:02:53 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #7 from Marcel de Rooy --- Even when I do: - 'aqbasket' => $basketno, + # 'aqbasket' => $basketno, I still have the basket name in the test output? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:03:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:03:02 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:03:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:03:05 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #14 from Owen Leonard --- Created attachment 123680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123680&action=edit Bug 10902: (follow-up) Account for singleBranchMode This patch checks singleBranchMode before highlighting the current branch in search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:08:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:08:41 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #8 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #7) > Even when I do: > > - 'aqbasket' => $basketno, > + # 'aqbasket' => $basketno, > > I still have the basket name in the test output? I had a library claim once the wrong notice would be sent, if the basket name was the same... now I wonder...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:10:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:10:28 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #9 from Katrin Fischer --- Sorry, probably totally off with the last comment - time for a break. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:14:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:14:04 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:14:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:14:08 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123587|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 123681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123681&action=edit Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Signed-off-by: David Nind Signed-off-by: Sally Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:14:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:14:13 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123588|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 123682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123682&action=edit Bug 10902: (QA follow-up) Show library name instead of code This patch modifies the patron search autocomplete so that library name is shown instead of library code. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:14:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:14:18 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123639|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 123683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123683&action=edit Bug 10902: (follow-up) Fix patron search autocomplete The circulation search autocomplete (e.g. from circulation.pl search header) was corrected in the previous patch to include library name instead of branchcode. This patch makes the same correction for patron search autocomplete (e.g. from members-home.pl search header). Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:14:22 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123680|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 123684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123684&action=edit Bug 10902: (follow-up) Account for singleBranchMode This patch checks singleBranchMode before highlighting the current branch in search results. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:16:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:16:43 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > Even when I do: > > - 'aqbasket' => $basketno, > + # 'aqbasket' => $basketno, > > I still have the basket name in the test output? Debugging Letters :) The info is in the $repeat and is filled in when reaching the repeat no enclosing tags block. my vendor|John Smith|<>|Ordernumber <> (<>) (<> ordered)my vendor|J ohn Smith|Named basket|Ordernumber 114 (Silence in the library) (1 ordered) In that block basketname is replaced. And not via $tables ! This essentially means that the second patch does nothing for the orderacquistion notice. The unit test shows that you can fill basketname via $repeat but actually has no real added value. FQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:17:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:17:31 +0000 Subject: [Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:20:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:20:06 +0000 Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a failed response even when cancellation succeeds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22456 CC| |magnus at libriotech.no --- Comment #6 from Magnus Enger --- Is it a bit weird that waiting holds can be cancelled via SIP2, but not the UI? See bug 22456. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:20:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:20:06 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28464 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:44:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:44:57 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:45:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:45:38 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:46:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:46:28 +0000 Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:50:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:50:17 +0000 Subject: [Koha-bugs] [Bug 28695] Add shelving location column to overdue report (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28695 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122684|0 |1 is obsolete| | --- Comment #2 from sandboxes at biblibre.com --- Created attachment 123685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123685&action=edit Bug 28695: add shelving location column to overdue.tt To test: 1. have some overdues 2. go to the overdue report on the circulation page (overdue.tt) 3. no shelving location 4. apply patch and restart the things 5. look at the overdue report again and there should be a Shelving location column 6. make sure it is accurate 7. go to table settings and make sure you can properly hide the column. test other columns in the table and make sure they are still hiding correctly as well Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 14:51:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 12:51:44 +0000 Subject: [Koha-bugs] [Bug 28695] Add shelving location column to overdue report (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28695 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:10:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:10:46 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #47 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #46) > > But note also that Agustin still needs to respond to comment41. This is not > fixed yet. It works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:11:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:11:01 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:11:05 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123461|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123686&action=edit Bug 28804: (bug 25026 follow-up) Handle SQL errors in reports Since bug 25026 DBMS errors are raised, but the report module is not dealing correctly with the errors. If an error occurred in execute_query, next queries will fail as well, we should skip them. Test plan: 1. Create report from SQL queries, containing errors (invalid syntax, etc.) 'SELECT id FROM borrowers' can do it 2. Execute the query => Without this patch you get a 500 => With this patch applied you see that the error raised at DBMS level is propagated to the UI 3. Confirm that there is no regression on valid queries Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:15:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:15:22 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123666|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 123687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123687&action=edit Bug 28828: Fix unimarc_field_4XX.tt and marc21_linking_section.tt value builders Find closest ul for value builders. Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong: var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); Test plan 1: 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Test plan 2: 1) Use a MARC_21 DB 2) Define plugin marc21_linking_section.pl on 773$t 3) Make sure 773$t and other subfields are visible in intranet/editor 4) Create a new record in basic cataloging editor 5) Click on value builder in 773$t 6) Search fro a record 7) Click on "Choose" => Without patch fields are not fileld => With patch subfields are correctly filled Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:17:07 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #10 from David Nind --- (In reply to Katrin Fischer from comment #8) > Hi Frido or David, could one of you have a final look here? I've chosen > Nick's alternate and changed the bug title to reflect that this now fixes 2 > different value builders. I have run through the updated test plan and everything works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:18:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:18:30 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Katrin Fischer --- Thanks a lot David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:18:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:18:37 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Tomás Cohen Arazi --- (In reply to David Nind from comment #7) > Hi Agustín. > > There are errors when running the database update: Hi David, thanks for taking the time to test this! I've just applied bug 27946 and then this one, and the database update ran smoothly. Please try again! It seems that you didn't have 27946 DB upgrade applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:26:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:26:18 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123679|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 123688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123688&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. Test Plan: 0) Install the Perl library Parallel::ForkManager 1) Generate a huge number of holds ( a few thousand at the minimum ) 2) Run the holds queue builder, use the `time` utility to track how much time it took to run 3) Set HoldsQueueParallelLoopsCount to 10 4) Repeat step 2, note the improvement in speed 5) Experiment with other values for HoldsQueueParallelLoopsCount 6) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:27:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:27:39 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123688|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 123689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123689&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. Test Plan: 0) Install the Perl library Parallel::ForkManager 1) Generate a huge number of holds ( a few thousand at the minimum ) 2) Run the holds queue builder, use the `time` utility to track how much time it took to run 3) Set HoldsQueueParallelLoopsCount to 10 4) Repeat step 2, note the improvement in speed 5) Experiment with other values for HoldsQueueParallelLoopsCount 6) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:49:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:49:48 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:49:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:49:52 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123370|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 123690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123690&action=edit Bug 28779: Skip processing of non-existent biblios Just checking with a regex that whether an input looks like a biblionumber is not enough, we need to also verify there is a biblio really existing in the database and skip processing of hold request for non-existent biblionumbers. To test: 1) Go to page /cgi-bin/koha/reserve/request.pl?biblionumbers=XXXXX where XXXXX is non-existent biblionumber, notice internal server error 2) Apply patch 3) Repeat step 1 and notice we cannot place a hold Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:49:56 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123371|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 123691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123691&action=edit Bug 28779: (QA follow-up) More specific message and soem cleanup Signed-off-by: Nick Clemens Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:50:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:50:01 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 --- Comment #15 from Katrin Fischer --- Created attachment 123692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123692&action=edit Bug 28779: (QA follow-up) Even more specific message For the detail page, the MARC view etc. we use the text: The record you requested does not exist (488). I think this is better than "not found", because that sounds like it might be an issue with the search index, which we can rule out in this case. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:52:19 +0000 Subject: [Koha-bugs] [Bug 26656] Expiration date on waiting holds appears as editable but changes aren't saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 25619 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:52:19 +0000 Subject: [Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- *** Bug 26656 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:55:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:55:25 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to adjust |Updating an expiration date |expiration date for waiting |for a waiting hold won't |holds |save -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:59:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:59:50 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 15:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 13:59:55 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122929|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 123693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123693&action=edit Bug 25619: Add ability to adjust expiration date for waiting holds There are times when an item that is waiting for pickup needs to have the expiration date extended. This would give staff the ability to modify one by one, as needed, the reserves.expirationdate for a given item awaiting pickup. Test Plan: 1) Place a hold, trap an item for it such that is is waiting 2) Attempt to update the expiration date 3) Note the new date is not saved 4) Apply this patch, restart all the things! 5) Attempt to update the expiration date 6) The new date should be saved! Signed-off-by: Abbey Holt Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:00:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:00:01 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122930|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 123694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123694&action=edit Bug 25619: Unit Tests Signed-off-by: Abbey Holt Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:00:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:00:07 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123043|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 123695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123695&action=edit Bug 25619: (QA follow-up) Fix subtest description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:02:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:02:21 +0000 Subject: [Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:06:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:06:57 +0000 Subject: [Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 S. Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com --- Comment #2 from S. Brown --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:10:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:10:25 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:10:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:10:29 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123354|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123696&action=edit Bug 27847: Don't obscure page when checkin modal is non-blocking This patch changes the series of events striggered when a non-blocking modal dialog is displayed during checkin. If the "TransfersBlockCirc" preference is set to "Don't block," the user can continue to check in even though a transfer dialog has appeared. This patch hides the modal's "backdrop" element so that the modal doesn't look like one which blocks further action. There is no Bootstrap backdrop option which both hides the backdrop and makes it non-blocking, so we have to use the default non-blocking option and "manually" hide the backdrop. The "show.bs.modal" event must be added in order to make the necessary change before the modal is displayed. This prevents the darkened backdrop from appearing and then being hidden. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Set the "TransfersBlockCirc" preference to "Don't block." - Check in an item which belongs to another library. - A modal dialog should be displayed: "Please return this item to XXX" - The page "behind" the modal should not be darkened, and the cursor focus should remain in the check-in field. - Checking in an item which as a hold should still trigger the "blocking" behavior: The modal must be dismissed by clicking one of its buttons (not the backdrop) and the page behind the modal should be darkend. - Test with "TransfersBlockCirc" set to "Block." Checking in an item belonging to another library should trigger the "blocking" modal behavior. - Test that other checkins still work correctly. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:13:32 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123616|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 123697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123697&action=edit Bug 28830: Add cni index for 003 This patch adds the cni/Control-number-identifier index to enable searches to use the 003 field. Test plan 1/ Apply patch 2/ Re-index using updated configurations 3/ Confirm cni:number searches yield the expected results 4/ Signoff Split-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:15:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:15:14 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Martin Renvoize --- Good catch, seems I missed the ES bit from the other bug.. added into the patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:15:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:15:45 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123368|0 |1 is obsolete| | --- Comment #8 from sandboxes at biblibre.com --- Created attachment 123698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123698&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:15:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:15:49 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123462|0 |1 is obsolete| | --- Comment #9 from sandboxes at biblibre.com --- Created attachment 123699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123699&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:15:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:15:52 +0000 Subject: [Koha-bugs] [Bug 28837] New: Enhancement: Exclude patron category from fines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28837 Bug ID: 28837 Summary: Enhancement: Exclude patron category from fines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It could be helpful to be able to exclude an entire patron category from fines without having to create a separate set of circ/fine rules for them - for instance, library staff or youth. If it were a new section set in ‘Circulation and fine rules’, it could be defaulted for all libraries or customized per library, which would allow for a good deal of flexibility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:17:07 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #10 from Barbara Johnson --- This works and the visual presentation is very clear. I like using the x for Ignore and the trash can for Cancel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:17:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:17:12 +0000 Subject: [Koha-bugs] [Bug 28838] New: SCO impossible errors are hard to target with CSS/JS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Bug ID: 28838 Summary: SCO impossible errors are hard to target with CSS/JS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On sco-main.tt if a patron checks out something that is 'impossible' to check out via SCO they are presented with one of many reasons why the item cannot be checked out: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. If we could wrap each of these messages in a span with a unique ID it will be easier to change text/target each individual message with CSS/JS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:23:01 +0000 Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target with CSS/JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:23:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:23:05 +0000 Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target with CSS/JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 --- Comment #1 from Lucas Gass --- Created attachment 123700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123700&action=edit Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a with an ID. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:23:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:23:18 +0000 Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target with CSS/JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:24:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:24:49 +0000 Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target with CSS/JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:25:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:25:45 +0000 Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target with CSS/JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds unique ID's release notes| |to the SCO main page so the | |impossible errors can | |easily be targeted via JS | |and CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:33:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:33:20 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #48 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #47) > (In reply to Marcel de Rooy from comment #46) > > > > But note also that Agustin still needs to respond to comment41. This is not > > fixed yet. > > It works for me. Hmm. I guess you need to explain me :) Or read earlier comments more closely? The staff interface tells me now Article requests: 1. If I click on the link, I come in the New tab which lists no requests. The Pending tab contains one request, Processing 2. And now the code: The template shows: [% pending_article_requests | html %] Hote that pending is not the correct term anymore. These should be New. mainpage.pl contains: my $pending_article_requests = Koha::ArticleRequests->search_limited( { status => Koha::ArticleRequest::Status::Pending, $branch ? ( 'me.branchcode' => $branch ) : (), } )->count; Again, dont be misled by the bad variable names here. We should refer to New. Could you please explain how this produces the number of New requests on the main page :) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:33:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:33:42 +0000 Subject: [Koha-bugs] [Bug 26861] Indicate that a record is using OpacHiddenItems in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 --- Comment #6 from Christopher Brannon --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:36:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:36:34 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #49 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #46) > But note also that Agustin still needs to respond to comment41. This is not > fixed yet. Or comment31 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:39:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:39:57 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Marcel de Rooy --- On top of 27946: Applying: Bug 27945: Add tests Using index info to reconstruct a base tree... M t/db_dependent/ArticleRequests.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/ArticleRequests.t CONFLICT (content): Merge conflict in t/db_dependent/ArticleRequests.t error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:41:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:41:01 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #9) > On top of 27946: > > Applying: Bug 27945: Add tests > Using index info to reconstruct a base tree... > M t/db_dependent/ArticleRequests.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/ArticleRequests.t > CONFLICT (content): Merge conflict in t/db_dependent/ArticleRequests.t > error: Failed to merge in the changes. Wait thats not correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:42:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:42:28 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #11 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > (In reply to Marcel de Rooy from comment #9) > > On top of 27946: > > > > Applying: Bug 27945: Add tests > > Using index info to reconstruct a base tree... > > M t/db_dependent/ArticleRequests.t > > Falling back to patching base and 3-way merge... > > Auto-merging t/db_dependent/ArticleRequests.t > > CONFLICT (content): Merge conflict in t/db_dependent/ArticleRequests.t > > error: Failed to merge in the changes. > > Wait thats not correct It does apply correctly. Wrong base.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:44:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:44:08 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #12 from Marcel de Rooy --- FAIL opac/opac-request-article.pl OK critic FAIL forbidden patterns forbidden pattern: Use of Data::Printer, should only be used for devlopment purpose (line 85) OK git manipulation OK pod SKIP spelling FAIL valid Can't locate Data/Printer.pm in @INC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:44:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:44:48 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:46:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:46:01 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #50 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #48) > (In reply to Tomás Cohen Arazi from comment #47) > > (In reply to Marcel de Rooy from comment #46) > > > > > > But note also that Agustin still needs to respond to comment41. This is not > > > fixed yet. > > > > It works for me. > > Hmm. I guess you need to explain me :) Or read earlier comments more closely? I was looking at the wrong thing: if it was possible to set a request as pending. Which was Agustin's answer. Taking a closer look now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 16:54:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 14:54:18 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 --- Comment #5 from Katrin Fischer --- Because I got a question about this bug off-bugzila: What I saw in testing: * When checking in an item with no holds, the transfer prompt would pop up, but I could still continue scanning. The background remained accessible and unlocked. * When checking in an item with a hold, the background would lock up and I had to take care of the hold first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 17:08:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 15:08:08 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 17:27:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 15:27:17 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Kelly McElligott --- I signed off on this patch- Kelly McElligott kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 17:32:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 15:32:52 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Lisette Scheer --- Signed off in the Bywater Sandbox. I also checked and you can still search by first name. I do think it's a little strange that the only place to see the first name on the staff client is by editing the patron. Might be confusing if someone is trying to figure out why a patron came up in a search. Excited for this! Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 17:48:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 15:48:39 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123655|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 123702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123702&action=edit Bug 28819: Add item search to intranet-main.tt To test: 1. Apply patch 2. Go to staff main page ( intranet-main.tt ) 3. Now you should see an 'Item search' button and icon. Signed-off-by: kelly mcelligott Signed-off-by: kelly mcelligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 17:48:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 15:48:58 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123702|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 123703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123703&action=edit Bug 28819: Add item search to intranet-main.tt To test: 1. Apply patch 2. Go to staff main page ( intranet-main.tt ) 3. Now you should see an 'Item search' button and icon. Signed-off-by: kelly mcelligott Signed-off-by: kelly mcelligott Signed-off-by: kelly mcelligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 17:53:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 15:53:10 +0000 Subject: [Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #7 from Kelly McElligott --- I have signed off on this : Kelly McElligott kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:00:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:00:27 +0000 Subject: [Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122920|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 123704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123704&action=edit Bug 28719: Change somes links in the serials page to avoid them leading to nothing Signed-off-by: kelly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:02:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:02:00 +0000 Subject: [Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:14:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:14:17 +0000 Subject: [Koha-bugs] [Bug 9264] Make getitems default sort to set by a preference instead of hard coded to homebranch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27295|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 123705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123705&action=edit Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way. NOTE: I only rebased to make it apply. I still think Owen's feedback in comment #4 still applys. Hence the move from 'Patch does not apply' to 'In Discussion'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:15:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:15:23 +0000 Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122543|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 123706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123706&action=edit Bug 28653: Add new method RefreshIssuesTable On patrons check out or details page, after renewing loans they don't sort correctly when clicking on "Date due" tab. Page has to be reloaded so that sorting works. This patch adds new method RefreshIssuesTable to checkouts.js. When loans are renewed or checked in, issues table is reloaded to and due dates are sorted correctly. To test: 1. Add 3 loans for patron. 2. Change due dates so you they are e.g. 07/01, 07/02, 07/04 3. Make sure you have renewal period set e.g. 5 days and check your RenewalPeriodBase syspref (I use current date there) 4. Renew loan with date due on 07/01, it should now be 07/07 5. Sort loans by date due => Note that order from top to bottom is 07/04->07/02->07/07 or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would assume. 6. Apply patch and repeat. => Note that issues table is reloaded ("Loading..." pop-up is displayed) and that due dates are in correct order. Sponsored-by: Koha-Suomi Oy Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:15:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:15:41 +0000 Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:22:46 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kelly at bywatersolutions.com --- Comment #8 from Kelly McElligott --- This is fantastic, I love it. But,...it would be nice to see this on the Advanced Editor Cataloging module as well! Thank you for all you do !!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:31:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:31:10 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:31:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:31:13 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122340|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 123707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123707&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected 9 - Repeat for the advanced cataloging editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:32:49 +0000 Subject: [Koha-bugs] [Bug 9264] Make getitems default sort to set by a preference instead of hard coded to homebranch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- (In reply to Owen Leonard from comment #4) > (In reply to comment #3) > > 3) Test the sorting order for items with the preference set each way. > > This step is a little vague. In order to be thorough what places in Koha > should we test? The most obvious choice, detail.pl, can't be properly tested > because it has a JS-based tablesorter which overrides default sorting > (something which should at the very least be addressed in a follow-up). I can't see that this has affect anywhere, most pages are loading a datatables so the sorting is overridden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:34:09 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #14 from Kelly McElligott --- Hi ! Tried to sign off on this bug and received this error: Can't call method "date_due" on an undefined value at /kohadevbox/koha/C4/Members.pm line 702 Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:34:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:34:15 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123199|0 |1 is obsolete| | --- Comment #13 from sandboxes at biblibre.com --- Created attachment 123708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123708&action=edit Bug 14783: Change pickup location from opac. This patch allows users to change the pickup location for their holds from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what stage a hold can be changed. To test: 1. Set up holds with diffrent statuses for a patron (pending, waiting, in transit, suspended) 2. No pickup locations for any hold should be able to be changed. 3. Turn on and off the different options under OPACAllowUserToChangeBranch. Make sure that only the corresponding holds can be changed from the opac. Check eg in the staff client that pickup location has changed. 4. The available pickup locations should respect any transfer restrictions. (Same as the holds list for a biblio in staff client) 5. For an in-transit hold: Check in the item at the original pickup location. 6. Note that it will be redirected to the new location. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:34:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:34:18 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123271|0 |1 is obsolete| | --- Comment #14 from sandboxes at biblibre.com --- Created attachment 123709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123709&action=edit Bug 14783: (follow-up) Move pickup library form into modal This patch attemps to simplify the list of holds by moving the form for changing a hold's pickup library into a modal dialog. This patch also makes minor tweaks to the CSS for the "X" close button shown in modal in windows. Instances where modal markup used "x" have been updated to use the Bootstrap 4 standard "×" To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Turn on the OPACAllowUserToChangeBranch system preference. - Log in to the OPAC as a user with holds. - In the view of your holds, confirm that each hold which can be modified shows a "Change" link. - Clicking the link should show a modal window with the title of the item on hold shown in the header. - Confirm that changing the pickup location works correctly. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:38:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:38:32 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Kelly McElligott --- This is fantastic- quick work! I signed off on this: Kelly McElligott kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:39:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:39:37 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:44:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:44:10 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #51 from Tomás Cohen Arazi --- Created attachment 123710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123710&action=edit Bug 27944: REQUESTED is the new default status Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:44:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:44:15 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #52 from Tomás Cohen Arazi --- Created attachment 123711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123711&action=edit Bug 27944: (QA follow-up) Rename ->open for ->set_pending Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:44:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:44:21 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #53 from Tomás Cohen Arazi --- Created attachment 123712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123712&action=edit Bug 27944: (QA follow-up) Make staff home page show new article requests As exposed on comment 29, the current code is showing the 'pending' requests when it should display 'requested' ones (i.e. the new ones). This patch changes that accordingly. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:44:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:44:48 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:49:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:49:07 +0000 Subject: [Koha-bugs] [Bug 28695] Add shelving location column to overdue report (overdue.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28695 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123685|0 |1 is obsolete| | --- Comment #3 from sandboxes at biblibre.com --- Created attachment 123713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123713&action=edit Bug 28695: add shelving location column to overdue.tt To test: 1. have some overdues 2. go to the overdue report on the circulation page (overdue.tt) 3. no shelving location 4. apply patch and restart the things 5. look at the overdue report again and there should be a Shelving location column 6. make sure it is accurate 7. go to table settings and make sure you can properly hide the column. test other columns in the table and make sure they are still hiding correctly as well Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:49:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:49:29 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #54 from Tomás Cohen Arazi --- Marcel, I think I addressed the issues you highlighted. - Tests pass (they weren't passing) - Renamed 'open' to set_pending/pending. We could even open a new bug report to refactor the whole thing. I think it doesn't comply with our current practices in the codebase. Will address on a separate bug. - You were right about the bad search, fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:57:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:57:44 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 18:58:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 16:58:05 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123220|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi --- Created attachment 123714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123714&action=edit Bug 27945: Add limit article request feature This patch makes it possible to limit article requests per patron per day. To test: 1. Apply patches 2. updatedatabase 3. Enable ArticleRequests preference 4. Edit a patron category and set an article request limit to 1 CHECK => if you set the limit to anything else but a positive number or empty string, a warning appears 5. In staff search biblios and request an article for a patron of the modified category 6. Repeat step 5 SUCCESS => if limit is reached, when you select the user to request an article a warning appears saying that the limit was reached 7. Repeat steps 5 and 6 but this time in opac SUCCESS => Patron is not allowed to request another article if limit is reached 8. prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:00:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:00:28 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #31 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #29) > # Subtest: call_recursive() tests > 1..6 > ok 1 - Got back one element > not ok 2 - Got expected response > # Failed test 'Got expected response' > # at t/db_dependent/Koha/Plugins/Plugins.t line 97. > # got: '1' > # expected: '4' > ok 3 - Got back one element > ok 4 - Got expected response > ok 5 - Got back one element > ok 6 - call_recursive should return the original arguments if plugins > are disabled > # Looks like you failed 1 test of 6. > not ok 6 - call_recursive() tests Same here, @khall? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:04:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:04:49 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 123715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123715&action=edit Bug 27945: (QA follow-up) Fix exception POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:31:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:31:11 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:38:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:38:41 +0000 Subject: [Koha-bugs] [Bug 28834] Bad wording biblios/authorities in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123660|0 |1 is obsolete| | --- Comment #2 from sandboxes at biblibre.com --- Created attachment 123716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123716&action=edit Bug 28834: Correct wording biblios/authorities in tools home In tools home, we actually see 2 wordings : biblios/bibliographic authorities/authority Looks like bibliographic is more correct. Test plan : 1) Apply patch and look at words in tools home /cgi-bin/koha/tools/tools-home.pl Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:39:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:39:03 +0000 Subject: [Koha-bugs] [Bug 28834] Bad wording biblios/authorities in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:50:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:50:27 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121698|0 |1 is obsolete| | --- Comment #2 from sandboxes at biblibre.com --- Created attachment 123717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123717&action=edit Bug 28525: Dont let TinyMCE do code cleanup To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like 'TEST' 6. It's cleaned up by the editor. 7. Try something like '' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:50:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:50:54 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:56:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:56:21 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- CC|timothy_alexis.vass at ub.lu.s | |e | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 19:59:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 17:59:49 +0000 Subject: [Koha-bugs] [Bug 26761] Use aria-disabled attribute in OPAC cart for disabled links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | URL| |https://a11y-101.com/develo | |pment/aria-disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 20:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 18:00:24 +0000 Subject: [Koha-bugs] [Bug 26761] Use aria-disabled attribute in OPAC cart for disabled links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 20:00:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 18:00:28 +0000 Subject: [Koha-bugs] [Bug 26761] Use aria-disabled attribute in OPAC cart for disabled links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123348|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 123718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123718&action=edit Bug 26761: Use aria-disabled attribute in OPAC cart for disabled links This patch adds "aria-disabled" attributes to disabled links in the Cart, and adds JS to change the value from "true" to "false" when the links are enabled. The goal is to make the interface more informative to users of screen readers. To test, apply the patch and add some items to the Cart in the OPAC. - Inspect the markup of controls like "Remove", "Place hold," etc. Each should look disabled (grey) and has the correct aria-disabled attribute value. - Select one or more checkboxes. The links should be come active, and the aria-disabled attribute shoulk now be "false." - Deselect all checkboxes. The links should now be disabled. Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 20:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 18:01:06 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:00:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:00:26 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #55 from Katrin Fischer --- Been following the comments here all day and keep wondering - what are the new status named? I have seen new and pending - but they kind of are the same to me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:45:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:45:32 +0000 Subject: [Koha-bugs] [Bug 28839] New: Better texts in stage MARC for import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Bug ID: 28839 Summary: Better texts in stage MARC for import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:45:53 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:46:04 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:46:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:46:08 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123662|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 123719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123719&action=edit Bug 28835: Fix ability to pass list contents to batch record modification Bug 12759 added the ability to pass list contents to batch record modification/deletion tools. Patch Bug 22417 [Restore the 'add to list' feature] removed the fetch of lists in batch_record_modification.pl I don't understand why. It still exists in batch_delete_records.pl. Note that this is needed when first form is displayed. Test plan : 1) Create a private and a public list of records 2) Open Tools > Batch record modification 3) Check you can use the lists 4) Open Tools > Batch record deletion 5) Check you can use the lists Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:52:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:52:16 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:52:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:52:20 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #1 from Fridolin Somers --- Created attachment 123720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123720&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:53:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:53:46 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #2 from Fridolin Somers --- Created attachment 123721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123721&action=edit Screenshot without patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 10 23:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 21:54:11 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #3 from Fridolin Somers --- Created attachment 123722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123722&action=edit Screenshot with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:00:06 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- I also cannot get the forward button to work after using the back button. Also, if I click "A", then "B" then "C", then "D" it takes me to each of those pages correctly. But if I start pressing the back button I can go back to "C" but no further. If I try to go back any further I see the 'Processing...' box for a split second but noting happens. I am testing in Chrome and FF on MacOS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:01:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:01:23 +0000 Subject: [Koha-bugs] [Bug 28840] New: Better texts in batch record modification/deletion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Bug ID: 28840 Summary: Better texts in batch record modification/deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:01:33 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:01:45 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28839 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:01:45 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28840 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:04:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:04:44 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:04:48 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #1 from Fridolin Somers --- Created attachment 123723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123723&action=edit Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:05:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:05:24 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #2 from Fridolin Somers --- Created attachment 123724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123724&action=edit Screenshot with patch (modification) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:05:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:05:48 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #3 from Fridolin Somers --- Created attachment 123725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123725&action=edit Screenshot with patch (deletion) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 00:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 22:34:28 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #64 from Alex Buckley --- (In reply to Marcel de Rooy from comment #63) > Hmm. I do fear that we still need another QA iteration step. Sorry for that. Thanks for your QA work Marcel. I will attempt to keep my responses fast, but will probably not be able to attach amended patches till the end of this week/early next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:07:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:07:18 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:07:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:07:21 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123209|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 123726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123726&action=edit Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:07:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:07:25 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 --- Comment #4 from Katrin Fischer --- Created attachment 123727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123727&action=edit Bug 28727: (QA follow-up) Simplify permission check There was another permission check for edit_items directly below, so instead of changing them to both be edit_items, I think we can now remove one. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:08:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:08:38 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bad wording |Improve wording |biblios/authorities in |biblios/authorities in |tools home |tools home -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:08:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:08:50 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve wording |Improve wording |biblios/authorities in |biblios/authorities on |tools home |tools home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:11:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:11:10 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:11:15 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123716|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 123728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123728&action=edit Bug 28834: Correct wording biblios/authorities in tools home In tools home, we actually see 2 wordings : biblios/bibliographic authorities/authority Looks like bibliographic is more correct. Test plan : 1) Apply patch and look at words in tools home /cgi-bin/koha/tools/tools-home.pl Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:11:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:11:16 +0000 Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Nice. But why not using like rebuild_zebra.pl Koha::RecordProcessor and Koha::Filter::MARC::EmbedSeeFromHeadings ? Code looks the same no ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:18:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:18:13 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 --- Comment #3 from Katrin Fischer --- Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:19:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:19:00 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:19:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:19:03 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123719|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123729&action=edit Bug 28835: Fix ability to pass list contents to batch record modification Bug 12759 added the ability to pass list contents to batch record modification/deletion tools. Patch Bug 22417 [Restore the 'add to list' feature] removed the fetch of lists in batch_record_modification.pl I don't understand why. It still exists in batch_delete_records.pl. Note that this is needed when first form is displayed. Test plan : 1) Create a private and a public list of records 2) Open Tools > Batch record modification 3) Check you can use the lists 4) Open Tools > Batch record deletion 5) Check you can use the lists Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:23:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:23:44 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer --- Can you please check the QA tools? I am having this failure: FAIL t/Search.t FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). OK forbidden patterns OK git manipulation OK pod OK spelling OK valid Also the tests are failing: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/Search.t t/Search.t .. 1/4 # No tests run! # Failed test 'No tests run for subtest "searchResults PassItemMarcToXSLT test"' # at t/Search.t line 207. Undefined subroutine &main::searchResults called at t/Search.t line 197. # Looks like your test exited with 255 just after 4. t/Search.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/4 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:55:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:55:51 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:55:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:55:56 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:56:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:56:02 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:56:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:56:43 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 123730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123730&action=edit Bug 24387: Rename "News" with "Additional contents" One big patch for one big move. The "News" feature (opac_news) has been hijacked to handle some system preferences (bug 26050). The goal was to take profit of the UI (editor) and the ability to translate the value. Disclaimer: This patch is NOT offering the best implementation but, as we still don't have bug 24975, it cannot be done now. And no, we don't want to wait for it to move forward here. This patch is going into the right direction anyway. This enhancement is going to rename the "News" with a more genertic "Additional contents". We have two different "categories" of content: "news" and "html customizations". What does it bring? - A split on the UI for disambigate the two types of content (news and syspref/html customizations) - A simplification of the edit form: all languages will be translatable on the same view (like the "notice templates") - Ground will be prepared for different types of content (if needed later) - Staff news can be translated How was the "News" area working before this patch? The opac_news DB table contained a (very inconsistent) 'lang' column. The different values were: - '' => news to display at the OPAC and staff interfaces - 'koha' => news for staff only - 'slip' => news for slip notices - $lang => news for OPAC only, translated in $lang ('en', 'es-ES', etc.) - "$location_$lang" => A syspref moved to this "news" area. The syspref is $location, and is translated in $lang. Eg. OpacLoginInstructions_en, OpacLoginInstructions_fr-FR, opacheader_es-ES This patch is improving the DB structure with the following changes: - renaming 'opac_news' with 'additional_contents' - new 'category' column => 'news' or 'html_customizations' - new 'location' column => For 'news': 'staff_and_opac', 'staff_only', 'slip' => For 'html_customizations': the old syspref name (eg. 'OpacLoginInstructions'). - new 'code' column (see later for more info) - the 'lang' column will only contain the language code ('en', 'es-ES', etc.). BUT a 'default' entry will ALWAYS exist for fallback behaviour. We are getting closer to the 'notice template' table structure because we want to match its UI. The 'code' column will bring us the ability to group the different 'additional_contents' rows. The code for a given news will be the same, but the (lang, title, content) will differ. Examples: News 1 will have, for each of the translated versions (category, code, location, branchcode) ('news', 'News1', $location, $branchcode||undef) And the 3 following columns will differ: (title, content, lang) ('title for news 1', 'content for news 1', 'default') ('titulo para 1', 'contenido para 1', 'es-ES') Note that the "category" is not strictely necessary, but it seems better to have the ability to split the different content by category/type easily. Additional changes: - Syspref 'NewsToolEditor' is renamed 'AdditionalContentsEditor' - Koha::NewItem => Koha::AdditionalContent - Koha::News => Koha::AdditionalContents - Script and template renamed from koha-news to additional-contents - Foreign keys have been renamed - Subpermission edit_news has been renamed edit_additional_contents - The UI can now be accessed via a "News" or "HTML customizations" link from the tools module. The related contents will then be displayed (both categories are now split) Changes not done here: - Primary key 'idnew' could be renamed 'id' Limitations of the upgrade: News cannot be grouped by a unique code for existing translations. => A given news will be now displayed several times on the translated interface Any ideas to improve the upgrade behaviour? We will have to add a warning in the release notes to tell libraries to review their news. Test plan: 0. Don't apply the patches 1. Translate the interfaces in some languages . Create some news for staff and OPAC . Create some content for different entry of HTML customizations Note that you are forced to define a 'default'. Also note that you are only forced to fill the title (not the content). This is certainly problematic (see FIXME in the code) as sometime only the content is displayed. . Play with the interface (edit, delete, filter) . Go to the different places the news are displayed, and confirm they are displayed correctly (staff home, opac home, opac rss) . Create 1+ news for 'slip', check an item out and 'print slip' (from the circulation page). You must see the news. . Go to the different places you are expecting the HTML customizations to be present and confirm that you see them. . Switch the lang of the interface and confirm that you now see the content in the translated version . Generate the templates in another language, don't translate the content . Use this language for the interface and confirm that the 'default' version is displauyed. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:56:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:56:51 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 123731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123731&action=edit Bug 24387: Fix location options when editing HTML custom Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:56:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:56:59 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 123732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123732&action=edit Bug 24387: DBIC schema changes Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:57:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:57:06 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 123733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123733&action=edit Bug 24387: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 01:57:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Aug 2021 23:57:14 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 123734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123734&action=edit Bug 24387: (QA follow-up) Fix method import issues Raised by the QA script, a couple issues carried by pre-17600 patches. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 02:12:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 00:12:53 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 02:34:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 00:34:05 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- This is an interesting one! On one hand, I like the use of a system preference to allow the value to be set on a per-instance basis. On the other hand, letting a library define an unrestricted number of forks for a script seems potentially dangerous, especially if you have multiple Koha instances on the same server. I think this change needs more sanity checks. Some options: 1) A CLI override that doesn't let the $loops be beyond X. This allows a sysadmin to constrain the resource usage 2) Perhaps the size of $bibs_with_pending_requests should correlate with the number of forks up to a maximum. (If you only have 10 bibs but your $loops is 10, it doesn't make sense to have 10 forks of 1 bib each. ) 3) Maybe we should limit nproc in /etc/security/limits.d on a per-user basis (but maybe this is best left to local sysadmins and this is a very blunt instrument) Actually, we should also do a int() check on $loops before feeding it to Parallel::ForkManager, since it is user-provided input. (I suppose a non-number would just cause a fatal error on a $loops > 1 check, but better to not fork than to fail.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 02:40:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 00:40:05 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #10 from David Cook --- Another option might be to use koha-conf.xml instead of a system preference. I think it's important for it to be a configurable value per-instance, but I'm opposed to the idea of library staff being able to determine server resource usage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 02:41:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 00:41:45 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #11 from David Cook --- The following is totally out of scope but inspired by the above: What if default values in koha-conf.xml were determined based on a "profile" provided for koha-create? By default, we'd have permissive values, so that inexperienced people could have the most power possible through the Web UI, since they might not have a sysadmin to update the backend. But we'd have a more restrictive profile that vendors and more experienced people could use to have more locked down/secure Koha instances. I'm trying to think of an approach that could make everyone happy... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 02:51:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 00:51:55 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 --- Comment #14 from David Cook --- Comment on attachment 123393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123393 Bug 28785: Adjust check_cookie_auth calls Review of attachment 123393: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28785&attachment=123393) ----------------------------------------------------------------- Why do this patch instead of having check_cookie_auth return the sessionID instead of the session? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 02:51:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 00:51:57 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 --- Comment #15 from David Cook --- Comment on attachment 123393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123393 Bug 28785: Adjust check_cookie_auth calls Review of attachment 123393: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28785&attachment=123393) ----------------------------------------------------------------- Why do this patch instead of having check_cookie_auth return the sessionID instead of the session? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 02:55:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 00:55:28 +0000 Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #16 from David Cook --- Excited to see this change overall. At some point, I would love to rewrite checkauth... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 06:30:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 04:30:24 +0000 Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 08:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 06:52:56 +0000 Subject: [Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Just came accross this myself.. the same function in additem is also not used as far as I can tell but you appear to have dealt with that in bug 27526. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 08:53:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 06:53:48 +0000 Subject: [Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123353|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 123735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123735&action=edit Bug 28765: Remove sub find_value from batchMod.pl It has never been used and should be removed Test plan: Search for "find_value" in the file and confirm that there is no more occurrence Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 08:54:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 06:54:03 +0000 Subject: [Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Trivial fix, PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:00:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:00:28 +0000 Subject: [Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- I jump into the discussion. Template contains : [% UNLESS noautorenew_checkouts %] Surely this column must be added to borrowers.json. Switching the all feature off is in my opinion another problem. PS : I think patch need rebase because of : Bug 11879: (follow up) Some fixes and code cleanup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:04:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:04:25 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123617|0 |1 is obsolete| | Attachment #123618|0 |1 is obsolete| | Attachment #123619|0 |1 is obsolete| | Attachment #123620|0 |1 is obsolete| | Attachment #123621|0 |1 is obsolete| | Attachment #123622|0 |1 is obsolete| | Attachment #123623|0 |1 is obsolete| | Attachment #123624|0 |1 is obsolete| | Attachment #123625|0 |1 is obsolete| | Attachment #123626|0 |1 is obsolete| | Attachment #123627|0 |1 is obsolete| | Attachment #123628|0 |1 is obsolete| | Attachment #123629|0 |1 is obsolete| | Attachment #123630|0 |1 is obsolete| | Attachment #123631|0 |1 is obsolete| | Attachment #123632|0 |1 is obsolete| | Attachment #123633|0 |1 is obsolete| | Attachment #123634|0 |1 is obsolete| | Attachment #123635|0 |1 is obsolete| | Attachment #123636|0 |1 is obsolete| | Attachment #123637|0 |1 is obsolete| | Attachment #123638|0 |1 is obsolete| | --- Comment #256 from Martin Renvoize --- Created attachment 123736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123736&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:04:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:04:32 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #257 from Martin Renvoize --- Created attachment 123737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123737&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:04:39 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #258 from Martin Renvoize --- Created attachment 123738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123738&action=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:04:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:04:45 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #259 from Martin Renvoize --- Created attachment 123739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123739&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:04:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:04:51 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #260 from Martin Renvoize --- Created attachment 123740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123740&action=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:04:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:04:58 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #261 from Martin Renvoize --- Created attachment 123741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123741&action=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:05 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #262 from Martin Renvoize --- Created attachment 123742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123742&action=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:11 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #263 from Martin Renvoize --- Created attachment 123743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123743&action=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:18 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #264 from Martin Renvoize --- Created attachment 123744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123744&action=edit Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:24 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #265 from Martin Renvoize --- Created attachment 123745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123745&action=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:30 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #266 from Martin Renvoize --- Created attachment 123746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123746&action=edit Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:37 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #267 from Martin Renvoize --- Created attachment 123747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123747&action=edit Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:43 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #268 from Martin Renvoize --- Created attachment 123748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123748&action=edit Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:49 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #269 from Martin Renvoize --- Created attachment 123749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123749&action=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:05:56 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #270 from Martin Renvoize --- Created attachment 123750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123750&action=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:06:02 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #271 from Martin Renvoize --- Created attachment 123751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123751&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:06:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:06:09 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #272 from Martin Renvoize --- Created attachment 123752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123752&action=edit Bug 11175: (QA follow-up) Move get_component_part_query This patch removes Koha::Util::Search in preference to embedding the search query builder in Koha::Biblio as get_analytics_query. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:06:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:06:15 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #273 from Martin Renvoize --- Created attachment 123753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123753&action=edit Bug 11175: (QA follow-up) Only get biblio once Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:06:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:06:22 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #274 from Martin Renvoize --- Created attachment 123754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123754&action=edit Bug 11175: (QA follow-up) Fix queries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:06:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:06:28 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #275 from Martin Renvoize --- Created attachment 123755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123755&action=edit Bug 11175: Display components in own tab This patch updates the display so that rather than displaying the components using the main XSLT and then using CSS to move them into a box on the right side for display, which causes issues with RTL records; We instead add them in a new tab beneath the rest of the record details alongside holdings and other details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:06:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:06:34 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #276 from Martin Renvoize --- Created attachment 123756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123756&action=edit Bug 11175: (QA follow-up) Rename back to get_marc_components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:12:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:12:24 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:13:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:13:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|'ShowComponentParts' system |'ShowComponentParts' system |preference. |preference. | | |Upon enabling |Upon enabling |this preference, where a |this preference, where a |record has analytic records |record has analytic records |attached we will replace |attached we will replace |the 'Show analytics' link |the 'Show analytics' link |with a new box on the right |with a new tab below the |of the display containing |record detail containing |links to all the analytic |links to all the component |records. |parts records. | | |The feature is |The feature |set to display a maximum of |is set to display a maximum |300 attached records; if |of 300 attached records; if |more records are found then |more records are found then |a link to the 'Show |a link to the 'Show |analytics' search will |analytics' search will |appear at the bottom of the |appear at the bottom of the |listed analytics. |listed analytics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:31:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:31:59 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 --- Comment #4 from Fridolin Somers --- Bug summary changed : Bad wording biblios/authorities in tools home => Improve wording biblios/authorities in tools home I'm OK with that, its Joubu which insisted on other bugs that summary must tell what the problem is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:18 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122946|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize --- Created attachment 123757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123757&action=edit Bug 27526: Remove ModItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:22 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122947|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 123758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123758&action=edit Bug 27526: Remove AddItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:27 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122948|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 123759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123759&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:32 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122949|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize --- Created attachment 123760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123760&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:36 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122950|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize --- Created attachment 123761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123761&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:41 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122951|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize --- Created attachment 123762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123762&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:46 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122952|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize --- Created attachment 123763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123763&action=edit Bug 27526: Fix PrefillItem We are basically adding: $current_item = $item->unblessed; Other changes are for readability Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:52 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122953|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize --- Created attachment 123764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123764&action=edit Bug 27526: Fix Add & duplicate Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:55:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:55:58 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122954|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize --- Created attachment 123765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123765&action=edit Bug 27526: Fix Add multiple copies This has been moved to Koha::Item->store by bug 27545. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:56:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:56:04 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122958|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize --- Created attachment 123766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123766&action=edit Bug 27526: Fix incorrect condition The barcode was always prefilled! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:56:09 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122959|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize --- Created attachment 123767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123767&action=edit Bug 27526: Fix empty string vs undef Empty strings must be removed, not inserted as empty strings in DB. The relevant code is in TransformHtmlToXml, $skip variable. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:56:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:56:14 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123006|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize --- Created attachment 123768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123768&action=edit Bug 27526: Remove uneeded call to TransformMarcToKoha And also clean some imports. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:56:18 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123007|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize --- Created attachment 123769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123769&action=edit Bug 27526: Fix encoding issue on subfield If you have a "é" subfield it should work! Note that VARCHAR(1) for binary means 1-byte (from MySQL doc): "For example, if the default character set is utf8mb4, CHAR(5) BINARY is treated as CHAR(5) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin. This differs from BINARY(5), which stores 5-byte binary strings that have the binary character set and collation." Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:56:24 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123110|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize --- Created attachment 123770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123770&action=edit Bug 27526: Fix cn_source display For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are calling from Koha::Item->columns_to_str) does not deal with class sources. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:56:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:56:29 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123329|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize --- Created attachment 123771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123771&action=edit Bug 27526: Add missing POD Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:56:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:56:34 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123415|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize --- Created attachment 123772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123772&action=edit Bug 27526: Add tests for columns_to_str and host_items Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 09:58:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 07:58:51 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #100 from Martin Renvoize --- I tested pretty thoroughly but will admit this isn't an area I'm most familiar with. Added my SO line to all the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:22:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:22:19 +0000 Subject: [Koha-bugs] [Bug 17335] waitingreserves.pl cancel button needs simplification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17335 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3288 CC| |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:22:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:22:19 +0000 Subject: [Koha-bugs] [Bug 3288] Transit prompt not immediately triggered after hold is canceled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3288 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17335 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:24:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:24:53 +0000 Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 --- Comment #3 from Fridolin Somers --- Oups indeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:25:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:25:26 +0000 Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:25:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:25:30 +0000 Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122599|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers --- Created attachment 123773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123773&action=edit Bug 28667: Check damaged item can be reserved in OPAC detail pages In OPAC detail pages, damaged items must impact the "place hold" link. This behavior depends on preference AllowHoldsOnDamagedItems. Test plan : 1) Create a record with one damaged item 2) Set AllowHoldsOnDamagedItems to 'Allow' 3) Go to OPAC record detail page : opac-detail.pl 4) Check you see "Place hold" link 5) Set AllowHoldsOnDamagedItems to 'Don't allow' 6) Refresh page 7) Check you don't see "Place hold" link Same tests 2 to 7 for pages opac-ISBDdetail.pl and opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:27:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:27:56 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 --- Comment #5 from Katrin Fischer --- (In reply to Fridolin Somers from comment #4) > Bug summary changed : > > Bad wording biblios/authorities in tools home > => Improve wording biblios/authorities in tools home > > I'm OK with that, its Joubu which insisted on other bugs that summary must > tell what the problem is. Hi Frido, you are right. I just thought that "Bad wording" doesn't sound so nice in the release note. And it's not actually "bad words", just something to turn nicer. We could make it... "needs to be improved" otherwise? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:29:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:29:46 +0000 Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #5 from Fridolin Somers --- Oupsy :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:44:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:44:48 +0000 Subject: [Koha-bugs] [Bug 28841] New: Canceling holds from Waiting Reserves should follow the same rules as for checking in items concerning transfers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28841 Bug ID: 28841 Summary: Canceling holds from Waiting Reserves should follow the same rules as for checking in items concerning transfers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When a Hold is canceled from Waiting Reserves, it is automatically transfered to homebranch if it is different from holdingbranch, ignoring return policy defined in circulation rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:45:10 +0000 Subject: [Koha-bugs] [Bug 28841] Canceling holds from Waiting Reserves should follow the same rules as for checking in items concerning transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28841 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17335 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:45:10 +0000 Subject: [Koha-bugs] [Bug 17335] waitingreserves.pl cancel button needs simplification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17335 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28841 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:58:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:58:22 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #37 from Katrin Fischer --- I believe there might be some problematic constructions for translation in the JavaScript, but need to investigate further: lightbox_descriptions.push("Custom cover image"); lightbox_descriptions.push(_("Image from Google Books (see the original image)").format($(img).data('link'))); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 11:59:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 09:59:00 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #38 from Katrin Fischer --- One more: img.alt = "Cover image"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:15:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:15:32 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use a lightbox gallery to |Use a lightbox gallery to |display the images - detail |display the images on the |page, OPAC interface |detail pages in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:18:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:18:54 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #39 from Katrin Fischer --- There is something weird, if multiple cover providers are activated: - Turn on OpenLibrary covers - Turn on Amazon covers - Search for "perl" - Most books will show 2 covers in results and in the detail pages - Example: CGI programming with Perl - Turn on Google covers - Result list shows 3 - Detail page: only Amazon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:20:40 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:20:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:20:45 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123217|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 123774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123774&action=edit Bug 27945: Add tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:21:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:21:08 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123218|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 123775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123775&action=edit Bug 27945: Add article_request_limit in categories table Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:21:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:21:27 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123219|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 123776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123776&action=edit Bug 27945: [DO NOT PUSH] Update DBIx schema Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:21:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:21:41 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123714|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 123777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123777&action=edit Bug 27945: Add limit article request feature This patch makes it possible to limit article requests per patron per day. To test: 1. Apply patches 2. updatedatabase 3. Enable ArticleRequests preference 4. Edit a patron category and set an article request limit to 1 CHECK => if you set the limit to anything else but a positive number or empty string, a warning appears 5. In staff search biblios and request an article for a patron of the modified category 6. Repeat step 5 SUCCESS => if limit is reached, when you select the user to request an article a warning appears saying that the limit was reached 7. Repeat steps 5 and 6 but this time in opac SUCCESS => Patron is not allowed to request another article if limit is reached 8. prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:21:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:21:57 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123715|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 123778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123778&action=edit Bug 27945: (QA follow-up) Fix exception POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:22:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:22:15 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #40 from Katrin Fischer --- (In reply to Katrin Fischer from comment #37) > I believe there might be some problematic constructions for translation in > the JavaScript, but need to investigate further: > > lightbox_descriptions.push("Custom cover image"); > lightbox_descriptions.push(_("Image from Google Books (see the > original image)").format($(img).data('link'))); They appear to work, at least seeing the strings in the po file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 12:45:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 10:45:14 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #41 from Katrin Fischer --- Please check comment#39. Also: 1) Link to source At the bottom of the lightbox view it says: [provider] cover image (see the original image) I wonder if we could make it clearer here that we are linking to the provider's page as this is an external link where you will leave the library's website. And it won't only be the image you get to. Maybe something along the lines of: (see the original image on the [provider]'s website) A native speaker might come up with a better wording :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:07:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:07:06 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement lets you release notes| |limit the number of article | |requests a patron can make | |each day. Edit the patron | |category and enter the | |'Maximum article scan | |requests'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:10:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:10:29 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #16 from Jonathan Druart --- I think we should add a warning message but let the user continue the process with the available records. No blocking those patches as they are a good enhancement to the current behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:15:03 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Attachment #120284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:16:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:16:05 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #20 from David Nind --- One minor thing I noted after signing off. The column heading in patron categories is 'Maximum request limit' and the edit form says 'Maximum article scan requests'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:18:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:18:25 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 --- Comment #22 from Jonathan Druart --- Created attachment 123779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123779&action=edit Bug 25619: Adjust POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:20:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:20:07 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:22:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:22:17 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123665|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 123780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123780&action=edit Bug 26852: subfield $e missing in X11 definition of MARC21 headings This patch adds $e to 111 and 611, but removes it from 100 and 110 as it's used for the relator term there and should not be copied. Same for 111$j. Test plan: 1. Have a biblio record with, for example, 711 field with a $e subfield. 2. Have two auth records: one with 111 field reflecting the 711 field and second similar but without $e subfield 3. Have LinkerModule set to Default 4. Run link_bibs_to_authorities.pl 5. 711 should remain unlinked since there were two record found by the Default Linker and no one was chosen. 6. Apply the patch. 7. Run link_bibs_to_authorities.pl 8. 711 should be linked now. Repeat testing in similar fashion for authorities: 9. 100/110 $e 10. 111 $j NB zebra index definition is OK: kohaidx:index_match_heading tag="111" subfields="acdefghjklnpqstvxyz" subdivisions="vxyz"> in etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml Signed-off-by: Sara Brown Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:22:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:22:55 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > I've added a sign-off line for "S. Brown" manually using the email address > from the bugzilla account. First name adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:23:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:23:42 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:23:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:23:45 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:23:48 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:23:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:23:50 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:23:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:23:53 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:23:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:23:55 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:23:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:23:58 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:00 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:02 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:05 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:07 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:10 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 --- Comment #17 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:13 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:15 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:18 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:20 +0000 Subject: [Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #16 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:23 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:25 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:28 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:30 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:33 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:35 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:37 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:24:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:24:40 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:28:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:28:46 +0000 Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target with CSS/JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:28:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:28:50 +0000 Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target with CSS/JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123700|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 123781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123781&action=edit Bug 28838: add unique IDs to sco-main.tt impossible errors To test: 1. Apply patch 2. Go SCO and try to checkout some items that will generate some of the following errors: The system does not recognize this barcode. You have checked out too many items and can't check out any more. This item is checked out to someone else. You cannot renew this item again. This item is not for loan. You owe the library [% DEBT | $Price %] and cannot check out. This item has been withdrawn from the collection. This item is restricted. This item is on hold for another patron. This item belongs to another branch. Your account has expired. Your account has been suspended. This card has been declared lost. Your contact information seems to be incomplete. Due date is not valid. Item must be checked out at a circulation desk. 3. The display should be exactly as it was without the patch but if you use the browsers dev tools you should be able to inscept each error message and see that it is now wrapped in a with an ID. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:36:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:36:10 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Tomás Cohen Arazi --- Some DB columns are missing default values (category, code and location): DBD::mysql::db do failed: Field 'code' doesn't have a default value at /kohadevbox/koha/C4/Installer.pm line 572. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:47:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:47:42 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #12 from Kyle M Hall --- Created attachment 123783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123783&action=edit Bug 28833: (follow-up) Move loops count control to koha conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:47:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:47:51 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #13 from Kyle M Hall --- Created attachment 123784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123784&action=edit Bug 28833: (follow-up) Only spawn multiple processes if there are more records than loops specified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:49:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:49:03 +0000 Subject: [Koha-bugs] [Bug 28813] Fix recording and display of delivery errors for patron notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Delivery notes feature was |Fix recording and display |pushed prior to its |of delivery errors for |completion |patron notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:49:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:49:35 +0000 Subject: [Koha-bugs] [Bug 28813] Fix recording and display of delivery errors for patron notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 --- Comment #17 from Martin Renvoize --- (In reply to Katrin Fischer from comment #15) > Maybe we could update the bug description a bit, keeping release notes in > mind. Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:50:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:50:31 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123783|0 |1 is obsolete| | Attachment #123784|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 123785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123785&action=edit Bug 28833: (follow-up) Move loops count control to koha conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:50:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:50:40 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #15 from Kyle M Hall --- Created attachment 123786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123786&action=edit Bug 28833: (follow-up) Only spawn multiple processes if there are more records than loops specified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:56:49 +0000 Subject: [Koha-bugs] [Bug 28842] New: Missing summary for /items/:item_id/pickup_locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Bug ID: 28842 Summary: Missing summary for /items/:item_id/pickup_locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Bug 27931 introduced /items/:item_id/pickup_locations but missed to add the route summary and the top level display title for the 'pickup_locations' tag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:56:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:56:56 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27931 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 [Bug 27931] Add GET /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:56:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:56:56 +0000 Subject: [Koha-bugs] [Bug 27931] Add GET /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:59:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:59:46 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26988, 27932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27932 [Bug 27932] Add GET /biblios/:biblio_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:59:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:59:46 +0000 Subject: [Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 13:59:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 11:59:46 +0000 Subject: [Koha-bugs] [Bug 27932] Add GET /biblios/:biblio_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27932 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:00:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:00:38 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #42 from Jonathan Druart --- (In reply to Katrin Fischer from comment #39) > There is something weird, if multiple cover providers are activated: > > - Turn on OpenLibrary covers > - Turn on Amazon covers > - Search for "perl" > - Most books will show 2 covers in results and in the detail pages > - Example: CGI programming with Perl > - Turn on Google covers > - Result list shows 3 > - Detail page: only Amazon Found it! There is 2 functions "verify_images", and one (the existing one) is coming from amazonimages.js! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:08:48 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27932, 26988 |28461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27932 [Bug 27932] Add GET /biblios/:biblio_id/pickup_locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28461 [Bug 28461] Specify only one tag per route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:08:48 +0000 Subject: [Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28842 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:08:48 +0000 Subject: [Koha-bugs] [Bug 27932] Add GET /biblios/:biblio_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27932 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28842 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:08:48 +0000 Subject: [Koha-bugs] [Bug 28461] Specify only one tag per route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28461 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 [Bug 28842] Missing summary for /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:09:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:09:07 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123787&action=edit Bug 28842: A summary to the /items/:item_id/pickup_locations route This patch simply adds a summary to the route. This will be picked by the API docs. It also removes the 'pickup_locations' tag, as we did in bug 28461. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:09:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:09:31 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:09:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:09:47 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://api.koha-community. | |org/#operation/getItemPicku | |pLocations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:26:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:26:59 +0000 Subject: [Koha-bugs] [Bug 28843] New: Add view and edit buttons to result of MARC record import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Bug ID: 28843 Summary: Add view and edit buttons to result of MARC record import Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org After importing a staged file of MARC records, the results of the import are shown in a table. The last column contains the biblionumber linked to the detail view of that record. I'd like to replace that biblionumber link with two buttons: View and Edit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:37:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:37:22 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:37:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:37:26 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122443|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall --- Created attachment 123788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123788&action=edit Bug 28026: Add call_recursive() as a supliment for call() The method call() is not sufficient for all plugin hook types. It's possible that more than one plugin will be installed that wants to return the arguaments passed in an updated form. These transformation plugins need to work recursively rather than independantly. This patch adss a `call_recursive()` method that takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the arguament list and modify it as necessary. Test plan 1/ Run the included tests - t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:38:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:38:15 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123788|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 123789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123789&action=edit Bug 28026: Add call_recursive() as a supplement for call() The method call() is not sufficient for all plugin hook types. It's possible that more than one plugin will be installed that wants to return the arguaments passed in an updated form. These transformation plugins need to work recursively rather than independantly. This patch adss a `call_recursive()` method that takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the arguament list and modify it as necessary. Test plan 1/ Run the included tests - t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:44:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:44:40 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #43 from Jonathan Druart --- Created attachment 123790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123790&action=edit Bug 28180: Fix collision with existing verify_images At the OPAC we already had a verify_images JS function in amazonimages.js It's preferable to use another function name. This patch replace our verify_images with verify_cover_images and apply the change to the staff code as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:44:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:44:51 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:44:54 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 --- Comment #1 from Owen Leonard --- Created attachment 123791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123791&action=edit Bug 28843: Add view and edit buttons to result of MARC record import This patch adds "View" and "Edit" buttons to the output of the result of a MARC record import. To test, apply the patch and go to Tools -> State MARC for import. - Import a file of MARC records. - Click the "Manage staged records" button. - In the table of staged records the last column labeled "Records" should be empty. - Click "Import this batch into the catalog." - The table of records will be shown again, and this time the last column should contain "View" and "Edit" buttons for each row. - Confirm that the buttons work correctly, opening the correct record for viewing and editing. Test with both bibliographic and authority records to confirm that the correct view and edit pages open for each. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:46:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:46:46 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:47:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:47:27 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #44 from Jonathan Druart --- Created attachment 123792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123792&action=edit Bug 28180: Fix some non-translatable strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:48:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:48:41 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:58:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:58:40 +0000 Subject: [Koha-bugs] [Bug 28844] New: Suggestion from existing title can alert patron in error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Bug ID: 28844 Summary: Suggestion from existing title can alert patron in error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 14963 To recreate: - in acquisitions, create an order - on the OPAC, find the bib relating to your order and put in a purchase suggestion tied to that bib - back in acquisitions, receive your order without interacting with the purchase suggestion at all - the patron tied to the suggestion has received a notice that their suggestion is available While the suggestion and the order tie to the same bib, we cannot assume the suggestion and the order are linked directly. Especially in a multi-library system, there's no guarantee that the received copy of this title will go to the patron that requested it. We should only send suggestion notices to the patron for receipt of orders created from a purchase suggestion directly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 14:58:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 12:58:40 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 [Bug 28844] Suggestion from existing title can alert patron in error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 15:07:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 13:07:33 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123790|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 123793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123793&action=edit Bug 28180: Fix collision with existing verify_images At the OPAC we already had a verify_images JS function in amazonimages.js It's preferable to use another function name. This patch replace our verify_images with verify_cover_images and apply the change to the staff code as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 15:41:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 13:41:04 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #46 from Jonathan Druart --- It's a problem in master as well (staff-side) and highlighted at the OPAC as we have more images coming from external providers. The code to hide the non-existent images does not work as we expect. In my case, a new laptop (faster) make the problem more obvious, the JS code is processed faster than before and we remove the div that contain images from amazon, google, etc. because the images are not loaded yet. I think we should fix that on a separate bug report to fix the staff side at the same time. And obviously this new enhancement won't be pushed until it's fixed. You can continue testing with the following (non optimal) patch: diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 03f41fe8317..93b3c682f61 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1620,7 +1620,7 @@ } } } else { - div.remove(); + //div.remove(); } }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 16:37:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 14:37:41 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #47 from Jonathan Druart --- Created attachment 123794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123794&action=edit Bug 28180: Correctly guess if images have been loaded window.load won't assure us that the images loaded using JS code are correctly loaded. This patch adds a flag to the different providers when the images are fully loaded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 16:38:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 14:38:04 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #48 from Jonathan Druart --- I think this patch is the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 16:52:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 14:52:09 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #37 from Jonathan Druart --- Created attachment 123795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123795&action=edit Bug 24387: Fix sample_news.yml installer file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 16:52:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 14:52:14 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #38 from Jonathan Druart --- Created attachment 123796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123796&action=edit Bug 24387: Remove sample_news.for other languages We shouldn't continue to update those files as we are going to remove them soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 16:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 14:52:59 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #39 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #36) > Some DB columns are missing default values (category, code and location): > > DBD::mysql::db do failed: Field 'code' doesn't have a default value at > /kohadevbox/koha/C4/Installer.pm line 572. It's the installer file that was missing values for those columns! Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:14:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:14:07 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:14:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:14:16 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123795|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:14:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:14:23 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:15:03 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 123797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123797&action=edit Bug 24387: Fix sample_news.yml installer file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:15:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:15:18 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 123798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123798&action=edit Bug 24387: Remove sample_news.for other languages We shouldn't continue to update those files as we are going to remove them soon. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:21:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:21:32 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #42 from Tomás Cohen Arazi --- This action will erase all your data. Are you sure? (y/N) y Running [sudo koha-shell kohadev -p -c 'PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools perl /kohadevbox/misc4dev/populate_db.pl -v --opac-base-url http://kohadev.myDNSname.org:8080 --intranet-base-url http://kohadev-intra.myDNSname.org:8081 --marcflavour MARC21']... C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/koha/installer/data/mysql/en/optional/sample_news.yml: DBD::mysql::db do failed: Field 'code' doesn't have a default value at /kohadevbox/koha/C4/Installer.pm line 572. Inserting koha db structure... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:30:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:30:29 +0000 Subject: [Koha-bugs] [Bug 28845] New: OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Bug ID: 28845 Summary: OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If the OPAC_LIMIT_OVERRIDE and OPAC_SEARCH_LIMIT environment override values are set in apache and OpacAddMastheadLibraryPulldown is enabled, multibranchlimit values are not preselected as they should be: To recreate 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:31:43 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #21 from Heather --- We are on 20.05 and authority records that we import into Koha from OCLC's Connexion Client via the gateway have the OCLC record's ARN/001 number completely deleted and replaced and the 003 is: OCoLC ...which isn't correct--for us, the 003 should then be CSfMM. It would be great if the data in the OCLC record's ARN/001 could be *correctly* mapped into the 035 field. For an OCLC record number, there could possible be a prefix like with OCLC bibliographic record numbers, but I'm not familiar with the formats for aut record numbers, since we never have them preserved.:) For us, the important numbers are in the 010 field, the Library of Congress Control Number, but this is U.S.-based. For *bibliographic* 035 fields, the MARC code of the originator of the control number can be enclosed in parentheses preceding the number, e.g.: 035 ## $a (CaOTULAS)41063988 So perhaps someone could research if it's valid to format an aut 035 similarly, e.g.: 035 ## $a (DE-101)11915725X -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:31:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:31:50 +0000 Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:31:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:31:53 +0000 Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 --- Comment #1 from Nick Clemens --- Created attachment 123799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123799&action=edit Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:33:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:33:07 +0000 Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 17:59:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 15:59:36 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #108 from Kyle M Hall --- (In reply to Jonathan Druart from comment #107) > Patches (and remote branch) rebased on top of master. Any patches I would attach here would be out of date. Jonathan, consider this bug passed qa. Can you just add my sign-off before pushing to master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 18:49:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 16:49:33 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #43 from Jonathan Druart --- With all the patches attached to the bug report right now: root at kohadevbox:koha(bug_24387)$ reset_all This action will erase all your data. Are you sure? (y/N) y Running [sudo koha-shell kohadev -p -c 'PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools perl /kohadevbox/misc4dev/populate_db.pl -v --opac-base-url http://kohadev.myDNSname.org:8080 --intr anet-base-url http://kohadev-intra.myDNSname.org:8081 --marcflavour MARC21']... Inserting koha db structure... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/subtag_registry.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/auth_val_cat.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/message_transport_types.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/sample_notices_message_attributes.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/sample_notices_message_transports.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/keyboard_shortcuts.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/userflags.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/userpermissions.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/audio_alerts.sql... Skipping /kohadevbox/koha/installer/data/mysql/account_offset_types.sql Inserting /kohadevbox/koha/installer/data/mysql/mandatory/account_credit_types.sql... Inserting /kohadevbox/koha/installer/data/mysql/mandatory/account_debit_types.sql... Inserting /kohadevbox/koha/installer/data/mysql/en/mandatory/auth_values.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/mandatory/class_sources.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_frequencies.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_notices.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_numberpatterns.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/auth_val.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/csv_profiles.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/marc21_holdings_coded_values.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/marc21_relatorterms.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/parameters.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/patron_atributes.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/patron_categories.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_creator_data.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_itemtypes.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_libraries.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_libraries_holidays.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_news.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_patrons.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_quotes.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/optional/sample_z3950_servers.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/marcflavour/marc21/optional/marc21_sample_fastadd_framework.yml... Inserting /kohadevbox/koha/installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.yml... Setting the MARC flavour on the sysprefs... Setting Koha version to 21.0600014... Can you double-check please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 19:40:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 17:40:50 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #44 from Tomás Cohen Arazi --- My setup is KTD, using master-buster and mariadb:10.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 20:47:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 18:47:26 +0000 Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 20:47:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 18:47:29 +0000 Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122661|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 123800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123800&action=edit Bug 28682: Protect search for analytics in record detail page In record detail page, there is a search for analytics, see Bug 15851. If for any reason this search fails, the page will be broken with 'Internal server error'. This patch adds a protection with eval. Test plan : 1) Use a Zebra install with no Elasticsearch configuration 2) Go to staff interface 3) Go to any record detail page : no error 4) Change preference 'SearchEngine' to 'Elasticsearch' 5) Refresh ecord detail page : check you have no error 6) Check a record with analytics link 7) Repeat 3 to 6 on OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 20:48:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 18:48:35 +0000 Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with search for analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #7 from Fridolin Somers --- I rise to major because it can block one of the most important page, and impact OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:12:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:12:34 +0000 Subject: [Koha-bugs] [Bug 28749] All backups behave as if --without-db-name is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Depends on Bug 26947 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:14:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:14:55 +0000 Subject: [Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |25670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 [Bug 25670] Add useful methods to Koha::Acquisition::Orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:14:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:14:55 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 [Bug 28509] Koha/Acquisition/Orders.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:15:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:15:24 +0000 Subject: [Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #10 from Fridolin Somers --- Depends on Bug 25670 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:18:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:18:45 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #28 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:25:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:25:56 +0000 Subject: [Koha-bugs] [Bug 28689] Extra %s in alert message when saving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:33:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:33:00 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:33:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:33:03 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121491|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 123801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123801&action=edit Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previously released version, e.g. 'tags/v20.11.08' you will see a link directly to that schema page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:33:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:33:07 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 --- Comment #6 from Owen Leonard --- Created attachment 123802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123802&action=edit Bug 28454: (follow-up) Add schema version to link on reports home page This patch makes the same changes to the script and template for the reports home page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:33:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:33:19 +0000 Subject: [Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic parameters" on the sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |13881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 [Bug 13881] Add ability to defined circulation desks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:33:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:33:19 +0000 Subject: [Koha-bugs] [Bug 13881] Add ability to defined circulation desks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic parameters" on the sidebar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:33:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:33:39 +0000 Subject: [Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic parameters" on the sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:35:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:35:25 +0000 Subject: [Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers --- I see it has been pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:43:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:43:59 +0000 Subject: [Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:51:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:51:16 +0000 Subject: [Koha-bugs] [Bug 28704] Library MARCOrgCode field needs maxlength attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:57:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:57:04 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 21:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 19:57:19 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #22 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 22:00:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 20:00:12 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 22:01:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 20:01:09 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Depends on Bug 27584 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 22:02:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 20:02:56 +0000 Subject: [Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 22:04:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 20:04:08 +0000 Subject: [Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin Somers --- Depends on Bug 23302 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 22:13:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 20:13:48 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin Somers --- Since Bug 28455 is in 20.11.x, I choose to backport this one also. I skipped "Update wording of syspref", I does not apply because text is different. I this it is not very important. Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 22:26:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 20:26:21 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #11 from Katrin Fischer --- I am not sure the depedency applied - I backported this to our 20.11 early after some testing and it applied nicely (and works) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 23:06:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 21:06:59 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123797|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 123803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123803&action=edit Bug 24387: Fix sample_news.yml installer file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 23:08:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 21:08:09 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #46 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #44) > My setup is KTD, using master-buster and mariadb:10.3 Same here but with mariadb 10:1:48. The code was missing from yml, obvious mistake, sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 23:14:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 21:14:46 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #47 from Jonathan Druart --- [ We should docker up "d11" and have a D11 with dbms version brought by D11 We shouldn't have to explicitly tell that we need to up with docker-compose.mariadb_d11.yml Can this be fixed? is it worth opening a new ktd issue? ] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 23:16:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 21:16:21 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré > d'Art" (museum) This is waiting for an answer. Aleisha, maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 11 23:26:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 21:26:44 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #26 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #25) > (In reply to Jonathan Druart from comment #23) > > Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré > > d'Art" (museum) > > This is waiting for an answer. Aleisha, maybe? That's the name on the item types icon tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 00:00:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 22:00:05 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123791|0 |1 is obsolete| | --- Comment #2 from sandboxes at biblibre.com --- Created attachment 123804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123804&action=edit Bug 28843: Add view and edit buttons to result of MARC record import This patch adds "View" and "Edit" buttons to the output of the result of a MARC record import. To test, apply the patch and go to Tools -> State MARC for import. - Import a file of MARC records. - Click the "Manage staged records" button. - In the table of staged records the last column labeled "Records" should be empty. - Click "Import this batch into the catalog." - The table of records will be shown again, and this time the last column should contain "View" and "Edit" buttons for each row. - Confirm that the buttons work correctly, opening the correct record for viewing and editing. Test with both bibliographic and authority records to confirm that the correct view and edit pages open for each. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 00:01:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 22:01:29 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 00:19:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 22:19:12 +0000 Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123773|0 |1 is obsolete| | --- Comment #5 from sandboxes at biblibre.com --- Created attachment 123805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123805&action=edit Bug 28667: Check damaged item can be reserved in OPAC detail pages In OPAC detail pages, damaged items must impact the "place hold" link. This behavior depends on preference AllowHoldsOnDamagedItems. Test plan : 1) Create a record with one damaged item 2) Set AllowHoldsOnDamagedItems to 'Allow' 3) Go to OPAC record detail page : opac-detail.pl 4) Check you see "Place hold" link 5) Set AllowHoldsOnDamagedItems to 'Don't allow' 6) Refresh page 7) Check you don't see "Place hold" link Same tests 2 to 7 for pages opac-ISBDdetail.pl and opac-MARCdetail.pl Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 00:20:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 22:20:04 +0000 Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 00:34:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 22:34:22 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123720|0 |1 is obsolete| | --- Comment #4 from sandboxes at biblibre.com --- Created attachment 123806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123806&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 00:40:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Aug 2021 22:40:28 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off --- Comment #5 from Barbara Johnson --- I went ahead and signed off on this; however, there is one minor typo that needs to be fixed. 'Pre-fill values with profile ?' needs to have the extra space removed between the 'e' and the question mark. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 03:13:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 01:13:09 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #16 from David Cook --- Comment on attachment 123786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123786 Bug 28833: (follow-up) Only spawn multiple processes if there are more records than loops specified Review of attachment 123786: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28833&attachment=123786) ----------------------------------------------------------------- ::: C4/HoldsQueue.pm @@ +201,4 @@ > # Split the list of bibs into groups to run in parallel > if ( $loops > 1 ) { > my $bibs_per_chunk = ceil( scalar @$bibs_with_pending_requests / $loops ); > + $bibs_per_chunk = @$bibs_with_pending_requests if @$bibs_with_pending_requests <= $bibs_per_chunk; I don't understand this logic. scalar @$bibs_with_pending_requests = 10 $loops = 10 $bibs_per_chunk = 1 $bibs_per_chunk would still be 1. Maybe I'm confused but I can't think of a case where $bibs_per_chunk could be greater than scalar @$bibs_with_pending_requests. -- I was thinking we'd do the $loops would be changed to $max_loops, and $loops would be based on an arbitrary ratio. Perhaps 1000 bibs per 1 loop. So $loops = scalar @$bibs_with_pending_requests / 1000. If $loops < 1, then we don't fork. If $loops > 1, we double-check that we're not exceeding our maximum number of loops. For example: $max_loops = 4 scalar @$bibs_with_pending_requests = 10000 $loops = 10 We throttle $loops down from 10 to 4, because 4 is our maximum. Likewise, if @$bibs_with_pending_requests = 2000, we're only using 2 forks instead of our maximum of 4, so we're not using more resources than necessary. -- Alternatively, we could have an arbitrary threshold of 1000. Below that and we use $loops = 1. Above that, we use the $loops value supplied from config. I'm just trying to avoid scenarios where you have 50 Koha instances each spinning up 10 child processes to process 2 requests each. But maybe I'm just prematurely optimizing. I suppose most instances will have the default of 1 anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 03:14:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 01:14:00 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #17 from David Cook --- Comment on attachment 123689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123689 Bug 28833: Speed up holds queue builder via parallel processing Review of attachment 123689: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28833&attachment=123689) ----------------------------------------------------------------- ::: C4/HoldsQueue.pm @@ +210,5 @@ > + > + DATA_LOOP: > + foreach my $chunk (@chunks) { > + my $pid = $pm->start and next DATA_LOOP; > + _ProcessBiblios($chunk); I notice that the other _ProcessBiblios has arguments for $branches_to_use and $transport_cost_matrix. I'm guessing those should be included here too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 03:18:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 01:18:57 +0000 Subject: [Koha-bugs] [Bug 28846] New: MarcRecordFromNewSuggestion needs mapping to biblioitems.itemtype Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28846 Bug ID: 28846 Summary: MarcRecordFromNewSuggestion needs mapping to biblioitems.itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In C4::Suggestions, MarcRecordFromNewSuggestion uses mapping to biblioitems.itemtype : https://git.koha-community.org/Koha-community/Koha/src/commit/e9428f662fe2ec0271878ec78886e7f95a25a9e1/C4/Suggestions.pm#L614 But this Koha to MARC mapping may not exists when itemtype is on item level. Same for biblio.autor, even if unlikely. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 04:21:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 02:21:02 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 10:37:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 08:37:33 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #109 from Martin Renvoize --- Awesome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 10:59:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 08:59:29 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #22 from Martin Renvoize --- Looks pretty much like that's the case to me: https://www.loc.gov/marc/authority/ad035.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 11:15:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 09:15:12 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #23 from Martin Renvoize --- Do you understand how subfield z vs subfield a work here.. my interpretation is that a = 'current' (i.e what we're replacing with) and z = 'cancelled'. So am I right in thinking.. if we replace 001 + 003 on import we should add a 035 with a = (new003)new001 and z (original003)original001. As 035 is repeatable I can see that meaning we get an audit trail one could trace back through using the two subfields to get the order of actions... but I'm no librarian so I may to totally misinterpreting that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 11:22:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 09:22:08 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #24 from Katrin Fischer --- I haven't seen $z used like this tbh. I've only seen the numbers moved directly to 035$a around here and no use of $z at all. From the docs: https://www.loc.gov/marc/bibliographic/bd035.html For interchange purposes, documentation of the structure and use of the system control number must be provided to exchange partners by the originating organization. Each valid system control number and any related canceled/invalid control number are contained in a separate 035 field. So as our number is still valid at its source, I think $a is correct. I believe $z might be used if records are merged in their source catalog like the example suggests for WorldCat? A number that really no longer exists, no longer is in use at the source. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:02:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:02:45 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:06:02 +0000 Subject: [Koha-bugs] [Bug 28847] New: Branch limits while searching should be expanded in query building and not in CGI Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Bug ID: 28847 Summary: Branch limits while searching should be expanded in query building and not in CGI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 21249 introduced the SearchLimitLibrary system preference and added logic to the search scripts to account for it. Moving the code to modules allows us to cover the settings with tests. Additionally we should only expand the query passed to the search engine, the CGI param should remain brief -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:06:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:06:23 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28845, 21249 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:06:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:06:23 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:06:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:06:23 +0000 Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:35:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:35:17 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:35:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:35:20 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #1 from Nick Clemens --- Created attachment 123807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123807&action=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:35:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:35:23 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #2 from Nick Clemens --- Created attachment 123808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123808&action=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:35:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:35:26 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #3 from Nick Clemens --- Created attachment 123809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123809&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:37:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:37:44 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:37:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:37:48 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123787|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123810&action=edit Bug 28842: A summary to the /items/:item_id/pickup_locations route This patch simply adds a summary to the route. This will be picked by the API docs. It also removes the 'pickup_locations' tag, as we did in bug 28461. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 13:39:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 11:39:41 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): 1. Enable RESTPublicAPI system preference. 2. Go to http://127.0.0.1:8080/api/v1/.html 3. Search for getItemPickupLocations 4. Text immediately after should say "This resource is not documented." 5. Apply the patch, flush_memcached, restart_all. 6. Refresh the page. 7. The text should now say "Get valid pickup locations for an item" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 15:21:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 13:21:23 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123803|0 |1 is obsolete| | --- Comment #48 from Tomás Cohen Arazi --- Created attachment 123811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123811&action=edit Bug 24387: Fix sample_news.yml installer file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 15:29:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 13:29:55 +0000 Subject: [Koha-bugs] [Bug 28848] New: OpenAPI version should be a string Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Bug ID: 28848 Summary: OpenAPI version should be a string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com As mentioned explicitly in the OpenAPI 2.0 spec, the 'swagger' attribute needs to be a 'string': """ Required. Specifies the Swagger Specification version being used. It can be used by the Swagger UI and other clients to interpret the API listing. The value MUST be "2.0". """ Out stack doesn't take that into account, but some validator will take our spec as having a number instead. A fix should be backported to all stable releases so we can use newer versions of redoc for the API docs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 15:30:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 13:30:02 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 15:34:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 13:34:06 +0000 Subject: [Koha-bugs] [Bug 28770] Add request date to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28770 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 15:40:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 13:40:51 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #25 from Heather --- My understanding of the use of $z in many fields, including the 035, is the same as Katrin's. A number *that is still valid* in use in another system can't be placed in a $z, and it hasn't been canceled in that other system. It is used exactly in that way in WorldCat--when records are merged, the ID numbers of the subordinated & replaced records are placed in a $z of an 035. A $z is also used in a similar way in bib records in the 020 ISBN field, for example, if a lot of books have a misprinted and incorrect ISBN number, it will be placed in a $z with the correct number in a $a. But some people may still be seeing and using the incorrect number, thus its presence in the record in the $z. So I think, too, that other system's valid ID numbers should be in a $a in 035s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:06:02 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123575|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 123812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123812&action=edit Bug 7703: Don't block bulk hold action on search results if some items can't be placed on hold If you select multiple titles on the search results page in order to place a bulk hold and some of those titles have no items you get a JavaScript alert warning you can some cannot be placed on hold. You are blocked from completing the action until you deselect the invalid hold. This is unnecessary because the bulk hold process will safely refuse to place a hold on these titles later in the process. This patch removes the check that prevents submitting a multi-hold if one or more records in the multi-hold have no items. Test plan: 1) Apply patch 2) On the staff interface, do a search 3) On the search results, select at least one record with items and one record with no items. 4) Click the 'Place hold' button. 5) You should be redirected to reserve/request.pl with the message "Cannot place hold: this record has no items attached." Signed-off-by: Owen Leonard Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:06:06 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123576|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 123813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123813&action=edit Bug 7703: (QA follow-up) Revised test plan from Owen: This patch modifies the hold process so that if one of the titles in a multi-hold process has no items the process doesn't abort completely. To test, apply the patch and perform a search in the catalog which will return one or more records with no items attached. - Check checkboxes for multiple results, some of which have items and at least one of which has no items. - Click "Place hold." - You should be taken to the page for placing multiple holds, with a heading, "Cannot place hold on some items." - Note: You will not be able to complete the holds process without the next patch. Signed-off-by: Owen Leonard Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:06:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:06:09 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123577|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 123814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123814&action=edit Bug 7703: (follow-up) Treat no items like none available This patch modifies the holds template so that during the multi-hold process, titles with no items attached are treated the same way as titles with no items available (items exist but cannot be place don hold): - The row showing such a record will say "No items are available to be placed on hold." - The pickup location dropdown will be hidden. To test, follow the previous test plan and confirm that these change are reflected. Now that the pickup location field isn't present for titles without items you should be able to complete the holds process. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:06:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:06:35 +0000 Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #41 from Sally --- Works well, big improvement - thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:11:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:11:32 +0000 Subject: [Koha-bugs] [Bug 28849] New: Claim Returned should alert at checkout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28849 Bug ID: 28849 Summary: Claim Returned should alert at checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 14697 When checking out an item connected to an unresolved claim, we should alert the user just as we do at checkin. To recreate: - Set ClaimReturnedLostValue - set MarkLostItemAsReturned so that claimed items are marked as returned - check an item out to Patron A - mark that item claimed - check the item out to Patron B - Koha alerts you that it's removed the lost status, but not that there is an unresolved claim - set MarkLostItemAsReturned so that claimed items are NOT marked as returned - mark item as claimed on Patron B's account - check the item out to Patron C - Koha alerts you that the it's removed the item's lost status and asks if you want to end Patron B's checkout, but does not mention the 2 unresolved claims - check the item in - Koha gives a return-claim dialog alert with links to Patron A and Patron B We should give the same alert at checkout, since that's the moment at which Koha first knows this item has been found. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:11:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:11:32 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28849 [Bug 28849] Claim Returned should alert at checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:15:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:15:44 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123815&action=edit Bug 28848: Make sure the 'swagger' attribute is a string Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:15:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:15:56 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:20:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:20:18 +0000 Subject: [Koha-bugs] [Bug 28850] New: Clarify wording on AllFinesNeedOverride system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Bug ID: 28850 Summary: Clarify wording on AllFinesNeedOverride system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This syspref reads "[require/don't] staff to manually override all fines, even fines less than set in the noissuescharge system preference." We should explicitly state that this entirely blocks self checkout via the Koha selfcheck (and possibly also via SIP, I need to test that). It's vaguely implied as-is, since by definition there's no staff member present at the selfcheck to perform that override, but an explicit statement would be much clearer. I'm filing a separate bug to suggest an enhancement to split this into two system preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:22:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:22:57 +0000 Subject: [Koha-bugs] [Bug 28851] New: Separate AllFinesNeedOverride syspref into intranet and selfcheck versions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28851 Bug ID: 28851 Summary: Separate AllFinesNeedOverride syspref into intranet and selfcheck versions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The syspref AllFinesNeedOverride makes all checkouts require a staff override. It's enforced on both the intranet and on selfchecks. It ends up completely blocking checkout on selfchecks for patrons with any fines, as there is no mechanism for a staff override. It would be clearer and more flexible to split this into two sysprefs, one that applies to the intranet and one that applies to selfchecks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:22:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:22:57 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28851 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:30:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:30:48 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 --- Comment #2 from Tomás Cohen Arazi --- I'm not sure how this should be tested. Just see "2.0" is wrapped in double quotes, which is what the spec expects as mentioned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 16:55:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 14:55:38 +0000 Subject: [Koha-bugs] [Bug 28852] New: Extend options in SelfCheckoutByLogin syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Bug ID: 28852 Summary: Extend options in SelfCheckoutByLogin syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Right now, the koha selfcheck will only allow use of either cardnumber or username+password. We should extend those options. First, it'd be good to make the password requirement a separate question, thereby allowing cardnumber+password and username alone. Second, we should allow the possibility that a unique patron attribute might be used at checkout on a selfcheck (with or without a password). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:02:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:02:45 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:31:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:31:32 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:31:36 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117174|0 |1 is obsolete| | Attachment #119177|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 123816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123816&action=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:34:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:34:22 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:34:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:34:22 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:36:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:36:43 +0000 Subject: [Koha-bugs] [Bug 28817] It should be possible to configure the reply_address for various notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28817 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #4 from Christopher Brannon --- (In reply to Katrin Fischer from comment #3) > Maybe we should consider the overdues one as a bug first? > > I think we should match the reply to to the address we are sending the > notice from in this case and possible others as a default. > > I believe using a pref would not work for all notices. For example DUEDGST > are always sent from the patron's library and can contain information about > issues from multiple libraries, so any other setting makes no sense. > > I am also not sure we can fit a general solution in the notices tool well - > maybe we should look at some more use cases first to see where we are going > there. But I think fixing the overdues bug first would be most important. I think in cases where a digest is used, if notices are coming from only one library, then it could default to what the other notices are set to use for the reply to address. However, if it is a mix of libraries, then perhaps it could be preference options of A) patron home branch, B) first library in the list, C) the library referenced the most, or D) use a noreply at patronhomebranchdomain.com address (where the patronhomebranchdomain.com is actually their home branch's domain). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:44:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:44:33 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119025|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 123817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123817&action=edit Bug 27546: Add 'Search within results' search box This enhancement adds a new input above the search results allowing one to search within the results. The search box will take a query and add it as a limit to the previous search These patches make a slight change to the search header, passing the dropdown selection as a parameter rather thandirectly. Searching this way is functionally equivaled to adding 'AND' with the new term to original results. To test: 1 - Apply patch 2 - Search on staff client wiht a term that returns results 3 - Note the new 'Search within results box' 4 - Add a search term 5 - Note new results and confirm they are as expected 6 - Enable IntranetCatalogSearchPulldown and confirm the dropdown works as expected 7 - Edit your search - the reinfements appear in the limits section and can be removed Signed-off-by: Barbara Johnson Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:59:38 +0000 Subject: [Koha-bugs] [Bug 28326] If ElasticSearch enable is not possible to edit or save records with ' ES reserved charset' like [] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 17:59:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 15:59:42 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:05:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:05:22 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:05:26 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123815|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 123818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123818&action=edit Bug 28848: Make sure the 'swagger' attribute is a string Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:06:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:06:55 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Testing notes (koha-testing-docker): 1. Go to https://editor.swagger.io/ 2. Load the api/v1/swagger/swagger.yaml file (File > Import file) 3. You should get this message: Unable to render this definition The provided definition does not specify a valid version field. Please indicate a valid Swagger or OpenAPI version field. Supported version fields are swagger: "2.0" and those that match openapi: 3.0.n (for example, openapi: 3.0.0). 4. Apply the patch 5. Repeat steps 1-2 6. The file should now load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:29:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:29:17 +0000 Subject: [Koha-bugs] [Bug 28853] New: Textarea in biblio record editor breaks authority plugin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Bug ID: 28853 Summary: Textarea in biblio record editor breaks authority plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In biblio record editor, when subfield value contains more than 100 characters the editor uses a textarea instead of an input. On a field using authority plugin, this breaks the JavaScript because it only searches for input tags : In /koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt : > this.getElementsByTagName('input')[1].value = values[i]; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:30:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:30:12 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:30:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:30:56 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #15 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:52:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:52:51 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 --- Comment #1 from Fridolin Somers --- BTW : This JavaScript code is a mix of JQuery and old style. It seams it is not very solid and several parts are repeated, like : > var re = new RegExp('^subfield' + subfield_name,'g'); > var subfields = $(field_start).children('ul').children('li').filter( function() { > return this.id.match(re); > }); This would need a big revamping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:53:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:53:14 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 22:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 20:53:18 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 --- Comment #2 from Fridolin Somers --- Created attachment 123819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123819&action=edit Bug 28853: Fix authority plugin when textarea in biblio record editor In biblio record editor, when subfield value contains more than 100 characters the editor uses a textarea instead of an input. On a field using authority plugin, this breaks the JavaScript because it only searches for input tags : In /koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt : > this.getElementsByTagName('input')[1].value = values[i]; Test plan : 1) Prepare : 1.1) Create a new biblio record this a field using authority plugin, for example 606 1.2) Do not use authority plugin but enter in 606$x more than 100 chars 1.3) Save record 1.4) Create a new autority for 606 biblio field with $a and a $x containing more than 100 chars 2) Test 1 : 2.1) Edit again the biblio record, you see a text area for 606$x 2.2) Use authority plugin on field 606 2.3) Search and choose the new autority 2.4) Check $a,$x and $9 are well filled 3) Test 2 : 3.1) Empty field 606 3.2) Create a second $x subfield and fill it with a random value 3.3) Use authority plugin again on field 606 3.4) Search and choose the new autority 3.5) Check $a and $9 are well filled 3.6) Check first $x contains the value from autority and second $x is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 23:11:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 21:11:53 +0000 Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register statistics wizard report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 23:12:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 21:12:30 +0000 Subject: [Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #23 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 23:13:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 21:13:07 +0000 Subject: [Koha-bugs] [Bug 28418] Show template_id of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28418 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 23:36:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 21:36:27 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 12 23:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 21:36:28 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Bug 28572 depends on bug 28570, which changed state. Bug 28570 Summary: bor_issues_top.pl using a /tmp file to log debug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 00:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 22:04:03 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 00:05:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 22:05:43 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 00:05:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 22:05:44 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 28516, which changed state. Bug 28516 Summary: Koha/Patrons/Import.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 00:20:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 22:20:04 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 00:20:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 22:20:04 +0000 Subject: [Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 Bug 28613 depends on bug 28480, which changed state. Bug 28480 Summary: GET /patrons missing q parameters on the spec https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 00:29:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 22:29:59 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #21 from Agustín Moyano --- (In reply to David Nind from comment #20) > One minor thing I noted after signing off. > > The column heading in patron categories is 'Maximum request limit' and the > edit form says 'Maximum article scan requests'. Thanks David, I'll attach a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 00:38:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Aug 2021 22:38:48 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #22 from Agustín Moyano --- Created attachment 123820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123820&action=edit Bug 27945: (follow-up) Fix column header title and edit form label -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 10:25:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 08:25:41 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #6 from Fridolin Somers --- (In reply to Barbara Johnson from comment #5) > I went ahead and signed off on this; however, there is one minor typo that > needs to be fixed. 'Pre-fill values with profile ?' needs to have the extra > space removed between the 'e' and the question mark. Oh indeed, french-style typo. I fix it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 10:27:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 08:27:23 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123806|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers --- Created attachment 123821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123821&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 10:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 08:29:47 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123821|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers --- Created attachment 123822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123822&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 10:50:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 08:50:04 +0000 Subject: [Koha-bugs] [Bug 28220] Exception not caught when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27858, 27833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27858 [Bug 27858] Make Koha::Patron::Attribute->store raise an exception on invalid type/code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 10:50:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 08:50:04 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 [Bug 28220] Exception not caught when importing patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 10:50:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 08:50:04 +0000 Subject: [Koha-bugs] [Bug 27858] Make Koha::Patron::Attribute->store raise an exception on invalid type/code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27858 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 [Bug 28220] Exception not caught when importing patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 11:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 09:41:34 +0000 Subject: [Koha-bugs] [Bug 28854] New: [ALTERNATIVE] Add ability to create bundles of items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug ID: 28854 Summary: [ALTERNATIVE] Add ability to create bundles of items Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: andrew at bywatersolutions.com, bwsdonna at gmail.com, cecile.joyet at biblibre.com, dcook at prosentient.com.au, e.betemps at gmail.com, fiona.borthwick at ptfs-europe.com, george at nekls.org, jonathan.field at ptfs-europe.com, julian.maurice at biblibre.com, m.de.rooy at rijksmuseum.nl, martin.renvoize at ptfs-europe.com, severine.queune at bulac.fr, testopia at bugs.koha-community.org, tomascohen at gmail.com +++ This bug was initially created as a clone of Bug #24023 +++ This bug started as a rebase of bug 24023, but as time went on and I tested that bug I found bits of it lacking and felt enough time had passed that we could try a more modern approach. To keep the work distinct, I created this bug to encompass my alternative approach. This new feature will add the ability to bundle existing items together into loanable sets linked to a new collection bibliographic record. Items will be withdrawn from their original bib and take on the circulation rules of the collection record. We update the display for items attached to a collection to show what collection they are linked to and we added the ability to expand a collection item to list it's content items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 11:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 09:41:34 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28854 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 11:41:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 09:41:50 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 12:30:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 10:30:09 +0000 Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on issuehistory.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #2 from Sally --- I've tested this on a sandbox (current version, 21.06) and on our test server (20.11), and the error is valid on both. The setting is turned on. The checked out by information correctly populates in the patron's circulation history, but not in the item checkout history: /cgi-bin/koha/catalogue/issuehistory.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 12:30:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 10:30:47 +0000 Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on issuehistory.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 12:30:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 10:30:47 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27279 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 12:44:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 10:44:06 +0000 Subject: [Koha-bugs] [Bug 28855] New: Purging Suggestions test should not being on timestamp Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Bug ID: 28855 Summary: Purging Suggestions test should not being on timestamp Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: didier.gautheron at biblibre.com Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 28408, 23590 Hi, DelSuggestionsOlderThan is on 'date', a timestamp, which is rather unreliable for that kind of stuff. eg: 'date' field is trashed by #23590 updatedatabase.pl , (which could use date=date in SET BTW) Maybe it could use lastmodificationdate ? Note: to some extend it's a RGPD issue. Regards Didier Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 [Bug 28408] Last modification date for suggestions is wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 12:44:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 10:44:06 +0000 Subject: [Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 [Bug 28855] Purging Suggestions test should not being on timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 12:44:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 10:44:06 +0000 Subject: [Koha-bugs] [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 [Bug 28855] Purging Suggestions test should not being on timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:29:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:29:26 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:31:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:31:46 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:33:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:33:15 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:36:28 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #13 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:38:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:38:01 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:47:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:47:25 +0000 Subject: [Koha-bugs] [Bug 28813] Fix recording and display of delivery errors for patron notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:52:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:52:05 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:58:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:58:01 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 13:58:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 11:58:55 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:01:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:01:46 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #18 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:02:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:02:30 +0000 Subject: [Koha-bugs] [Bug 28856] New: Upload of zipped cover images will fail if idlink.txt contains empty lines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28856 Bug ID: 28856 Summary: Upload of zipped cover images will fail if idlink.txt contains empty lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Uploading a zipped collection of cover images requires that the zip file include a file listing the file names and biblionumbers. If this file contains one or more blank lines the upload will fail with this deceptive error message: Unrecognized or missing field delimiter. Please verify that you are using either a single quote or a tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:04:41 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:06:13 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:24:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:24:31 +0000 Subject: [Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:31:21 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123818|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 123823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123823&action=edit Bug 28848: Make sure the 'swagger' attribute is a string Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:32:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:32:32 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:33:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:33:25 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Obvious fix.. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:36:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:36:48 +0000 Subject: [Koha-bugs] [Bug 28857] New: Allow hold to be suspended at point of creation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28857 Bug ID: 28857 Summary: Allow hold to be suspended at point of creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Holds with a future start date and an element of complexity that some libraries would like to avoid. Instead, they use suspensions to delay the fulfilling of holds. However, there's no way to suspend a hold as you place it -- you need to place the hold and then suspend it from another screen. We should make it possible to set a suspension on a hold as you place it. But we should make is easy to hide the option to do so, so this probably means a new system preference, something like SuspendHoldsAtCreation, with options for No / Intranet / OPAC / Both Intranet and OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:37:01 +0000 Subject: [Koha-bugs] [Bug 28857] Allow hold to be suspended at point of creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28857 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:46:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:46:11 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123810|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 123824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123824&action=edit Bug 28842: A summary to the /items/:item_id/pickup_locations route This patch simply adds a summary to the route. This will be picked by the API docs. It also removes the 'pickup_locations' tag, as we did in bug 28461. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 14:46:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 12:46:48 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Nice fix, no typos or spelling issues. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 15:01:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 13:01:57 +0000 Subject: [Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 15:29:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 13:29:58 +0000 Subject: [Koha-bugs] [Bug 25025] Drag-and-drop cover image upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 15:30:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 13:30:01 +0000 Subject: [Koha-bugs] [Bug 25025] Drag-and-drop cover image upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 --- Comment #1 from Owen Leonard --- Created attachment 123825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123825&action=edit Bug 25025: Drag-and-drop cover image upload This patch updates the Upload local cover image page so that the user has the option of dragging a file from a folder on their computer instead of using a file upload button. The patch also adds a preview of uploaded single images and display of existing images on the record you're adding to. To test, apply the patch and make sure the LocalCoverImages system preference is enabled. - Go to Tools -> Upload local cover image and test the following processes: - Upload single cover image, specifying a biblionumber - Test dragging an image from a file on your computer - Test clicking the "Drop files here or click..." link. - You should see a preview of the image file on the screen, with information about the file: file name, image type, file size. - Click "Process images" - with "Existing covers will be replaced" checked - with "Existing covers will be replaced" unchecked When the upload process completes you should see information about the title in the page heading and a thumbnail of the cover in the sidebar. - Test that the image can be deleted from this page. You should be redirected back to this page with the same title still selected. - Upload a zip file of images - Test dragging an image from a file on your computer - Test clicking the "Drop files here or click..." link. - A zip file can't be previewed onscreen but you should see the same file information and a Font Awesome "zip file" icon. - Click "Process images" >From the bibliographic detail page, click the "Images" tab, and click "Upload." With this workflow the field asking for a biblionumber should not appear. Test with AllowMultipleCovers enabled and disabled to confirm that the "Existing covers will be replaced" checkbox is enabled only when multiple covers are possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 15:41:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 13:41:20 +0000 Subject: [Koha-bugs] [Bug 25025] Drag-and-drop cover image upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Owen Leonard --- (In reply to Owen Leonard from comment #0) > dragging the image file into the local cover images > tab on the bibliographic detail page. This patch doesn't do this (you still have to go to the "Upload local cover images" page), but it lays the framework for making it possible. I'm putting it back to ASSIGNED because there is a problem with the way the page displays item information when you upload an image at the item level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:20:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:20:36 +0000 Subject: [Koha-bugs] [Bug 28858] New: Table Settings should control Checked out by field in Circulation history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 Bug ID: 28858 Summary: Table Settings should control Checked out by field in Circulation history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users. 'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to that patron's Circulation history - cgi-bin/koha/members/readingrec.pl - Note that 'Checked out by' is visible and populated - Go to Koha > Administration > Table Settings - Choose Patrons - Choose Page: checkouthistory - Choose Table id: checkouthistory-table - Note that 'Checked out by' is not an option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:21:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:21:33 +0000 Subject: [Koha-bugs] [Bug 28858] Table Settings should control Checked out by field in Circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:21:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:21:33 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28858 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:27:42 +0000 Subject: [Koha-bugs] [Bug 28858] Table Settings should control Checked out by field in Circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 --- Comment #1 from Sally --- This also has the effect of targeting the wrong field via Table Settings. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to that patron's Circulation history - cgi-bin/koha/members/readingrec.pl - Note that 'Checked out by' is visible and populated - Go to Koha > Administration > Table Settings - Choose Patrons - Choose Page: checkouthistory - Choose Table id: checkouthistory-table - Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'date_due' - Reload the patron's Circulation history - Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Date due' is not This is because 'Checked out by' is sitting in the original 'Date due' position in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:31:08 +0000 Subject: [Koha-bugs] [Bug 28859] New: Table Settings should control Checked out by field in Checkout history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Bug ID: 28859 Summary: Table Settings should control Checked out by field in Checkout history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users. 'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Note that 'Checked out by' is not an option This also has the effect of targeting the wrong field via Table Settings. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'renewed' - Reload the item's Checkout history - Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Renewed' is not This is because 'Checked out by' is sitting in the original 'Renewed' position in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:31:21 +0000 Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28858 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:31:21 +0000 Subject: [Koha-bugs] [Bug 28858] Table Settings should control Checked out by field in Circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28859 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:31:43 +0000 Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 16:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 14:31:43 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28859 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:09:39 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:10:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:10:53 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Autoparallel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.marquez at autoparallel.c | |om Assignee|oleonard at myacpl.org |ivan.marquez at autoparallel.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:13:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:13:08 +0000 Subject: [Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:13:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:13:11 +0000 Subject: [Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123704|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 123826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123826&action=edit Bug 28719: Change somes links in the serials page to avoid them leading to nothing To test: 1- Search for a serial 2- Pick one 3- Go to 'Serial collection' on the left 4- An issue should be selected if you're expected a new issue 5- delete it using 'Delete selected issues' 6- Confirm deletion 7- If you're supposed to receive more issues the next one should now be there 8- Now edit the serial ('Edit serials') 9- See that the link leads to nothing 10- Apply patch and redo steps 1 to 8 11- See that the link now leads to something Signed-off-by: kelly Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:13:37 +0000 Subject: [Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexis.ripetti at inLibro.com |ity.org | QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:16:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:16:17 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:16:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:16:20 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123703|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 123827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123827&action=edit Bug 28819: Add item search to intranet-main.tt To test: 1. Apply patch 2. Go to staff main page ( intranet-main.tt ) 3. Now you should see an 'Item search' button and icon. Signed-off-by: kelly mcelligott Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:16:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:16:48 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens --- Trivial, passing QA, understand if RM wants outside opinion :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:42:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:42:21 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #2 from Christopher Brannon --- (In reply to George Williams (NEKLS) from comment #1) > We have AllowAllMessageDeletion set to "Don't allow" so I'd like to see a > system preference that can turn this feature on or off if added. After reviewing the intended functionality of this feature and the purpose of AllowAllMessageDeletion, we have determined that this feature will not change anything with this permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:49:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:49:02 +0000 Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:49:05 +0000 Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123799|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123828&action=edit Bug 28845: Match against the full limit string, not just the group id To test: 1 - Add to OPAC virtual host in apache conf: SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-1" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 2 - Enable system preference OpacAddMastheadLibraryPulldown 3 - Create a library group enabled as OPAC search group (or make sure existing group 1 is an OPAC search group) 4 - Load the opac - dropdown does not pree-select the search group 5 - Apply patch 6 - Relaod opac - group is pre-selected! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:57:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:57:17 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #3 from Christopher Brannon --- The koha-US development committee met and has determined the following criteria for this new feature: * A new field (ie patron_read) will be added to the messages table to record that the patron has read the message. * If a message is set to display on the OPAC for the patron, the patron will have a 'Dismiss' or 'Mark as read' button next to the message. * When the patron marks the message as read, the message_type field will change from B (patron) to L (librarian), and the new field (ie patron_read) will have a value, indicating that they read the message. * If this new field is true (showing the patron has read the message), it will now have the message_type set to L (librarian), and the message will show on the patron account. Because the new field has a value, it will also display some form of label next to the message indicating that the patron has read the message. The label could say something like 'Patron acknowledged', or something similar. This functionality will not delete the message. It will allow staff to see that the patron has read the message, and staff will still have the ability to delete the message at their discretion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 17:59:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 15:59:22 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #3 from Barbara Johnson --- I originally signed off on this bug, but had some concerns so I revisited it and changed the status to In Discussion. 1. A staff member who does not have edit permissions still sees the edit button. Clicking on the edit button takes them to a Koha login screen. It would be better if the staff member did not see the edit button at all if they can't edit anything. 2. When a staff member that does not have bib editing permissions clicks on the View button from manage-marc-import.pl they are taken to a view only display on detail.pl which seems correct. However, clicking on the Edit dropdown on this screen gives them the ability to edit the record using a MARC mod template even though they do not have the permission for editing these templates. A staff member with view only permissions should not be able to edit the bib record at all. 3. In discussing this issue with an expert cataloger she had the following to say: "I can't think of a single reason why I'd allow someone to load files without any editing permissions, frankly--looking at a loaded file is a quality control step, and if someone doesn't have the expertise to edit MARC (bib or aut), how are they going to have the expertise to, e.g., troubleshoot something that should have overlaid but didn't?" Based on this comment it seems she would question whether a view option is even needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:01:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:01:53 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew at bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- I stumbled into a problem: - create a library group for use for OPAC searching BUT NOT staff searching - go to advanced search in the intranet - confirm you can select an individual library but no groups are shown - apply patch - reload adv search on the intranet - individual library selector is disabled (incorrect), groups selector doesn't show (correct) - edit your group, make it usable on the intranet - reload adv search - the group picker is now showing and the libraries picker is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:14:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:14:24 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #8 from Barbara Johnson --- This is a constant problem for our patrons who are used to searching Amazon or Google without having to worry about apostrophes. Fixing this issue would really improve the ability for our patrons to find items in our catalog. The status of this bug is listed as Needs Signoff. Is there a test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:16:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:16:46 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:17:06 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123789|0 |1 is obsolete| | --- Comment #34 from Tomás Cohen Arazi --- Created attachment 123829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123829&action=edit Bug 28026: Add call_recursive() as a supplement for call() The method call() is not sufficient for all plugin hook types. It's possible that more than one plugin will be installed that wants to return the arguaments passed in an updated form. These transformation plugins need to work recursively rather than independantly. This patch adss a `call_recursive()` method that takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the arguament list and modify it as necessary. Test plan 1/ Run the included tests - t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:17:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:17:55 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:17:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:17:58 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123809|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 123830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123830&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:22:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:22:28 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:22:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:22:31 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 123831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123831&action=edit Bug 28850: Reword AllFinesNeedOverride To test: Apply patch, look up AllFinesNeedOverride, confirm it now says that checkouts will be blocked via the web-based selfcheck and SIP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:31:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:31:38 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #4 from Owen Leonard --- (In reply to Barbara Johnson from comment #3) > > 2. ...However, clicking on the Edit > dropdown on this screen gives them the ability to edit the record using a > MARC mod template even though they do not have the permission for editing > these templates. This sounds like it needs a new bug report. > 3. ... Based on this > comment it seems she would question whether a view option is even needed. The view option was always there, it was just unclear what it was because the link was just a number. Marking "Failed QA" in order to address issue 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 18:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 16:34:44 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123830|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 123832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123832&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:11:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:11:24 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123832|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 123833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123833&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:13:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:13:34 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #7 from Owen Leonard --- Created attachment 123834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123834&action=edit Bug 28819: (follow-up) Use stacked icons for different searches This patch modifies the staff interface home page so that the "Advanced search" and "Item search" links are differentated using stacked Font Awesome icons. To test, apply the patch and view the staff interface home page. The icons associated with advanced and item searches should be different: - The Advanced search link should have a magnifying glass icon on top of a grey book icon. - The Item search link should have a magnifying glass icon on top of a grey list icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:17:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:17:24 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:17:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:17:27 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123807|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 123835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123835&action=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:17:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:17:30 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123808|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 123836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123836&action=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:17:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:17:34 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123833|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 123837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123837&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:19:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:19:22 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #8 from Owen Leonard --- I talked Fridolin out of doing this in Bug 24088, but I guess this is a sign it really is wanted. I hope my follow-up helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:19:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:19:30 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:19:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:19:35 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #4 from Autoparallel --- Since this is what came out from the committee we will consider it as the official scope for this project and what will be built. Please be aware that any changes to this scope will have to be re-discussed in the committee and if approved would have to be treated as a new development, which would require a new work agreement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:20:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:20:52 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123834|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 123838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123838&action=edit Bug 28819: (follow-up) Use stacked icons for different searches This patch modifies the staff interface home page so that the "Advanced search" and "Item search" links are differentated using stacked Font Awesome icons. To test, apply the patch and view the staff interface home page. The icons associated with advanced and item searches should be different: - The Advanced search link should have a magnifying glass icon on top of a grey book icon. - The Item search link should have a magnifying glass icon on top of a grey list icon. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 19:55:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 17:55:48 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 20:04:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 18:04:38 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123816|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 123839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123839&action=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 20:21:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 18:21:22 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Andrew Fuerste-Henry --- Sorry, just noticed the same issue exists on the OPAC. If there is no search group in place for use on the OPAC, the Libraries dropdown is erroneously disabled. Kicking back to FQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 20:31:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 18:31:34 +0000 Subject: [Koha-bugs] [Bug 28860] New: Add system setting to mark Patron fields important Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28860 Bug ID: 28860 Summary: Add system setting to mark Patron fields important Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice to add a system setting similar to the BorrowerMandatoryField for the patron form to mark fields important. This would give a visual clue for fields that should be filled in but are not necessarily required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 20:54:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 18:54:14 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #20 from Fridolin Somers --- (In reply to Kyle M Hall from comment #17) > Created attachment 120994 [details] [review] > Bug 26860: facets.inc refactor availability facet > Oh crap, only first patch has been QA and others set obsolete. So only first patch is in master : > git log --online --grep=26860 origin/master 63d6c1d8c5 Bug 26860: facets.inc refactor availability facet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:09:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:09:43 +0000 Subject: [Koha-bugs] [Bug 28861] New: Item type column always hidden in holds history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Bug ID: 28861 Summary: Item type column always hidden in holds history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The page replicated the behavior from the holds history page on staff and added: [% IF show_itemtype_column %] Requested item type [% END %] but 'show_itemtype_column' is never set. To reproduce: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:09:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:09:54 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:18:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:18:16 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:25:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:25:31 +0000 Subject: [Koha-bugs] [Bug 28862] New: Add suffix to name field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28862 Bug ID: 28862 Summary: Add suffix to name field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: rcoert at arlingtonva.us QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Requesting the addition to the name field for suffix entries (Jr., Sr. III, etc.). Ideally it would be a drop-down box that could be prepopulated (auth_value?) with common entries; allowing for cleaner data and easier account viewing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:26:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:26:56 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #11 from Rebecca Coert --- +1 I agree with the group that this would be an extremely useful field to have in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:28:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:28:59 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:38:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:38:10 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #14 from Fridolin Somers --- (In reply to Katrin Fischer from comment #13) > (In reply to Fridolin Somers from comment #12) > > Oh crap, a real ergonomic bug then. I backport. > > > > The backport on 20.11 actually fails because there is on select tag the > > attribute size="1". > > This has been removed in 21.05.x by Bug 28066. > > > > Should we keep it or remove it ? > > I believe removing it would be ok, but leaving it in probably won't cause > issues right away either. Ok I choose to keep it. Thanks for your help ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:39:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:39:34 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:51:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:51:38 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123839|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 123840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123840&action=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:52:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:52:37 +0000 Subject: [Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Depends on Bug 25026 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:52:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:52:55 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 21:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 19:52:59 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #12 from Nick Clemens --- Created attachment 123841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123841&action=edit Bug 28847: Only apply JS to branch/multibranch selection if there are search groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:04:03 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:04:03 +0000 Subject: [Koha-bugs] [Bug 20936] Holds history for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 [Bug 28861] Item type column always hidden in holds history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:05:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:05:06 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123842&action=edit Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:07:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:07:26 +0000 Subject: [Koha-bugs] [Bug 25995] Log changes to due date using bulk edit tool in circulation log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25995 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:07:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:07:47 +0000 Subject: [Koha-bugs] [Bug 26036] Suggestion for the "Batch extend due dates" result screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26036 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:08:53 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Another funny behavior. With only edit_items you have access and links to "Cataloguing" home page, but its empty. It is for another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:09:23 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:10:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:10:38 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:11:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:11:35 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:12:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:12:40 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:15:01 +0000 Subject: [Koha-bugs] [Bug 28813] Fix recording and display of delivery errors for patron notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin Somers --- Depends on Bug 14723 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:16:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:16:58 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:20:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:20:13 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:22:38 +0000 Subject: [Koha-bugs] [Bug 28825] Can't edit local cover image for item from details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Depends on Bug 28179 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:25:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:25:08 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:25:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:25:38 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:33:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:33:04 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:33:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:33:08 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:33:12 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:33:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:33:15 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:33:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:33:17 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:34:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:34:25 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 123843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123843&action=edit Bug 27358: Add a generic way to handle API privileged access attributes deny-list This patch introduces a way for Koha::Object(s)->to_api to filter out attributes that require privileged access. It is done in a way that the 'public' parameter is recursively passed to nested objects in recursive to_api() calls. This way, Koha::Object-based classes can determine how they will render depending on this parameter. For example, for implementing a route for fetching an item looks like: GET /items The controller will look like: my $item = Koha::Items->find( $c->validation->param('item_id') ); return $c->render( status => 200, openapi => $item->to_api ); Implementing an unprivileged (public) route would look like: GET /public/items/:item_id The controller will look like: my $item = Koha::Items->find( $c->validation->param('item_id') ); return $c->render( status => 200, openapi => $item->to_api({ public => 1 }) ); To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object*.t => SUCCESS: Tests pass (i.e. current behaviour is kept, new behaviour passes the tests) 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:34:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:34:30 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 123844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123844&action=edit Bug 27358: Make is_public stashed on public routes This patch makes the API authentication code stash the 'is_public' value when public routes are hit. This will be particularly useful to have $c->objects->search generically pass this info down to the ->to_api method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass! When a public route is reached, the controller has the 'is_public' value stashed 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:34:36 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 123845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123845&action=edit Bug 27358: Teach objects.search about public requests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:34:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:34:42 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 123846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123846&action=edit Bug 27358: Add GET /public/biblios/:biblio_id/items This patch introduces a route to fetch items belonging to a biblio. It is expected to return the 'public' representation of the Koha::Item objects. It is also enforcing the visibility rules, by using Koha::Items->filter_by_visible_in_opac. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Test pass and they cover all the cases! 3. Try your favourite REST tool against the new route. 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:34:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:34:48 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 123847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123847&action=edit Bug 27358: Unit tests for public items retrieval Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:35:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:35:31 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #12 from Christopher Brannon --- Could someone just simply start off by adding a middle name field in the borrower tables, and putting the field on the patron edit page??? That would be a start. Please, lets get this ball rolling at least! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:36:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:36:47 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #9 from Fridolin Somers --- Actually Zebra as a rule in words-icu.xml : But it may not be optimal to do the exact same thing in Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:47:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:47:48 +0000 Subject: [Koha-bugs] [Bug 28863] New: Cancel a Pending Notice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863 Bug ID: 28863 Summary: Cancel a Pending Notice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: rcoert at arlingtonva.us QA Contact: testopia at bugs.koha-community.org We would like the ability to cancel any notice that is currently "Pending" on the Notices tab in a user's account. Also, a record of which librarian cancelled the notice and date/time stamp would be very useful. Use Case: Item is discharged, hold is trapped, & notice is generated. Staff then realizes that the item is badly damaged and reverts the hold to obtain another copy. However, the notice for the original item is now Pending in the account and the email will be sent - even though the item is not on the Hold Shelf. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 13 22:50:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 20:50:39 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #24 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #17) > I am a little worried about the short list here: > > +sub api_privileged_attrs { > + return [ > + 'checked_out_date', > + 'checkouts_count', > + 'holds_count', > + 'internal_notes', > + 'extended_subfields', > + ]; > +} > + > > Can you help me? Just wondering if it also uses the framework visibility, > then I'd be happy already :) If we leave more_subfields_xml/frameworks out of the item representation (we have plans for that), would y'all help me refine this deny-list for the items? I have just rebased this work and it still works nicely. If I don't get feedback in a few days, I will move the 'public' layer work to another (simpler) table, so other devs see the benefit from this and can work on top of it. My feeling is we can have a list of 'hidden in opac' attributes from the 'items' table, and then we can sort visibility in the views. I might be wrong, though. Looking for feedback. Please PM me if you feel like there's a good use case that could be simpler than this (I'm thinking accountlines). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 14 00:15:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 22:15:51 +0000 Subject: [Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #7 from Michael Hafen --- (In reply to Katrin Fischer from comment #6) > Hi Michael, > > as David pointed out, currently with IndependentBranches the records are > shared and there are no limitations to editing them. A record doesn't belong > to any library, everyone can edit. I think this is a too big change to > existing behavior that will be unwanted by many, so it should be made > strictly optional. > > I also believe we might not want to add a new concept like this on top of > IndependentBranches. In my opinion it needs more hashing out and it would > look better in the new library group settings that I hope will replace > IndependentBranches at some point in the not too soon future. > > Also there are a lot of edge cases here I am not sure about: > > * If shared records cannot be edited by libraries using it, who can edit it > to fix issues? > * What about records for electronics, serials etc. that don't need to > necessarily have items? > * What about the Advanced cataloguing editor? > > There is also no test plan here, please add one to your commit message. Also > take a look at how the subject etc. should look like: > https://wiki.koha-community.org/wiki/Commit_messages Should be easy to implement this with a new type of library group. I haven't done that before though, so I'd have to go through the code to figure that out. The point of a record not belonging to any library (or library group) is pivotal here. The best I can think of would be adding a column to the biblio(items) table to hold either the branch or branch group claiming the record, or maybe that could be added through the biblio_metadata. This would cover your second edge case too, as electronics and serials could be given an owner that way. I used C4::Context->only_my_library() in the patch, so SuperLibrarians would still be able to edit shared records, which addresses your first edge case. The third edge case is also a bit sticky for me. It would mean, to me, greatly increasing the size of the patch, as I would also want to expand this to the cataloging search and import batch record matching. I figure once we start declaring that a branch group owns a record, then we'd want to limit cataloging to only records owned by the group or with no owner. That would pretty much eliminate the cases of shared records between library groups, but also reduce the ability to reuse records. Or, in cataloging, limit actions on records owned by another library group to just duplicating the record. I feel that to fully flesh-out the feature that would be the way to go, but maybe I'm over-thinking it. If there is some interest in the feature I could work on the library groups and advanced editor points, at least. I'm also willing to withdraw the bug (I don't see a "Won't Fix" status, so push it to "In Discussion" I guess), if there isn't any interest. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 14 00:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 22:50:25 +0000 Subject: [Koha-bugs] [Bug 28864] New: The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Bug ID: 28864 Summary: The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: michael.hafen at washk12.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The patron search results in the patron card creator card batch doesn't include the value of the PatronsPerPage system preference in the per page drop down, which means it isn't using the system preference. Also, on the Patrons page, the patron search includes the PatronsPerPage value, but doesn't use it as the default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 14 00:51:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Aug 2021 22:51:10 +0000 Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 --- Comment #1 from Michael Hafen --- Created attachment 123848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123848&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 15 21:08:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Aug 2021 19:08:20 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 15 21:12:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Aug 2021 19:12:09 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #11) > Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. Can you please backport it to the 20.05.x branch? Thanks :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 01:47:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Aug 2021 23:47:52 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- It might be a good idea to harmonize the normalization used between Zebra and Elasticsearch just for consistency... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 05:24:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 03:24:24 +0000 Subject: [Koha-bugs] [Bug 28532] Accessibility: Staff Client - add legends to forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wainuiwitikapark at catalyst.n |koha-bugs at lists.koha-commun |et.nz |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 10:51:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 08:51:34 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #19 from Jonathan Druart --- Created attachment 123849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123849&action=edit Bug 10902: Use prefetch and dbic rs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 11:11:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 09:11:36 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 11:19:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 09:19:02 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 11:45:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 09:45:33 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #110 from Jonathan Druart --- Created attachment 123850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123850&action=edit Bug 25078: Move skeleton file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 11:45:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 09:45:39 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #111 from Jonathan Druart --- Created attachment 123851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123851&action=edit Bug 25078: Don't process db revs if updatedatabase.pl failed The updatedatebase stops when something wrong happens, we should not continue to process the new DB revs (db_revs dir) in that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 11:54:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 09:54:55 +0000 Subject: [Koha-bugs] [Bug 28865] New: serial cataloguing REQUEST GATEWAY TIMEOUT Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28865 Bug ID: 28865 Summary: serial cataloguing REQUEST GATEWAY TIMEOUT Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Windows Status: NEW Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: mafzal at jmi.ac.in QA Contact: testopia at bugs.koha-community.org MARC record for Serials is navigationg to BOOKS or gives error as REQUEST GATEWAY TIMEOUT. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 11:56:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 09:56:14 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 --- Comment #25 from Martin Renvoize --- (In reply to Tomás Cohen Arazi from comment #24) > (In reply to Katrin Fischer from comment #17) > > I am a little worried about the short list here: > > > > +sub api_privileged_attrs { > > + return [ > > + 'checked_out_date', > > + 'checkouts_count', > > + 'holds_count', > > + 'internal_notes', > > + 'extended_subfields', > > + ]; > > +} > > + > > > > Can you help me? Just wondering if it also uses the framework visibility, > > then I'd be happy already :) > > If we leave more_subfields_xml/frameworks out of the item representation (we > have plans for that), would y'all help me refine this deny-list for the > items? I still think we should switch from 'deny-list' to 'allow-list'.. security by default ;) > > I have just rebased this work and it still works nicely. If I don't get > feedback in a few days, I will move the 'public' layer work to another > (simpler) table, so other devs see the benefit from this and can work on top > of it. Hmm, I don't think it would be a bad idea to move the core idea to another, simpler, endpoint/table so other work can be based upon it. > > My feeling is we can have a list of 'hidden in opac' attributes from the > 'items' table, and then we can sort visibility in the views. I might be > wrong, though. Looking for feedback. Hmm, not sure I understand this one.. do you mean expose fields in the API and only use the 'hidden in opac' options for the final display.. I can see a use case for that.. but I can also see people complaining that some hidden fields are still publically available if you know how to use the API. > > Please PM me if you feel like there's a good use case that could be simpler > than this (I'm thinking accountlines). Accountlines could work.. though I still have a way to go regarding the api's there. Questions like '/credits vs /debits vs /lines' and how embeds should work for offsets and things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:01:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:01:42 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:09 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:12 +0000 Subject: [Koha-bugs] [Bug 10902] Highlight patrons from logged-in library in patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:14 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:17 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #37 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:21 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:24 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #49 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:27 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:29 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #112 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:32 +0000 Subject: [Koha-bugs] [Bug 26761] Use aria-disabled attribute in OPAC cart for disabled links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:34 +0000 Subject: [Koha-bugs] [Bug 26761] Use aria-disabled attribute in OPAC cart for disabled links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26761 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:37 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:39 +0000 Subject: [Koha-bugs] [Bug 28339] Elasticsearch - Add 8XX to default title-series index mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28339 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:41 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:44 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:46 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:46 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #12 from Jonathan Druart --- Created attachment 123852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123852&action=edit Bug 26852: Fix Heading.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:48 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:51 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - Correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:54 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - Correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:56 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:04:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:04:58 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:00 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:03 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:06 +0000 Subject: [Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:09 +0000 Subject: [Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:12 +0000 Subject: [Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:15 +0000 Subject: [Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:17 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:20 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:23 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:25 +0000 Subject: [Koha-bugs] [Bug 28842] Missing summary for /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28842 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:28 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:30 +0000 Subject: [Koha-bugs] [Bug 28848] OpenAPI version should be a string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28848 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:05:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:05:44 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Created attachment 123852 [details] [review] > Bug 26852: Fix Heading.t > > Signed-off-by: Jonathan Druart Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:20:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:20:05 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119113|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:20:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:20:11 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119114|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:25:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:25:19 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:25:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:25:27 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:26:58 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 | released in| | Text to go in the|Can be hidden with CSS, |Can be hidden with CSS, release notes|using the #withoutitems_id |using the #withoutitems_id |selector. |selector. | | | |RM NOTE: | |Reverted --- Comment #21 from Jonathan Druart --- The patch that has been pushed is now reverted. Please clarify the situation. Tests are missing anyway and the patches are not ready for integration into master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:27:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:27:59 +0000 Subject: [Koha-bugs] [Bug 28866] New: lose ccode when coming back to results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28866 Bug ID: 28866 Summary: lose ccode when coming back to results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At Admin advanced search, if it the search include a ccode filter (limit), if opens a record, and try to go back to results... you will get always 0 results. koha forgets the ccode limit , the url is like /cgi-bin/koha/catalogue/search.pl?idx=kw&q=a*&limit=&limit=mc-ccode: no ccode and it always gives 'No results found No results match your search for 'kw,wrdl: a*' with limit(s): 'mc-ccode:""' in ByWater Library System Catalog. ' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:48:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:48:52 +0000 Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com, | |jonathan.druart+koha at gmail. | |com See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 | Depends on| |23916 --- Comment #1 from Jonathan Druart --- Caused by commit eb283d13fab70d8a32216a5bee8fb4a71e6d875e Bug 23916: Record and display item issuer Andrew, can you fix this please? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 [Bug 23916] Issuer should be recorded and visible in patron circulation history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:48:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:48:52 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28859 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28859 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 [Bug 28859] Table Settings should control Checked out by field in Checkout history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 12:59:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 10:59:10 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA Keywords|release-notes-needed | --- Comment #27 from Jonathan Druart --- I am really sorry, I got confused and was confusing! I thought we were adding a new set of icons. I have no idea how I understood that, everything is clear when reading the commit message and bug title: we are only adding a new 'info' icon to the existing "carredart" set. Sorry everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 14:55:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 12:55:07 +0000 Subject: [Koha-bugs] [Bug 28811] Cant receive orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- It's certainly coming from a bad value in your koha.list (apt) file. Similar problem reported (and fixed) today on IRC: http://irc.koha-community.org/koha/2021-08-16#i_2371014 More info: https://wiki.koha-community.org/wiki/Koha_on_Debian#Pick_which_Koha_version_to_follow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 14:59:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 12:59:42 +0000 Subject: [Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #8 from Katrin Fischer --- I am not sure a db column would work, unless we only store the "first library to add a record", because library groups can overlap by definition. For your intended use case... would we need to store it on record level? Or could we get away with looking at the items attached to a record? How hard should the limit be on editing the records? Because I think if you just added an item to a record, you could edit the record and then delete it... still seems like no hard "lock". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:02:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:02:35 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 --- Comment #4 from Magnus Enger --- (In reply to David Cook from comment #3) > Could you elaborate more on your use case for this? I don't understand why > you'd need to capture and store the password. In Norway we have a national patron database, that among other things holds patron's PIN codes. These are encrypted using a key that only vendors have access to. To be able to store and transmit the encypted PIN in the correct format, we need to be able to capture it, and encrypt it in the way the national patron database expects, so we can sync it to other ILSes. This was not my idea, and it might change in the future, but for now it is something we have to implement, in order to be able to answer RFPs etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:11:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:11:08 +0000 Subject: [Koha-bugs] [Bug 28865] serial cataloguing REQUEST GATEWAY TIMEOUT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Afzhal, there is not enough information here for us to see what is going wrong for you and this is very likely to be a configuration or installation issue instead of a code bug. I suggest to bring this up on the mailing list first: https://koha-community.org/support/koha-mailing-lists/ Please include information about the Koha version you are using, how it was installed and what steps lead to the error. The URL that doesn't open might be helpful too. What do you mean by "is navigating to BOOKS"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:11:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:11:40 +0000 Subject: [Koha-bugs] [Bug 28866] lose ccode when coming back to results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:16:15 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #521 from Ere Maijala --- Eww... As far as I can see, bug 24857 looks like a subset of proper holdings records. It's a lot of semi-duplicate work... I'll pick up from where Joonas got things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:18:04 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #5 from Katrin Fischer --- Probably should stay away... but since this question could also come up later in the process...: Why the change from B to L? For me that indicates for whose eyes the message was initially intended for and I think changing it, might make us lose some valuable information. Reporting could for example be affected. Visibility to the patron in the OPAC and also the new note "patron acknowledged" could also use just rely on the new db column. So the change B/L would not be strictly necessary to achieve the described behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:18:51 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #113 from Jonathan Druart --- Created attachment 123853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123853&action=edit Bug 25078: Add exec flags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:19:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:19:23 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #50 from Jonathan Druart --- Created attachment 123854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123854&action=edit Bug 24387: Fix one remaining occurrence of KohaNews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:19:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:19:28 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #51 from Jonathan Druart --- Created attachment 123855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123855&action=edit Bug 24387: Fix AdditionalContents.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:19:34 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #52 from Jonathan Druart --- Created attachment 123856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123856&action=edit Bug 24387: Fix Letters/TemplateToolkit.t We must cast to date or the comparison does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:20:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:20:36 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #114 from Jonathan Druart --- (In reply to Jonathan Druart from comment #113) > Created attachment 123853 [details] [review] > Bug 25078: Add exec flags Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:20:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:20:53 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #53 from Jonathan Druart --- Last 3 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:33:12 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #12 from Ere Maijala --- Sorry about breaking this and thanks for the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 15:36:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 13:36:59 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #6 from Owen Leonard --- (In reply to Katrin Fischer from comment #5) > Why the change from B to L? I agree that this doesn't seem to be a necessary step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 17:10:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 15:10:15 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #7 from Christopher Brannon --- (In reply to Owen Leonard from comment #6) > (In reply to Katrin Fischer from comment #5) > > Why the change from B to L? > > I agree that this doesn't seem to be a necessary step. This step was added because the message system does not archive these messages. If the message were just deleted, there would be no easy way for staff to see that the patron acknowledged receiving the message. If it were marked and hidden, we would be retaining messages that would build up over time, and the table would have to be maintained. When a message is marked as B (patron), it is seen on BOTH sides, by patron and staff. Changing it to L (staff) would accomplish dismissing it on the patron side, and maintaining current workflows on the staff side. After this enhancement, staff would be able to KNOW that the patron has seen the message, and the staff could decide whether to keep or delete the message from that point. Right now, staff have NO idea if the message is seen, and therefore have no idea when it would be appropriate to delete, if desired. This workflow enhancement has the least impact on current practices while adding needed functionality, and adding information for staff to enhance their workflow with these messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 17:12:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 15:12:13 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #8 from Christopher Brannon --- One small adjustment I would suggest, and should be easy enough, is to add the date of when the message was read to the label on the staff side. Perhaps the date could be the flag in the new field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 18:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 16:32:28 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #9 from Owen Leonard --- (In reply to Christopher Brannon from comment #7) > When a message is marked as B (patron), it is seen on BOTH sides, by patron > and staff. Changing it to L (staff) would accomplish dismissing it on the > patron side, and maintaining current workflows on the staff side. It's not necessary if we're using logic in the OPAC to hide any message which is marked as seen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 18:46:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 16:46:19 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #10 from Christopher Brannon --- (In reply to Owen Leonard from comment #9) > (In reply to Christopher Brannon from comment #7) > > > When a message is marked as B (patron), it is seen on BOTH sides, by patron > > and staff. Changing it to L (staff) would accomplish dismissing it on the > > patron side, and maintaining current workflows on the staff side. > > It's not necessary if we're using logic in the OPAC to hide any message > which is marked as seen. Oh, wait. I think I understand. So, if we flag the it as read by putting a date in the new field, we just turn off visibility on the opac side. We don't have to touch the message_type field at all. That makes sense. :) Am I understanding correctly? Everything else should still work the same, because we will still be able to see it on the staff side, and it will still be flagged as read? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 19:02:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 17:02:16 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #11 from Katrin Fischer --- > Oh, wait. I think I understand. So, if we flag the it as read by putting a > date in the new field, we just turn off visibility on the opac side. We > don't have to touch the message_type field at all. That makes sense. :) > Am I understanding correctly? Everything else should still work the same, > because we will still be able to see it on the staff side, and it will still > be flagged as read? Yep, exactly what I meant. This way we don't change the current logic, but just enhance it a bit further. Changing the display logic in the OPAC to filter by the new 'read flag' should not be too hard and it will be a little less disruptive for the current workflows. Also, if we needed to revert from read to unread or wanted to optionally show read messages again, that would be relatively easy, because we can still tell what messages are 'patron' messages. I like the idea of making the 'read flag' a date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 19:22:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 17:22:05 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #12 from Christopher Brannon --- Okay, based on this discussion, we can simplify the scope of this project: * A new field (ie patron_read) will be added to the messages table to record that the patron has read the message. * If a message is set to display on the OPAC for the patron, the patron will have a 'Dismiss' or 'Mark as read' button next to the message. * When the patron marks the message as read, the new field (ie patron_read) will have the current date added to it, indicating the date that they read the message. * If this new field has a value (a date), it will no longer show on the OPAC. It will also display a label, such as 'Read xx-xx-xxxx', where x is the date in the field. (Date will need to be formatted to admin date settings.) This functionality will not delete the message. It will allow staff to see that the patron has read the message, and staff will still have the ability to delete the message at their discretion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:24:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:24:08 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.02,20.11.09 |21.11.00,21.05.02,20.11.09, released in| |20.05.15 --- Comment #23 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:27:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:27:18 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #18 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:27:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:27:18 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Bug 15504 depends on bug 28455, which changed state. Bug 28455 Summary: If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:27:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:27:49 +0000 Subject: [Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:28:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:28:57 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:31:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:31:09 +0000 Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an undefined value at C4/Reserves.pm line 607 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.02,20.11.09 |21.11.00,21.05.02,20.11.09, released in| |20.05.15 CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:31:15 +0000 Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an undefined value at C4/Reserves.pm line 607 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:33:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:33:54 +0000 Subject: [Koha-bugs] [Bug 27906] Add support for circulation status 9 ( waiting to be re-shelved ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27906 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:33:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:33:54 +0000 Subject: [Koha-bugs] [Bug 27907] Add support for circulation status 2 ( on order ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27907 Bug 27907 depends on bug 27906, which changed state. Bug 27906 Summary: Add support for circulation status 9 ( waiting to be re-shelved ) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27906 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:34:32 +0000 Subject: [Koha-bugs] [Bug 27907] Add support for circulation status 2 ( on order ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27907 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:34:32 +0000 Subject: [Koha-bugs] [Bug 27908] Add support for circulation status 1 ( other ) for damaged items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27908 Bug 27908 depends on bug 27907, which changed state. Bug 27907 Summary: Add support for circulation status 2 ( on order ) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27907 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:34:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:34:55 +0000 Subject: [Koha-bugs] [Bug 27908] Add support for circulation status 1 ( other ) for damaged items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27908 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:40:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:40:24 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED Version(s)|21.11.00,21.05.02,20.11.09 |21.11.00,21.05.02,20.11.09, released in| |20.05.15 --- Comment #13 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:40:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:40:37 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:40:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:40:46 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:40:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:40:54 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:42:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:42:00 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldoldstable --- Comment #14 from Victor Grousset/tuxayo --- (sorry the spam, I couldn't find a quiet way to go from "closed" to "pushed to oldoldstable") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:46:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:46:35 +0000 Subject: [Koha-bugs] [Bug 28631] Holds History title link returns "not found" error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:49:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:49:42 +0000 Subject: [Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:50:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:50:35 +0000 Subject: [Koha-bugs] [Bug 28747] Clarify wording on RestrictionBlockRenewing syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:51:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:51:03 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #21 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:52:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:52:55 +0000 Subject: [Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:55:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:55:19 +0000 Subject: [Koha-bugs] [Bug 28747] Clarify wording on RestrictionBlockRenewing syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28747 --- Comment #9 from Victor Grousset/tuxayo --- errata: no issue related to dependencies, anyway: Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:55:27 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #22 from Victor Grousset/tuxayo --- errata: no issue related to dependencies, anyway: Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:57:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:57:27 +0000 Subject: [Koha-bugs] [Bug 28336] Cannot change matching rules for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:59:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:59:12 +0000 Subject: [Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:59:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:59:12 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Bug 28855 depends on bug 28408, which changed state. Bug 28408 Summary: Last modification date for suggestions is wrong https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:59:38 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 20:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 18:59:59 +0000 Subject: [Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:00:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:00:47 +0000 Subject: [Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:00:50 +0000 Subject: [Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123231|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 123857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123857&action=edit Bug 18631: Add option to specify logs to preserve or delete in cleanup_database.pl This adds two new parameters: --log_module --preserve_log These can be repeated to include or exclude specific modules from the cleanup To test: 0 - Apply patch 1 - Enable cataloging log and borrowers log 2 - Make some changes to borrowers and records 3 - run cleanup databse with --logs 0 --preserve_log=MEMBERS --preserve_log=CATALOGUING 4 - nothing is removed 5 - run cleanup databse with --logs 0 --log_module=MEMBERS 6 - the borrower logs are removed, the record changes remain 7 - run cleanup database with --logs 0 8 - record changes are removed (all other logs too) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:10:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:10:15 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:10:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:10:15 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28632 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 [Bug 28632] patrons.t fragile on slow boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:11:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:11:28 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.03,20.11.09 |21.11.00,21.05.03,20.11.09, released in| |20.05.15 --- Comment #16 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:17:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:17:57 +0000 Subject: [Koha-bugs] [Bug 28867] New: Use Bootstrap button menu and modal for adding patrons to lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28867 Bug ID: 28867 Summary: Use Bootstrap button menu and modal for adding patrons to lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 123858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123858&action=edit Screenshot showing Bootstrap button menu I propose to modify the patron search results page so that the controls for adding patrons to a new or existing list are Bootstrap style: A button menu for selecting a patron list, and a modal for entering the name of a new list. See attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:18:04 +0000 Subject: [Koha-bugs] [Bug 28867] Use Bootstrap button menu and modal for adding patrons to lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28867 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:18:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:18:27 +0000 Subject: [Koha-bugs] [Bug 28867] Use Bootstrap button menu and modal for adding patrons to lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28867 --- Comment #1 from Owen Leonard --- Created attachment 123859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123859&action=edit Bootstrap modal for patron list creation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:35:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:35:57 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #11 from Fridolin Somers --- (In reply to David Cook from comment #10) > It might be a good idea to harmonize the normalization used between Zebra > and Elasticsearch just for consistency... +1 So we just need to change replacement with a space character ? This will require a unit test I bet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:46:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:46:36 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #71 from Barbara Johnson --- +1 - Displaying the bib info for cancelled orders is essential functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 21:57:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 19:57:00 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #6 from Barbara Johnson --- We set up the parent/child fund structure a couple of budget cycles ago. But when we discovered we could not depend on the parent totals accurately reflecting expenditures made to the child funds we had to abandon it. If this functionality existed it would save me from having to export data to a spreadsheet or use a calculator to make sure all my figures are correct. We would love to see this fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:02:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:02:33 +0000 Subject: [Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #3 from Barbara Johnson --- +1 Yes, this does require a lot of clicks. I think a new column displaying the invoice number and a link to the actual invoice would be great. There are times when we need to see the invoice but sometimes we just need to have the invoice number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:03:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:03:50 +0000 Subject: [Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 --- Comment #4 from Katrin Fischer --- (In reply to Barbara Johnson from comment #3) > +1 Yes, this does require a lot of clicks. I think a new column displaying > the invoice number and a link to the actual invoice would be great. There > are times when we need to see the invoice but sometimes we just need to have > the invoice number. Barbara, just want to take this chance to say thank you for your sign-offs and commenting on bugs - much appreciated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:04:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:04:16 +0000 Subject: [Koha-bugs] [Bug 26878] Add ability to prevent spending against parent funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26878 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #4 from Barbara Johnson --- +1 Yes, let's do this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:07:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:07:20 +0000 Subject: [Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.09 |20.11.09,20.05.15 released in| | --- Comment #13 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.15 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:09:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:09:24 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #29 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:09:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:09:46 +0000 Subject: [Koha-bugs] [Bug 28689] Extra %s in alert message when saving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:26:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:26:23 +0000 Subject: [Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic parameters" on the sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:26:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:26:40 +0000 Subject: [Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:27:54 +0000 Subject: [Koha-bugs] [Bug 28704] Library MARCOrgCode field needs maxlength attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:34:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:34:05 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:34:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:34:08 +0000 Subject: [Koha-bugs] [Bug 28562] Add date received to basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28562 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- +1 Excellent suggestion. I would prefer a new column for the receive date. I'm not sure if this is what you mean but I'm concerned about adding it alongside the title/author/ISBN because I don't want to obscure scanning for that info (screenshot attached) Also it seems like if it was in its own column then it would be easily sortable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:34:09 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123831|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123860&action=edit Bug 28850: Reword AllFinesNeedOverride To test: Apply patch, look up AllFinesNeedOverride, confirm it now says that checkouts will be blocked via the web-based selfcheck and SIP. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:36:14 +0000 Subject: [Koha-bugs] [Bug 28562] Add date received to basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28562 --- Comment #2 from Barbara Johnson --- Created attachment 123861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123861&action=edit Received date Feels like a display such as this is getting too crowded. A separate column would be nicer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:38:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:38:04 +0000 Subject: [Koha-bugs] [Bug 28237] Make notes from the basket visible on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28237 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- +1 Yes, this would be very helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:39:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:39:26 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This clarifies the wording release notes| |for the | |AllFinesNeedOverride system | |preference. If set to | |'require', checkouts are | |blocked when using the | |web-based selfcheck and | |SIP. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:55:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:55:40 +0000 Subject: [Koha-bugs] [Bug 27119] Allow batch actions from item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27119 --- Comment #3 from Barbara Johnson --- I'm commenting on this one again because I just had an occasion where this functionality would have been a big time saver. I performed an item search for a specific not for loan status. After viewing my results I had to download/save a barcode file. I then had to go to Tools › Batch item modification and paste in my barcodes. It would have been great if I could have reduced the number of clicks and page changes. Also, I have to remember to go back and delete a barcode file on my PC that I won't need any more. It would be so much better to be able to link to barch mod and deletion from the results of an item search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 22:59:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 20:59:24 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.03,20.11.09 |21.11.00,21.05.03,20.11.09, released in| |20.05.15 --- Comment #23 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:05:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:05:52 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:06:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:06:17 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:06:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:06:19 +0000 Subject: [Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:06:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:06:21 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123842|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123862&action=edit Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:06:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:06:59 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #24 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:07:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:07:00 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Bug 15504 depends on bug 28630, which changed state. Bug 28630 Summary: ILSDI::AuthenticatePatron should set borrowers.lastseen https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:07:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:07:35 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:07:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:07:53 +0000 Subject: [Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:08:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:08:30 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:08:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:08:54 +0000 Subject: [Koha-bugs] [Bug 28828] Bug 22399 breaks unimarc_field_4XX.tt and marc21_linking_section.tt value builders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:09:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:09:42 +0000 Subject: [Koha-bugs] [Bug 28835] Ability to pass list contents to batch record modification broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28835 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:09:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:09:57 +0000 Subject: [Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:10:43 +0000 Subject: [Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:11:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:11:26 +0000 Subject: [Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #20 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:11:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:11:50 +0000 Subject: [Koha-bugs] [Bug 28834] Improve wording biblios/authorities on tools home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28834 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:21:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:21:40 +0000 Subject: [Koha-bugs] [Bug 28868] New: Masthead.inc is missing class name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Bug ID: 28868 Summary: Masthead.inc is missing class name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In masthead.inc there is a wrapper for the main search bar called #opac-main-search. Prior to Bug 20168 that warpper had a class name of 'mastheadsearch'. Historically CSS/JS customization of the main search bar was done via the mastheadsearch class. Can we add that back so we don't disrupt customization? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:23:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:23:19 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:23:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:23:19 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 [Bug 28868] Masthead.inc is missing class name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:28:18 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:28:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:28:22 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #1 from Lucas Gass --- Created attachment 123863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123863&action=edit Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 16 23:28:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 21:28:43 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 00:26:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 22:26:43 +0000 Subject: [Koha-bugs] [Bug 28869] New: If authorized values for STACK (shelving control number) are > 127 things explode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Bug ID: 28869 Summary: If authorized values for STACK (shelving control number) are > 127 things explode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The A.V. category of STACK maps to items.stack. In the schema (for master) it claims items.stack but if I 'describe items' it tells me it is tinyint(1). Tinyint can be anything between -128 and 127. To recreate: -Add AV's for STACK that are greater than 127. -Edit an item and attempt to change the shelving control number to that value. -See an error -Add AV's less than 127 -Edit an item, things seem to work fine. Should items.stack be int? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 00:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 22:31:43 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #1 from Lucas Gass --- TYPO: In the schema (for master) it claims items.stack is the data type BIT but if I 'describe items' it tells me it is tinyint(1). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 01:33:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 23:33:06 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 --- Comment #5 from David Cook --- (In reply to Magnus Enger from comment #4) > (In reply to David Cook from comment #3) > > Could you elaborate more on your use case for this? I don't understand why > > you'd need to capture and store the password. > > In Norway we have a national patron database, that among other things holds > patron's PIN codes. These are encrypted using a key that only vendors have > access to. To be able to store and transmit the encypted PIN in the correct > format, we need to be able to capture it, and encrypt it in the way the > national patron database expects, so we can sync it to other ILSes. > > This was not my idea, and it might change in the future, but for now it is > something we have to implement, in order to be able to answer RFPs etc. Thanks for explaining. I think that I understand more now. I just took a peek at bug 11401 and https://lanekortet.no/ (thanks Google Translate). I wonder why they don't use something like LDAP or use SSO. Inertia maybe. I still think how the NNPDB works is bizarre but I understand the rationale. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 01:37:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 23:37:10 +0000 Subject: [Koha-bugs] [Bug 27287] Make note fields from orders searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 01:37:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Aug 2021 23:37:13 +0000 Subject: [Koha-bugs] [Bug 27287] Make note fields from orders searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 --- Comment #1 from Hayley Pelham --- Created attachment 123864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123864&action=edit Bug 27287: Make note fields from orders history searchable This patch adds aqorders.order_internalnote and aqorders.order_vendornote to the Acquisitions history search. To test: 1) Apply patch and restart services 2) Create an order in Acquisitions and set an internal note and a vendor note 3) Go to /cgi-bin/acqui/histsearch.pl and search by internal or vendor note using the terms you set in step 2 4) Note your order is returned and internal note and vendor note are included in the search results at the end of the table Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg https://bugs.koha-community.org/show_bug.cgi?id=27827 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 02:26:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 00:26:31 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #24 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x for 19.11.21? Or if it contains string changes, backported to 19.11.22? As we are currently in a string freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 02:31:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 00:31:03 +0000 Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an undefined value at C4/Reserves.pm line 607 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x for 19.11.21? Or if it contains string changes, backported to 19.11.22? As we are currently in a string freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 02:32:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 00:32:21 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #15 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x for 19.11.21? Or if it contains string changes, backported to 19.11.22? As we are currently in a string freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 02:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 00:34:44 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #17 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x for 19.11.21? Or if it contains string changes, backported to 19.11.22? As we are currently in a string freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 03:35:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 01:35:14 +0000 Subject: [Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 --- Comment #14 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x for 19.11.21? Or if it contains string changes, backported to 19.11.22? As we are currently in a string freeze. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 03:37:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 01:37:49 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #24 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x for 19.11.21? Or if it contains string changes, backported to 19.11.22? As we are currently in a string freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 07:11:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 05:11:02 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement is release notes| |renaming the "News" tool | |with a more generic | |"Additional contents". | |It | |creates two different | |"categories" of content: | |"news" and "html | |customizations". CC| |fridolin.somers at biblibre.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 07:21:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 05:21:14 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- Mmm this is changed since 20.11.00. We at Biblibre have fixed each broken customisation of OPAC. This is not the only change, and for me it makes sens to have an id instead of a class for a tag existing only once in the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 07:33:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 05:33:24 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 --- Comment #4 from Fridolin Somers --- It looks great. Just missing the job status "new". It appears when job is added with koha-worker stopped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 07:37:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 05:37:15 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Nice. But like for analyticals, please add eval() in get_marc_volumes() in case search fails, see Bug 28682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 07:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 05:45:10 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #4 from Martin Renvoize --- Good call, I wasn't aware of that bug. I'll add a follow-up layer today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:15:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:15:34 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24088 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:15:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:15:34 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28819 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:16:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:16:22 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #11 from Fridolin Somers --- (In reply to Owen Leonard from comment #8) > I talked Fridolin out of doing this in Bug 24088, but I guess this is a sign > it really is wanted. I hope my follow-up helps. Yeeeees we love this :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:23:01 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:23:01 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 [Bug 28776] Warns from GetItemsInfo when biblio marked as serial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:24:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:24:17 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:24:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:24:20 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123251|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 123865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123865&action=edit Bug 28776: Warns from GetItemsInfo when biblio marked as serial GetItemsInfo sorts the items using serial fields if the biblio is defined as a serial The fields may not be defined. We can add a fallback to blank in this case To test: 1 - Mark a record with items as serial in the marc (942$s) 2 - At least one of the items should have no enumchron defined 3 - Load the detail page 4 - Warns in logs: [WARN] Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/C4/Items.pm line 811. 5 - Apply patch and restart all 6 - Reload the details page 7 - No more warns Signed-off-by: Fridolin Somers https://bugs.koha-community.org/show_bug.cgi?id=25790 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 08:48:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 06:48:22 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #17 from Fridolin Somers --- After a second look : Second patch looks great (Cache Koha::Library object in Branches template plugin). It should be on a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:11:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:11:50 +0000 Subject: [Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Is this valid in actual master ? No need to impact C4/Heading/MARC21.pm ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:14:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:14:27 +0000 Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- (In reply to Hakam Almotlak from comment #4) > Created attachment 122346 [details] [review] > Bug 28356: Consolidate catalogue search box code > > To test: > 1 - Apply patch > 2 - Confirm searchign the catalog works from: > Administration->Budgets > Cataloging > Circulation->Check in > Administration->Cities and towns > Acquisitions->{Vendor}->Contracts > Administration->Currencies > Administration->Circulation desks (requires UseCirculationDesks > preference) > Home > Tools->Notices and slips > Patrons > Adminstration > Serials > Acquisitions->Suggestions > Administration->Z39.50/SRU servers > > Signed-off-by: hakam You forgot to change status to "Signed off" no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:16:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:16:18 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26587 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:16:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:16:18 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23035 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:19:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:19:09 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:19:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:19:09 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26587 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:19:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:19:19 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:19:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:19:19 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23035 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 09:31:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 07:31:28 +0000 Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Fridolin Somers --- Sorry patch does not apply anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 10:04:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 08:04:54 +0000 Subject: [Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 --- Comment #15 from Jonathan Druart --- (In reply to wainuiwitikapark from comment #14) > Should this be backported to 19.11.x for 19.11.21? If it's broken in 19.11 you should backport it for the next one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 10:17:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 08:17:25 +0000 Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 10:17:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 08:17:30 +0000 Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120405|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 123868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123868&action=edit Bug 28279: Re-sync mappings.yaml We are missing some changes in the mappings.yaml file: * missing staff_client/opac (bug 25325 and bug 20589) * missing mandatory (bug 19482) * sort (bug 27316) became a boolean field Which means export_elasticsearch_mappings.pl generates a file that differs a lot from the one we have in our codebase. There are also indentation changes certainly caused by the replacement of YAML with YAML::XS Test plan: 1. reset_all without this patch 2. export the mappings to a non-tracked file (ie. don't erate mappings.yaml from source) 3. Apply this patch 4. Compare both file => No change expected 5. Reset the mappings (so using the mappings.yaml after the changes from this patch) 6. Compare the tables on the UI (with and without the patch applied) => No change expected QA will use --word-diff to make sure only mandatory, sort and staff_client/opac are modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 11:12:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 09:12:11 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement is |This enhancement is release notes|renaming the "News" tool |renaming the "News" tool to |with a more generic |the more generic |"Additional contents". |"Additional contents". |It |It |creates two different |creates two different |"categories" of content: |"categories" of content: |"news" and "html |"news" and "HTML |customizations". |customizations". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 12:12:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 10:12:47 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 12:12:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 10:12:51 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123862|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 123869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123869&action=edit Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 12:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 10:19:33 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 --- Comment #5 from Owen Leonard --- Created attachment 123870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123870&action=edit Bug 28149: (follow-up) Add string for job status "new" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 12:24:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 10:24:27 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 12:24:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 10:24:32 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123822|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 123871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123871&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 12:24:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 10:24:36 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #10 from Katrin Fischer --- Created attachment 123872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123872&action=edit Bug 28839: (QA follow-up) Fix tabs/indentation in code paragraph QA tools complained about a tab char. Cleaned up the template paragraph it pointed out, removing tabs and correcting indentation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 14:23:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 12:23:28 +0000 Subject: [Koha-bugs] [Bug 28870] New: Cart shipping fails because of Non-ASCII characters in display-name of reply-to address Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Bug ID: 28870 Summary: Cart shipping fails because of Non-ASCII characters in display-name of reply-to address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: ulrich.kleiber at bsz-bw.de QA Contact: testopia at bugs.koha-community.org After the upgrade from 18.11 to 20.11, users with non-ASCII characters (e.g. German umlauts) in their first name or surname can no longer send shopping carts because the newly introduced email address validation of the create function of Email.pm fails. A possible solution would be to omit the display name generated from first name and surname in opac-sendbasket.pl. diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl index 55dc7546bc..c4dee93e3d 100755 --- a/opac/opac-sendbasket.pl +++ b/opac/opac-sendbasket.pl @@ -59,7 +59,7 @@ if ( $email_add ) { my $user_email = $patron->first_valid_email_address || C4::Context->preference('KohaAdminEmailAddress'); - my $email_replyto = $patron->firstname . " " . $patron->surname . " <$user_email>"; + my $email_replyto = $user_email; my $comment = $query->param('comment'); # Since we are already logged in, no need to check credentials again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 14:29:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 12:29:34 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #4 from Andrew Fuerste-Henry --- I marked this an enhancement when I filed it. In retrospect, I believe it is a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 14:31:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 12:31:40 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Christian Stelzenmüller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:02:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:02:40 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:05:11 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:05:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:05:17 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123865|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 123873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123873&action=edit Bug 28776: Warns from GetItemsInfo when biblio marked as serial GetItemsInfo sorts the items using serial fields if the biblio is defined as a serial The fields may not be defined. We can add a fallback to blank in this case To test: 1 - Mark a record with items as serial in the marc (942$s) 2 - At least one of the items should have no enumchron defined 3 - Load the detail page 4 - Warns in logs: [WARN] Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/C4/Items.pm line 811. 5 - Apply patch and restart all 6 - Reload the details page 7 - No more warns Signed-off-by: Fridolin Somers https://bugs.koha-community.org/show_bug.cgi?id=25790 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:09:39 +0000 Subject: [Koha-bugs] [Bug 27287] Make note fields from orders searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:09:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:09:43 +0000 Subject: [Koha-bugs] [Bug 27287] Make note fields from orders searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123864|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123874&action=edit Bug 27287: Make note fields from orders history searchable This patch adds aqorders.order_internalnote and aqorders.order_vendornote to the Acquisitions history search. To test: 1) Apply patch and restart services 2) Create an order in Acquisitions and set an internal note and a vendor note 3) Go to /cgi-bin/acqui/histsearch.pl and search by internal or vendor note using the terms you set in step 2 4) Note your order is returned and internal note and vendor note are included in the search results at the end of the table Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg https://bugs.koha-community.org/show_bug.cgi?id=27827 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:12:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:12:37 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:12:54 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:13:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:13:00 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123411|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi --- Created attachment 123875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123875&action=edit Bug 28802: Untranslatable strings in browser.js File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js We must move it to prog/js. Test plan : 1) Perform a search on staff interface 2) Click on a result 3) Check you see records browser Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:13:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:13:30 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|martin.renvoize at ptfs-europe |tomascohen at gmail.com |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:17:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:17:00 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #3 from Lucas Gass --- (In reply to Fridolin Somers from comment #2) > Mmm this is changed since 20.11.00. > We at Biblibre have fixed each broken customisation of OPAC. > This is not the only change, and for me it makes sens to have an id instead > of a class for a tag existing only once in the page. Why can't it have both? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:24:14 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Tomás Cohen Arazi --- Could we squash this patches? In this tiny change it makes sense to have a single patch. Also - payout-amount - invoice-print - receipt-print => should have the -action suffix for consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:28:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:28:44 +0000 Subject: [Koha-bugs] [Bug 27947] Add cancellation reasons to article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #1 from Agustín Moyano --- (In reply to Nick Clemens from comment #0) > Similar to holds we propose to add an authorised value list of 'reasons' > for cancellation of article requests Hi Nick, should we add a default list of reasons? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 15:40:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 13:40:28 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 16:10:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 14:10:50 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Ulrich Kleiber changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 16:27:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 14:27:40 +0000 Subject: [Koha-bugs] [Bug 28871] New: Koha::Objects->empty doesn't work correctly in list context Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Bug ID: 28871 Summary: Koha::Objects->empty doesn't work correctly in list context Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When in list context, it assigns an array with an interator inside. To test: my @patrons = Koha::Patrons->new->empty; Dumper(@patrons); => FAIL: prints [ Koha::Patrons... ] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 16:32:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 14:32:38 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 16:33:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 14:33:00 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:01:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:01:51 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123876&action=edit Bug 28871: Regression test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:01:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:01:55 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 123877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123877&action=edit Bug 28871: Make Koha::Objects->empty work on list context This patch makes Koha::Objects->empty work on list context, by making it return the $self->search call. To test: 1. Apply the regression test patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Note: this patch has the side effect of making Koha::Objects->new->empty to perform a search on the DB. I'm not sure how to solve this because the cache needs to be set after the resultset is generated. It feels like a cleaner approach (i.e. not using the set_cache method). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:01:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:01:59 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 123878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123878&action=edit Bug 28871: (follow-up) Remove caching This patch removes the use of set_cache, as it gets ineffective with this patchset. To test: 1. Without any patches applied do: $ docker exec -ti koha_db_1 bash m$ mysql -ppassword > SET GLOBAL general_log=1; > SET GLOBAL general_log_file='mariadb.log'; > \q m$ tail -f /var/lib/mysql/mariadb.log 2. On a separate terminal run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => Notice that before the DELETE tests are run, there are some queries about borrowers and 0 = 1 3. Apply this patches 4. Repeat 2 => Notice there's an extra query This is only to highlight the side-effect of this change. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:21:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:21:28 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:21:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:21:31 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:21:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:21:33 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:21:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:21:56 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 123879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123879&action=edit Bug 28871: Make Koha::Objects->empty work on list context This patch makes Koha::Objects->empty work on list context, by making it return the $self->search call. To test: 1. Apply the regression test patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:23:01 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 17:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 15:23:01 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 [Bug 28871] Koha::Objects->empty doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:05:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:05:45 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/mrenvoiz | |e/Koha/-/commits/bug_28854 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:06:06 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #1 from Martin Renvoize --- See branch for work in progress: https://gitlab.com/mrenvoize/Koha/-/commits/bug_28854 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:11:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:11:50 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:15:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:15:38 +0000 Subject: [Koha-bugs] [Bug 26878] Add ability to prevent spending against parent funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26878 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:17:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:17:38 +0000 Subject: [Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:19:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:19:06 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:21:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:21:21 +0000 Subject: [Koha-bugs] [Bug 28562] Add date received to basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28562 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:23:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:23:25 +0000 Subject: [Koha-bugs] [Bug 28237] Make notes from the basket visible on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28237 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:42:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:42:59 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 Marci changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mchen at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:44:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:44:53 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 --- Comment #6 from Marci --- This would be very helpful, both for holds and for tracking turnover rate for items purchased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 18:46:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 16:46:46 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 19:13:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 17:13:09 +0000 Subject: [Koha-bugs] [Bug 28872] New: AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Bug ID: 28872 Summary: AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In system preferences, AcquisitionLog, NewsLog, and NoticesLog are all saving values of "on" and "off" when they should be "1" and "0." That means if you change any of these prefs and save new values you end up with errors on the About page: Warning System preference 'AcquisitionLog' must be '0' or '1', but is 'on'. Warning System preference 'NewsLog' must be '0' or '1', but is 'on'. Warning System preference 'NoticesLog' must be '0' or '1', but is 'on'. In a little preliminary testing, this seems to mean we default to ALWAYS logging acquisitions actions, even if it's set to "Don't log." I didn't check whether the other two are ending up on or off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 19:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 17:13:37 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com, | |kelly at bywatersolutions.com, | |sbrown at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 19:13:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 17:13:57 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 19:29:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 17:29:24 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 19:29:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 17:29:27 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 123880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123880&action=edit Bug 28872: make AcquisitionLog, NewsLog, NoticesLog use 1/0 for their values To test: 1 - edit AcquisitionLog, NewsLog, NoticesLog to change their values 2 - in About Koha, see the errors noted above 3 - apply patch, restart services 4 - re-edit AcquisitionLog, NewsLog, NoticesLog to change their values again 5 - reload About, see errors are cleared 6 - confirm that actions are logged as expected when logs are on, not logged when logs are off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 20:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 18:27:28 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #2 from Andrew Fuerste-Henry --- A note on my test plan, the NewsLog is currently broken (bug 28717), so don't expect it to log anything. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 20:41:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 18:41:08 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 20:41:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 18:41:11 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117123|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 123881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123881&action=edit Bug 27725: Use JavaScript to set history state during patron search This patch modifies the patron search page so that clicks on the "Browse by last name" letters add an entry to the browser history, allowing the user to click back and forth from results while preserving their search. To test, apply the patch and go to Patrons in the staff interface. - Click one of the "Browse by last name" letters. - The table of search results should load the correct data. - In the browser's location bar you should see a query string added to the URL, e.g. /cgi-bin/koha/members/members-home.pl?firstletter=Q - Click another letter. - Click the back button. You should be returned to the search results for your first letter choice. - Clicking the forward button should work correctly as well. - Other patron searches (header search, sidebar search) should continue to work as expected. EDIT: Clear single-letter querystring history item if only one result was returned. EDIT 2: Fixed handling of history state changes so that forward and back buttons work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 21:59:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 19:59:05 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 21:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 19:59:14 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 21:59:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 19:59:22 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122810|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 21:59:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 19:59:29 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122811|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 21:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 19:59:38 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122812|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 21:59:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 19:59:49 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122813|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 21:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 19:59:59 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122814|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:00:08 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122815|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:00:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:00:16 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122816|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:00:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:00:25 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:00:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:00:33 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122818|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:00:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:00:41 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:00:50 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:00:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:00:58 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:01:06 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122822|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:01:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:01:14 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:01:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:01:22 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:01:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:01:34 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:01:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:01:44 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:01:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:01:56 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122827|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:02:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:02:04 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122828|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:02:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:02:12 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:02:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:02:17 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:02:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:02:23 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122830|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:02:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:02:32 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:03:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:03:56 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #319 from Tomás Cohen Arazi --- Created attachment 123882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123882&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:04:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:04:07 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #320 from Tomás Cohen Arazi --- Created attachment 123883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123883&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:04:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:04:20 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #321 from Tomás Cohen Arazi --- Created attachment 123884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123884&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:04:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:04:30 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #322 from Tomás Cohen Arazi --- Created attachment 123885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123885&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:04:41 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #323 from Tomás Cohen Arazi --- Created attachment 123886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123886&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:04:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:04:53 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #324 from Tomás Cohen Arazi --- Created attachment 123887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123887&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:05:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:05:04 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #325 from Tomás Cohen Arazi --- Created attachment 123888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123888&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:05:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:05:15 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #326 from Tomás Cohen Arazi --- Created attachment 123889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123889&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:05:26 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #327 from Tomás Cohen Arazi --- Created attachment 123890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123890&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:05:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:05:35 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #328 from Tomás Cohen Arazi --- Created attachment 123891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123891&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:05:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:05:46 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #329 from Tomás Cohen Arazi --- Created attachment 123892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123892&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:05:59 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #330 from Tomás Cohen Arazi --- Created attachment 123893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123893&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:06:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:06:10 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #331 from Tomás Cohen Arazi --- Created attachment 123894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123894&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:06:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:06:22 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #332 from Tomás Cohen Arazi --- Created attachment 123895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123895&action=edit Bug 24857: Fix license statements Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:06:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:06:32 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #333 from Tomás Cohen Arazi --- Created attachment 123896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123896&action=edit Bug 24857: Fix POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:06:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:06:42 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #334 from Tomás Cohen Arazi --- Created attachment 123897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123897&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:06:52 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #335 from Tomás Cohen Arazi --- Created attachment 123898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123898&action=edit Bug 24857: Fix simple-quote string Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:07:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:07:01 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #336 from Tomás Cohen Arazi --- Created attachment 123899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123899&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:07:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:07:12 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #337 from Tomás Cohen Arazi --- Created attachment 123900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123900&action=edit Bug 24857: Fix sorting of new syspref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:07:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:07:24 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #338 from Tomás Cohen Arazi --- Created attachment 123901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123901&action=edit Bug 24857: Change button text from "Create new" to "New volume" Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:07:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:07:33 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #339 from Tomás Cohen Arazi --- Created attachment 123902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123902&action=edit Bug 24857: (QA follow-up) Add volume to table settings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:07:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:07:45 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #340 from Tomás Cohen Arazi --- Created attachment 123903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123903&action=edit Bug 24857: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:07:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:07:55 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #341 from Tomás Cohen Arazi --- Created attachment 123904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123904&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:08:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:08:07 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #342 from Tomás Cohen Arazi --- Created attachment 123905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123905&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:08:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:08:18 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #343 from Tomás Cohen Arazi --- Created attachment 123906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123906&action=edit Bug 24857: (QA follow-up) Fix QA script issues Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:08:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:08:27 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #344 from Tomás Cohen Arazi --- Created attachment 123907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123907&action=edit Bug 24857: (follow-up) Use $c->unhandled_exception This patch makes the controller up to date with the currently used style and codebase. It also sinlences a useless warning, and makes it return 404 (instead of 409) when trying to add items to a volume on a non-existing biblio. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Some warnings 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors, no warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:08:40 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #345 from Tomás Cohen Arazi --- Created attachment 123908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123908&action=edit Bug 24857: Use $c->objects->find Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:08:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:08:52 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #346 from Tomás Cohen Arazi --- Created attachment 123909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123909&action=edit Bug 24857: Fix permissions in spec This patch corrects the spec so it requires the right permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:09:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:09:07 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #347 from Tomás Cohen Arazi --- Created attachment 123910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123910&action=edit Bug 24857: (QA follow-up) Adding items should check volume linked to biblio I noticed some tests included /biblios/{biblio_id}/volumes... in the URL. And they passed :-D This means the biblio_id is never tested. This patch fixes those two tests so they have valid biblio_id in the path, and adds a proper regression test for the expected behavior (409). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Notice the tests pass, even with bad data on the request 2. Apply this patch, notice a test is added for the bad biblio_id case and the other two tests are fixed so they have the intended biblio_id. 3. Repeat 1 => SUCCESS: Tests pass! This means things are correctly tested in the controller and the unit tests cover teh 'bad case' returning 409. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:09:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:09:16 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123880|0 |1 is obsolete| | --- Comment #3 from sandboxes at biblibre.com --- Created attachment 123911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123911&action=edit Bug 28872: make AcquisitionLog, NewsLog, NoticesLog use 1/0 for their values To test: 1 - edit AcquisitionLog, NewsLog, NoticesLog to change their values 2 - in About Koha, see the errors noted above 3 - apply patch, restart services 4 - re-edit AcquisitionLog, NewsLog, NoticesLog to change their values again 5 - reload About, see errors are cleared 6 - confirm that actions are logged as expected when logs are on, not logged when logs are off Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:09:18 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #348 from Tomás Cohen Arazi --- Created attachment 123912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123912&action=edit Bug 24857: (QA follow-up) Further spec fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:10:33 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:15:03 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:15:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:15:07 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123881|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 123913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123913&action=edit Bug 27725: Use JavaScript to set history state during patron search This patch modifies the patron search page so that clicks on the "Browse by last name" letters add an entry to the browser history, allowing the user to click back and forth from results while preserving their search. To test, apply the patch and go to Patrons in the staff interface. - Click one of the "Browse by last name" letters. - The table of search results should load the correct data. - In the browser's location bar you should see a query string added to the URL, e.g. /cgi-bin/koha/members/members-home.pl?firstletter=Q - Click another letter. - Click the back button. You should be returned to the search results for your first letter choice. - Clicking the forward button should work correctly as well. - Other patron searches (header search, sidebar search) should continue to work as expected. EDIT: Clear single-letter querystring history item if only one result was returned. EDIT 2: Fixed handling of history state changes so that forward and back buttons work correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:18:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:18:01 +0000 Subject: [Koha-bugs] [Bug 28873] New: Incorrect age displayed in db_dependent/Koha/Patrons.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Bug ID: 28873 Summary: Incorrect age displayed in db_dependent/Koha/Patrons.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In test suite db_dependent/Koha/Patrons.t actually shows : # Subtest: is_valid_age 1..10 ok 1 - Patron with no dateofbirth is always valid for any category ok 2 - Today=2020-02-28, dob=2015-03-01, is 5, should be valid=0 ok 3 - Today=2020-02-28, dob=2015-02-27, is 5, should be valid=1 ok 4 - Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 ok 5 - Today=2020-02-28, dob=2015-02-28, is 7, should be valid=1 ok 6 - Today=2020-02-28, dob=2009-02-27, is 11, should be valid=0 ok 7 - Today=2020-02-28, dob=2016-08-27, is 3, should be valid=0 ok 8 - Today=2020-02-28, dob=2009-03-01, is 11, should be valid=1 ok 9 - Today=2020-02-28, dob=2007-08-27, is 12, should be valid=0 ok 10 - Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 Some ages are incorrect : 1) dob=2009-03-01, is 11 => it is age 10 so valid=1 in category 5 to 10 2) dob=2015-03-01, is 5 => it is age 4 so valid=0 in category 5 to 10 3) dob=2015-02-28, is 7 => this date of birth is already tested I suppose here dob is wrong, age wanted is 7 in the middle of age restrictions. so dob=2013-02-28 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:18:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:18:27 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:19:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:19:38 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 --- Comment #10 from David Nind --- Testing notes: - Tested using Firefox 91 and Google Chrome 91.0.4472.114 on Ubuntu 18.04 (64 bit) - Back and forward buttons work and display previous results - everything else seems to work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:22:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:22:53 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 22:22:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 20:22:57 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 --- Comment #1 from Fridolin Somers --- Created attachment 123914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123914&action=edit Bug 28873: Fix age displayed in db_dependent/Koha/Patrons.t In test suite db_dependent/Koha/Patrons.t actually shows : 1..10 ok 1 - Patron with no dateofbirth is always valid for any category ok 2 - Today=2020-02-28, dob=2015-03-01, is 5, should be valid=0 ok 3 - Today=2020-02-28, dob=2015-02-27, is 5, should be valid=1 ok 4 - Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 ok 5 - Today=2020-02-28, dob=2015-02-28, is 7, should be valid=1 ok 6 - Today=2020-02-28, dob=2009-02-27, is 11, should be valid=0 ok 7 - Today=2020-02-28, dob=2016-08-27, is 3, should be valid=0 ok 8 - Today=2020-02-28, dob=2009-03-01, is 11, should be valid=1 ok 9 - Today=2020-02-28, dob=2007-08-27, is 12, should be valid=0 ok 10 - Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 Some ages are incorrect : 1) dob=2009-03-01, is 11 => it is age 10 so valid=1 in category 5 to 10 2) dob=2015-03-01, is 5 => it is age 4 so valid=0 in category 5 to 10 3) dob=2015-02-28, is 7 => this date of birth is already tested I suppose here dob is wrong, age wanted is 7 in the middle of age restrictions. so dob=2013-02-28 This patch fixes ages. Also adds the category code 'AGE_5_10' in messages to display age limits Test plan : Run prove -v t/db_dependent/Koha/Patrons.t without and with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:19:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:19:08 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:19:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:19:13 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123914|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123915&action=edit Bug 28873: Fix age displayed in db_dependent/Koha/Patrons.t In test suite db_dependent/Koha/Patrons.t actually shows : 1..10 ok 1 - Patron with no dateofbirth is always valid for any category ok 2 - Today=2020-02-28, dob=2015-03-01, is 5, should be valid=0 ok 3 - Today=2020-02-28, dob=2015-02-27, is 5, should be valid=1 ok 4 - Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 ok 5 - Today=2020-02-28, dob=2015-02-28, is 7, should be valid=1 ok 6 - Today=2020-02-28, dob=2009-02-27, is 11, should be valid=0 ok 7 - Today=2020-02-28, dob=2016-08-27, is 3, should be valid=0 ok 8 - Today=2020-02-28, dob=2009-03-01, is 11, should be valid=1 ok 9 - Today=2020-02-28, dob=2007-08-27, is 12, should be valid=0 ok 10 - Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 Some ages are incorrect : 1) dob=2009-03-01, is 11 => it is age 10 so valid=1 in category 5 to 10 2) dob=2015-03-01, is 5 => it is age 4 so valid=0 in category 5 to 10 3) dob=2015-02-28, is 7 => this date of birth is already tested I suppose here dob is wrong, age wanted is 7 in the middle of age restrictions. so dob=2013-02-28 This patch fixes ages. Also adds the category code 'AGE_5_10' in messages to display age limits Test plan : Run prove -v t/db_dependent/Koha/Patrons.t without and with patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:21:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:21:04 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): - Look for test 19 - is_valid_age -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:30:08 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hm, I think we should add a database update here, to set the logs to 0 or 1 according to the current setting to fit what was actually selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:43:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:43:30 +0000 Subject: [Koha-bugs] [Bug 20587] Add option to delete notices out of message queue via notices tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28863 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:43:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:43:30 +0000 Subject: [Koha-bugs] [Bug 28863] Cancel a Pending Notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20587 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:57:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:57:10 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 17 23:57:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 21:57:14 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123915|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 123916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123916&action=edit Bug 28873: Fix age displayed in db_dependent/Koha/Patrons.t In test suite db_dependent/Koha/Patrons.t actually shows : 1..10 ok 1 - Patron with no dateofbirth is always valid for any category ok 2 - Today=2020-02-28, dob=2015-03-01, is 5, should be valid=0 ok 3 - Today=2020-02-28, dob=2015-02-27, is 5, should be valid=1 ok 4 - Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 ok 5 - Today=2020-02-28, dob=2015-02-28, is 7, should be valid=1 ok 6 - Today=2020-02-28, dob=2009-02-27, is 11, should be valid=0 ok 7 - Today=2020-02-28, dob=2016-08-27, is 3, should be valid=0 ok 8 - Today=2020-02-28, dob=2009-03-01, is 11, should be valid=1 ok 9 - Today=2020-02-28, dob=2007-08-27, is 12, should be valid=0 ok 10 - Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 Some ages are incorrect : 1) dob=2009-03-01, is 11 => it is age 10 so valid=1 in category 5 to 10 2) dob=2015-03-01, is 5 => it is age 4 so valid=0 in category 5 to 10 3) dob=2015-02-28, is 7 => this date of birth is already tested I suppose here dob is wrong, age wanted is 7 in the middle of age restrictions. so dob=2013-02-28 This patch fixes ages. Also adds the category code 'AGE_5_10' in messages to display age limits Test plan : Run prove -v t/db_dependent/Koha/Patrons.t without and with patch Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:10:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:10:28 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:10:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:10:31 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123801|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 123917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123917&action=edit Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previously released version, e.g. 'tags/v20.11.08' you will see a link directly to that schema page. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:10:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:10:36 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123802|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 123918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123918&action=edit Bug 28454: (follow-up) Add schema version to link on reports home page This patch makes the same changes to the script and template for the reports home page. Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:20:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:20:43 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:20:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:20:47 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123717|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 123919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123919&action=edit Bug 28525: Dont let TinyMCE do code cleanup To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like 'TEST' 6. It's cleaned up by the editor. 7. Try something like '' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:24:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:24:49 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:24:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:24:53 +0000 Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123697|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 123920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123920&action=edit Bug 28830: Add cni index for 003 This patch adds the cni/Control-number-identifier index to enable searches to use the 003 field. Test plan 1/ Apply patch 2/ Re-index using updated configurations 3/ Confirm cni:number searches yield the expected results 4/ Signoff Split-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 00:26:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 22:26:14 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to item search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add link to Item Search |Add link to item search |from mainpage.pl |from mainpage.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 01:59:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 23:59:06 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 01:59:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Aug 2021 23:59:09 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 123921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123921&action=edit Bug 28872: Atomicupdate to correct existing values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 02:00:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 00:00:01 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #6 from Andrew Fuerste-Henry --- Good call! I've added an atomicupdate to correct existing values. That structure has changed a little since the last one I did, so please let me know if I've done something wrong! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 03:54:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 01:54:14 +0000 Subject: [Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 --- Comment #16 from wainuiwitikapark at catalyst.net.nz --- It is broken in 19.11 so will backport it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 04:03:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 02:03:40 +0000 Subject: [Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.09,20.05.15 |20.11.09,20.05.15,19.11.21 released in| | Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #17 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.21 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 04:37:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 02:37:43 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01,20.11.07, released in| |19.11.21 --- Comment #11 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 08:46:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 06:46:36 +0000 Subject: [Koha-bugs] [Bug 26995] Drop column relationship from borrower tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 --- Comment #24 from David Cook --- Uh oh, we've introduced a regression here with data loss... It turns out we still needed the "relationship" column for "Non-patron guarantor" entries. It means you can't save patron records that need guarantors because the form can't be processed. And anyone who applies 21.05 will lose the data that they had in borrowers.relationship... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 08:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 06:47:54 +0000 Subject: [Koha-bugs] [Bug 26995] Drop column relationship from borrower tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 --- Comment #25 from David Cook --- (In reply to David Cook from comment #24) > Uh oh, we've introduced a regression here with data loss... > > It turns out we still needed the "relationship" column for "Non-patron > guarantor" entries. > > It means you can't save patron records that need guarantors because the form > can't be processed. > > And anyone who applies 21.05 will lose the data that they had in > borrowers.relationship... Ah, just noticed bug 28490. People are already on top of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:23:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:23:12 +0000 Subject: [Koha-bugs] [Bug 28874] New: We need javascript equivalents to many of our TT plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 Bug ID: 28874 Summary: We need javascript equivalents to many of our TT plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We have some really great TT plugins and includes.. but with a slow but steady move to using ajax for various things, many of these TT specific snippets would benefit from a javascript equivalent. Some examples off the top of my head: * AuthorisedValues * Biblio title * Accountline type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:25:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:25:48 +0000 Subject: [Koha-bugs] [Bug 28875] New: 500 ISE when saving OAI-PMH:ConfFile Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28875 Bug ID: 28875 Summary: 500 ISE when saving OAI-PMH:ConfFile Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 123922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123922&action=edit Screenshot of 500 response On 20.11.05, when I try to set OAI-PMH:ConfFile to the path of a file (e.g. /home/me/file.yalm), I get the message "Internal Server Error, please reload the page". This error comes because /cgi-bin/koha/svc/config/systempreferences/ gives a 500 Internal Server Error response. I have tried reloading the page, logging in and out etc, but the error is still there. The logs do not get anything at all when the 500 response happens, which seems weird. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:26:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:26:34 +0000 Subject: [Koha-bugs] [Bug 28863] Cancel a Pending Notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:26:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:26:50 +0000 Subject: [Koha-bugs] [Bug 28875] 500 ISE when saving OAI-PMH:ConfFile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28875 --- Comment #1 from Magnus Enger --- Oh, and if i enter some random string like "dfdf" it saves just fine, so it might be the slashes ("/") that cause problems? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:46:43 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121120|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 123923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123923&action=edit Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:46:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:46:47 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #18 from Martin Renvoize --- Created attachment 123924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123924&action=edit Bug 28346: (QA follow-up) Add `-action` for consistency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:47:07 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:47:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:47:16 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121122|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:47:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:47:23 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:48:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:48:22 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #19 from Martin Renvoize --- Patches squashed and follow-up added to address -action consistency concerns. Feel free to squash the follow-up on push.. I was not entirely sure about updating the pre-existing 'void' class and hence kept the patch distinct for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:50:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:50:17 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123876|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 123925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123925&action=edit Bug 28871: Regression test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:50:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:50:20 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123879|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 123926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123926&action=edit Bug 28871: Make Koha::Objects->empty work on list context This patch makes Koha::Objects->empty work on list context, by making it return the $self->search call. To test: 1. Apply the regression test patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 10:50:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 08:50:49 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- No obvious regressions found, nice simple patch. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:11:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:11:33 +0000 Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hm, I have a few issues and concerns here: 1) I think I'd like to have the note show in the column once it was added. At the moment it's easy to miss it, as you have to click on "Edit note" first to see it. 2) We have export functionality on this table now (I think after this patch was initially written) and instead of the notes we see "Add note" or "Edit note" in the column. 3) I am a little worried if translation tools will pick up on this construct: [% IF ( ISSUE.note ) -%] + [% SET note_action = "Edit note" %] + [% ELSE -%] + [% SET note_action = "Add note" %] + [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:16:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:16:31 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:16:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:16:37 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123272|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 123927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123927&action=edit Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:16:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:16:42 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123273|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 123928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123928&action=edit Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:16:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:16:46 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123274|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 123929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123929&action=edit Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:21:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:21:01 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Katrin Fischer --- The question here is which icon to keep - I like Owen's a little better as it's not as heavy and matches the style of the other carredart icons a little better. But then we should possibly only add his to the repo and remove the first 2 patches? Owen, could you provide your icon as a 'only' patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:23:01 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #4 from Fridolin Somers --- (In reply to Lucas Gass from comment #3) > (In reply to Fridolin Somers from comment #2) > > Mmm this is changed since 20.11.00. > > We at Biblibre have fixed each broken customisation of OPAC. > > This is not the only change, and for me it makes sens to have an id instead > > of a class for a tag existing only once in the page. > > Why can't it have both? It can, I'm not against it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:28:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:28:50 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:28:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:28:54 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123275|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 123930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123930&action=edit Bug 27523: Adding new itemtype lock image to carredart This patch adds a new "lock" image to the carredart icon set. The source of the image is in the public domain: https://thenounproject.com/icon/89649. Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a lock item type under the carredart 3. Modify the item type so the lock item type is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:31:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:31:04 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:31:08 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123276|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 123931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123931&action=edit Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:32:17 +0000 Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:33:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:33:13 +0000 Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing 'Holds history' tab for a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:37:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:37:33 +0000 Subject: [Koha-bugs] [Bug 28876] New: No renewal before advisory text not wrapped in selector Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 Bug ID: 28876 Summary: No renewal before advisory text not wrapped in selector Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org Using 'No renewal before' in the circulation rules is a very useful setting, as it blocks a patron from accidentally renewing too many times in quick succession on the OPAC and using up all of their permitted renewals. But the setting also adds some advisory text to the OPAC which confuses our patrons. We would like to be able to hide this text, but it's not wrapped in a selector so we can't target it. To replicate: - Create a circulation rule which includes: Renewals allowed: 4 Renewal period: 21 No renewal before: 20 - Check an appropriate item out to an account with a due date of +10 days - Log into the OPAC with the account - Renew the item - Note that the following (example) information appears in the Renew column: Renewed! No renewal before 19/08/2021 00:00 (3 of 4 renewals remaining) - Use Chrome/Firefox dev/inspect tools and note that 'Renewed!' is wrapped in a span class called 'blabel label-success', and '(3 of 4 renewals remaining)' is wrapped in a span class called 'renewals'. It would be really helpful if a span class could be added to this part of the opac-user.tt template: [% ELSIF ( ISSUE.too_soon ) %] No renewal before [% ISSUE.soonestrenewdate | html %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:50:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:50:50 +0000 Subject: [Koha-bugs] [Bug 28877] New: Fix warns in logs when using plural translations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28877 Bug ID: 28877 Summary: Fix warns in logs when using plural translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Depends on: 26979 Bug 26979 added some plural handling to the labels shown in circulation. There are some additional warns that are appearing because of this in the QA test tools: Argument "" isn't numeric in subroutine entry at /usr/local/share/perl/5.24.1/Locale/Messages.pm line 285. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 [Bug 26979] Show correctly-pluralized labels on checkouts page tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:50:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:50:50 +0000 Subject: [Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28877 [Bug 28877] Fix warns in logs when using plural translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:51:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:51:19 +0000 Subject: [Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 --- Comment #4 from Katrin Fischer --- This patch set adds a few warns to the logs, but I believe that these will likely appear on other pages using the plural translations: Argument "" isn't numeric in subroutine entry at /usr/local/share/perl/5.24.1/Locale/Messages.pm line 285. Argument "" isn't numeric in subroutine entry at /usr/local/share/perl/5.24.1/Locale/Messages.pm line 285. Argument "" isn't numeric in subroutine entry at /usr/local/share/perl/5.24.1/Locale/Messages.pm line 285. So I am moving them to a separate bug 28877. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:52:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:52:23 +0000 Subject: [Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 11:52:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 09:52:26 +0000 Subject: [Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123350|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 123932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123932&action=edit Bug 26979: Show correctly-pluralized labels on checkouts page tabs This patch modifies the tabs shown on the checkout and patron detail page so that counts of checkouts, etc. have the correct pluralization. This avoids the use of labels like "Checkout(s)" To test, apply the patch and check out to a patron. - The tabs showing checkouts, holds, claims, etc. should show the correct plural or singular on each label, e.g.: 14 Checkouts 20 Holds 0 Article requests 1 Club - Test that each plural/singular changes appropriately when you add checkouts, holds, clubs, etc. To test translation, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the templates e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from circulation.tt and moremember.tt translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:770 msgid "Relatives' checkout" msgid_plural "Relatives' checkouts" msgstr[0] "" msgstr[1] "" - Edit the "msgstr[0]" and "msgstr[1]" strings however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the staff client, switch to the language you're testing. Confirm that your translated strings appear correctly in singular and plural cases. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:06:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:06:46 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123863|0 |1 is obsolete| | --- Comment #5 from sandboxes at biblibre.com --- Created attachment 123933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123933&action=edit Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:07:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:07:10 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #6 from Sally --- Works as described - thanks Lucas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:14:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:14:45 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:14:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:14:49 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123860|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 123934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123934&action=edit Bug 28850: Reword AllFinesNeedOverride To test: Apply patch, look up AllFinesNeedOverride, confirm it now says that checkouts will be blocked via the web-based selfcheck and SIP. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:14:53 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 --- Comment #4 from Katrin Fischer --- Created attachment 123935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123935&action=edit Bug 28850: (QA follow-up) Add "patrons with fines" for clarification Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:15:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:15:28 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 --- Comment #5 from Katrin Fischer --- I can confirm from our experience that this also blocks checkouts via SIP2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:19:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:19:59 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:20:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:20:04 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123933|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 123936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123936&action=edit Bug 28868: Add back mastheadsearch class name Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:24:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:24:54 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #7 from Katrin Fischer --- Also my first! There are some problems noted by the QA script: FAIL installer/data/mysql/atomicupdate/bug_28872_update_log_values.pl OK critic FAIL file permissions File must have the exec flag OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Useless use of anonymous hash ({}) in void context The first one would be an easy fix, but not sure if strictly necessary. updatedatabase still works correctly and the file will be removed. The second one is a bit puzzling to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 12:39:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 10:39:08 +0000 Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of our TT plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- What do you mean by "javascript equivalent"? Using a REST API route? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:00:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:00:57 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #115 from Jonathan Druart --- Created attachment 123937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123937&action=edit Bug 25078: Explicitely return from DB revs to avoid warnings % perl -wc installer/data/mysql/atomicupdate/skeleton.pl Useless use of anonymous hash ({}) in void context at installer/data/mysql/atomicupdate/skeleton.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:01:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:01:34 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #116 from Jonathan Druart --- (In reply to Jonathan Druart from comment #115) > Created attachment 123937 [details] [review] > Bug 25078: Explicitely return from DB revs to avoid warnings > > % perl -wc installer/data/mysql/atomicupdate/skeleton.pl > Useless use of anonymous hash ({}) in void context at > installer/data/mysql/atomicupdate/skeleton.pl Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:03:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:03:50 +0000 Subject: [Koha-bugs] [Bug 28878] New: Advanced search button on mainpage.pl incorrectly links to item search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Bug ID: 28878 Summary: Advanced search button on mainpage.pl incorrectly links to item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The follow-up on Bug 28819 changed the link for the Advanced search button on mainpage.pl. If you roll your mouse over the Advanced search button, note that the link is now: cgi-bin/koha/catalogue/itemsearch.pl It should be: cgi-bin/koha/catalogue/search.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:04:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:04:00 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28819 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:04:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:04:00 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to item search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28878 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:04:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:04:22 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:06:18 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:24:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:24:00 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #56 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #55) > Been following the comments here all day and keep wondering - what are the > new status named? > > I have seen new and pending - but they kind of are the same to me? No, new and pending are not the same. You could say that a pending request is a new request that has been put on hold since there is a reason why you cannot fill the request right away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:24:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:24:33 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:24:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:24:36 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123804|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 123938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123938&action=edit Bug 28843: Add view and edit buttons to result of MARC record import This patch adds "View" and "Edit" buttons to the output of the result of a MARC record import. To test, apply the patch and go to Tools -> State MARC for import. - Import a file of MARC records. - Click the "Manage staged records" button. - In the table of staged records the last column labeled "Records" should be empty. - Click "Import this batch into the catalog." - The table of records will be shown again, and this time the last column should contain "View" and "Edit" buttons for each row. - Confirm that the buttons work correctly, opening the correct record for viewing and editing. Test with both bibliographic and authority records to confirm that the correct view and edit pages open for each. EDIT: Add permission check for "Edit" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:28:32 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:28:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:28:35 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123927|0 |1 is obsolete| | Attachment #123928|0 |1 is obsolete| | Attachment #123929|0 |1 is obsolete| | --- Comment #16 from Owen Leonard --- Created attachment 123939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123939&action=edit Bug 27521: Add new item type headset image for carredart The image added by this patch was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:33:22 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #8 from Kyle M Hall --- Created attachment 123940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123940&action=edit Bug 28872: (QA follow-up) print a message describing what has happened -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:40:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:40:24 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #57 from Katrin Fischer --- Hm, I am not sure how clear that is from the naming, although I understand the intention better now. A little worried about the terminology clashing with what we have for holds in translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 13:50:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 11:50:29 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123940|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 123941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123941&action=edit Bug 28872: (QA follow-up) Update printed messaged, fix file permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:17:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:17:20 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123941|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 123942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123942&action=edit Bug 28872: Fix QA issues on atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:17:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:17:34 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #11 from Jonathan Druart --- There was a problem in the skeleton file, I've fixed it in master and adjusted the atomic update here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:18:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:18:14 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #12 from Jonathan Druart --- Sorry, I got a collision a couple of hours ago when I submitted the patch and didn't realize until now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:18:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:18:55 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #13 from Andrew Fuerste-Henry --- Thanks Jonathan and Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:22:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:22:26 +0000 Subject: [Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Katrin Fischer --- Looking at this again I can see that it removes the divided display of unresolved/resolved claims with the colored mark-up. I think as this was explicitly added after the initial feature request, this could be missed. Setting back to FQA for now. completely different question: should it be 1 checkout or 1 Checkout? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:26 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:31 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122984|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy --- Created attachment 123943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123943&action=edit Bug 27944: Add new letter in atomicupdate, and modify status column in article_requests table Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:35 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122985|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy --- Created attachment 123944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123944&action=edit Bug 27944: Add AR_REQUESTED message in sample_notices.yml and modify AR_PENDING Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:39 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122986|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy --- Created attachment 123945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123945&action=edit Bug 27944: Add "requested" stage in article request process This patch adds the stage "requested" in article request process, which is previous to pending stage. To test: 1. apply this patch 2. updatedatabase 3. enable ArticleRequests syspref 4. from staff inteface and from opac search for a record and place an article request 5. koha-mysql kohadev 6. query: select subject, content, letter_code from message_queue; CHECK => There is a message for each article request with code AR_REQUESTED => In opac-user.pl, in "Article requests" tab you should see a row in the table with "Requested" status 5. in staff go to Circulation -> Article Requests SUCCESS => You should see 3 tabs, one for Requested stage (with two requests), one for Pending stage and one for Processing stage. 6. play with actions buttons CHECK => you should see a new action called "Set request as pending" SUCCESS => All action buttons behave as expected, and tab counts updates correctly. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:43 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122987|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy --- Created attachment 123946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123946&action=edit Bug 27944: Add missing Status module Test plan: perl -c the module or run qa tools Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:47 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122988|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy --- Created attachment 123947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123947&action=edit Bug 27944: (follow-up) Improving consistency between notice names Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:51 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122989|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy --- Created attachment 123948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123948&action=edit Bug 27944: (follow-up) Move existing statuses, rename idempotent Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:55 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122990|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy --- Created attachment 123949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123949&action=edit Bug 27944: (follow-up) Move statuses to constants Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:28:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:28:59 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123710|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy --- Created attachment 123950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123950&action=edit Bug 27944: REQUESTED is the new default status Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:29:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:29:03 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123711|0 |1 is obsolete| | --- Comment #66 from Marcel de Rooy --- Created attachment 123951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123951&action=edit Bug 27944: (QA follow-up) Rename ->open for ->set_pending Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:29:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:29:08 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123712|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy --- Created attachment 123952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123952&action=edit Bug 27944: (QA follow-up) Make staff home page show new article requests As exposed on comment 29, the current code is showing the 'pending' requests when it should display 'requested' ones (i.e. the new ones). This patch changes that accordingly. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:40:42 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:40:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:40:47 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123923|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 123953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123953&action=edit Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:40:53 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #21 from Katrin Fischer --- Created attachment 123954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123954&action=edit Bug 28346: (QA follow-up) Add `-action` for consistency Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:42:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:42:23 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:42:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:42:27 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123939|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 123955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123955&action=edit Bug 27521: Add new item type headset image for carredart The image added by this patch was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:47:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:47:15 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #23 from Marcel de Rooy --- FAIL Koha/Exceptions/ArticleRequest.pm FAIL pod coverage POD is missing for 'description' False negative -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:47:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:47:22 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:47:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:47:26 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123911|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 123956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123956&action=edit Bug 28872: make AcquisitionLog, NewsLog, NoticesLog use 1/0 for their values To test: 1 - edit AcquisitionLog, NewsLog, NoticesLog to change their values 2 - in About Koha, see the errors noted above 3 - apply patch, restart services 4 - re-edit AcquisitionLog, NewsLog, NoticesLog to change their values again 5 - reload About, see errors are cleared 6 - confirm that actions are logged as expected when logs are on, not logged when logs are off Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:47:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:47:31 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123921|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 123957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123957&action=edit Bug 28872: Atomicupdate to correct existing values Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:47:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:47:35 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123942|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 123958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123958&action=edit Bug 28872: Fix QA issues on atomicupdate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:50:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:50:06 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #17 from Katrin Fischer --- Why do I not find any references to NewsLog outside of the log viewer tt? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:50:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:50:32 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 --- Comment #5 from Jonathan Druart --- Shouldn't we actually move all the JS files to koha-tmpl/intranet-tmpl/prog/js? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:55:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:55:50 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #18 from Kyle M Hall --- (In reply to Katrin Fischer from comment #17) > Why do I not find any references to NewsLog outside of the log viewer tt? It's from Bug 26205. You are right, something has happened -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:55:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:55:59 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #24 from Marcel de Rooy --- Koha::Patron + my $count = Koha::ArticleRequests->search({ + borrowernumber => $self->borrowernumber, + status => {'!=' => 'CANCELED'}, + created_on => { + '>=' => $date->date.' 00:00:00', + '<=' => $date->date.' 23:59:59' + } + })->count; We should use Koha::Database->new->schema->storage->datetime_parser. Look in the same modules for more examples. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:57:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:57:44 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #19 from Kyle M Hall --- (In reply to Kyle M Hall from comment #18) > (In reply to Katrin Fischer from comment #17) > > Why do I not find any references to NewsLog outside of the log viewer tt? > > It's from Bug 26205. You are right, something has happened Removed by Bug 22544, looks like you caught a regression! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:59:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:59:15 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Attachment #123924|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:59:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:59:29 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #20 from Kyle M Hall --- (In reply to Kyle M Hall from comment #19) > (In reply to Kyle M Hall from comment #18) > > (In reply to Katrin Fischer from comment #17) > > > Why do I not find any references to NewsLog outside of the log viewer tt? > > > > It's from Bug 26205. You are right, something has happened > > Removed by Bug 22544, looks like you caught a regression! Looks like Bug 28717 is the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:59:55 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Depends on| |26205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 [Bug 26205] News changes aren't logged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 14:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 12:59:55 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 [Bug 28717] NewsLog doesn't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:06:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:06:20 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 --- Comment #9 from Jonathan Druart --- Master_D11 367 Docker_1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:06:38 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:07:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:07:51 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #11 from Jonathan Druart --- Patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:10:52 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123919|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 123959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123959&action=edit Bug 28525: Dont let TinyMCE do code cleanup If you look at Bug 24764 and Bug 26942 we adjusted the TinyMCE for the News tool so it will not do some types of automatic code clean up. The TinyMCE editor for system preferences which can be enabled by 'UseWYSIWYGinSystemPreferences' has the same problems. We should make the configurations the same. To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like 'TEST' 6. It's cleaned up by the editor. 7. Try something like '' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:11:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:11:39 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- Lucas, don't forget the commit message to describe a bit the context please (not only the commit title) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:11:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:11:49 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123936|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 123960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123960&action=edit Bug 28868: Add back mastheadsearch class name In masthead.inc there is a wrapper for the main search bar called #opac-main-search. Prior to Bug 20168 that warpper had a class name of 'mastheadsearch'. Historically CSS/JS customization of the main search bar was done via the mastheadsearch class. Test plan: 1. Inscept the element on the OPAC main page and see the element with an ID of 'opac-main-search'. 2. Apply patch 3. Inscept that same element and you should now also see a class of 'mastheadsearch'. 4. Nothing visually should be different with the patch applied. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:12:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:12:05 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:12:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:12:29 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:18:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:18:33 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27521, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27522, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27523 CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:18:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:18:33 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27505 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:18:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:18:33 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27505 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:18:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:18:33 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27505 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:19:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:19:11 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:19:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:19:11 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27505 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:31:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:31:02 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #25 from Marcel de Rooy --- Side note Currently we use the following custom check to limit numbers: my $compdate = dt_from_string->add( days => -1 ); my $count = Koha::ArticleRequests->search([ { borrowernumber => $borrowernumber, status => ['PENDING','PROCESSING'] }, { borrowernumber => $borrowernumber, status => 'COMPLETED', updated_on => { '>', Koha::Database->new->schema->storage->datetime_parser->format_date($compdate) }}, ])->count; This does not take into consideration the new/requested and pending status. So pending is still new here. But it looks at the number of requests in the pipeline for the user PLUS the completed ones within the last 24 hours. Advantage illustrated by the example below: Proposed check: Say that the limit is 5. User submits 5 requests on Friday night, Saturday, Sunday and Monday morning. This makes that we need to process 20 requests coming in on Monday. "Custom" check: User may only submit 5 requests on Friday night if we did not complete requests during that day. He is not allowed any more requests during the weekend. Only when we complete say 1 request on Monday, he is allowed to submit another one on Tuesday (24 hours later). What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:35:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:35:39 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- The second patch is removing lines that is not related to this change (and not advertised in the commit message). Is that expected? Moreover you are duplicating code (that exists already), why don't you use 'Koha.Version' from the template instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:13 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:17 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:19 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:22 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:25 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:29 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:32 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:34 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:37 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:39 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:42 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:44 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:47 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:51 +0000 Subject: [Koha-bugs] [Bug 28850] Clarify wording on AllFinesNeedOverride system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28850 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:53 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:56 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:36:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:36:58 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:37:01 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:37:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:37:03 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:37:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:37:05 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:41:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:41:28 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds back the release notes| |class 'mastheadsearch' | |which was lost during the | |upgrade to Bootstrap 4 in | |Bug 20168. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:47:07 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #26 from Marcel de Rooy --- diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm index e79e01610c..078f00bc70 100644 --- a/Koha/ArticleRequest.pm +++ b/Koha/ArticleRequest.pm @@ -27,7 +27,9 @@ use Koha::Items; use Koha::Libraries; use Koha::DateUtils qw( dt_from_string ); use C4::Context; +use Koha::ArticleRequests; Why do you add it here? Note that bug 27944 adds the Status module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:54:47 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:56:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:56:08 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #27 from Marcel de Rooy --- } elsif ($article_request_limit ne '' && $article_request_limit !~ /\d+/) { If I add 2a in the limit field (fool proof), the form says that I successfully updated the record. But actually I didnt. Your regex could include ^\d+$ ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:57:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:57:21 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:59:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:59:27 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #28 from Marcel de Rooy --- Overall: Looks good to me. Discussion item in comment25. Needs a few small adjustments for comment24, comment26 and comment27. Note that the dependency on 27946 is unfortunate. This could reach master sooner than 27946 which has a dependency on unfinished Accounting work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 15:59:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 13:59:36 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:00:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:00:43 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:06:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:06:35 +0000 Subject: [Koha-bugs] [Bug 28879] New: Display of metadata with long label names looks terrible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Bug ID: 28879 Summary: Display of metadata with long label names looks terrible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com This has come to light whilst developing a RapidILL backend. When viewing a request, the request metadata display is completely borked if a metadata property name is long. The CSS appears to be trying to emulate a table layout, which only works with short metadata labels. This can much better be achieved with Flex. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:07:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:07:03 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:09:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:09:34 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 --- Comment #1 from Andrew Isherwood --- Created attachment 123961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123961&action=edit Bug 28879: Fix display of request metadata This commit adjusts the CSS surrounding the display of request metadata, it improves the display for metadata with long key names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:11:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:11:28 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Andrew Isherwood --- Test plan: - Do not apply patch - Create a FreeForm ILL request with a custom metadata field with a long name - View the created request - Observe that the long metadata name breaks the display of the metadata - Apply the patch - View the created request => TEST: Observe that the display is no longer broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:13:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:13:24 +0000 Subject: [Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart --- You must html filter the tn (not raw). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:15:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:15:53 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:16:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:16:22 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115752|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:16:27 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115751|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:17:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:17:38 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Attachment #123955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:17:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:17:46 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115747|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:17:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:17:51 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115748|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:18:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:18:28 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Attachment #123930|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:18:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:18:36 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115743|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:18:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:18:41 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115744|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:19:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:19:12 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Attachment #122931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:19:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:19:24 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:19:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:19:32 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:22:46 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 --- Comment #14 from Jonathan Druart --- Based on bug 27522 comment 22 I have decided to restore the original version of the icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:22:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:22:52 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 --- Comment #11 from Jonathan Druart --- Based on bug 27522 comment 22 I have decided to restore the original version of the icon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:23:01 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #10 from Jonathan Druart --- Based on bug 27522 comment 22 I have decided to restore the original version of the icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:23:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:23:07 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 --- Comment #18 from Jonathan Druart --- Based on bug 27522 comment 22 I have decided to restore the original version of the icon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:26:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:26:11 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 --- Comment #7 from Jonathan Druart --- Created attachment 123962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123962&action=edit Bug 28802: Fix Asset.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:27:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:27:49 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:16 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:19 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:21 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:24 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:29 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:34 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 --- Comment #19 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:36 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:39 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #28 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:42 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:43 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > Created attachment 123962 [details] [review] > Bug 28802: Fix Asset.t Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:31:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:31:45 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:39:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:39:47 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:51:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:51:10 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 --- Comment #10 from Jonathan Druart --- Created attachment 123963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123963&action=edit Bug 21670: Add debug to Plugins.t It's failing randomly (at least on Jenkins, cannot recreate locally). Maybe the plugin is not actually installed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:51:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:51:48 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 --- Comment #11 from Jonathan Druart --- What about pushing this patch to get a bit more info? Do you think we should add more? If so, which ones? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:58:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:58:06 +0000 Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of our TT plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 --- Comment #2 from Martin Renvoize --- As in a nice simple way to construct display options from data returned from the API. Example, if we want to replace some of our data tables with Ajax equivalents using the API, for anything that includes Biblio title we can't easily replicate the structure returned by the biblio-title.inc template.. i.e a nice linked title consisting of multiple fields from the bib record. Yes, we can add a custom render function but we should keep it dry/reusable in the same way the template include is. Similarly, I'm not sure what route we've taken with regards av displays and the API. We return lots of codes.. is the intention to use embeds to get descriptions and even then, are we distinguishing between opac and staff and translations? Having a nice easy to call tender function that takes the code and converts it for display the way we have for TT would aid in the route to modernising the front end with load on demand and things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 16:58:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 14:58:15 +0000 Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of our TT plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 --- Comment #3 from Martin Renvoize --- As in a nice simple way to construct display options from data returned from the API. Example, if we want to replace some of our data tables with Ajax equivalents using the API, for anything that includes Biblio title we can't easily replicate the structure returned by the biblio-title.inc template.. i.e a nice linked title consisting of multiple fields from the bib record. Yes, we can add a custom render function but we should keep it dry/reusable in the same way the template include is. Similarly, I'm not sure what route we've taken with regards av displays and the API. We return lots of codes.. is the intention to use embeds to get descriptions and even then, are we distinguishing between opac and staff and translations? Having a nice easy to call tender function that takes the code and converts it for display the way we have for TT would aid in the route to modernising the front end with load on demand and things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:02:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:02:28 +0000 Subject: [Koha-bugs] [Bug 28877] Fix warns in logs when using plural translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28877 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- I am seeing Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 128. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 128. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 237. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 716. but not yours. Which version of Locale::Messages are you using? % pmvers Locale::Messages 1.26 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:07:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:07:30 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 --- Comment #12 from Lucas Gass --- I very much appreciate everyone's efforts on this one, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:08:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:08:30 +0000 Subject: [Koha-bugs] [Bug 28875] 500 ISE when saving OAI-PMH:ConfFile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Works for me on master and v20.11.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:19:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:19:50 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas at bywatersolutions.com |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:19:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:19:56 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:39:02 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #12 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > What about pushing this patch to get a bit more info? Do you think we should > add more? If so, which ones? Yes, please! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:39:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:39:25 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Keywords| |release-notes-needed CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:41:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:41:52 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 17:45:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 15:45:12 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #5 from Andrew Nugged --- Note: Jonathan, Bug 28700 has much bigger impact on logs records size -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:01:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:01:59 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 --- Comment #16 from Jonathan Druart --- Created attachment 123964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123964&action=edit Bug 28717: Fix additional content logs The logging for additional contents added by bug 26205 has been broken by but 22544. This patch is a revisited version as bug 24387 has been pushed. It does not log MODIFY if no modification has been made on a template (useful when only 1 version/lang of a content has been modified) Test plan: Turn on NewsLog Add/modify and delete additional contents/News and confirm that modification are logged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:02:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:02:07 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:02:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:02:26 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122944|Bug 28717: Add logging |[20.05] Bug 28717: Add description|logic to koha-news.pl |logging logic to | |koha-news.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:02:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:02:35 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122955|Bug 28717: (follow-up) add |[20.05] Bug 28717: description|title to logged information |(follow-up) add title to | |logged information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:03:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:03:20 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 --- Comment #17 from Jonathan Druart --- We should actually log Dumper of the additional content object, but we need bug 28692 to prevent logging DateTime object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:03:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:03:44 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #13 from Andrew Fuerste-Henry --- (confirmed library limits are showing up properly on the OPAC now) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:05:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:05:42 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > We should actually log Dumper of the additional content object, but we need > bug 28692 to prevent logging DateTime object. I meant bug 28700. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:06:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:06:34 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:06:38 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123840|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry --- Created attachment 123965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123965&action=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 2 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now 3 - Previously selected branch or group selections will populate the dropdowns, only one is allowed To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives https://bugs.koha-community.org/show_bug.cgi?id=26605 Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:20:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:20:23 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:21:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:21:07 +0000 Subject: [Koha-bugs] [Bug 26357] Create preference for staff notification of patron self-renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:23:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:23:28 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org --- Comment #2 from Amanda Campbell --- Yes, we would be interested in this. Manually placing holds is very tedious and time consuming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:29:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:29:00 +0000 Subject: [Koha-bugs] [Bug 28072] Z39.50/SRU servers would be a great addition to Mana KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org --- Comment #3 from Lauren Denny --- This sounds like a wonderful idea! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:32:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:32:07 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 18:32:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 16:32:10 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123654|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123966&action=edit Bug 28832: Don't batch modify fields that we don't update In bug 27837 we made sure to always pass through the permanent_location if it was passed in unlike other fields which are not passed if they have no value. During batch mod, however, fields that aren't editied have no value, so forcing permanent_location to pass through forces blanking it. This patch alters the script to only pass thgouhr for edit the fields that have been updated or cleared. To test: 1 - In frameworks add a new subfield to 952, "C" - make it editable in items tab and visible in intranet/editor 2 - In mappings map that subfield to items.permanent_location 3 - Set an item to have differing shelving location and permanent_location 4 - This saves correctly for an individual item 5 - Edit the item using Tools->batch item modification, updating the note field 6 - Note the permanet_location is removed 7 - Check the DB, the field is set to NULL 8 - Apply patch 9 - Repeat 10 - Permanent location is not cleared 11 - Verify that clearing fields works as before, including permanent_location Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 20:24:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 18:24:41 +0000 Subject: [Koha-bugs] [Bug 28880] New: Warning in tr (at Mojo/Headers.pm) because of undef X-Base-Total-Count HTTP header value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28880 Bug ID: 28880 Summary: Warning in tr (at Mojo/Headers.pm) because of undef X-Base-Total-Count HTTP header value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: nugged at gmail.com CC: jonathan.druart+koha at gmail.com, stalkernoid at gmail.com Depends on: 27353 There was an introduced X-Base-Total-Count header for REST API in Bug 27353. When used from external plugins and "base_total" not provided (is it mandatory?) all logs are heavily filled with: [WARN] Use of uninitialized value $_ in transliteration (tr///) at /usr/share/perl5/Mojo/Headers.pm line 43. It's because X-Base-Total-Count comes with "undef" as I debugged, what solution to choose: A. should we demand this value from plugin creators? B. or should we add this (not "0" as default, anyway, right?): my $base_total = $args->{base_total} // $total; to Koha/REST/Plugin/Pagination.pm line 63? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27353 [Bug 27353] Return the number of total records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 20:24:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 18:24:41 +0000 Subject: [Koha-bugs] [Bug 27353] Return the number of total records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27353 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28880 [Bug 28880] Warning in tr (at Mojo/Headers.pm) because of undef X-Base-Total-Count HTTP header value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 20:24:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 18:24:41 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28880 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 20:26:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 18:26:40 +0000 Subject: [Koha-bugs] [Bug 27353] Return the number of total records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27353 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com --- Comment #21 from Andrew Nugged --- Bug 28800: X-Base-Total-Count undefined in "old-style-usage", should we add backward compatibility? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 20:55:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 18:55:59 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Fridolin Somers --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 22:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 20:30:10 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #12 from Victor Grousset/tuxayo --- After request: Backported: Pushed to 20.05.x branch for 20.05.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 23:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 21:39:02 +0000 Subject: [Koha-bugs] [Bug 27644] Add button to SQL report editor for inserting runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 UGD changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Reports |ILL CC| |niicoibarra1 at gmail.com QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 18 23:41:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 21:41:13 +0000 Subject: [Koha-bugs] [Bug 27644] Add button to SQL report editor for inserting runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 UGD changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ILL |Reports QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 00:10:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 22:10:51 +0000 Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Hannah Co changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hannah.co at northwestu.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:03:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:03:43 +0000 Subject: [Koha-bugs] [Bug 27320] Add collection and shelving location options to MARC export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27320 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:05:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:05:45 +0000 Subject: [Koha-bugs] [Bug 27182] Add ability to rename a MARC modification template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:06:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:06:12 +0000 Subject: [Koha-bugs] [Bug 27809] Make entries from 'modification log' tab in patron record sort by date descending as a default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27809 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:06:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:06:41 +0000 Subject: [Koha-bugs] [Bug 27363] Restore temporary selection of Z39.50 targets throughout multiple searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27363 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:08:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:08:52 +0000 Subject: [Koha-bugs] [Bug 28059] Move OPAC news block to new protected area In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28059 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:09:18 +0000 Subject: [Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:09:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:09:38 +0000 Subject: [Koha-bugs] [Bug 27255] Authorized values does not allow you to provide a description for the category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27255 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:10:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:10:11 +0000 Subject: [Koha-bugs] [Bug 28251] Display number of selected items on Batch Item Modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28251 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:10:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:10:54 +0000 Subject: [Koha-bugs] [Bug 12733] Interactive inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:12:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:12:18 +0000 Subject: [Koha-bugs] [Bug 25631] Adding ability to alter the expiration date of the hold from the patron's account in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25631 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:14:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:14:18 +0000 Subject: [Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:14:38 +0000 Subject: [Koha-bugs] [Bug 27501] Add 'star ratings' feature to the facets in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27501 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:15:00 +0000 Subject: [Koha-bugs] [Bug 26861] Indicate that a record is using OpacHiddenItems in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:20:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:20:39 +0000 Subject: [Koha-bugs] [Bug 27119] Allow batch actions from item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27119 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:21:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:21:38 +0000 Subject: [Koha-bugs] [Bug 26839] Add a 'date published' feature to the facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:21:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:21:58 +0000 Subject: [Koha-bugs] [Bug 26840] Add a 'date added' feature to the facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26840 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:22:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:22:35 +0000 Subject: [Koha-bugs] [Bug 27502] Add target audience feature to the facets in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27502 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 01:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Aug 2021 23:32:49 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 04:20:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 02:20:00 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 04:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 02:20:40 +0000 Subject: [Koha-bugs] [Bug 26839] Add a 'date published' feature to the facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 04:21:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 02:21:37 +0000 Subject: [Koha-bugs] [Bug 27119] Allow batch actions from item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27119 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 04:30:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 02:30:55 +0000 Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of our TT plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- I've been thinking about this same topic for another project of mine. I actually ended up making specific DataTables controllers and had it send back descriptions instead of codes. (Of course, that through a little spanner in the search functionality, but it mostly works.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 04:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 02:33:22 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:32:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:32:07 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:34:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:34:23 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolin Somers --- Oh crap indeed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:34:34 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 [Bug 28819] Add link to item search from mainpage.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:34:34 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to item search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28878 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:34:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:34:43 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28819 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:34:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:34:43 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to item search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28878 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:38:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:38:28 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:38:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:38:31 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 --- Comment #2 from Fridolin Somers --- Created attachment 123967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123967&action=edit Bug 28878: Fix advanced search button on mainpage.pl incorrectly links to item search The follow-up on Bug 28819 changed the link for the Advanced search button on mainpage.pl. Test plan : 1) Go to intranet main page 2) Click on big button "Advanced search" => Without patch you go to item search /cgi-bin/koha/catalogue/itemsearch.pl => With patch you go to advanced search /cgi-bin/koha/catalogue/search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 08:54:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 06:54:36 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 --- Comment #9 from Fridolin Somers --- (In reply to Jonathan Druart from comment #5) > Shouldn't we actually move all the JS files to > koha-tmpl/intranet-tmpl/prog/js? I think yes but I can not confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:47:07 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 --- Comment #19 from Jonathan Druart --- To clarify, only the last patch is for master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:47:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:47:25 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122944|[20.05] Bug 28717: Add |[21.05] Bug 28717: Add description|logging logic to |logging logic to |koha-news.pl |koha-news.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:47:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:47:34 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122955|[20.05] Bug 28717: |[21.05] Bug 28717: description|(follow-up) add title to |(follow-up) add title to |logged information |logged information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:51:11 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to item search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 --- Comment #12 from Jonathan Druart --- Created attachment 123968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123968&action=edit Bug 28819: Fix advanced search button on mainpage.pl incorrectly links to item search The previous follow-up changed the link for the Advanced search button on mainpage.pl. Test plan : 1) Go to intranet main page 2) Click on big button "Advanced search" => Without patch you go to item search /cgi-bin/koha/catalogue/itemsearch.pl => With patch you go to advanced search /cgi-bin/koha/catalogue/search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:51:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:51:21 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |jonathan.druart+koha at gmail. | |com Resolution|--- |MOVED --- Comment #3 from Jonathan Druart --- Patch moved to bug 28819. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:55:27 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #21 from Katrin Fischer --- (In reply to Kyle M Hall from comment #20) > (In reply to Kyle M Hall from comment #19) > > (In reply to Kyle M Hall from comment #18) > > > (In reply to Katrin Fischer from comment #17) > > > > Why do I not find any references to NewsLog outside of the log viewer tt? > > > > > > It's from Bug 26205. You are right, something has happened > > > > Removed by Bug 22544, looks like you caught a regression! > > Looks like Bug 28717 is the fix. Thx for poking this one some more - I had to run off yesterday shortly after leaving the references comment :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:59:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:59:56 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 09:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 07:59:59 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:00:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:00:34 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to item search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:01:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:01:35 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 --- Comment #13 from Jonathan Druart --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:03:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:03:02 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |RM NOTE: Not mark as pushed release notes| |yet - only a debug patch | |has been pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:18:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:18:00 +0000 Subject: [Koha-bugs] [Bug 28880] Warning in tr (at Mojo/Headers.pm) because of undef X-Base-Total-Count HTTP header value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:34:44 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22544 Status|ASSIGNED |RESOLVED Resolution|--- |FIXED CC| |jonathan.druart+koha at gmail. | |com --- Comment #33 from Jonathan Druart --- No longer valid after bug 22544. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:34:44 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:56:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:56:47 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- Actually I am wondering if the proper fix here would not be to ->get_from_storage before the ->unblessed call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 10:58:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 08:58:49 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 --- Comment #6 from Andrew Nugged --- will it lead sometimes to +1 SQL request which is not so fast... but this method used intensively all around? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:00:24 +0000 Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:00:24 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18382 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:00:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:00:35 +0000 Subject: [Koha-bugs] [Bug 24182] Cancelling a hold floods the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|REOPENED |RESOLVED CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 28700 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:00:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:00:35 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Jonathan Druart --- *** Bug 24182 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:13:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:13:34 +0000 Subject: [Koha-bugs] [Bug 28866] lose ccode when coming back to results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- This should be fixed by bug 20529. *** This bug has been marked as a duplicate of bug 20529 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:13:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:13:34 +0000 Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #32 from Jonathan Druart --- *** Bug 28866 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:15:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:15:53 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 --- Comment #8 from Jonathan Druart --- (In reply to Andrew Nugged from comment #6) > will it lead sometimes to +1 SQL request which is not so fast... but this > method used intensively all around? I will do a fetch, but it's what we want. When an object is stored (added or modified) and we want to log what has been modified, I guess we want to log what has been effectively stored in the DB (like we have trigger in some ->store methods, or the default values defined at schema level). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:16:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:16:23 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 --- Comment #9 from Jonathan Druart --- (In reply to Andrew Nugged from comment #6) > will it lead sometimes to +1 SQL request which is not so fast... but this > method used intensively all around? It will do a fetch, but it's what we want I think. When an object is stored (added or modified) and we want to log what has been modified, I guess we want to log what has been effectively stored in the DB (like we have trigger in some ->store methods, or the default values defined at schema level). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:35:41 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8000 Severity|normal |critical CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com --- Comment #1 from Jonathan Druart --- Email::Valid is no longer maintained and there are several known bugs (including this one). We should reconsider this module. https://github.com/Perl-Email-Project/Email-Valid/issues https://github.com/Perl-Email-Project/Email-Valid/issues/47 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 [Bug 8000] Test mode for notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 11:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 09:35:41 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:16:27 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #2 from Jonathan Druart --- I don't know what to do. I have the feeling that what Ulrich is suggesting is not the right thing as we are using the "Full name " format for a while (bug 3280) now. On the other hand removing the validation seems bad as well. Adding a split in Koha::Email is not optimal (we could search for "<>" and pass that to Email::Valid instead of the whole replyto string). Any good other suggestions, Tomas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:34:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:34:31 +0000 Subject: [Koha-bugs] [Bug 28881] New: Suggestion not displayed on the order receive page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Bug ID: 28881 Summary: Suggestion not displayed on the order receive page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:34:40 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |ASSIGNED Depends on| |23376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 [Bug 23376] Cleanup order receive page code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:34:40 +0000 Subject: [Koha-bugs] [Bug 23376] Cleanup order receive page code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 [Bug 28881] Suggestion not displayed on the order receive page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:38:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:38:31 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:38:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:38:35 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 --- Comment #1 from Jonathan Druart --- Created attachment 123969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123969&action=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:39:23 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 [Bug 5346] Linking suggestions & orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:39:23 +0000 Subject: [Koha-bugs] [Bug 5346] Linking suggestions & orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 [Bug 28881] Suggestion not displayed on the order receive page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:40:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:40:08 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28881 CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 12:40:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 10:40:08 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28844 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 13:27:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 11:27:41 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr, | |severine.queune at bulac.fr --- Comment #1 from Jonathan Druart --- Looks like we need an additional link between the 2 tables aqorders and suggestions to achieve that. That would make sense, especially when looking at such code: SELECT suggestions.*, U1.surname AS surnamesuggestedby, U1.firstname AS firstnamesuggestedby, U1.borrowernumber AS borrnumsuggestedby FROM suggestions LEFT JOIN borrowers AS U1 ON suggestedby=U1.borrowernumber WHERE biblionumber=? LIMIT 1 in GetSuggestionInfoFromBiblionumber. It is wrong if there are several suggestions on the same bib. Hard to know it won't break existing workflows however. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 13:32:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 11:32:48 +0000 Subject: [Koha-bugs] [Bug 25604] Plugin unlinking failing during uninstall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25604 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=25550 |?id=21670 --- Comment #1 from Jonathan Druart --- How do you recreate that? Is it a random failure? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 13:32:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 11:32:48 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25604 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 13:32:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 11:32:48 +0000 Subject: [Koha-bugs] [Bug 25550] Koha/Plugins/Plugins.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25604 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 13:41:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 11:41:11 +0000 Subject: [Koha-bugs] [Bug 9941] with Plack, Web installer should not die with stacktrace when database does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #15 from Jonathan Druart --- In 2021, with dev_install=0, if the DB does not exist the client get a standard 500 "Internal Server Error". No stacktrace displayed. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:05:37 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:05:41 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 --- Comment #1 from Jonathan Druart --- Created attachment 123970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123970&action=edit Bug 11750: Hide patron's attributes on overdue list if needed If a patron's attributes is limited to some libraries, we must apply this limit on the overdue list view. Test plan: 1. Create the following patron attributes: A that is not searchable B is searchable and does not have library limitation C is searchable and is limited to another library than yours 2. On the right part of the overdue list view you must see B only Without this patch C is displayed as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:12:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:12:00 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Depends on| |7919 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 [Bug 7919] Display of values depending on the connexion library (authorised values, patron categories, extended attributes) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:12:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:12:00 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion library (authorised values, patron categories, extended attributes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 [Bug 11750] Overdue report does not limit patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:17:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:17:44 +0000 Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:17:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:17:47 +0000 Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 --- Comment #5 from Owen Leonard --- Created attachment 123971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123971&action=edit Bug 28720: (follow-up) Improve string translation This patch fixes the following issues raised by QA: - It modifies the markup so that "Add note" and "Edit note" can be translated more easily. - It adds display of existing notes back to the table of checkouts. - It adds to the table configuration so that a "plain" view of the notes (without buttons) is shown in print view and in CSV export. - It improves handling of notes containing quotation marks which would previously have broken some edit interactions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:57:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:57:13 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:57:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:57:26 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 14:57:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 12:57:37 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:03:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:03:20 +0000 Subject: [Koha-bugs] [Bug 28882] New: Incorrect permissions check client-side Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Bug ID: 28882 Summary: Incorrect permissions check client-side Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:03:51 +0000 Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20100, 22150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 [Bug 22150] Make it easier to unselect one member permission after selecting all -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:03:51 +0000 Subject: [Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 [Bug 28882] Incorrect permissions check client-side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:03:51 +0000 Subject: [Koha-bugs] [Bug 22150] Make it easier to unselect one member permission after selecting all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 [Bug 28882] Incorrect permissions check client-side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:04:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:04:01 +0000 Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:17:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:17:00 +0000 Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 --- Comment #1 from Jonathan Druart --- Created attachment 123972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123972&action=edit Bug 28882: permission UI allows selection of superlibrarian permission With bug 20100 and 22150 we allow to select all the permissions but the superlibrarian permission, to ease the selection. And we also forbid a non-superlibrarian user to add superlibrarian permission. However there is something wrong in the JS code and it's possible to add the superlibrarian permission. The user is getting an ugly 500 and so the permission change is not done, but the UI checks must be fixed. To recreate: Login with a non-superlibrarian user Edit permission Clear all => You can select the "superlibrarian" permission Test plan: Login with a non-superlibrarian user Try to set the superlibrarian permissions to a user => not possible Try the select all/clear all => still cannot set the superlibrarian permission Work to be done: Login with a non-superlibrarian user Edit permissions for a superlibrarian user => You can remove it, then cannot add it back Should we allow removal of superlibrarian permission by non-superlibrarian user? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:20:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:20:00 +0000 Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |katrin.fischer at bsz-bw.de, | |m.de.rooy at rijksmuseum.nl, | |oleonard at myacpl.org --- Comment #2 from Jonathan Druart --- Can you have a look at the "work to be done" in the last patch please? What's your opinion? Did we discuss it already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:35:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:35:18 +0000 Subject: [Koha-bugs] [Bug 28883] New: Koha::Objects->_new_from_dbic doesn't work correctly in list context Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Bug ID: 28883 Summary: Koha::Objects->_new_from_dbic doesn't work correctly in list context Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It will always return a resultset, it should return a list in list context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:35:41 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28871 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:35:41 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28883 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:35:46 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:55:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:55:39 +0000 Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #5 from Marcel de Rooy --- (In reply to Phil Ringnalda from comment #4) > Inconveniently, you can't just pad with either pipes or the remaining > characters from our default blindly, since filling position 35-39 with pipes > is just fine, but filling position 36-39 is invalid, since "e||" is not a > valid language code. So it's an awkward case of length 6-7 you can pad, 8-11 > you have to truncate to 7 and pad, 12 you can pad, 13-15 you have to > truncate to 12 and pad, etc. Phil. I added a proposal to right pad with characters from the default from the last complete data element onwards. Viewing block 18-34 as one element, since it depends on material type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:56:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:56:21 +0000 Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:56:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:56:25 +0000 Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115248|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 123973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123973&action=edit Bug 27461: Move hardcoded value to module Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:56:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:56:28 +0000 Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #7 from Marcel de Rooy --- Created attachment 123974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123974&action=edit Bug 27461: Add tests for biblio_008 Test plan: Run t/db_dependent/FrameworkPlugin.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:56:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:56:32 +0000 Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #8 from Marcel de Rooy --- Created attachment 123975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123975&action=edit Bug 27461: Right pad with default elements for too short 008s Note that we treat the elements 18-34 as one block of elements, since its subdivision may vary. E.g. if you pass 24 characters to the form, it will use the first 18 chars (until the last complete element) and pad with default elements from position 18-39. Test plan: [1] Go to addbiblio. Make sure that 008 is connected to the plugin. [2] Backspace field 008 a bit, click on the plugin button. [3] Verify that the last elements come from the default. [4] Repeat for a few different lengths. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 15:56:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 13:56:45 +0000 Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:01:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:01:20 +0000 Subject: [Koha-bugs] [Bug 28884] New: ElasticSearch: Question mark in title search returns no results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 Bug ID: 28884 Summary: ElasticSearch: Question mark in title search returns no results Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: jyorio at equinoxinitiative.org When searching for a title with a question mark, Who's Afraid of Virginia Woolf? for example, Koha returns no results with ElasticSearch. Removing the question mark or escaping it retrieves results, as does enclosing the entire title with the question mark in quotes. Since ? is a wildcard for ElasticSearch, this may be expected behavior (I'm not sure that it is or isn't), but explaining to patrons that they need to change their search behavior can be a big ask for libraries. Not sure what the best option is. Perhaps a system preference to automatically escape ? and not treat it as a wildcard for those libraries who would prefer that? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:15:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:15:55 +0000 Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 --- Comment #3 from Marcel de Rooy --- Work to be done: Login with a non-superlibrarian user Edit permissions for a superlibrarian user => You can remove it, then cannot add it back Should we allow removal of superlibrarian permission by non-superlibrarian user? No, I definitely think that a non-superlib should not be able to remove perms from a superlib. That would be kind of a security hole imo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:20:40 +0000 Subject: [Koha-bugs] [Bug 27294] Error when deleting claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:20:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:20:41 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Bug 27296 depends on bug 27294, which changed state. Bug 27294 Summary: Error when deleting claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:29:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:29:41 +0000 Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #9 from Marcel de Rooy --- For the record noting here that we are using as default pipe chars in the country field. MARC specs say: Three fill characters (|||) may be used in place of a valid code, but their use in 008/15-17 is discouraged. If we want to change that too, please open up a new report ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:46:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:46:32 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123976&action=edit Bug 28883: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:46:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:46:46 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 123977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123977&action=edit Bug 28883: Make Koha::Objects->_new_from_dbic honour list context This patch makes the _new_from_dbic method return a list in list context. It does so by leveraging on the existing Koha::Objects->_wrap internal method that _does the right thing_. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Boo! Tests fail! The list is not empty, and it contains... a resultset intead of empty or individual items. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Things work as expected! 5. Run: k$ probe t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! It uses the chaining: $biblio->items->as_list and doesn't break. It implies that the change won't break any Koha place in which ->as_list is being used on a resultset created by _new_from_dbic 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:47:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:47:37 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:49:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:49:10 +0000 Subject: [Koha-bugs] [Bug 28885] New: OpacBrowseResults can cause errors with bad search indexes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Bug ID: 28885 Summary: OpacBrowseResults can cause errors with bad search indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a record is deleted from Koha, but is for some reason not deleted from the search indexes, OpacBrowseResults can cause an ISE if the deleted record is in the search results for any given item. OpacBrowseResults loops through the search results, and checks if there is a biblionumber, but does *not* check to see if a result was pulled from the database for that biblionumber. It simply assumes the result must exist. We should be checking to ensure the biblionumber was valid before operating on the biblio object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:49:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:49:16 +0000 Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:49:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:49:34 +0000 Subject: [Koha-bugs] [Bug 28886] New: Remove uses of ->as_list from the codebase Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 Bug ID: 28886 Summary: Remove uses of ->as_list from the codebase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It seems that instead of fixing it (bug 28883) we've been using Koha::Objects->as_list to workaround the wrong behavior. We should fix this, globally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:49:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:49:46 +0000 Subject: [Koha-bugs] [Bug 28886] Remove uses of ->as_list from the codebase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:49:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:49:46 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 [Bug 28886] Remove uses of ->as_list from the codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:50:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:50:18 +0000 Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:54:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:54:41 +0000 Subject: [Koha-bugs] [Bug 28887] New: Enhance ILL request creation / display to extend functionality Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28887 Bug ID: 28887 Summary: Enhance ILL request creation / display to extend functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com This bug will make small enhancements to the ILL, specifically the request creation and display. This work was prompted by requirements that came to light during creation of the RapidILL backend. Improvements such as the following will be included: - Allow the conditional display of certain metadata properties when displaying a request's metadata in the OPAC, the suppression list will be specified by the backend responsible for creating the request. - Allow the linking of a local request to a request made with a third party based on the backend responsible for creating the request. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:54:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:54:58 +0000 Subject: [Koha-bugs] [Bug 28887] Enhance ILL request creation / display to extend functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28887 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:56:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:56:39 +0000 Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 16:56:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 14:56:42 +0000 Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 --- Comment #1 from Kyle M Hall --- Created attachment 123978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123978&action=edit Bug 28885: Skip invalid biblios for OpacBrowseResults If a record is deleted from Koha, but is for some reason not deleted from the search indexes, OpacBrowseResults can cause an ISE if the deleted record is in the search results for any given item. OpacBrowseResults loops through the search results, and checks if there is a biblionumber, but does *not* check to see if a result was pulled from the database for that biblionumber. It simply assumes the result must exist. We should be checking to ensure the biblionumber was valid before operating on the biblio object. Test Plan: 1) Use zebra for searching 2) Disable koha-indexer 3) Enable OpacBrowseResults 4) Perform a search 5) Delete an item in the search results 6) View on of the remaining items in the search results 7) Note the error 8) Apply this patch 9) Restart plack 10) Reload the page 11) The error should be gone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 19:28:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 17:28:48 +0000 Subject: [Koha-bugs] [Bug 28888] New: Add option for field to include with export.pl tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28888 Bug ID: 28888 Summary: Add option for field to include with export.pl tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bibliwho at gmail.com QA Contact: testopia at bugs.koha-community.org The current tool includes an option, "Don't export fields". There are over 200 MARC fields, and perhaps 20-25 that are heavily used. So I think it would be far more useful to be able to specify which specific fields to *include* when exporting records. Lately, for example, we've wanted to export records w/ just a handful of fields (leader, title, author, isbn, etc.) Propose a new option, "Fields to include". Thank you, Cab Vinton Plaistow Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 20:21:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 18:21:39 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 20:21:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 18:21:46 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123969|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 123979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123979&action=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 21:18:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 19:18:34 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 21:18:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 19:18:39 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123976|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 123980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123980&action=edit Bug 28883: Regression tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 21:18:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 19:18:43 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123977|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 123981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123981&action=edit Bug 28883: Make Koha::Objects->_new_from_dbic honour list context This patch makes the _new_from_dbic method return a list in list context. It does so by leveraging on the existing Koha::Objects->_wrap internal method that _does the right thing_. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Boo! Tests fail! The list is not empty, and it contains... a resultset intead of empty or individual items. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Things work as expected! 5. Run: k$ probe t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! It uses the chaining: $biblio->items->as_list and doesn't break. It implies that the change won't break any Koha place in which ->as_list is being used on a resultset created by _new_from_dbic 6. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 22:38:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 20:38:22 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |dstephen at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 22:40:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 20:40:15 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123966|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 123982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123982&action=edit Bug 28832: Don't batch modify fields that we don't update In bug 27837 we made sure to always pass through the permanent_location if it was passed in unlike other fields which are not passed if they have no value. During batch mod, however, fields that aren't editied have no value, so forcing permanent_location to pass through forces blanking it. This patch alters the script to only pass thgouhr for edit the fields that have been updated or cleared. To test: 1 - In frameworks add a new subfield to 952, "C" - make it editable in items tab and visible in intranet/editor 2 - In mappings map that subfield to items.permanent_location 3 - Set an item to have differing shelving location and permanent_location 4 - This saves correctly for an individual item 5 - Edit the item using Tools->batch item modification, updating the note field 6 - Note the permanet_location is removed 7 - Check the DB, the field is set to NULL 8 - Apply patch 9 - Repeat 10 - Permanent location is not cleared 11 - Verify that clearing fields works as before, including permanent_location Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Deb Stephenson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:10:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:10:55 +0000 Subject: [Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 Hannah Co changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hannah.co at northwestu.edu --- Comment #11 from Hannah Co --- Edit Item adds the NewItemsDefaultLocation, if the existing item has a blank shelving location. Our library expects that the Edit Item function would preserve the blank shelving location, while Add Item would fill in NewItemsDefaultLocation. Is filling in NewItemsDefaultLocation expected on item edit, or does the editing behavior need to be reviewed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:36 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:38 +0000 Subject: [Koha-bugs] [Bug 27814] Improve responsive behavior of the user page in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27814 Bug 27814 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:38 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Bug 28868 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:39 +0000 Subject: [Koha-bugs] [Bug 25771] Allow the user to sort checkouts by the renew column in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25771 Bug 25771 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:39 +0000 Subject: [Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 Bug 25775 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:39 +0000 Subject: [Koha-bugs] [Bug 26164] Replace OPAC table sort icons with SVG In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26164 Bug 26164 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:39 +0000 Subject: [Koha-bugs] [Bug 26419] Replace OPAC Koha logo with SVG In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26419 Bug 26419 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:40 +0000 Subject: [Koha-bugs] [Bug 26465] Generated RTL CSS files should be committed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26465 Bug 26465 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:40 +0000 Subject: [Koha-bugs] [Bug 26478] Display issue with buttons on the self checkout screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26478 Bug 26478 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:40 +0000 Subject: [Koha-bugs] [Bug 26512] Display issue with buttons for OPAC checkout note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 Bug 26512 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:40 +0000 Subject: [Koha-bugs] [Bug 26505] Suspend hold modal broken in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26505 Bug 26505 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:41 +0000 Subject: [Koha-bugs] [Bug 26519] Clean up OPAC buttons with incorrect classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 Bug 26519 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:41 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Bug 26665 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:41 +0000 Subject: [Koha-bugs] [Bug 26720] OPAC lists - button display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26720 Bug 26720 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:42 +0000 Subject: [Koha-bugs] [Bug 26749] Correct dropdown markup in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26749 Bug 26749 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:42 +0000 Subject: [Koha-bugs] [Bug 26735] Overdrive login modal broken in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26735 Bug 26735 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:42 +0000 Subject: [Koha-bugs] [Bug 26752] OPAC list download button broken by Bootstrap 4 upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Bug 26752 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:42 +0000 Subject: [Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Bug 26758 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:43 +0000 Subject: [Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Bug 26810 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:43 +0000 Subject: [Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Bug 27072 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:43 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Bug 27200 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:44 +0000 Subject: [Koha-bugs] [Bug 27881] Markup error in masthead-langmenu.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Bug 27881 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:44 +0000 Subject: [Koha-bugs] [Bug 28193] OpacLoginInstructions news block broken by Bug 20168 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Bug 28193 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:40:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:40:45 +0000 Subject: [Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Bug 28679 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 19 23:41:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 21:41:09 +0000 Subject: [Koha-bugs] [Bug 28868] Masthead.inc is missing class name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 01:14:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 23:14:31 +0000 Subject: [Koha-bugs] [Bug 25604] Plugin unlinking failing during uninstall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25604 --- Comment #2 from David Cook --- (In reply to Jonathan Druart from comment #1) > How do you recreate that? Is it a random failure? Good question. I haven't removed any plugins for a long time, so I'm not sure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 01:18:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 23:18:46 +0000 Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 01:22:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 23:22:25 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 01:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 23:22:29 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123672|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 123983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123983&action=edit Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X". Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 01:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 23:22:46 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123870|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers --- Created attachment 123984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123984&action=edit Bug 28149: (follow-up) Add string for job status "new" Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 01:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Aug 2021 23:46:04 +0000 Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #6 from Hannah Co --- I don't believe this patch catches items in "processing" that should end up with no shelving location. I have a freshly updated 21.05, with this patch included. My system pref UpdateItemLocationOnCheckin contains "PROC: _PERM_". Check-in does not make any changes to a record with "PROC" location and no other shelving location assigned. New items are automatically created with location AND permanent_location both set as PROC. It seems that "PROC" and "CART" should never populate permanent_location. Can we prevent "PROC" from populating the permanent_location? Or, can we handle the situation where "PROC" exists in both permanent_location AND location, so the location is completely removed and replaced with NULL? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 02:08:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 00:08:24 +0000 Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 --- Comment #5 from Fridolin Somers --- There is a strange thing in the patch. Some blocks are moving (for example field Heading). Looks like the export sorts by MARC type marc21->unimarc->normarc. But for me export sorts by MARC type alphabetical : marc21->normarc->unimarc. This is in patch : Bug 23204: Fix ordering of fields in exported file o_O -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 03:31:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 01:31:17 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #69 from Victor Grousset/tuxayo --- (In reply to Peter Vashchuk from comment #58) > I think search query like that should never work as it will always cause ES > syntax error, ElasticSearch is a mini-language after all and has it's own > syntax and it will die on something like that. Yes it makes sense. > Though we do need to notify the user, in cases like that, that the search > query is incorrect and that they need to correct it and search with it > again. I will make a ticket for it a bit later if. Thanks for bug 28736 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 06:13:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 04:13:07 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #70 from Victor Grousset/tuxayo --- (In reply to Andrew Nugged from comment #61) > Victor, please can you again give-this-a-go? > i.e. Re-Sign-off this ticket again according to that so we now might have > proper "error messages" for the wrong syntax in ES requests (bug 28736), if > that comforts you? test result: my signoffs still hold on top of bug 28736 :) Last two patches still not tested. - I don't know how QueryRegexEscapeOptions works - comment 41 about the last patch But thanks to Alex we have these covered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 06:14:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 04:14:48 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123404|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 123985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123985&action=edit Bug 28736: fix requirements for the correct error message to show up There is existing error message in the code stating: "Unable to understand your search query, please rephrase and try again." which fits perfectly but because it looks for "ParseException" in the warning output it doesn't show up on this page as it's actually "parse_exception". This patch makes that it's also checked if "parse_exception" is present in the warning output. To reproduce: 1) using ES search for something like "// ^ ! { } [ ] .. , <>" that will for sure break the syntax of ES. 2) after the search query fails note that the error is "Unable to perform your search. Please try again." 3) apply the patch 4) search for the same thing again 5) error message should be "Unable to understand your search query, please rephrase and try again." now. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 08:06:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 06:06:48 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 08:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 06:34:32 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Super, I like that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 08:35:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 06:35:05 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 08:35:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 06:35:09 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123938|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers --- Created attachment 123986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123986&action=edit Bug 28843: Add view and edit buttons to result of MARC record import This patch adds "View" and "Edit" buttons to the output of the result of a MARC record import. To test, apply the patch and go to Tools -> State MARC for import. - Import a file of MARC records. - Click the "Manage staged records" button. - In the table of staged records the last column labeled "Records" should be empty. - Click "Import this batch into the catalog." - The table of records will be shown again, and this time the last column should contain "View" and "Edit" buttons for each row. - Confirm that the buttons work correctly, opening the correct record for viewing and editing. Test with both bibliographic and authority records to confirm that the correct view and edit pages open for each. EDIT: Add permission check for "Edit" link Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:03:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:03:31 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #9 from Marcel de Rooy --- BTW It seems to me that we do not even need to do a search, just create a resultset with new only. But this is merely a theoretical difference. There will be no db read since we set the cache. # $self = $self->search(\'0 = 1'); $self->_resultset()->set_cache([]); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:06:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:06:07 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:06:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:06:10 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123925|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 123987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123987&action=edit Bug 28871: Regression test Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:06:13 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123926|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 123988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123988&action=edit Bug 28871: Make Koha::Objects->empty work on list context This patch makes Koha::Objects->empty work on list context, by making it return the $self->search call. To test: 1. Apply the regression test patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:08:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:08:10 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28149 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:08:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:08:10 +0000 Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:08:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:08:49 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:08:53 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123214|0 |1 is obsolete| | --- Comment #11 from Fridolin Somers --- Created attachment 123989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123989&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:09:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:09:14 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123215|0 |1 is obsolete| | --- Comment #12 from Fridolin Somers --- Created attachment 123990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123990&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:09:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:09:51 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123216|0 |1 is obsolete| | --- Comment #13 from Fridolin Somers --- Created attachment 123991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123991&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:10:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:10:31 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:11:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:11:27 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #14 from Fridolin Somers --- Works super. I hope we will see all task queue refactoring in 21.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 09:39:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 07:39:41 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #6 from Marcel de Rooy --- is( $items_scalar->count, 2, 'No items in resultset' ); Hmm that description ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:47:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:47:39 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #7 from Marcel de Rooy --- Seems to work as it is, but I am just wondering if we should force scalar context within the map statement of _wrap ? To prevent perl one day (another version etc) guessing list context and creating an nice endless loop. So making it: my @objects = map { scalar $self->object_class->_new_from_dbic( $_ ) } etc Instead of: sub _new_from_dbic { my ( $class, $resultset ) = @_; + if ( wantarray ) { + return $class->_wrap( $resultset->all() ); + } my $self = { _resultset => $resultset }; bless( $self, $class ); [..] sub _wrap { my ( $self, @dbic_rows ) = @_; my @objects = map { $self->object_class->_new_from_dbic( $_ ) } @dbic_rows; return @objects; } Adding an optional follow-up for it too. Please let me know what you think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:48:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:48:10 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:48:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:48:14 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123980|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 123992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123992&action=edit Bug 28883: Regression tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:48:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:48:18 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123981|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 123993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123993&action=edit Bug 28883: Make Koha::Objects->_new_from_dbic honour list context This patch makes the _new_from_dbic method return a list in list context. It does so by leveraging on the existing Koha::Objects->_wrap internal method that _does the right thing_. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Boo! Tests fail! The list is not empty, and it contains... a resultset intead of empty or individual items. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Things work as expected! 5. Run: k$ probe t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! It uses the chaining: $biblio->items->as_list and doesn't break. It implies that the change won't break any Koha place in which ->as_list is being used on a resultset created by _new_from_dbic 6. Sign off :-D Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:48:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:48:21 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #10 from Marcel de Rooy --- Created attachment 123994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123994&action=edit Bug 28883: (QA follow-up) Improve test description Copy-pasted descriptions. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:48:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:48:25 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #11 from Marcel de Rooy --- Created attachment 123995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123995&action=edit Bug 28883: [OPTIONAL] (follow-up) Should we force scalar context within map? Currently, this does not seem necessary. Somehow it feels better imo. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:49:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:49:34 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #12 from Marcel de Rooy --- Hmm wait -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:52:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:52:07 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #13 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > Seems to work as it is, but I am just wondering if we should force scalar > context within the map statement of _wrap ? This is nonsense. We are going to the singular class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 10:52:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 08:52:25 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 11:02:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 09:02:44 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 11:14:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 09:14:14 +0000 Subject: [Koha-bugs] [Bug 28775] Warn when viewing itemtypes.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- It seems to me that this fix is too easy. Can be translated may well pertain to the OPAC (not staff only). For instance we use staff in English, but OPAC in Dutch and English. If you look at the module routine, you see that no interface means OPAC + Intranet in returned languages. Giving another result in the above scenario. Please adjust the routine? Passing empty string might be a cheap solution but probably not the nicest ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 12:08:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 10:08:36 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #9) > BTW It seems to me that we do not even need to do a search, just create a > resultset with new only. But this is merely a theoretical difference. There > will be no db read since we set the cache. > > # $self = $self->search(\'0 = 1'); > $self->_resultset()->set_cache([]); That ->search call will not trigger a db search. That's correct. It was added so further chaining always returns ah empty set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 12:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 10:40:39 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #2 from Katrin Fischer --- (In reply to Jonathan Druart from comment #1) > Looks like we need an additional link between the 2 tables aqorders and > suggestions to achieve that. > > That would make sense, especially when looking at such code: > > SELECT suggestions.*, > U1.surname AS surnamesuggestedby, > U1.firstname AS firstnamesuggestedby, > U1.borrowernumber AS borrnumsuggestedby > FROM suggestions > LEFT JOIN borrowers AS U1 ON suggestedby=U1.borrowernumber > WHERE biblionumber=? > LIMIT 1 > > in GetSuggestionInfoFromBiblionumber. It is wrong if there are several > suggestions on the same bib. > > Hard to know it won't break existing workflows however. I agree - we should have a real link and not be guessing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 13:53:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 11:53:00 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123689|0 |1 is obsolete| | Attachment #123785|0 |1 is obsolete| | Attachment #123786|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 123996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123996&action=edit Bug 28833: Speed up holds queue builder via parallel processing The holds queue builder can take a very long time to run on systems with many holds. For example, a partner with 124,784 unfilled ( not found ) holds, is taking about 64 minutes to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of records as evenly as possible, but *not* taking into account the holds per bib ), it takes 21.5 minutes. If we use 10 loops, it takes less then 14 minutes. Test Plan: 0) Install the Perl library Parallel::ForkManager 1) Generate a huge number of holds ( a few thousand at the minimum ) 2) Run the holds queue builder, use the `time` utility to track how much time it took to run 3) Set HoldsQueueParallelLoopsCount to 10 4) Repeat step 2, note the improvement in speed 5) Experiment with other values for HoldsQueueParallelLoopsCount 6) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 13:55:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 11:55:02 +0000 Subject: [Koha-bugs] [Bug 28833] Speed up holds queue builder via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28833 --- Comment #19 from Kyle M Hall --- (In reply to David Cook from comment #17) > Comment on attachment 123689 [details] [review] > Bug 28833: Speed up holds queue builder via parallel processing > > Review of attachment 123689 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/HoldsQueue.pm > @@ +210,5 @@ > > + > > + DATA_LOOP: > > + foreach my $chunk (@chunks) { > > + my $pid = $pm->start and next DATA_LOOP; > > + _ProcessBiblios($chunk); > > I notice that the other _ProcessBiblios has arguments for $branches_to_use > and $transport_cost_matrix. I'm guessing those should be included here too? Good catch! I've fixed that issue and squashed the patches down for ease of use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:00:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:00:44 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:21:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:21:31 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:21:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:21:34 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:22:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:22:50 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 123997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123997&action=edit Bug 28376: Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). NEW: I've modified the default configuration of Flatpickr instances so that a "Clear date" link is automatically appended. This eliminates the need to add a button to the markup and event handling for each case. NEW: Date/time formatting should be corrected in this revised patch. The patch modifies three pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - NEW: You can also test the datepicker shown when you renew an on-hold item. This demonstrates a configuration which requires that the selection be after today. - Administration -> Patron categories -> New category, to demonstrate a calendar-only date picker enforcing a date after today. - NEW: Reports -> Patrons. The "Date of birth" fields are linked so that the second cannot be before the first. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:25:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:25:22 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #13 from Tomás Cohen Arazi --- I like the aesthetics of this library and it works like a charm. It is an easy replacement to the current library. The use cases work: limiting date ranges, time pick, etc. The only thing I would change is the font size, as it feels a bit bigger than the rest of the Koha fonts. We might even revisit the font itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:35:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:35:45 +0000 Subject: [Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:42:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:42:21 +0000 Subject: [Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:42:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:42:25 +0000 Subject: [Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:42:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:42:44 +0000 Subject: [Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 123998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123998&action=edit Bug 24019: Patron batch modification based on borrowernumber This patch adds batch patron modifications based on borrowernumber. The user can choose to upload a file of borrowernumbers or submit a list of borrowernumbers in a textarea, just like they can with card numbers. To test, apply the patch and prepare files containing borrowernumbers and card numbers. Patron lists should be enabled, and you should have at least one patron list with patrons on it. - Go to Tools -> Batch patron modification. - You should see three tabs: "By card number," "By borrowernumber," and "By patron list." - Test each option for batch patron modifications: - By card number file - By card number list - By borrowernumber file - By borrowernumber list - By patron list - In each case the correct batch should be submitted, and modifications should finish correctly.. - There should be an "order of operations" for card numbers and borrowernumbers: - If a file is uploaded AND a list of numbers is entered, the list of numbers should be used. - Batches should only get submitted from the active tab. - If you upload a file or enter card numbers in one tab and then switch to another tab and submit numbers from there, the original tab's batches should be ignored. Signed-off-by: kelly mcelligott Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:43:36 +0000 Subject: [Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019 --- Comment #4 from Tomás Cohen Arazi --- Nice and simple change. QA scripts happy and functionality makes sense and works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:52:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:52:04 +0000 Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:52:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:52:06 +0000 Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 14:52:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 12:52:26 +0000 Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 123999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123999&action=edit Bug 28536: Move translatable strings into overdrive.js This patch takes strings defined as variables in opac-bottom.inc for use in overdrive.js and moves them to overdrive.js, wrapped in the double-underscore translation function. To test you must have valid credentials entered in system preferences for the OverDrive API. Ideally you should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display correctly, with correct labels for controls like "Log out of your OverDrive account", "Check in", "On hold", etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, with correct labels on controls like "Check out" and "Place hold." To test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/overdrive.js for translation, e.g.: koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js:124 msgid "OverDrive account page" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated strings appear. In the above example, the string should appear at the top of the "Overdrive Account" tab. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 18:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 16:27:43 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 28346, which changed state. Bug 28346 Summary: Action buttons should have a class per action type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 18:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 16:27:43 +0000 Subject: [Koha-bugs] [Bug 28346] Action buttons should have a class per action type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 18:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 16:28:12 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 18:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 16:28:12 +0000 Subject: [Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Bug 28389 depends on bug 28390, which changed state. Bug 28390 Summary: Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 18:41:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 16:41:14 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 19:51:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 17:51:28 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |tomascohen at gmail.com --- Comment #3 from Tomás Cohen Arazi --- Trying something for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 19:57:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 17:57:41 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 19:58:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 17:58:27 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 19:58:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 17:58:37 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 19:59:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 17:59:22 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 19:59:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 17:59:40 +0000 Subject: [Koha-bugs] [Bug 28839] Better texts in stage MARC for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:00:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:00:40 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:02:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:02:06 +0000 Subject: [Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:02:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:02:41 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:03:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:03:20 +0000 Subject: [Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:03:51 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:04:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:04:16 +0000 Subject: [Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:05:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:05:24 +0000 Subject: [Koha-bugs] [Bug 28819] Add link to item search from mainpage.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:05:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:05:25 +0000 Subject: [Koha-bugs] [Bug 28878] Advanced search button on mainpage.pl incorrectly links to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28878 Bug 28878 depends on bug 28819, which changed state. Bug 28819 Summary: Add link to item search from mainpage.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:10:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:10:05 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #23 from Kyle M Hall --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 20:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 18:13:29 +0000 Subject: [Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:08:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:08:16 +0000 Subject: [Koha-bugs] [Bug 28889] New: Transfer ownership of public lists from one user to another Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28889 Bug ID: 28889 Summary: Transfer ownership of public lists from one user to another Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Staff create public and private lists for various uses and programs, and when a staff member moves on, there is no way for us to transfer the ownership of the list to the staff member taking their place. It would be great if there were a function in the list to do this, or a tool to move all selected lists to a new owner. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:28:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:28:31 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:28:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:28:35 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:28:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:28:39 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:29:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:29:08 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 124000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124000&action=edit Bug 28803: Add unit tests This patch updates Letters.t to confirm that invalid email addresses in the message_queue should not throw an exception when sending mail but instead set the status to failed and pass error details to the end user. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:29:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:29:13 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 124001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124001&action=edit Bug 28803: Add invalid email handling in _send_message_by_email This patch adds a try/catch block around the call to Koha::Email->create to catch and handle invalid emails being passed in the parameters. The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:31:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:31:41 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #9 from Tomás Cohen Arazi --- This is the right short-term solution for this issue. A more global solution should be implemented on bug 28870. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:50:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:50:32 +0000 Subject: [Koha-bugs] [Bug 28889] Transfer ownership of public lists from one user to another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28889 --- Comment #1 from Marcel de Rooy --- What about bug 11889 or bug 25498 already? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 21:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 19:52:33 +0000 Subject: [Koha-bugs] [Bug 10391] specify due date remaining even if not selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10391 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |andrew at bywatersolutions.com Status|NEW |RESOLVED --- Comment #6 from Andrew Fuerste-Henry --- Hi all, I'm closing this bug. Seems like Nicole and Nick both expected different behavior from what Koha does. But the current behavior seems to be what was intended by the code and also is very well established. If anyone's interested in an enhancement to give the option to make this work differently, let's file a new enhancement for that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 22:08:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 20:08:52 +0000 Subject: [Koha-bugs] [Bug 28889] Transfer ownership of public lists from one user to another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28889 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Christopher Brannon --- Well, if they would come up in my searches or I could remember them, then yes, that would do. *** This bug has been marked as a duplicate of bug 11889 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 22:08:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 20:08:52 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #46 from Christopher Brannon --- *** Bug 28889 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 22:15:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 20:15:51 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #47 from Christopher Brannon --- I'm confused. If this is signed off, why is it in discussion. Is there a reason it isn't going through QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 23:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 21:06:18 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #4 from Tomás Cohen Arazi --- Ok, I've been playing with this. My conclusion is that Jonathan is right: Email::Valid is buggy. I've learnt that regexps for validating RFC2822 addresses are not trivial [1] The author/maintainer of the libraries we use, also maintains the Email::Address library, that provides such regular expressions. My tests (on Debian Buster) verify that Email::Address is able to handle UTF-8 characters correctly. I can submit a patch that replaces one library with the other (will probably do it anyway) but I have doubts about the importance of validating email addresses here. It feels like overkill. [1] https://metacpan.org/pod/Email::Address#Package-Variables The script I used for testing: #!/usr/bin/perl use Modern::Perl; use utf8; use Email::Address; use Email::Valid; binmode STDOUT, ':encoding(UTF-8)'; binmode STDERR, ':encoding(UTF-8)'; my $string = 'Tomás Cohen Arazi '; my ($email) = Email::Address->parse($string); ## This construct could be used instead of manually crafting ## the address in the $string format above. Same results # my $email = Email::Address->new( # 'Tomás Cohen Arazi' => 'tomacohe at theke.io' # ); print "Testing address: $email\n"; say "Email::Address tests =>"; if ( "$email" =~ m/$Email::Address::mailbox/ ) { say "Yay!"; } else { say "Boo!"; } say "Email::Valid tests =>"; if (Email::Valid->address( -address => "$email", -fqdn => 0 )) { say "Yay!"; } else { say "Boo!"; } 1; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 23:41:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 21:41:02 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 124002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124002&action=edit Bug 28870: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 23:41:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 21:41:09 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 124003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124003&action=edit Bug 28870: Use Email::Address to validate email addresses This patch adds a new dependency, Email::Address. It is used in Koha::Email to replace the current use of Email::Valid, which proved to be problematic when it comes to UTF-8 characters. Email::Address provides suitable regexes that -when used- keep our tests passing, but also deal better with UTF-8 data. To test: 1. Apply the regression tests patch 2. Notice the only change is that it tweaks a couple addresses so they contain umlauts and also have the "Description
" format that is used when sending carts. 3. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: Tests fail! Things die because Email::Valid doesn't like the from we passed. 4. Run: $ sudo apt install libemail-address-perl 5. Apply this patch 6. Repeat 3 => SUCCESS: Tests pass! 7. Try what is described in comment 1 => SUCCESS: Things are back to normal 8. Sign off :-D 9. Send cookies Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 23:41:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 21:41:21 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 124004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124004&action=edit Bug 28870: Remove traces of Email::Valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 23:42:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 21:42:57 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 20 23:45:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 21:45:45 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #2) > I don't know what to do. I have the feeling that what Ulrich is suggesting > is not the right thing as we are using the "Full name " format > for a while (bug 3280) now. > > On the other hand removing the validation seems bad as well. > > Adding a split in Koha::Email is not optimal (we could search for "<>" and > pass that to Email::Valid instead of the whole replyto string). > > Any good other suggestions, Tomas? I would like to add that if this solution based on Email::Address moves forward, I would like to make sure we don't build addresses manually, but pass Email::Address objects around instead. Or Koha::Email::Address objects if we wanted to do something Koha-ish on the addresses. I really like the library and the stringification it does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 00:01:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 22:01:44 +0000 Subject: [Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes the login link release notes| |in the OPAC when | |GoogleOpenIDConnect is | |enabled. It removes | |modal-related markup which | |was causing the link to | |fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 00:07:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Aug 2021 22:07:00 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes age tests in release notes| |t/db_dependent/Koha/Patrons | |.t so that the correct | |ages are calculated and | |displayed. It also adds the | |category code 'AGE_5_10' in | |messages to display age | |limits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 10:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 08:56:18 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 10:56:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 08:56:21 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123985|0 |1 is obsolete| | --- Comment #5 from Andrew Nugged --- Created attachment 124005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124005&action=edit Bug 28736: fix requirements for the correct error message to show up There is existing error message in the code stating: "Unable to understand your search query, please rephrase and try again." which fits perfectly but because it looks for "ParseException" in the warning output it doesn't show up on this page as it's actually "parse_exception". This patch makes that it's also checked if "parse_exception" is present in the warning output. Side note: "ParseException" reaction code was added here: e0f6c4dc Bug 12478: improve error reporting a bit Search::Elasticsearch seems propagates clean ES JSON answer, and in current ES version inside of $@ it contains "parse_exception" string in dumped JSON answer ("'type' => 'parse_exception'"). Old seeked phrase "ParseException" wasn't reproduced, only in ES logs ("Caused by: org.apache.lucene.queryparser.classic.ParseException: Cannot parse ..."). Check for both phrases won't complicate future changes, but this note added for reference and code cleanup if needed. To reproduce: 1) using ES search for something like "// ^ ! { } [ ] .. , <>" that will for sure break the syntax of ES. 2) after the search query fails note that the error is "Unable to perform your search. Please try again." 3) apply the patch 4) search for the same thing again 5) error message should be "Unable to understand your search query, please rephrase and try again." now. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 10:56:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 08:56:25 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 --- Comment #6 from Andrew Nugged --- Created attachment 124006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124006&action=edit Bug 28736: (QA follow-up) hints in explanation about broken syntax Add direct hint for the user what might be the issues with search phrase. In most cases we have unescaped or not removed special characters when user copy-pastes book name. If we explain that error happens because there is special search language, user will know what to research because we explicitly will tell that this is NOT the empty result, but search wasn't performed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 10:59:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 08:59:36 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 --- Comment #7 from Andrew Nugged --- This "sub process_error" code was added here: e0f6c4dc Bug 12478: improve error reporting a bit And it expected to get 'ParseException' inside of $@. I didn't found any traces and explanations when we have text with "ParseException" from ES, is it older ES versions that had such word? (Search::Elasticsearch seems just propagates clean ES answer though) Nowadays we have "parse_exception" in "$@" contents, in dumped JSON answer from ES it contains answer body with "'type' => 'parse_exception'" value. I don't think the "ParseException" presence will make future updates more complicated but let's have this history-of-thoughts noted in the commit message, Part2: QA-follow-up: in my experience, I had a lot of users thinking that "nothing was found", when ES error happened. I changed the phrase to be wordier but to explain that there MIGHT be results, but the user needs to review his request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 11:33:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 09:33:08 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #277 from Andrew Nugged --- Can't apply on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 20:31:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 18:31:05 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #71 from Andrew Nugged --- Generally about these complications and some mess with ES search: we don't have at all ES query language parser and transmitting requests directly to ES and getting its "parse_exception" reactions, so in Perl can't explain in which part of the syntax the issue, if Operator wants to have a direct search result, then he/she must escape special symbols for not to be "commands" for ES or use quoted texts to search exact terms. this is a "fuzzy" search though so sometimes wrong queries might lead to not having results even if there are such characters in the book name, a tradeoff for full-text search. We have only basic analysis which by the way was lost and not worked and fixed in Bug 28736, at least now the user will know that it's not "nothing found", but there are problems in special ES query syntax. How to use that syntax the user should read from ES language docs (or it we have some intro in Koha Doc for that?), but if the operator knows that there is ES syntax used and there are special characters and should use those properly: escape or quote. In other cases, it becomes a "weird" mix of words and special characters which leads to "unpredictable behavior" if you don't know how to use ES syntax. And also error message was mangled before, but now in Bug 28736 user knows that it's not "book not found", but the syntax and special language for ES used wrongly, so "please escape or quote". But this my answer actually to forward that 28736 brought some light, as first part covering "most things", which we not covering in this current ticket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 20:48:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 18:48:07 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124006|0 |1 is obsolete| | --- Comment #8 from Andrew Nugged --- Created attachment 124007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124007&action=edit Bug 28736: (QA follow-up) hints in explanation about broken syntax Add direct hint for the user what might be the issues with search phrase. In most cases we have unescaped or not removed special characters when user copy-pastes book name. If we explain that error happens because there is special search language, user will know what to research because we explicitly will tell that this is NOT the empty result, but search wasn't performed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 20:57:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 18:57:43 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #72 from Andrew Nugged --- Now regarding the current ticket - why it's appeared: There already was some "prevention from dies (exceptions) in ES language" to make requests "just regular characters" instead of special commands, We already had some FUZY pre-processing before this current bugfix code in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm, "sub _clean_search_term": some extra "precleaning", for example, curly braces "{}" any of them were replaced by '"' doublequote, and "=" replaced with ":", and colons with space before or space after (": " or " :") were just removed so only the space left, but trailing colon, trailing exclamation mark, and square range braces which actually not range (like in "[OHO]" phrase: ES dies because it's not [X TO Y] format) misled ES and anyway made ES die sometimes, So, that was incomplete and this ticket adds some more of such fuzziness but in the proper way (for example, ranges like "{... TO ...]" (i.e. full mix of ],},[,{ now works), But please don't demand from it to be "fully covering ES language" thing, in my opinion, this ticket decreases the number of "crashes" and "syntax errors" but at the same time, fixes range searches and started to recognize even "ES regular expressions" if they are enabled (yes, "QueryRegexEscapeOptions" case!), and fixes behavior with "QueryAutoTruncate" enabled, let me provide some examples below. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 21:20:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 19:20:54 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124007|0 |1 is obsolete| | --- Comment #9 from Andrew Nugged --- Created attachment 124008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124008&action=edit Bug 28736: (QA follow-up) hints in explanation about broken syntax Add direct hint for the user what might be the issues with search phrase. In most cases we have unescaped or not removed special characters when user copy-pastes book name. If we explain that error happens because there is special search language, user will know what to research because we explicitly will tell that this is NOT the empty result, but search wasn't performed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 22:02:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 20:02:01 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 --- Comment #10 from Andrew Nugged --- Note for RM: it's now about "human language", not Perl question – please confirm my last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 22:02:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 20:02:13 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 22:02:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 20:02:39 +0000 Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 22:20:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 20:20:17 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #73 from Andrew Nugged --- First, if you create" crazy request like (exactly this to the search field): The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ / it's impossible to do such fuzziness to guess what's wrong in such message in ES query, so we will just tell the user this: Error: There might be results, but there is ElasticSearch query language syntax error in your search request: remove or escape with backslash ES-language reserved characters (those are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : / ) or change it to be the proper ES-language request and try again." (as from Bug 28736) But in the current ticket, we added some more clean fuzziness (let me describe difference between "current master" and what this current bugfix brings further -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 23:08:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 21:08:41 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #74 from Andrew Nugged --- QueryAutoTruncate case: ========================= This is a feature that BLINDLY adds to alphanumeric-ended words asterisk in the end before tossing that phrase to ES as a search query. So, if QueryAutoTruncate is enabled (default), the Perl part just adds to the end of any alphanumeric-ended word asterisk, disregards ES syntax (ranges too), so if we will put such request phrase, the current master branch (Perl part) will transfer the below examples to ES as a query string (here I provide "what we entered" in the search field as 'IN:' and what transferred to ES as 'OUT:' pairs): (before the patch, phrase 1) IN: The [Book] OUT: The* [Book] (will make ES fail with a yellow error text box) in fact, ES doesn't understand your "special language usage" [Book] confuses ES because not in [... TO ...] form, and with ranges: (before the patch, phrase 2) IN: The "Book" {2000 TO 2002} [1900 TO 1990] OUT: The* "Book" "2000 TO 2002" [1900* TO* 1990] (will make ES fail with a yellow error text box) [1900* TO* 1990] confuses ES because not in [... TO ...] form, Here we see that it converted '{' and '}' to '"', and added '*' because of "QueryAutoTruncate enabled" to all alphanumeric-ended words. Second even more weird example: (before the patch, phrase 3) IN: The "Book" [2000 TO 2002} OUT: The* Book* [2000* TO* 2002* (will make ES fail with a yellow error text box) [2000* confuses ES because [ has no pair and no range there, And here quotes get lost because one "}" brace was converted to doublequote, but because it was only one, so was "unpaired", then the logic of the current code is to remove quotes at all if they are unbalanced (I agree, but it shouldn't convert braces to quotes). All requests above lead to a "yellow" Error text box, which means that ES fired an exception because of the error in query language syntax (and in Koha server error log there will be the error message ES 'Failed to parse query'). Anyway, as I see, this "QueryAutoTruncate" mode is designed for very simple usage behavior, i.e. user expected to do the requests without using any special language at the most, and give as much as possible results to the user assuming that there was "just beginnings of the words" requested if one enters: so bi this will be translated by Perl code to so* bi* and passed to ES so ES will match with for examples books named "Something Big" and "Solved Binary Book" This QueryAutoTruncate as well ruins the syntax of ES range requests (that '[1900 TO 1990]' becomes '[1900* TO* 1990]' in ES-language) so no reason to keep the ranges, and that accounted in the patch: Now with the patch: This patch is not intended to make the "full fix", it's not so easy for this, but at least the patch makes braces in QueryAutoTruncate mode just regular symbols by pre-slashing them. Same as above but WITH this patch will make such internal transformations, let's see by example: (after patch, phrase 1) IN: The "Book" {2000 TO 2002} [1900 TO 1990] OUT: The* \[Book\] ES understands that here we search 'the* book' and actually even will find 6 results in the current dev-test database, instead of "failing to the error" like in the example above without the patch, (after patch, phrase 2) IN: The "Book" {2000 TO 2002} [1900 TO 1990] OUT: The* "Book" \{2000* TO* 2002\} \[1900* TO* 1990\] ES understands that here we search 'The* "Book" 2000* TO* 2002 1900* TO* 1990' but it's a pretty rare phrase to find something, so - zero results, but no "ES exception", (after patch, phrase 3) IN: The "Book" [2000 TO 2002} OUT: The* "Book" \[2000* TO* 2002\} Same here as above, zero results but no "exceptions". I.e. those braces now become not-special-language characters and just passed by to ES to decide. In real life, those braces ignored by ES as non-alphanumeric, so querying: some [word] with QueryAutoTruncate enabled after the patch will be the same as search: some* word and BEFORE the patch it was just the "yellow" "error happened" text box result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 21 23:58:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 21:58:00 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- I attempted to test, but always seem to have a problem with sending carts/list where I have an error "Problem sending the cart..." (before patches are applied, using koha-testing-docker). All the tests now ass. Also, does this address the issue of being able to send emails with accents and umlauts in them, or is that a separate bug? For example, I couldn't add an email address for a patron or system preferences where it has an accent or umlaut in either the address or the domain - get "Please enter a valid email address.". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 00:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 22:20:40 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #75 from Andrew Nugged --- QueryRegexEscapeOptions ========================= Now let's turn "QueryAutoTruncate" off and check with QueryRegexEscapeOptions: It's all about RegEx in ES queries, https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-regexp-query.html Koha admin settings QueryRegexEscapeOptions has three options: - escape, i.e. if the request will have any regular expressions between slashes: /book/ this will be passed in "disabled, not RegEx anymore" to ES: \/book\/ so ES will get this just as regular text to search, and in this example will just search for the word 'book', ignoring other non-alphanum chars. (*)NOTE: but this means that passing RegEx to ES is impossible, at all. and this means any book name like in the search field will work: We are / They are so if we copy-paste this to the search field, ES gets: We are \/ They are and Koha just searches it as it is. I assume this was added as a feature to disable "/" meaning as a special RegEx limiter and allow librarians to search "We are / They are" text directly. - don't escape, so: /go+d/ will be passed as it is to ES, so this will be special "Regular Expressions" in this example, this means "'g' then 'o' one or more times then 'd'" so search in ES for /go+d/ example is similar to search: god OR good ( yet not the same because RegExp 'go+d' is not limited by a few 'o's, so might match for 'gooooood' too) BTW it founds 7 books for me in both ways (/go+d/ and god OR good) in the current master dev-test DB. (*)NOTE: but this means that now any '/' which appears in the text will cause ES to throw an exception if the syntax is not understood, i.e. search for exactly this: We are / They are now won't work so the users need to do escaping themself and ask: We are \/ They are (by backslashing '/' in the request field) to make ES not "die" and search to work. That's why I assume to make 1+2 both working, 3rd one was introduced: - unescape escaped, yeah, that's "The Trick" to make 1st way "We are / They are" requests to work and ES not to fail, but at the same time allowing to bring Regular Expressions by users, just in "pre-slashed form", i.e. what pre-slashed WILL BE RegExs, what isn't -- won't be but won't "throw a syntax error" too, so: We are / They are will be tossed to ES as "We are \/ They are" and will search for "We are They are", bit this (NOW THE TRICK! BEHOooooLD!): We are / They are \/go+\/ will be transferred to ES in such form: We are \/ They are /go+/ and ES will search for 'we', 'they', 'are' words, all to be present, plus one of the any: go, goo, gooo, goooo.. words ( this founds, btw, "Seesaw [sound recording] / Beth Hart, Joe Bonamassa" in current test DB :-), hey! ) This is how it is expected to work. But the reality in current master a little worse, Let's have "unescape escaped", let's invent such request: \/go{1,2}d\/ which EXPECTED by us to be transferred to ES as RegEx: /go{1,2}d/ what means we want ES to find for us: 'g', then one or max two 'o', and 'd' i.e. this is exactly ONLY for finding "good" or "god". But current master branch code breaks these expectations: replaces "{" and "}" with double quotes), so for real this transferred to ES as the request: /go"1,2"d/ and obviously, nothing was found. But with this patch, the request: \/go{1,2}d\/ will be passed to ES as: /go{1,2}d/ and voila, "7 result(s) found for '\/go{1,2}d\/'." in our test DB. Huh! More, because this patch respects {,} in regex but escapes those outside, it will pass those escaped, so if you will search: \/go{1,2}d\/ [go] this will pass to ES request WITHOUT patch: /go"1,2"d/ [go] and bring yellow "Error" text box, and this will be passed to ES request WITH patch: /go{1,2}d/ \[go\] and because "\[" and "\]" ignored by ES, it searches just for "good" or "god" plus the word "go", so the final searched text should contain "good to go" or "go god" combinations (or others like those). And yes, on test DB it founds 3 results! With patch. And gives "error/nothing" without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 00:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 22:40:39 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #76 from Andrew Nugged --- Ranges in ES language ========================= let's disable QueryAutoTruncate for not adding those asterisks, and QueryRegexEscapeOptions doesn't matter here unless we will add regular expressions. So: ES allows us to have ranges requests, like: novel {1947 TO 1950] this expects to find word "novel" and one of the words in the range between "1948 to 1950", and 1948 said here because '{' means "not included in range" value, but starting from it (i.e. not '>=', but '>'), but code in current master replaces '{' with '"', and then even more, unbalanced (unpaired) '"' removed as well, so the final request to ES will be: novel 1947 TO 1950] which has 'hanging ]' that ES doesn't understands and throws an exception (welcome to the 'yellow Error box' instead of 'found' result here again). Now, with the patch: novel {1947 TO 1950] transferred correctly as it is, and ES on test DB finds single: The vixens. A novel. Publication details: London, 1948. for obvious reasons. Now to play another example "without and with patch", here: [novel] [1900 TO 1950] without the patch, it transferred "as is" to ES, and gives a yellow error, because ES doesn't understands range as in '[novel]'. With patch it becomes transformed to such request to ES: \[novel\] [1900 TO 1950] and because backslashed non-alphanumeric characters are ignored, it works and brings the result - one book, like in the previous example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 01:57:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Aug 2021 23:57:20 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #77 from Andrew Nugged --- Tricks with colons: ====================== colons in Koha expected to separate search field and search value, so "title:good" should search word "good" only in "titles", but if you will use "some : like this" form, when copypasting from usual combined book names we often have, current code removed colons at all from the text, if colon has the space at any side, but there was forgotten trailing ":" removal, i.e. ES failed without patch if to search: Books: also, some fuzziness added, for example, if you rename any book to have "23:59" in the name, then will search with an old code for: title:23:59 it will die ("yellow error box"), but with the patch, it will find, as this transformed by the patch to: title:23\:59 i.e. there every next semicolon after first in the term preslashed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 02:01:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 00:01:38 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #78 from Andrew Nugged --- And the exclamation mark: ====================== this used to be the "negate" command for words in queries, ONLY when '!' sticking to the beginning of the word, so patch fuzziness added: non-sticky and trailing exclamations marks removed, so in the case of the search: Dalek! without the patch, this brought a yellow error box, but with the patch dangling "!" was removed and it just passes "Dalek" to ES. It finds two books in our test DB, btw. And this one: Dalek !War works normally with both, with and without the patch. It searches for "Dalek" but negates "war" word presence. In our test dev-DB by the way, it gives just one book as a result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 02:15:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 00:15:58 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #79 from Andrew Nugged --- (In reply to Victor Grousset/tuxayo from comment #41) > > 4) additionally perform a search using range, Vicor, this seems working now, By the way, it should find normally this with and without patches for you: date-of-publication:[1983 TO 1985] But before the patch, if you will use "not including border values" ranges: date-of-publication:{1983 TO 1985} and then because not-patched code converts it to this: date-of-publication:"1983 TO 1985" it even did not fail to "yellow error box", just said "no results", but there is: with patch now it finds 4 books for me on test DB for {1983 TO 1985}. Besides you for sure can find when ES crashes, :hugs: but without the patch, you will have much more possibilities to get that ES syntax error now. And I covered come in/outs and experiments above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 02:16:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 00:16:19 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #80 from Andrew Nugged --- So, the patch adds more order with "QueryRegexEscapeOptions" than before, same with "QueryAutoTruncate", and keeps ranges working as well. Yet it loooo+ng read above :), for a strong coffee and murky cat nearby ^_^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 02:27:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 00:27:03 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #81 from Andrew Nugged --- Why this fuzziness and the extra job was done by us? We wanted to limit syntax errors from ES and make it easier for librarians to copy-paste just book names and have results, but NOT TO FORCE THEM backslash or re-edit text "for as long as possible", so for example earlier, they pasted "normal human phrases", like each of these: The Book! The Book [directed by robert b weide] The Book: and that lead earlier for ES to crash and bring "yellow Error box", even worse: before Bug 28736 people were confused that "oh, nothing found!" but for real there not even searched because of syntax error. Now, these above examples working and finding results (except the middle one because no such book in test DB yet :) ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 06:44:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 04:44:21 +0000 Subject: [Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Mark Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #13 from Mark Tompsett --- I'm thankful this is already pushed, but I'm curious why was the role attribute removed as well? It was only the data-modal part that was preventing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 22:18:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 20:18:17 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #10 from David Nind --- Oops... tat should have said "All tests pass"! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 22:51:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 20:51:18 +0000 Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 22 22:51:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Aug 2021 20:51:22 +0000 Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123978|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 124009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124009&action=edit Bug 28885: Skip invalid biblios for OpacBrowseResults If a record is deleted from Koha, but is for some reason not deleted from the search indexes, OpacBrowseResults can cause an ISE if the deleted record is in the search results for any given item. OpacBrowseResults loops through the search results, and checks if there is a biblionumber, but does *not* check to see if a result was pulled from the database for that biblionumber. It simply assumes the result must exist. We should be checking to ensure the biblionumber was valid before operating on the biblio object. Test Plan: 1) Use zebra for searching 2) Disable koha-indexer 3) Enable OpacBrowseResults 4) Perform a search 5) Delete an item in the search results 6) View on of the remaining items in the search results 7) Note the error 8) Apply this patch 9) Restart plack 10) Reload the page 11) The error should be gone! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 08:40:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 06:40:03 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122691|0 |1 is obsolete| | --- Comment #65 from Alex Buckley --- Created attachment 124010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124010&action=edit Bug 26346: (follow-up) Fixes in response to QA * Fix addressing comment #59 - Making can_be_deleted() consistent to testing Patrons::find * Fix addressing comment comment #61 - Have made the first and second lines consistent, both now return 0 Sponsord-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 08:52:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 06:52:00 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #66 from Alex Buckley --- Created attachment 124011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124011&action=edit Public list with "Allow changes to contents from=Anyone seeing this list" shows to anonymous patron in Add to a list page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 08:53:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 06:53:49 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #67 from Alex Buckley --- (In reply to Marcel de Rooy from comment #63) Hi Marcel, * Follow-up patch attached containing fixes for comments #59 and #61. Could you please take a look? * Regarding comment #60: I've been testing this today. When a 'staff only' list is created both the virtualshelves.allow_change_from_owner and virtualshelves.allow_change_from_staff values are set to 1 (see below): | allow_change_from_owner | allow_change_from_others | allow_change_from_staff | +-------------------------+--------------------------+-------------------------+ | 1 | 0 | 1 | +-------------------------+--------------------------+-------------------------+ So the first condition ($self->owner == $borrowernumber && > $self->allow_change_from_owner) is true when a staff member who owns a 'staff only' list and doesn't have the staff_only_lists permission tries to add/delete an item from their list. i.e. they can add/remove an item in their cart. Am I perhaps missing something? * Regarding comment #62: When you refer to anonymous user do you mean logging in as the borrower set in the AnonymousPatron system preference? When I log into the OPAC as borrower 53 (AnonymousPatron = 53), do a search, click 'Save to lists' under a biblio, then public lists set to "Allow changes to contents from=Anyone seeing this list" show in the "Select a list" dropdown (I've attached a screenshot showing 'public' displaying in the Add to a list page), I can then add the item to that list. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 09:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 07:10:21 +0000 Subject: [Koha-bugs] [Bug 28890] New: Serial cataloguing GATEWAY TIMEOUT Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28890 Bug ID: 28890 Summary: Serial cataloguing GATEWAY TIMEOUT Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: mafzal at jmi.ac.in QA Contact: testopia at bugs.koha-community.org after feeding MARC RECORD in serials it takes long to process the data. Finally error appears as GATEWAY TIMEOUT. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:22:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:22:53 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:23:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:23:03 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123055|0 |1 is obsolete| | --- Comment #522 from Ere Maijala --- Created attachment 124012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124012&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:23:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:23:11 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123056|0 |1 is obsolete| | --- Comment #523 from Ere Maijala --- Created attachment 124013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124013&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:23:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:23:20 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123057|0 |1 is obsolete| | --- Comment #524 from Ere Maijala --- Created attachment 124014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124014&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:23:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:23:28 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123058|0 |1 is obsolete| | --- Comment #525 from Ere Maijala --- Created attachment 124015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124015&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:23:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:23:36 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123059|0 |1 is obsolete| | --- Comment #526 from Ere Maijala --- Created attachment 124016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124016&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:23:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:23:45 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123060|0 |1 is obsolete| | --- Comment #527 from Ere Maijala --- Created attachment 124017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124017&action=edit Bug 20447: Fixes for bug 17600 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:23:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:23:53 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123061|0 |1 is obsolete| | --- Comment #528 from Ere Maijala --- Created attachment 124018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124018&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged Rebased-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 11:25:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 09:25:55 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #529 from Ere Maijala --- Martin, should be working now. Joonas did most of the work, and I fixed a typo in "Fixes for bug 17600" patch and holdings XML creation for XSLT. ALso rebased to fix expected test counts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 14:18:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 12:18:05 +0000 Subject: [Koha-bugs] [Bug 28890] Serial cataloguing GATEWAY TIMEOUT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Afzal, please see my reply on the mailing list and my comment on bug 28865. *** This bug has been marked as a duplicate of bug 28865 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 14:18:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 12:18:05 +0000 Subject: [Koha-bugs] [Bug 28865] serial cataloguing REQUEST GATEWAY TIMEOUT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28865 --- Comment #2 from Katrin Fischer --- *** Bug 28890 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 15:24:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 13:24:09 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #11 from Tomás Cohen Arazi --- (In reply to David Nind from comment #9) > I attempted to test, but always seem to have a problem with sending > carts/list where I have an error "Problem sending the cart..." (before > patches are applied, using koha-testing-docker). Yes, that's because KTD doesn't have an SMTP server running. But you should look at the error logs before and after the patches. The errors should go from: [2021/08/23 12:45:40] [WARN] Error sending mail: Invalid 'to' parameter: tomascohen+á@gmail.com at /kohadevbox/koha/opac/opac-sendbasket.pl line 178. into [2021/08/23 13:11:22] [WARN] Error sending mail: unable to establish SMTP connection to localhost port 25 > All the tests now ass. :-D > Also, does this address the issue of being able to send emails with accents > and umlauts in them, or is that a separate bug? For example, I couldn't add > an email address for a patron or system preferences where it has an accent > or umlaut in either the address or the domain - get "Please enter a valid > email address.". It really depends on the context. But generally I'd say it is a different bug, as validation on (say) memberentry is done a JavaScript level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 15:27:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 13:27:40 +0000 Subject: [Koha-bugs] [Bug 28891] New: RecordStaffUserOnCheckout display a new column but default sort column isn't changed. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 Bug ID: 28891 Summary: RecordStaffUserOnCheckout display a new column but default sort column isn't changed. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: didier.gautheron at biblibre.com Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 23916 Hi, If system preference RecordStaffUserOnCheckout is set a new column is displayed but table default sort column stays the same (column 4). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 [Bug 23916] Issuer should be recorded and visible in patron circulation history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 15:27:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 13:27:40 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:06:24 +0000 Subject: [Koha-bugs] [Bug 9815] <> can't contain "The Library" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9815 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28870 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:06:24 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9815 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:13:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:13:48 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:13:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:13:51 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #22 from Nick Clemens --- Created attachment 124019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124019&action=edit Bug 28373: (follow-up) QA fixes Use fully qualified subroutine name Don't return explicit undef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:26:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:26:06 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:28:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:28:02 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:28:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:28:02 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:31:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:31:31 +0000 Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 --- Comment #1 from Didier Gautheron --- Created attachment 124020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124020&action=edit Bug 28891: (bug 23916 follow up) Always use 'Checkout on' as default Checkout history sort column To test: 1 - Unset RecordStaffUserOnCheckout 2 - Check out an item 3 - Display Checkout history, table is sorted by 'Checkout on' column 4 - Set RecordStaffUserOnCheckout 5 - Display Checkout history, table is sorted by 'Renewed' column 6 - Apply patch 7 - Redo 1, 3, 4 and 5, table is always sorted by 'Checkout on' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:33:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:33:16 +0000 Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:56:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:56:55 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:57:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:57:29 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:57:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:57:47 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:58:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:58:06 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123907|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:58:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:58:24 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:58:45 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:58:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:58:59 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:59:14 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 16:59:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 14:59:43 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:00:06 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:00:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:00:26 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:00:51 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123885|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:01:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:01:15 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:01:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:01:40 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:02:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:02:01 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123888|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:02:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:02:11 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:02:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:02:19 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123890|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:02:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:02:30 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:02:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:02:43 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:03:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:03:08 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123893|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:03:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:03:26 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:03:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:03:52 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123895|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:04:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:04:13 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123896|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:04:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:04:29 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123897|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:04:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:04:51 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123898|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:05:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:05:08 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123899|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:05:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:05:31 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:05:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:05:54 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123901|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:06:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:06:04 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123902|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:06:13 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:08:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:08:06 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #349 from Tomás Cohen Arazi --- Created attachment 124021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124021&action=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:08:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:08:28 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #350 from Tomás Cohen Arazi --- Created attachment 124022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124022&action=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:08:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:08:45 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #351 from Tomás Cohen Arazi --- Created attachment 124023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124023&action=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:08:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:08:59 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #352 from Tomás Cohen Arazi --- Created attachment 124024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124024&action=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:09:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:09:14 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #353 from Tomás Cohen Arazi --- Created attachment 124025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124025&action=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:09:39 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #354 from Tomás Cohen Arazi --- Created attachment 124026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124026&action=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:10:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:10:19 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #355 from Tomás Cohen Arazi --- Created attachment 124027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124027&action=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:10:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:10:41 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #356 from Tomás Cohen Arazi --- Created attachment 124028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124028&action=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:11:00 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #357 from Tomás Cohen Arazi --- Created attachment 124029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124029&action=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:11:15 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #358 from Tomás Cohen Arazi --- Created attachment 124030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124030&action=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:11:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:11:27 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #359 from Tomás Cohen Arazi --- Created attachment 124031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124031&action=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:11:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:11:41 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #360 from Tomás Cohen Arazi --- Created attachment 124032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124032&action=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:12:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:12:14 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #361 from Tomás Cohen Arazi --- Created attachment 124033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124033&action=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:12:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:12:27 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #362 from Tomás Cohen Arazi --- Created attachment 124034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124034&action=edit Bug 24857: Fix license statements Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:12:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:12:52 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #363 from Tomás Cohen Arazi --- Created attachment 124035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124035&action=edit Bug 24857: Fix POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:13:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:13:22 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #364 from Tomás Cohen Arazi --- Created attachment 124036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124036&action=edit Bug 24857: Add missing filter and move js to footer on additem.tt Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:13:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:13:48 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #365 from Tomás Cohen Arazi --- Created attachment 124037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124037&action=edit Bug 24857: Fix simple-quote string Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:14:19 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #366 from Tomás Cohen Arazi --- Created attachment 124038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124038&action=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:14:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:14:39 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #367 from Tomás Cohen Arazi --- Created attachment 124039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124039&action=edit Bug 24857: Fix sorting of new syspref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:14:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:14:57 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #368 from Tomás Cohen Arazi --- Created attachment 124040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124040&action=edit Bug 24857: Change button text from "Create new" to "New volume" Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:15:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:15:20 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #369 from Tomás Cohen Arazi --- Created attachment 124041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124041&action=edit Bug 24857: (QA follow-up) Add volume to table settings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:15:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:15:47 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #370 from Tomás Cohen Arazi --- Created attachment 124042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124042&action=edit Bug 24857: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:16:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:16:04 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #371 from Tomás Cohen Arazi --- Created attachment 124043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124043&action=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:16:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:16:24 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #372 from Tomás Cohen Arazi --- Created attachment 124044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124044&action=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:16:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:16:50 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #373 from Tomás Cohen Arazi --- Created attachment 124045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124045&action=edit Bug 24857: (QA follow-up) Fix QA script issues Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:17:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:17:08 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #374 from Tomás Cohen Arazi --- Created attachment 124046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124046&action=edit Bug 24857: (follow-up) Use $c->unhandled_exception This patch makes the controller up to date with the currently used style and codebase. It also sinlences a useless warning, and makes it return 404 (instead of 409) when trying to add items to a volume on a non-existing biblio. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Some warnings 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors, no warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:17:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:17:28 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #375 from Tomás Cohen Arazi --- Created attachment 124047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124047&action=edit Bug 24857: Use $c->objects->find Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:17:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:17:56 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #376 from Tomás Cohen Arazi --- Created attachment 124048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124048&action=edit Bug 24857: Fix permissions in spec This patch corrects the spec so it requires the right permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:18:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:18:23 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #377 from Tomás Cohen Arazi --- Created attachment 124049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124049&action=edit Bug 24857: (QA follow-up) Adding items should check volume linked to biblio I noticed some tests included /biblios/{biblio_id}/volumes... in the URL. And they passed :-D This means the biblio_id is never tested. This patch fixes those two tests so they have valid biblio_id in the path, and adds a proper regression test for the expected behavior (409). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/volumes.t => FAIL: Notice the tests pass, even with bad data on the request 2. Apply this patch, notice a test is added for the bad biblio_id case and the other two tests are fixed so they have the intended biblio_id. 3. Repeat 1 => SUCCESS: Tests pass! This means things are correctly tested in the controller and the unit tests cover teh 'bad case' returning 409. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:18:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:18:43 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #378 from Tomás Cohen Arazi --- Created attachment 124050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124050&action=edit Bug 24857: (QA follow-up) Further spec fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:19:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:19:06 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #379 from Tomás Cohen Arazi --- Created attachment 124051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124051&action=edit Bug 24857: Rename Volumes => Item groups (DB) This patch renames Volumes => Item groups in the DB structure, and also on permissions and sysprefs. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:19:34 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #380 from Tomás Cohen Arazi --- Created attachment 124052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124052&action=edit Bug 24857: Adapt code to the volumes => item_groups change This patch updates the code so all references to 'volumes' are translated into 'item groups'. Relevant changes: - API routes and specs - Permission name is changed - Syspref name changed Note: I removed a behavior that felt unnatural (at least in the place it was put): deleting the item group if the linked item is deleted. It feels like a controller thing, and also something that could be offered to the staff on the UI on item deletion. To avoid blocking the feature, I suggest this removal, and discuss it in its own context. To test: 1. Run: $ reset_all 2. Apply this patchset 3. Run: $ updatedatabase => SUCCESS: Update works 4. Repeat 1 (with the patches applied) => SUCCESS: Install works with this DB structure 5. Run all the tests: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 6. Follow the original plan (with the Volume=>ItemGRoup change in mind) => SUCCESS: All good! 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:20:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:20:01 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #381 from Tomás Cohen Arazi --- Created attachment 124053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124053&action=edit Bug 24857: item_group_items.item_id must be unique -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:47:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:47:08 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #25 from Nick Clemens --- (In reply to wainuiwitikapark from comment #24) > Should this be backported to 19.11.x for 19.11.21? > > Or if it contains string changes, backported to 19.11.22? As we are > currently in a string freeze. Not urgent, so 22 is fine if it applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 17:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 15:48:46 +0000 Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Nick Clemens --- Moving to Signed-Off, QA queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 19:31:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 17:31:41 +0000 Subject: [Koha-bugs] [Bug 22458] PatronSelfRegistrationEmailMustBeUnique disallows self modification requests if multiple accounts share an email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org --- Comment #1 from Chris Slone --- Can confirm that this is an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 20:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 18:56:57 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #13 from Nick Clemens --- Created attachment 124054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124054&action=edit Bug 28741: [20.11.x] Fix warning and position check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 20:57:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 18:57:58 +0000 Subject: [Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #14 from Nick Clemens --- (In reply to Fridolin Somers from comment #10) > Depends on Bug 27584 not in 20.11.x The dependency affects the variable name change, the other parts of the patch set are still valid - we still show 'Show more' when at end of list and have a warning about the undef metadata prefix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 23:08:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 21:08:20 +0000 Subject: [Koha-bugs] [Bug 26570] Search Functionality in Borrowing History In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26570 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com --- Comment #1 from Marie-Luce Laflamme --- Hi Christofer there is a similar new feature in the latest Koha version 21.05. see bugzilla 25775 Hope it would fit your needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 23:36:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 21:36:38 +0000 Subject: [Koha-bugs] [Bug 26570] Search Functionality in Borrowing History In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25775 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 23:36:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 21:36:38 +0000 Subject: [Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26570 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 23:50:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 21:50:15 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |koha-bugs at lists.koha-commun | |ity.org --- Comment #14 from Katrin Fischer --- I think I need someone else to finish this one off here :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 23 23:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 21:52:12 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 --- Comment #15 from Katrin Fischer --- Can confirm this to still be an issue on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 00:38:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 22:38:42 +0000 Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron details page when City field is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 00:38:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 22:38:47 +0000 Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron details page when City field is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82136|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 124055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124055&action=edit Bug 21794: Fix display of addresses on details tab in staff when city is empty If the city field was not filled out on the main or alternate address, the content of state, country and zipcode wouldn't display on the Details tab in the patron account in staff. To test: - Enter main contact and alternate address without city - Verify that the address information isn't shown on the details tab after saving - Apply patch - Verify that the information is displayed now - Toggle AddressFormat and check display is correct for all settings - Switch back to US address format - Try several combinations of empty fields for city, zipcode, country and state. The punctuation and whitespace should always appear correctly. Examples: - Enter just country - Enter zipcode and country - ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 00:39:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 22:39:51 +0000 Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron details page when City field is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794 --- Comment #5 from Katrin Fischer --- I had to rewrite the patch completely as we have moved things around quite a bit (for the better) since the first attempt here was made. But I think this should fix the problem with city and also the punctuation issue noted in comment#2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 00:41:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 22:41:06 +0000 Subject: [Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- I can't fix the only remaining bug 22115 myself, so removing myself as Assignee. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:17:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:17:57 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #45 from Katrin Fischer --- (In reply to Fridolin Somers from comment #40) > (In reply to Nick Clemens from comment #39) > > We need to figure a method to make the query case sensitive > > Looks like we can set COLLATE like : > select city_name from cities where city_name='Paris' COLLATE utf8mb4_bin; I believe that is not quite the solution yet, as it would affect the strings we compare to instead of only the subfield codes, as we intend. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:31:15 +0000 Subject: [Koha-bugs] [Bug 28892] New: Item search treats lower and upper case subfields as the same Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28892 Bug ID: 28892 Summary: Item search treats lower and upper case subfields as the same Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 20689 At the moment when you are using upper case subfields in items and your bibliographic records, this will work in the frameworks, in cataloguing and in searching with Zebra. But as the item search uses SQL and ExtractValue, it will always return the contents of the lower and upper case subfield, no matter what you configured for your additional item search fields. Example: 520$a, 520$A Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 [Bug 20689] Make it possible to add capital letter subfields to item search fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:31:15 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28892 [Bug 28892] Item search treats lower and upper case subfields as the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:34:40 +0000 Subject: [Koha-bugs] [Bug 28892] Item search treats lower and upper case subfields as the same In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20689 Depends on|20689 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 [Bug 20689] Make it possible to add capital letter subfields to item search fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:34:40 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28892 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28892 [Bug 28892] Item search treats lower and upper case subfields as the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:40:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:40:17 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:40:22 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87955|0 |1 is obsolete| | Attachment #87956|0 |1 is obsolete| | Attachment #87957|0 |1 is obsolete| | Attachment #88294|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer --- Created attachment 124056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124056&action=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:40:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:40:27 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #47 from Katrin Fischer --- Created attachment 124057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124057&action=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. Both templates (the main view and the edit view) have been modified so that item_search_fields.js can be included in both. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Test both "new" and "edit" operations. Test other operations like delete and cancel. Signed-off-by: Mark Tompsett Signed-off-by: Jose-Mario Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:40:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:40:33 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #48 from Katrin Fischer --- Created attachment 124058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124058&action=edit Bug 20689: (follow-up) Tiny typo fix Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 24 01:40:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Aug 2021 23:40:37 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #49 from Katrin Fischer --- Created attachment 124059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124059&action=edit Bug 20689: (follow-up) Correct scope of template variables The removal of the behaves and how a Select2 dropdown (like on additem.pl) works: HTML . 2. Use arrow key to highlight option. 3. Hit tab key -> Option is selected. * ENTER key also works. 4. Hit tab key -> Focus moves to next input. Select2 dropdown: 1. Tab to field. 2. Hit ENTER. 3. Use arrow key to highlight option. 4. Hit ENTER -> Option is selected. * TAB key does NOT work to select an option. 5. Hit tab key -> Focus moves to next input. If that's correct, it looks like the tab key difference can be changed by setting a new default in select2.js: "selectOnClose" -> true In terms of having the same number of interactions (key presses or clicks), it would be nice if one didn't have to hit ENTER to activate a Select2 menu. I don't think that's currently configurable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:15:03 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #7 from Didier Gautheron --- (In reply to Katrin Fischer from comment #5) > Maybe I am testing the wrong thing. > > Do you mean copying a repeatable field or are we talking about the authority > linker? > Authority editor or editing bibliographic records? Authority search Window. 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- as in 19.11 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:23:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:23:07 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 --- Comment #2 from Marcel de Rooy --- >From a keyboard user perspective may be harder to explain? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:23:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:23:56 +0000 Subject: [Koha-bugs] [Bug 27197] Empty information in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 28567 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:23:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:23:56 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #30 from Jonathan Druart --- *** Bug 27197 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:26:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:26:16 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 --- Comment #3 from Owen Leonard --- I don't understand your comment Marcel. The change would be harder to explain? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:31:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:31:30 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #5 from Jonathan Druart --- What's your version of JSON::Validator? Are you using Debian 11? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:33:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:33:52 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #6 from Jonathan Druart --- See http://irc.koha-community.org/koha/2021-08-16#i_2371014 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:35:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:35:03 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28811, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26893 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:35:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:35:03 +0000 Subject: [Koha-bugs] [Bug 28811] Cant receive orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28800 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:35:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:35:03 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28800 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:37:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:37:18 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #8 from Jonathan Druart --- (In reply to Didier Gautheron from comment #7) > 4- Apply patch Which one? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:44:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:44:13 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 --- Comment #4 from Marcel de Rooy --- (In reply to Owen Leonard from comment #3) > I don't understand your comment Marcel. The change would be harder to > explain? Yeah too short. The fact that one form has a dropdown type A and another one dropdown type B, and you should press X on form A but press Y on form B is harder to explain. For users it may just be a dropdown.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:58:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:58:51 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 15:58:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 13:58:55 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #9 from Didier Gautheron --- Created attachment 124116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124116&action=edit Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:03:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:03:45 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |didier.gautheron at biblibre.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:04:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:04:22 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #10 from Didier Gautheron --- (In reply to Jonathan Druart from comment #8) > (In reply to Didier Gautheron from comment #7) > > 4- Apply patch > > Which one? :) The one I forgot to add :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:21:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:21:49 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:21:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:21:58 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:22:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:22:58 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to create |Add ability to group items |"Volumes" for records, and |for records |assign items to volumes | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:23:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:23:17 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:30:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:30:55 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- (In reply to Owen Leonard from comment #1) > If that's correct, it looks like the tab key difference can be changed by > setting a new default in select2.js: "selectOnClose" -> true Pierre, does Owen's suggestion answer your need? > In terms of having the same number of interactions (key presses or clicks), > it would be nice if one didn't have to hit ENTER to activate a Select2 menu. > I don't think that's currently configurable. You can open the dropdown list hitting "space" in both situations. So if we turn selectOnClose on, we are good. Am I missing something? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:42:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:42:32 +0000 Subject: [Koha-bugs] [Bug 26570] Search Functionality in Borrowing History In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 25775 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 16:42:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 14:42:32 +0000 Subject: [Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #14 from Jonathan Druart --- *** Bug 26570 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:14:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:14:06 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #12 from Jonathan Druart --- Created attachment 124117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124117&action=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:14:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:14:11 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #13 from Jonathan Druart --- Created attachment 124118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124118&action=edit Bug 28870: Use Email::Address->parse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:15:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:15:45 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #14 from Jonathan Druart --- Tomas, see the last 2 patches. It seems that matching the regex is not enough (last patch fixes a test). However there is still a test failing, root at localhost is considered valid (FQDN no longer required). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:19:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:19:09 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #15 from Katrin Fischer --- (In reply to Jonathan Druart from comment #14) > Tomas, see the last 2 patches. > > It seems that matching the regex is not enough (last patch fixes a test). > > However there is still a test failing, root at localhost is considered valid > (FQDN no longer required). Shoudl it not be valid since bug 28017? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:21:53 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #16 from Jonathan Druart --- Created attachment 124119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124119&action=edit Bug 28870: non-FQDN addresses are valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:22:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:22:26 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28017 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > (In reply to Jonathan Druart from comment #14) > > Tomas, see the last 2 patches. > > > > It seems that matching the regex is not enough (last patch fixes a test). > > > > However there is still a test failing, root at localhost is considered valid > > (FQDN no longer required). > > Shoudl it not be valid since bug 28017? I forgot that one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:22:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:22:26 +0000 Subject: [Koha-bugs] [Bug 28017] Allow non-FQDN and IP addresses in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28870 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:32:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:32:18 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #99 from Jonathan Druart --- The way this enhancement is implemented sounds weird to me. Why are you using perl when it can be done using Datatables (client-side)? Having the ability to define a list of word to ignore is great, but it can be done (at first glance) easily by extending the 'anti-the' plugin (and it will apply to *all* tables of Koha). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 17:32:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 15:32:33 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 19:41:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 17:41:59 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #7 from Manos PETRIDIS --- (In reply to Jonathan Druart from comment #5) > What's your version of JSON::Validator? Are you using Debian 11? JSON::Validator (0.97) 0.97 JSON (2.07) 2.90 Template::Plugin::JSON::Escape (0.02) 0.02 I'm using Debian 9, wasn't aware that koha is now compatible with later Debian releases. Koha version: 21.05.02.000 OS version ('uname -a'): Linux koha 4.9.0-16-amd64 #1 SMP Debian 4.9.272-2 (2021-07-19) x86_64 Perl interpreter: /usr/bin/perl Perl version: 5.024001 MySQL version: mysql Ver 15.1 Distrib 10.4.19-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 Apache version: Server version: Apache/2.4.25 (Debian) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 19:45:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 17:45:42 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > Tomas, see the last 2 patches. > > It seems that matching the regex is not enough (last patch fixes a test). > > However there is still a test failing, root at localhost is considered valid > (FQDN no longer required). On it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 19:47:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 17:47:53 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #26 from Christopher Brannon --- Unexpectedly misspelling! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 21:09:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 19:09:31 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123693|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 124120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124120&action=edit Bug 25619: Add ability to adjust expiration date for waiting holds There are times when an item that is waiting for pickup needs to have the expiration date extended. This would give staff the ability to modify one by one, as needed, the reserves.expirationdate for a given item awaiting pickup. Test Plan: 1) Place a hold, trap an item for it such that is is waiting 2) Attempt to update the expiration date 3) Note the new date is not saved 4) Apply this patch, restart all the things! 5) Attempt to update the expiration date 6) The new date should be saved! Signed-off-by: Abbey Holt Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 21:09:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 19:09:36 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123694|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 124121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124121&action=edit Bug 25619: Unit Tests Signed-off-by: Abbey Holt Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 21:09:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 19:09:40 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123695|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 124122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124122&action=edit Bug 25619: (QA follow-up) Fix subtest description Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 21:09:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 19:09:45 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123779|0 |1 is obsolete| | --- Comment #26 from Nick Clemens --- Created attachment 124123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124123&action=edit Bug 25619: Adjust POD Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 21:09:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 19:09:51 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 --- Comment #27 from Nick Clemens --- Created attachment 124124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124124&action=edit Bug 25619: Adjust POD and move date check before logging Potentially we could have logged a change when no date was passed. This patch moves the test before logging and updates POD Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 23:15:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 21:15:40 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19294 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 23:15:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 21:15:40 +0000 Subject: [Koha-bugs] [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20985 | CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 26 23:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 21:17:06 +0000 Subject: [Koha-bugs] [Bug 28905] Make it possible to hide export column in table configuration in checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28905 --- Comment #2 from Katrin Fischer --- I could be sold on this :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 00:02:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 22:02:04 +0000 Subject: [Koha-bugs] [Bug 28908] New: Bug 18017 removed indexing field 245 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908 Bug ID: 28908 Summary: Bug 18017 removed indexing field 245 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Before bug 18017 there was in etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml : Title-uniform:w ... Indexing of 245, 445, ... is now missing. Is this on purpose ? Note that Title-uniform was used in authorities fields 230, 235 and 245. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 00:02:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 22:02:15 +0000 Subject: [Koha-bugs] [Bug 28908] Bug 18017 removed indexing field 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 00:02:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 22:02:15 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908 [Bug 28908] Bug 18017 removed indexing field 245 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 00:09:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 22:09:33 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120994|0 |1 is obsolete| | --- Comment #22 from Fridolin Somers --- Created attachment 124125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124125&action=edit Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 00:09:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 22:09:53 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119113|0 |1 is obsolete| | --- Comment #23 from Fridolin Somers --- Created attachment 124126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124126&action=edit Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 00:10:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 22:10:07 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119114|0 |1 is obsolete| | --- Comment #24 from Fridolin Somers --- Created attachment 124127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124127&action=edit Bug 26860: (follow-up) case requesting zebra with ccl query When calling a ccl syntax query, code must be added like for availability facet. See Bug 17278: Use available limit when requesting zebra when ccl query is used This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne 'available' } @limits". Following the logic of : Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Test plan : 1) Use Zebra search engine 2) Perform a search on staff interface with explicit index, for example 'ti:history' 3) This search must return some records with and some without items 4) Click on 'Limit to records without items' 5) Check you see only records without items 6) Click on 'Show all records' 7) Check you see all records again 8) Check availability facet is also working Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 01:19:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 23:19:43 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 01:19:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 23:19:47 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 --- Comment #2 from Henry Bolshaw --- Created attachment 124128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124128&action=edit Bug 28188: Accessibility: OPAC contrast ratio for text is insufficient This patch makes minor changes to the OPAC SCSS files to improve the contrast ratio for text on the OPAC, including the main navigation links and buttons. These issues were identified using the WebAIM WAVE accessibility browser extension, Chrome's Lighthouse tool, and Khan Academy's Tota11y bookmarklet (the results using the three tools were very similar). To Test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse Tool or WebAim's Wave Extension) to test the contrast ratio for text. 2. Confirm that the OPAC has contrast ratio issues affecting the main navigation links, the buttons, and the text of search results. 3. Apply the patch and rebuild the OPAC CSS: yarn build --view opac 4. Use the accessibility tool to confirm the contrast ratio issues have been fixed 5. Check that the OPAC still looks ok after the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 01:35:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 23:35:16 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #382 from David Cook --- I'm really glad to see Volume change to Item Group, because we've had a number of times when we've wanted to have Item Group holds where library staff could group together items. I haven't looked through the code in a long time. Is it just for holds or does it handle aspects of circulation too like checkouts? That's just a question and by no means a comment on the patches. Just curious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 01:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 23:45:10 +0000 Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 --- Comment #2 from David Cook --- (In reply to Jonathan Druart from comment #1) > Not affecting master? Steps to recreate? It'll probably be affecting master. It might affect other versions after 19.11, but I haven't gotten around to looking yet. I've just fixed it locally for 20.11. I'll have a think about drafting up some steps. I'll probably do something with injecting a HTML element above the navbar using Javascript. I wasn't supposed to be working on Koha yesterday, and today after I get through my emails I'm going to work on something else. But i'll make a note to come back to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 01:45:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 23:45:55 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #383 from Tomás Cohen Arazi --- (In reply to David Cook from comment #382) > I'm really glad to see Volume change to Item Group, because we've had a > number of times when we've wanted to have Item Group holds where library > staff could group together items. > > I haven't looked through the code in a long time. Is it just for holds or > does it handle aspects of circulation too like checkouts? That's just a > question and by no means a comment on the patches. Just curious. This code implements the groups. There's a separate bug that implements hold fulfillment by group items. That one will need some changes after the refactoring we made. It would be great if you could go QA this one so we can build the rest on top of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 01:56:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Aug 2021 23:56:30 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #48 from David Cook --- If I recall correctly, consideration of hold rules is a mess across the board. I keep thinking that we need to do something that covers them all otherwise all the changes will always just be Band-Aids. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 02:15:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 00:15:41 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #384 from David Cook --- (In reply to Tomás Cohen Arazi from comment #383) > This code implements the groups. There's a separate bug that implements hold > fulfillment by group items. That one will need some changes after the > refactoring we made. > > It would be great if you could go QA this one so we can build the rest on > top of this. With 33 patches, I think this might make it on the TODO list that I just feel guilty about and never action :(. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 02:40:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 00:40:49 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #385 from Tomás Cohen Arazi --- (In reply to David Cook from comment #384) > (In reply to Tomás Cohen Arazi from comment #383) > > This code implements the groups. There's a separate bug that implements hold > > fulfillment by group items. That one will need some changes after the > > refactoring we made. > > > > It would be great if you could go QA this one so we can build the rest on > > top of this. > > With 33 patches, I think this might make it on the TODO list that I just > feel guilty about and never action :(. If you apply them, and do a git diff, things are pretty clear and simple. I hesitated to squash everything because it wasn't my dev. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 04:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 02:51:23 +0000 Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and punctuation in XSLT display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 04:51:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 02:51:28 +0000 Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and punctuation in XSLT display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124060|0 |1 is obsolete| | --- Comment #16 from Hayley Pelham --- Created attachment 124129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124129&action=edit Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21) At the moment the punctuation entered for $n $p and is removed in the part template, which leads to displaying the subfields without any punctuation and spaces in between. To test: - Catalog records with various combinations of 8xx series added entry fields. Subfield a, t, n, p and v are the most important. - Verify the display in OPAC and staff is not great. - Apply the patch. - Verify the display in OPAC and staff is improved. For examples see: https://www.loc.gov/marc/bibliographic/bd80x83x.html Important note: At the moment 8xx series added entry fields will only display, when there is also a 490 ind. 1 = 1 field present. Signed-off-by: Hayley Pelham -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 05:34:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 03:34:24 +0000 Subject: [Koha-bugs] [Bug 28324] Pagination displays weirdly when there are more than 10 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28324 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham at catalyst.net.n | |z --- Comment #2 from Hayley Pelham --- I can confirm this is an annoying display issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:18:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:18:49 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #68 from Marcel de Rooy --- Will follow-up on this report after it has been signed off again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:36:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:36:05 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #8 from Jonathan Druart --- (In reply to Manos PETRIDIS from comment #7) > (In reply to Jonathan Druart from comment #5) > > What's your version of JSON::Validator? Are you using Debian 11? > > JSON::Validator (0.97) 0.97 On Debian 9 you should have JSON::Validator 3.14. Do you see the REST API doc if you hit /api/v1/.html? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:38:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:38:18 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:38:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:38:22 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123979|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 124130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124130&action=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:38:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:38:35 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:40:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:40:48 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:41:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:41:43 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > (In reply to Manos PETRIDIS from comment #7) > > (In reply to Jonathan Druart from comment #5) > > > What's your version of JSON::Validator? Are you using Debian 11? > > > > JSON::Validator (0.97) 0.97 > > On Debian 9 you should have JSON::Validator 3.14. Hum, forget that, I am not sure actually. I am getting that in a dev env (ktd/stretch), but that does not make sense. root at kohadevbox:koha(master|BISECTING)$ pmvers JSON::Validator 3.14 root at kohadevbox:koha(master|BISECTING)$ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 3.25+dfsg-1+koha3 Candidate: 3.25+dfsg-1+koha3 Version table: *** 3.25+dfsg-1+koha3 500 500 http://debian.koha-community.org/koha-staging dev/main amd64 Packages 100 /var/lib/dpkg/status 0.92+dfsg-1 500 500 http://httpredir.debian.org/debian stretch/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:47:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:47:56 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #10 from Marcel de Rooy --- + [% ELSIF ( QUEUED_MESSAGE.failure_code == "INVALID_EMAIL" ) %]Invalid email address found [% borrowernumber | html %] This is probably the most obvious reason, but actually we only know that Koha::Email->create crashed (or Email::Stuffer->new). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:49:23 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:49:27 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124000|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 124131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124131&action=edit Bug 28803: Add unit tests This patch updates Letters.t to confirm that invalid email addresses in the message_queue should not throw an exception when sending mail but instead set the status to failed and pass error details to the end user. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 08:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 06:49:31 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124001|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 124132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124132&action=edit Bug 28803: Add invalid email handling in _send_message_by_email This patch adds a try/catch block around the call to Koha::Email->create to catch and handle invalid emails being passed in the parameters. The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 09:12:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 07:12:26 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 09:12:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 07:12:34 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121922|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 124133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124133&action=edit Bug 28456: Add WHERE option to membership_expiry cronjob Some libraries have a large amount of accounts and want to be able to limit how many email reminders they send. Adding a where statement will allow for flexibility To test: 1 - Set some borrowers to expire soon 2 - Set MembershipExpiryDaysNotice to 10 3 - perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 4 - Note the patrons that yo uadjusted show up 5 - Limit by various patron fields, e.g. perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NOT NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname LIKE '%a%'" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname NOT LIKE '%a%'" 6 - Confirm expected results 7 - perl misc/cronjobs/membership_expiry.pl 8 - Confirm the help message makes sense Signed-off-by: Azucena Aguayo Signed-off-by: Marcel de Rooy [EDIT] Replace two inclue by include. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 09:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 07:14:12 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Note: There is no checking on the $where values. Passing invalid columns will crash the script etc. No blocker to me for this cron job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 09:18:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 07:18:43 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #45 from Marcel de Rooy --- Please look at comment43 too? Katrin could you elaborate on what exactly should be discussed here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 09:42:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 07:42:48 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Looks like it can be tested by adding in syspref IntranetUserJS : $(document).ready(function() { $.fn.select2.defaults.set("selectOnClose", "true" ); }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 09:59:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 07:59:22 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #49 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:07:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:07:34 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #46 from Jonathan Druart --- I don't think it is a discussion for 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:36:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:36:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123736|0 |1 is obsolete| | --- Comment #278 from Martin Renvoize --- Created attachment 124134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124134&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:36:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:36:44 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123737|0 |1 is obsolete| | --- Comment #279 from Martin Renvoize --- Created attachment 124135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124135&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:36:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:36:51 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123738|0 |1 is obsolete| | --- Comment #280 from Martin Renvoize --- Created attachment 124136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124136&action=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:36:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:36:59 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123739|0 |1 is obsolete| | --- Comment #281 from Martin Renvoize --- Created attachment 124137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124137&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:37:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:37:08 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123740|0 |1 is obsolete| | --- Comment #282 from Martin Renvoize --- Created attachment 124138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124138&action=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:37:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:37:16 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123741|0 |1 is obsolete| | --- Comment #283 from Martin Renvoize --- Created attachment 124139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124139&action=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:37:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:37:26 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123742|0 |1 is obsolete| | --- Comment #284 from Martin Renvoize --- Created attachment 124140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124140&action=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:37:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:37:39 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123743|0 |1 is obsolete| | --- Comment #285 from Martin Renvoize --- Created attachment 124141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124141&action=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:37:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:37:47 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123744|0 |1 is obsolete| | --- Comment #286 from Martin Renvoize --- Created attachment 124142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124142&action=edit Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:37:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:37:57 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123745|0 |1 is obsolete| | --- Comment #287 from Martin Renvoize --- Created attachment 124143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124143&action=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:38:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:38:11 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123746|0 |1 is obsolete| | --- Comment #288 from Martin Renvoize --- Created attachment 124144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124144&action=edit Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:38:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:38:19 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123747|0 |1 is obsolete| | --- Comment #289 from Martin Renvoize --- Created attachment 124145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124145&action=edit Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:38:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:38:27 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123748|0 |1 is obsolete| | --- Comment #290 from Martin Renvoize --- Created attachment 124146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124146&action=edit Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:38:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:38:34 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123749|0 |1 is obsolete| | --- Comment #291 from Martin Renvoize --- Created attachment 124147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124147&action=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:38:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:38:41 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123750|0 |1 is obsolete| | --- Comment #292 from Martin Renvoize --- Created attachment 124148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124148&action=edit Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:38:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:38:48 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123751|0 |1 is obsolete| | --- Comment #293 from Martin Renvoize --- Created attachment 124149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124149&action=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:38:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:38:55 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123752|0 |1 is obsolete| | --- Comment #294 from Martin Renvoize --- Created attachment 124150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124150&action=edit Bug 11175: (QA follow-up) Move get_component_part_query This patch removes Koha::Util::Search in preference to embedding the search query builder in Koha::Biblio as get_analytics_query. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:39:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:39:03 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123753|0 |1 is obsolete| | --- Comment #295 from Martin Renvoize --- Created attachment 124151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124151&action=edit Bug 11175: (QA follow-up) Only get biblio once Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:39:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:39:12 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123754|0 |1 is obsolete| | --- Comment #296 from Martin Renvoize --- Created attachment 124152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124152&action=edit Bug 11175: (QA follow-up) Fix queries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:39:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:39:21 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123755|0 |1 is obsolete| | --- Comment #297 from Martin Renvoize --- Created attachment 124153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124153&action=edit Bug 11175: Display components in own tab This patch updates the display so that rather than displaying the components using the main XSLT and then using CSS to move them into a box on the right side for display, which causes issues with RTL records; We instead add them in a new tab beneath the rest of the record details alongside holdings and other details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:39:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:39:31 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123756|0 |1 is obsolete| | --- Comment #298 from Martin Renvoize --- Created attachment 124154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124154&action=edit Bug 11175: (QA follow-up) Rename back to get_marc_components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:39:40 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #299 from Martin Renvoize --- Created attachment 124155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124155&action=edit Bug 11175: (QA follow-up) Fixes for bug 12561 Bug 12561 changed the prototype for XSLTParse4Display so this patcha accounts for the additional calls to that method introduced in this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:42:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:42:48 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #300 from Martin Renvoize --- Rebased on master :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:54:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:54:19 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart --- - # FIXME must be 'failed' - is( $message_1->{status}, 'pending', 'Invalid KohaAdminEmailAddress => status pending' ); + is( $message_1->{status}, 'failed', 'Invalid KohaAdminEmailAddress => status failed' ); That's very pleasant to read :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 10:59:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 08:59:22 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #14 from Martin Renvoize --- (In reply to Jonathan Druart from comment #13) > - # FIXME must be 'failed' > - is( $message_1->{status}, 'pending', 'Invalid KohaAdminEmailAddress => > status pending' ); > + is( $message_1->{status}, 'failed', 'Invalid KohaAdminEmailAddress => > status failed' ); > > That's very pleasant to read :) Haha, it made me smile too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:01:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:01:13 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #15 from Jonathan Druart --- This is tight to bug 28870. I think we should push both altogether. However there is one thing that seems wrong to me: + my $email = try { + Koha::Email->create( [SKIP] + } + catch { + _set_message_status( + { + message_id => $message->{'message_id'}, + status => 'failed', + failure_code => 'INVALID_EMAIL' + } + ); + return 0; + }; Koha::Email->create is raising different exception, and Email::Stuffer certainly raised its own. Shouldn't we actually base this on top of bug 28870 and simply call (the newly added) Koha::Email->is_valid to check if the email if valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:03:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:03:29 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #50 from Marcel de Rooy --- (In reply to Lari Taskula from comment #48) > Rebased You removed the signoff lines of Michal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:04:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:04:17 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:04:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:04:23 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120844|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy --- Created attachment 124156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124156&action=edit Bug 20028: Add Koha::Patron->export The logic behind gathering related data relies on DBIx relationships to Borrower source. This patch does not care about object name terminology - it returns related data in a hashref containing keys of DBIx source class names, such as Borrower. Return example: { "Borrower" => Koha::Patron, "BorrowerMessagePreference" => DBIx::Class::ResultSet, "ReturnClaim" => Koha::Checkouts::ReturnClaims } This has the benefit of giving caller the ability to format response as they want. For example, you can then easily use the "unblessed" or "to_api" representation of the object. To test: 1. prove t/db_dependent/Koha/Patron.t 2. Observe success Sponsored-by: The National Library of Finland Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:04:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:04:31 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120845|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy --- Created attachment 124157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124157&action=edit Bug 20028: Add a system preference for patron data export Add a system preference to determine whether patron data export is permitted. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:04:37 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120846|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy --- Created attachment 124158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124158&action=edit Bug 20028: Add OpenAPI spec Includes a test that validates the existence of all related properties. To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:04:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:04:42 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120847|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy --- Created attachment 124159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124159&action=edit Bug 20028: Add Patron Export REST controller This patch adds a REST controller for patron data exporting. GET /api/v1/patrons/51/export GET /api/v1/public/patrons/51/export Supports pagination parameters "_per_page" and "_page". Response is an array that contains "_per_page" amount of objects, each with the following format: { "data": {the object, e.g. patron} "type": DBIx source name, e.g. "Borrower" } Example response: [ { "data":{ "address":null, ..., "patron_id":1, ... }, "type":"Borrower" }, { "data":{ "borrower_message_preference_id":24, "borrowernumber":1, ..., "wants_digest":1 }, "type":"BorrowerMessagePreference" }, { "data":{ "auto_renew":false, ..., "checkout_id":97, "due_date":"2021-02-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"Issue" }, { "data":{ "auto_renew":false, ..., "checkout_id":42, "due_date":"2021-01-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"OldIssue" } ] To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:04:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:04:47 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #55 from Marcel de Rooy --- Created attachment 124160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124160&action=edit Bug 20028: (QA follow-up) Fix test plan for Patron.t t/db_dependent/Koha/Patron.t .. 8/8 # Looks like you planned 8 tests but ran 9. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:04:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:04:52 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #56 from Marcel de Rooy --- Created attachment 124161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124161&action=edit Bug 20028: (QA follow-up) Add atomic update for new pref Setting the initial value to 0 just to be on the safe side. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:05:41 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28854 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:05:41 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24857 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:06:24 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #57 from Marcel de Rooy --- Lari raised various questions on this bug, but did not receive (many) answers. I do like what he wrote and I think it would be a good starting point to refine. Since it is controlled by a pref, I would not see much harm in pushing this first step and refining later. > Should we first implement something that simply returns all the data related to a patron, and if someone wants to focus on formatting it nicely, then solve that issue in another Bug? I would agree with that direction. > Another issue is how far do we want to expand the results? Hmm. This will open up a lot of trouble? Since there are so many relations, we would imo need some mechanism to do so instead of ad-hoc stuff. > The current patches completely ignore any REST API terminology guidelines we use. [...] This will become a terminology hell. Sure. Your approach is understandable. And you are using to_api now. > We also need pagination, but paginating the currently proposed model would be weird. How would one paginate such response? Should we instead return an array of objects with the same structure ... You added basic pagination with "_per_page" and "_page". Hard to say what would be the best pagination approach here ;) > I will ask these questions on koha-devel mailing list. I may have missed that one. I have searched in the archive, but could not find anything. Passing QA to stir up the discussion ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:08:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:08:41 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 --- Comment #7 from pierre.genty at biblibre.com --- Fridolin, I added this code in IntranetUserJS but it changes nothing for me (still have to click on the menu or hit Enter). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:17:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:17:38 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:18:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:18:11 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- Base does not apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:44:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:44:35 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #58 from Lari Taskula --- (In reply to Marcel de Rooy from comment #50) > You removed the signoff lines of Michal? Good spot, I'm pretty sure this happened by accident. I probably didn't pull Michal's signed-off patches before rebasing. Shall I add it back? Also I agree with setting syspref default to 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:54:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:54:25 +0000 Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:54:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:54:30 +0000 Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123152|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 124162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124162&action=edit Bug 28744: Regression tests This patch adds tests for the following cases: - to_api_mapping not defined - to_api_mapping returning an empty hashref To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail :-( Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:54:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:54:35 +0000 Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123153|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 124163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124163&action=edit Bug 28744: Better handling of undefined to_api_mapping We always had some mapping because of the DB vs. API object definition discrepancies. But bug 25260 revamps the reserves table, and it is a perfect match. It highlights this edge case: if no mapping defined, then and undef from_api_mapping is generated (as opposed to an empty hashref) and this leads to errors in the query translation from the API. This patch makes a small change so this method always returns an empty hashref. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Test fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:54:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:54:45 +0000 Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 11:57:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 09:57:04 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #59 from Marcel de Rooy --- (In reply to Lari Taskula from comment #58) > Good spot, I'm pretty sure this happened by accident. I probably didn't pull > Michal's signed-off patches before rebasing. Shall I add it back? If you do not remove mine :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:00:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:00:02 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124156|0 |1 is obsolete| | --- Comment #60 from Lari Taskula --- Created attachment 124164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124164&action=edit Bug 20028: Add Koha::Patron->export The logic behind gathering related data relies on DBIx relationships to Borrower source. This patch does not care about object name terminology - it returns related data in a hashref containing keys of DBIx source class names, such as Borrower. Return example: { "Borrower" => Koha::Patron, "BorrowerMessagePreference" => DBIx::Class::ResultSet, "ReturnClaim" => Koha::Checkouts::ReturnClaims } This has the benefit of giving caller the ability to format response as they want. For example, you can then easily use the "unblessed" or "to_api" representation of the object. To test: 1. prove t/db_dependent/Koha/Patron.t 2. Observe success Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:00:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:00:22 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124157|0 |1 is obsolete| | --- Comment #61 from Lari Taskula --- Created attachment 124165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124165&action=edit Bug 20028: Add a system preference for patron data export Add a system preference to determine whether patron data export is permitted. Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:00:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:00:47 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124159|0 |1 is obsolete| | --- Comment #62 from Lari Taskula --- Created attachment 124166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124166&action=edit Bug 20028: Add Patron Export REST controller This patch adds a REST controller for patron data exporting. GET /api/v1/patrons/51/export GET /api/v1/public/patrons/51/export Supports pagination parameters "_per_page" and "_page". Response is an array that contains "_per_page" amount of objects, each with the following format: { "data": {the object, e.g. patron} "type": DBIx source name, e.g. "Borrower" } Example response: [ { "data":{ "address":null, ..., "patron_id":1, ... }, "type":"Borrower" }, { "data":{ "borrower_message_preference_id":24, "borrowernumber":1, ..., "wants_digest":1 }, "type":"BorrowerMessagePreference" }, { "data":{ "auto_renew":false, ..., "checkout_id":97, "due_date":"2021-02-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"Issue" }, { "data":{ "auto_renew":false, ..., "checkout_id":42, "due_date":"2021-01-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"OldIssue" } ] To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:00:53 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124160|0 |1 is obsolete| | --- Comment #63 from Lari Taskula --- Created attachment 124167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124167&action=edit Bug 20028: (QA follow-up) Fix test plan for Patron.t t/db_dependent/Koha/Patron.t .. 8/8 # Looks like you planned 8 tests but ran 9. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:01:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:01:01 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124161|0 |1 is obsolete| | --- Comment #64 from Lari Taskula --- Created attachment 124168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124168&action=edit Bug 20028: (QA follow-up) Add atomic update for new pref Setting the initial value to 0 just to be on the safe side. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:23:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:23:50 +0000 Subject: [Koha-bugs] [Bug 27684] serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:23:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:23:54 +0000 Subject: [Koha-bugs] [Bug 27684] serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 --- Comment #2 from Didier Gautheron --- Created attachment 124169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124169&action=edit Bug 27684: Serial 0 is valid default value. To test: 1- Create a NOT_LOAN VA: code = 0 lib = available 2- Add a serial with one item 3- Check that in items modification 952$7 is on 'available' 4- Receive this serial. 5- Add item 6- check that not for loan is empty 6- Apply patch 7- redo 4,5 8- check that not for loan is on 'available' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:42:01 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:42:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:42:05 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 --- Comment #8 from Owen Leonard --- Created attachment 124170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124170&action=edit Bug 28903: Tab key and drop-down menu in item module This patch changes the default configuration of Select2 menus so that the tab key can be used to choose an option which has been highlighted using arrow keys. To reproduce the behavior this fixes, open a page with Select2 menus, e.g. additem.pl: 1. Tab to a Select2 field (withdrawn, lost, damaged, etc.) 2. Hit ENTER. 3. Use arrow key to highlight option. 4. Hit TAB -> Option is NOT selected. 5. Hit tab key -> Focus moves to next input. Apply the patch and test again. At step 4 the tab key should work to select the option you've highlighted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:42:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:42:21 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Version|20.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:44:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:44:18 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:44:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:44:22 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121199|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 124171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124171&action=edit Bug 26326: Add Koha Objects for Import Records and Import Record Matches To test: 1 - Apply patches 2 - Update database 3 - Generate schema files (dbic) 4 - prove -v t/db_dependent/Koha/Import/Records.t 5 - prove -v t/db_dependent/Koha/Import/Record/Matches.t Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:44:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:44:25 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121200|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 124172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124172&action=edit Bug 26326: (follow-up) Add ability to check for existence of any primary key Before dropping a primary key we need to see if one exists - this updates the installer method to allow searching for existence of key Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:44:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:44:30 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121201|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 124173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124173&action=edit Bug 26326: DO NOT PUSH Schema changes Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:51:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:51:44 +0000 Subject: [Koha-bugs] [Bug 28909] New: Allow Interlibrary Loans illview method to use backend template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Bug ID: 28909 Summary: Allow Interlibrary Loans illview method to use backend template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com A number of the various "stages" of an ILL request allow the request's backend to add additional template to be displayed. It would be useful for the "illview" stage to be able to do this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 12:52:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 10:52:02 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 13:01:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 11:01:21 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #1 from Andrew Isherwood --- Created attachment 124174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124174&action=edit Bug 28909: Allow illview to use backend template This commit allows illview to use an intranet template supplied by the backend, as per other stages. The template must be named illview.inc Test plan: - Apply the patch - Install FreeForm backend (https://github.com/PTFS-Europe/koha-ill-freeform) - Create a request - On the resulting "Manage ILL request" note the display is normal - Create a new file in the FreeForm backend directory: /intra-includes/illview.inc with the following content: [% BLOCK backend_jsinclude %] [% END %] - Restart Plack if enabled - Reload the page => TEST: Observe that the alert specified in the template is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 13:01:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 11:01:55 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 13:07:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 11:07:16 +0000 Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master --- Comment #3 from Owen Leonard --- This can be reproduced in master by adding this to OPACUserJS: $(document).ready(function(){ $("#wrapper").prepend(''); }); - Search the catalog - Scroll down the page to a later search result - Click the "Add to cart" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 13:26:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 11:26:42 +0000 Subject: [Koha-bugs] [Bug 28910] New: Correct eslint errors in OPAC basket.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Bug ID: 28910 Summary: Correct eslint errors in OPAC basket.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 23833 Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in the OPAC's copy of basket.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 13:26:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 11:26:42 +0000 Subject: [Koha-bugs] [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 [Bug 28910] Correct eslint errors in OPAC basket.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 13:37:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 11:37:42 +0000 Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 [Bug 28910] Correct eslint errors in OPAC basket.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 13:37:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 11:37:42 +0000 Subject: [Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 [Bug 28901] showCart incorrectly calculates position if content above navbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:24:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:24:01 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:24:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:24:05 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124116|0 |1 is obsolete| | --- Comment #11 from George Veranis --- Created attachment 124175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124175&action=edit Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' Signed-off-by: George Veranis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:32:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:32:35 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #194 from Jonathan Druart --- About the new FK added to the linktracker table, is it relevant to keep the entry if the biblio has been deleted? + CONSTRAINT `linktracker_biblio_ibfk` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE SET NULL ON UPDATE SET NULL, (not blocker but please answer) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:37:07 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #195 from Jonathan Druart --- Created attachment 124176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124176&action=edit Bug 22690: Remove uneeded return and add no_triggers * C4/Items.pm - Koha::Biblios not used * Koha/Item.pm - Koha::Item->orders must return an empty set if no order attached - no_triggers should be passed to other update calls * Item.t - No need to build a fund - Add new test to test Koha::Item->orders when no order attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:49:47 +0000 Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:49:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:49:52 +0000 Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 --- Comment #4 from Nick Clemens --- Created attachment 124177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124177&action=edit Bug 16446: Add ability to add patrons to list by borrowernumber AddPatronsToList already took a borrowernumber parameter, however, it did not check if those were valid numbers. This patch expands the search to apply to cardnumber or borrowernumbers in the subroutine. Template and script are adjusted to allow choosing borrowernumbers or cardnumbers To test: 1 - Apply patch 2 - Browse to Tools->Patron lists 3 - Create a list, or choose Actions->Add patrons for an existing list 4 - Click 'Add multiple patrons' 5 - Cardnumbers is preselected 6 - Enter a list of cardnumbers, ensure you test: Cardnumber already in list Cardnumber not in list Non-existent cardnumber 7 - Patrons should be added/errors reported correctly 8 - Repeat with borowernumbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:50:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:50:13 +0000 Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:55:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:55:23 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Jonathan Druart --- Wow, no! This is not as trivial as it looks like. We must force scalar context actually. I am expecting lot of side-effects with this change. Try with: use Koha::Items; my $item = Koha::Items->find(1); my $h1 = { holds => $item->holds, something => 'else' }; use Data::Printer colored => 1; warn p $h1 Add 1 hold => holds is a Koha::Hold when we expect a set Add another hold Outch, you get: { holds => Koha::Hold, Koha::Hold=Hash => "something", else => undef } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 14:58:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 12:58:13 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #15) > Wow, no! This is not as trivial as it looks like. > > We must force scalar context actually. I am expecting lot of side-effects > with this change. I get that, but isn't it the case already? We already force scalar context when passing things to the templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:04:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:04:33 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124117|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi --- Created attachment 124178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124178&action=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:04:39 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124118|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi --- Created attachment 124179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124179&action=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:04:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:04:45 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124119|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi --- Created attachment 124180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124180&action=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:05:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:05:02 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #17 from Jonathan Druart --- I don't know, did you check the hundreds occurrences we have in the code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:05:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:05:14 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:13:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:13:57 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #18 from Jonathan Druart --- Created attachment 124181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124181&action=edit Bug 28883: Fix wrong list context calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:14:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:14:08 +0000 Subject: [Koha-bugs] [Bug 23792] Send borrowernumbers from report to batch modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:14:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:14:15 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #19 from Tomás Cohen Arazi --- I get it, but consistency will always be a good thing! Right now we need: $template->param( outstanding_debits => scalar $patron->account->outstanding_debits, items => $biblio->items, ); Because we are not consistent (i.e. outstanding_debits does a return $smth->search) I'd prefer $template->param( outstanding_debits => scalar $patron->account->outstanding_debits, items => scalar $biblio->items, ); The motivation for this bug was to find consensus on a predictable way of coding to lower amount of bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:20:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:20:19 +0000 Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:20:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:20:22 +0000 Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124177|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 124182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124182&action=edit Bug 16446: Add ability to add patrons to list by borrowernumber AddPatronsToList already took a borrowernumber parameter, however, it did not check if those were valid numbers. This patch expands the search to apply to cardnumber or borrowernumbers in the subroutine. Template and script are adjusted to allow choosing borrowernumbers or cardnumbers To test: 1 - Apply patch 2 - Browse to Tools->Patron lists 3 - Create a list, or choose Actions->Add patrons for an existing list 4 - Click 'Add multiple patrons' 5 - Cardnumbers is preselected 6 - Enter a list of cardnumbers, ensure you test: Cardnumber already in list Cardnumber not in list Non-existent cardnumber 7 - Patrons should be added/errors reported correctly 8 - Repeat with borowernumbers Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:22:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:22:37 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Jonathan Druart --- I have found only one problematic occurrence but I'd like another QA stamp with that in mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:25:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:25:27 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #21 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #19) > $template->param( > outstanding_debits => scalar $patron->account->outstanding_debits, > items => scalar $biblio->items, > ); I'd personally prefer to not have to forget the "scalar" (and almost always use iterator) and explicitly ask for the list when I need it (->as_list). Not blocking, just expressing my opinion :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:27:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:27:09 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #22 from Jonathan Druart --- If we need consistency, then should we adjust all the other methods? Koha::UploadedFiles->getCategories? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:30:45 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #22 from Jonathan Druart --- Ulrich, can we get your signoff on those patches please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:36:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:36:42 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:36:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:36:45 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #196 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:36:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:36:49 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:36:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:36:52 +0000 Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 --- Comment #28 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:36:56 +0000 Subject: [Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:36:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:36:58 +0000 Subject: [Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #17 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:37:01 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:37:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:37:04 +0000 Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:39:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:39:22 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28870 Status|Passed QA |Failed QA --- Comment #16 from Jonathan Druart --- IMO we should base this on top of bug 28870 and provide a separate simple patch for backporting. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:39:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:39:22 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:42:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:42:33 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124178|0 |1 is obsolete| | Attachment #124179|0 |1 is obsolete| | Attachment #124180|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 124183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124183&action=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:42:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:42:37 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #24 from Jonathan Druart --- Created attachment 124184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124184&action=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:42:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:42:42 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #25 from Jonathan Druart --- Created attachment 124185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124185&action=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:52:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:52:38 +0000 Subject: [Koha-bugs] [Bug 28911] New: Bcrypt settings are required for pseudonymization but are not set on upgrade Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Bug ID: 28911 Summary: Bcrypt settings are required for pseudonymization but are not set on upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 24151 added a way to pseudonymize patron transactions. It added a new config to koha-conf This is added for new installs, but not for upgraded sites, and there are no instructions on the syspref or elsewhere for adding To recreate: 1 - Spin up a 20.05 (checkout 20.05.x and reset_all in kohadevbox) 2 - Upgrade to master (checkout master, updatedatabase) 3 - Enable pseudonymization 4 - Attempt a checkout 5 - boom you can manually add the settings by running the command below: htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' And pasting the results into in the config -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:52:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:52:50 +0000 Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:52:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:52:50 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 15:53:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 13:53:35 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #17 from Jonathan Druart --- The easy way here is actually to keep the existent patches and replace "INVALID_EMAIL" by "UNKNOWN_ERROR", and we follow-up on a separate bug reports with the different exceptions/errors possible. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 16:01:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 14:01:41 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #18 from Martin Renvoize --- (In reply to Jonathan Druart from comment #17) > The easy way here is actually to keep the existent patches and replace > "INVALID_EMAIL" by "UNKNOWN_ERROR", and we follow-up on a separate bug > reports with the different exceptions/errors possible. > > What do you think? Seems reasonable to me.. I think.. Must admit though, my brain has moved on a bit since I wrote this.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 16:05:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 14:05:42 +0000 Subject: [Koha-bugs] [Bug 28912] New: Pseudonymization should display a nice error message when brcypt_settings are not defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Bug ID: 28912 Summary: Pseudonymization should display a nice error message when brcypt_settings are not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently we cause an ISE when bcrypt_settings are missing We should throw/catch an exception and display a nicer error message To recreate: 1 - edit koha-conf, remove 'bcrypt_settings' 2 - Enable pseudonymization 3 - Attempt a checkout 4 - Boom! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 16:05:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 14:05:54 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28911 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 16:05:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 14:05:54 +0000 Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28912 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:00:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:00:34 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:00:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:00:38 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 --- Comment #1 from Jonathan Druart --- Created attachment 124186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124186&action=edit Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set If Pseudonymization is set but the bcrypt_settings config used by the feature is not set, then there is an ugly 500 on checking out. bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 116. However it's pretty hard to handle correctly this exception (and that's why it hasn't be done initially). However we could prevent the pref to be turned on if the config entry is not present. Test plan: Remove the bcrypt_settings from the config Try to turn the syspref on Add the config Try to turn the syspref on/off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:00:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:00:42 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 --- Comment #2 from Jonathan Druart --- Created attachment 124187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124187&action=edit Bug 28912: Remove duplicated warnings on the about page Bad conflict resolution -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:00:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:00:56 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Depends on| |24151 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:00:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:00:56 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:07:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:07:44 +0000 Subject: [Koha-bugs] [Bug 12998] Option to exclude withdrawn items when exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12998 --- Comment #2 from JaTara Barnes --- Still not resolved in 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:07:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:07:49 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #197 from Jonathan Druart --- Created attachment 124188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124188&action=edit Bug 22690: Add koha_object[s]_class to fix TestBuilder.t 'Can't locate object method "_new_from_dbic" via package "Koha::Linktracker" (perhaps you forgot to load "Koha::Linktracker"?) at /kohadevbox/koha/Koha/Object.pm line 334. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:08:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:08:20 +0000 Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30 at gmail.com --- Comment #4 from JaTara Barnes --- Still valid in 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:08:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:08:46 +0000 Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 --- Comment #5 from JaTara Barnes --- Still valid in 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:09:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:09:00 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #198 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:13:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:13:39 +0000 Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, mtj at kohaaloha.com --- Comment #1 from Jonathan Druart --- Mason, is it something we could do? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:28:12 +0000 Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124163|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 124189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124189&action=edit Bug 28744: Better handling of undefined to_api_mapping We always had some mapping because of the DB vs. API object definition discrepancies. But bug 25260 revamps the reserves table, and it is a perfect match. It highlights this edge case: if no mapping defined, then and undef from_api_mapping is generated (as opposed to an empty hashref) and this leads to errors in the query translation from the API. This patch makes a small change so this method always returns an empty hashref. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Test fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy JD amended patch: remove uneeded commented lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:29:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:29:21 +0000 Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124162|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 124190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124190&action=edit Bug 28744: Regression tests This patch adds tests for the following cases: - to_api_mapping not defined - to_api_mapping returning an empty hashref To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail :-( Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy JD amended patch: remove uneeded commented lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 17:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 15:35:01 +0000 Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:04:39 +0000 Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:06:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:06:35 +0000 Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:06:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:06:43 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:12:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:12:58 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:13:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:13:02 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124186|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 124191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124191&action=edit Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set If Pseudonymization is set but the bcrypt_settings config used by the feature is not set, then there is an ugly 500 on checking out. bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 116. However it's pretty hard to handle correctly this exception (and that's why it hasn't be done initially). However we could prevent the pref to be turned on if the config entry is not present. Test plan: Remove the bcrypt_settings from the config Try to turn the syspref on Add the config Try to turn the syspref on/off Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:13:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:13:05 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124187|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 124192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124192&action=edit Bug 28912: Remove duplicated warnings on the about page Bad conflict resolution Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:16:27 +0000 Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:16:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:16:32 +0000 Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 --- Comment #6 from Owen Leonard --- Created attachment 124193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124193&action=edit Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:20:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:20:18 +0000 Subject: [Koha-bugs] [Bug 28913] New: Automatic checkin setting in item type setup should note required cronjob Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Bug ID: 28913 Summary: Automatic checkin setting in item type setup should note required cronjob Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: andrew at bywatersolutions.com Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: bwsdonna at gmail.com, gmcharlt at gmail.com, kelly at bywatersolutions.com, sbrown at bywatersolutions.com Depends on: 23207 The automatic checkin feature introduced in bug 23207 requires a cron job. We should note that in item type setup so users don't expect the feature to start working simply because they checked the box. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 [Bug 23207] Allow automatic checkin/return at end of circulation period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:20:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:20:18 +0000 Subject: [Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 [Bug 28913] Automatic checkin setting in item type setup should note required cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:29:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:29:36 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 18:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 16:29:40 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 124194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124194&action=edit Bug 28913: Note cronjob on automatic return settings in itemtypes To test: 1 - go to itemtype config in Admin 2 - confirm it doesn't mention the automatic_return cron 3 - apply patch and restart 4 - confirm note now says "This feature requires the misc/cronjobs/automatic_checkin.pl cronjob. Ask your system administrator to schedule it." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 19:27:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 17:27:59 +0000 Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:15:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:15:59 +0000 Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrew at bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry --- I got a couple of small merge errors here. I managed to apply the patches, but something in pendingreseves is still mad. I get this error when I try to go to Holds to Pull as part of your Test plan for amendment to circ/pendingreserves.pl: Could not compile /kohadevbox/koha/circ/pendingreserves.pl: Global symbol "$admin_email_address" requires explicit package name (did you forget to declare "my $admin_email_address"?) at /kohadevbox/koha/circ/pendingreserves.pl line 95. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/circ/pendingreserves.pl line 315. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:25:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:25:31 +0000 Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #12 from Andrew Fuerste-Henry --- Also running into issues with auto-renew notices, probably due to changes made in bug 18532. That added messaging preferences for auto-renew notices. Might that mean we should remove them from this bug? Since now patrons/libraries are more explicitly choosing how they want auto-renews sent? With the patch applied right now, I have FallbackToSMSIfNoEmail turned off, my patron has an SMS number but no email address, and their messaging prefs say to send auto-renew as an email only. When I run the cron, my patron gets an SMS. So that's not right. For what it's worth, the acq and membership expiry notices worked as described. I didn't test the list share. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:36:14 +0000 Subject: [Koha-bugs] [Bug 28914] New: Wording in authentication forms is confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Bug ID: 28914 Summary: Wording in authentication forms is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl semicolon are missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:44:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:44:56 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:45:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:45:00 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #1 from Fridolin Somers --- Created attachment 124196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124196&action=edit Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:51:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:51:36 +0000 Subject: [Koha-bugs] [Bug 28915] New: MARC Modification Templates should allow specification of a position or range within a control field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Bug ID: 28915 Summary: MARC Modification Templates should allow specification of a position or range within a control field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When dealing with the MARC Leader, 008, and other fixed length control fields, it would be nice to be able to make the modification templates look at, match on, and alter only a specific position or range. For example, suppose I have several records in which I want to change the 008 position 33 (Literary form) from a 0 to a 1 (nonfiction to fiction). Currently I could tell my modification template to update the 008 of every record I point it at where the character in position 33 is a 0 (using regex to match only that specific character). But then there's no way to change ONLY that character and preserve the rest of the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:54:11 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin Somers --- Bug 21958 as impacted C4::Heading::MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:54:22 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:54:22 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26852 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:56:13 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 Note that 20.11 does not contain Bug 21958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:57:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:57:15 +0000 Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 20:59:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 18:59:31 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:00:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:00:11 +0000 Subject: [Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:02:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:02:47 +0000 Subject: [Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:09:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:09:04 +0000 Subject: [Koha-bugs] [Bug 28861] Item type column always hidden in holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:10:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:10:26 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:29:45 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23971, 26205, 14233 CC| |fridolin.somers at biblibre.co | |m --- Comment #24 from Fridolin Somers --- Those preferences are recent : AcquisitionLog Bug 23971 NewsLogBug Bug 26205 NoticesLog Bug 14233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 [Bug 14233] Add logging support to notices and slips management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 [Bug 26205] News changes aren't logged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:29:45 +0000 Subject: [Koha-bugs] [Bug 14233] Add logging support to notices and slips management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:29:45 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:29:45 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 21:30:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 19:30:09 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #25 from Fridolin Somers --- None are in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 22:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 20:54:21 +0000 Subject: [Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 --- Comment #12 from Fridolin Somers --- Is this a duplicate of Bug 28554 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 22:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 20:54:31 +0000 Subject: [Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 22:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 20:54:31 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:00:08 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:00:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:00:12 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85920|0 |1 is obsolete| | --- Comment #24 from Alexis Ripetti --- Created attachment 124197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124197&action=edit Bug 19336: Add --maxfinesday option to fines.pl This is a functionality we have for some of our clients we want to push to the community. Adds the --maxfinesday argument to fines.pl which creates or updates a fine with the maximum amount set in the circulation rules after the delay has passed. e.g.: ./fines.pl --maxfinesdays 30 All item over 30 days late will have the maximal fine applied. Here is a test plan I followed based on above. Test plan: 1. Create circulation rule with Overdue fines cap set 2. Set finesMode systempreference to 'Calculate and charge' 3. Check out an item with the due date set 30 days ago 4. In Koha shell run ./fines.pl --maxfinesdays 30 5. There should now be a new fine in the accountlines table of the amount set in overdue fines cap Followed test plan, patch worked as intended -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:00:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:00:16 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85921|0 |1 is obsolete| | --- Comment #25 from Alexis Ripetti --- Created attachment 124198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124198&action=edit Bug 19336: (follow-up) Correct DateTime and Koha calls This fixes the 'DateTime does not overload' error. It also fixes the next error, which was that C4::GetIssuingRules is deprecated. Finally it now handles no overduefinescap being define (does nothing). Passes QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:00:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:00:20 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85922|0 |1 is obsolete| | --- Comment #26 from Alexis Ripetti --- Created attachment 124199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124199&action=edit Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:00:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:00:25 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #27 from Alexis Ripetti --- Created attachment 124200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124200&action=edit Bug 19336: (follow-up) Initialize $unitcount instead of $unitcounttotal after changes on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:00:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:00:29 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #28 from Alexis Ripetti --- Created attachment 124201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124201&action=edit Bug 19336: (QA follow-up) Using CirculationRules instead of IssuingRules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:01:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:01:21 +0000 Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not defined for key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:01:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:01:21 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228 [Bug 28228] Warns from plugins when metadata value not defined for key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:05:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:05:14 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexis.ripetti at inLibro.com Attachment #85923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:52:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:52:34 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 --- Comment #9 from Fridolin Somers --- (In reply to pierre.genty from comment #7) > Fridolin, I added this code in IntranetUserJS but it changes nothing for me > (still have to click on the menu or hit Enter). Are you OK with test plan ? For me it is the wanted behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 27 23:55:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 21:55:33 +0000 Subject: [Koha-bugs] [Bug 28902] Grey color should be on label for record metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 00:10:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Aug 2021 22:10:05 +0000 Subject: [Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 --- Comment #13 from Martin Renvoize --- (In reply to Fridolin Somers from comment #12) > Is this a duplicate of Bug 28554 ? Looks like it could be.. it's been a while since I wrote this patch though so would need to investigate a little deeper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 02:57:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 00:57:45 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #4 from Victor Grousset/tuxayo --- ES8 is coming. So is ES6 actual EOL. Is turns out the EOL ES page is wrong. As 6.8.x still gets updates. But the 1st ES8 alpha has been published [2]. So we should expect ES6 to EOL in around 6 months [3]. https://github.com/elastic/elasticsearch/tags https://discuss.elastic.co/t/elasticsearch-8-release-date/202759/2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 08:39:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 06:39:15 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #10 from Manos PETRIDIS --- Created attachment 124202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124202&action=edit kept back packages (image 1/6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 08:39:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 06:39:52 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #11 from Manos PETRIDIS --- Created attachment 124203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124203&action=edit kept back packages (image 2/6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 08:40:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 06:40:16 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #12 from Manos PETRIDIS --- Created attachment 124204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124204&action=edit kept back packages (image 3/6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 08:40:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 06:40:41 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #13 from Manos PETRIDIS --- Created attachment 124205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124205&action=edit kept back packages (image 4/6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 08:41:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 06:41:12 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #14 from Manos PETRIDIS --- Created attachment 124206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124206&action=edit kept back packages (image 5/6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 08:41:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 06:41:38 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #15 from Manos PETRIDIS --- Created attachment 124207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124207&action=edit kept back packages (image 6/6) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 08:49:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 06:49:25 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #16 from Manos PETRIDIS --- I wonder why version 0.97-1~kohadev1 was installed, and prefered over the current version. Upgrades were performed in command-line (apt-get upgrade) up till now. Upgrade via GUI fixed things and library list appears populated again. Thank you all for your help! MP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 11:33:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 09:33:15 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 13:51:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 11:51:01 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 13:51:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 11:51:05 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124128|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 124208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124208&action=edit Bug 28188: Accessibility: OPAC contrast ratio for text is insufficient This patch makes minor changes to the OPAC SCSS files to improve the contrast ratio for text on the OPAC, including the main navigation links and buttons. These issues were identified using the WebAIM WAVE accessibility browser extension, Chrome's Lighthouse tool, and Khan Academy's Tota11y bookmarklet (the results using the three tools were very similar). To Test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse Tool or WebAim's Wave Extension) to test the contrast ratio for text. 2. Confirm that the OPAC has contrast ratio issues affecting the main navigation links, the buttons, and the text of search results. 3. Apply the patch and rebuild the OPAC CSS: yarn build --view opac 4. Use the accessibility tool to confirm the contrast ratio issues have been fixed 5. Check that the OPAC still looks ok after the changes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 13:54:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 11:54:36 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #4 from Katrin Fischer --- Hi Henry, thanks a lot for this! Especially for the tips on how to test. It was the first time for me using Chrome dev tools and the lighthouse audit tool. Lots of interesting things there. I noticed that there is another warn on the OPAC front page, that is only visible if you are logged in, have some checkouts and OPACUserSummary active. The "heading" of the summary table has bad contrast (grey script on grey background). Owen, would you mind having a look here too and give us your opinion? I also wonder if we could automate tests for accessibility using these kind of tools somehow. So we'd get a warn if the accessibility rate of a page drops after pushing a new feature or patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 13:55:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 11:55:29 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 --- Comment #5 from Katrin Fischer --- Ah, just a tip: if we do this for more pages, it might be good to file separate bugs for separate pages/elements to be changed and link it to this omnibus bug, instead of posting the bugs directly here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:01:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:01:28 +0000 Subject: [Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #14 from Katrin Fischer --- I believe it's a duplicate that goes a quite similar route - as the newer patches appear to be more current, complete and include unit tests, I am marking this one as the duplicate. *** This bug has been marked as a duplicate of bug 28554 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:01:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:01:28 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #13 from Katrin Fischer --- *** Bug 27565 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:10:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:10:18 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #14 from Katrin Fischer --- Also tested for translated item type descriptions. Note: you need to have at least one additional language installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:10:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:10:48 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:10:52 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123464|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 124209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124209&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:10:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:10:56 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123465|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 124210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124210&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:11:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:11:01 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123466|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 124211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124211&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:38:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:38:45 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Andrew, I tried to test this and it's well possible I misunderstood something, but I am stuck with: Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 121 I've triple checked the contents of my illview.inc and I just can't spot any error. Also did multiple restart_all, so Plack should not be the issue. Any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:42:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:42:37 +0000 Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|serial add is confused by |Serial add is confused by |authorized values with a |authorized values with a |code of '0' |code of '0' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 14:46:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 12:46:02 +0000 Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and punctuation in XSLT display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #17 from Katrin Fischer --- Thank you, Hayley! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:11:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:11:17 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:11:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:11:21 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124089|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 124212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124212&action=edit Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:11:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:11:26 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #6 from Katrin Fischer --- Created attachment 124213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124213&action=edit Bug 28898: (follow-up) Remove comment lines before PROCESS statements Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:11:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:11:30 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #7 from Katrin Fischer --- Created attachment 124214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124214&action=edit Bug 28898: (follow-up) Add context to some more occurrences of Term in course reserves Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:12:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:12:31 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #8 from Katrin Fischer --- Hi Caroline, I used to have to rename these with jQuery, so quite keen on these patches. I have found some more "Term:" in the course reserves templates, would you check my follow-up and maybe sign off on them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:34:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:34:27 +0000 Subject: [Koha-bugs] [Bug 28916] New: RecordStaffUserOnCheckout breaks table configuration of last column in checkout histories Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28916 Bug ID: 28916 Summary: RecordStaffUserOnCheckout breaks table configuration of last column in checkout histories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 23916 If RecordStaffUserOnCheckout is set to 'record' the last column on the checkout histories - available on the patron account in staff - available from the staff detail page can no longer be hidden using the "Columns" button. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 [Bug 23916] Issuer should be recorded and visible in patron circulation history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:34:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:34:27 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28916 [Bug 28916] RecordStaffUserOnCheckout breaks table configuration of last column in checkout histories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:35:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:35:25 +0000 Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28916 Summary|RecordStaffUserOnCheckout |RecordStaffUserOnCheckout |display a new column but |display a new column but |default sort column isn't |default sort column isn't |changed. |changed --- Comment #2 from Katrin Fischer --- I filed a new bug 28916 as there is another issue with table configuration on these pages concerning which columns can be hidden/toggled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:35:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:35:25 +0000 Subject: [Koha-bugs] [Bug 28916] RecordStaffUserOnCheckout breaks table configuration of last column in checkout histories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28891 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:36:14 +0000 Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:36:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:36:17 +0000 Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124020|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 124215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124215&action=edit Bug 28891: (bug 23916 follow up) Always use 'Checkout on' as default Checkout history sort column To test: 1 - Unset RecordStaffUserOnCheckout 2 - Check out an item 3 - Display Checkout history, table is sorted by 'Checkout on' column 4 - Set RecordStaffUserOnCheckout 5 - Display Checkout history, table is sorted by 'Renewed' column 6 - Apply patch 7 - Redo 1, 3, 4 and 5, table is always sorted by 'Checkout on' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:36:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:36:47 +0000 Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- Easy patch, setting to PQA directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:39:04 +0000 Subject: [Koha-bugs] [Bug 28917] New: Catalog tab on table settins is missing tables in "Jumpt to:" list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28917 Bug ID: 28917 Summary: Catalog tab on table settins is missing tables in "Jumpt to:" list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When you go to administration > table settings and look at the "Catalog" tab, you will notice that there is only one table listed in "Jump to", but there are multiple in the list. Also: Tab is labelled catalog, but list is headed with "Catalogue tables" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 15:39:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 13:39:15 +0000 Subject: [Koha-bugs] [Bug 28916] RecordStaffUserOnCheckout breaks table configuration of last column in checkout histories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 16:27:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 14:27:19 +0000 Subject: [Koha-bugs] [Bug 28800] Library list at /cgi-bin/koha/admin/branches.pl appears empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 --- Comment #17 from Manos PETRIDIS --- Could it have anything to do with https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 17:13:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 15:13:26 +0000 Subject: [Koha-bugs] [Bug 28915] MARC Modification Templates should allow specification of a position or range within a control field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 18:09:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 16:09:19 +0000 Subject: [Koha-bugs] [Bug 28917] Catalog tab on table settins is missing tables in "Jump to:" list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Catalog tab on table |Catalog tab on table |settins is missing tables |settins is missing tables |in "Jumpt to:" list |in "Jump to:" list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 19:18:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 17:18:40 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 28 19:18:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Aug 2021 17:18:44 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124196|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 124216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124216&action=edit Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:49:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:49:33 +0000 Subject: [Koha-bugs] [Bug 28902] Grey color should be on label for record metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:49:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:49:37 +0000 Subject: [Koha-bugs] [Bug 28902] Grey color should be on label for record metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124100|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 124217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124217&action=edit Bug 28902: Grey color on label for record metadata Actually looking at a record search or details, we see a black label (for example "Author:") and a grey metadata (for example "J.R.R Tolkien"). Seems bad for accessibility. In my opinion the most important to see is the metadata not the label. It is possible to change with a custom CSS but I open this report to propose to change default display. Test plan : 1) Apply patch and build CSS in OPAC and staff interface 2) Search for any record in OPAC/Staff interface 3) You see grey label and black metadata Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:50:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:50:48 +0000 Subject: [Koha-bugs] [Bug 28902] Grey color should be on label for record metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902 --- Comment #4 from Katrin Fischer --- I've used the Lighthouse audit in Google chrome (hints on bug 28188) to check if it would complain about the grey, but it does not. So I think we are good here and I like the idea of highlighting the more important information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:52:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:52:31 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:54:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:54:16 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:54:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:54:19 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124216|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 124218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124218&action=edit Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:54:43 +0000 Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #4 from Katrin Fischer --- I didn't dig deep, but I believe we already had agreed on that wording before and made changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 12:58:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 10:58:35 +0000 Subject: [Koha-bugs] [Bug 28893] Unused opac/rss directory can be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 --- Comment #3 from Katrin Fischer --- Doing some investigation here... does someone know what misc/rss is for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:00:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:00:49 +0000 Subject: [Koha-bugs] [Bug 28893] Unused opac/rss directory can be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:00:53 +0000 Subject: [Koha-bugs] [Bug 28893] Unused opac/rss directory can be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124088|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 124219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124219&action=edit Bug 28893: Remove unused opac/rss directory RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. Test plan: Confirm that this directory is useless and can be removed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:05:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:05:25 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 --- Comment #8 from Katrin Fischer --- I like :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:06:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:06:10 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:06:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:06:14 +0000 Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123986|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 124220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124220&action=edit Bug 28843: Add view and edit buttons to result of MARC record import This patch adds "View" and "Edit" buttons to the output of the result of a MARC record import. To test, apply the patch and go to Tools -> State MARC for import. - Import a file of MARC records. - Click the "Manage staged records" button. - In the table of staged records the last column labeled "Records" should be empty. - Click "Import this batch into the catalog." - The table of records will be shown again, and this time the last column should contain "View" and "Edit" buttons for each row. - Confirm that the buttons work correctly, opening the correct record for viewing and editing. Test with both bibliographic and authority records to confirm that the correct view and edit pages open for each. EDIT: Add permission check for "Edit" link Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:10:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:10:31 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 --- Comment #3 from Katrin Fischer --- I like that it preserves the line breaks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:11:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:11:23 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:11:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:11:27 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123455|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 124221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124221&action=edit Bug 28810: replace housebould detail inputs with textarea To test: 1. apply patch 2. enable housebound module 3. go to a patron and look at the housebound tab 4. Edit the detials. 5. The preferred materials, subjects, authors, referral, and note inputs should be replace with much larger textareas. 6. You should now be able to added line breaks, so fill out each of the fields adding some line breaks. I added something like: Fiction authors: Frank Herbert Non-fiction authors: Malcolm Gladwell 7. Save changes 8. Now when you look at the housebound details those line breaks should be preserved and much easier to read. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:28:12 +0000 Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Nice try, Nick, but you have been caught by the translation police ;) + [% id_column | html FILTER ucfirst %] not found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:34:39 +0000 Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 --- Comment #7 from Katrin Fischer --- This is only one of the lines I think are not good. Please make sure cardnumber or borrowernumber remain translatable throughout instead of using the variables to replace the text. Otherwise this looks pretty good to me. QA tools and tests pass. As translation length of strings may vary I think I'd like the text for the radio box after the radio box instead of below. It kind of looks strange to me that there are not center or beginning of the text now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 29 13:40:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Aug 2021 11:40:30 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- There are 2 fails here in the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt FAIL filters missing_filter at line 118 (