[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Tiny wording change suggestion, do you agree with the last patch?

2. You need a new method in Koha::CirculationRules to retrieve the effective
value of the new rule (have a look at 'sub get_effective_*')

3. 
-                        } else if ( i == 5 || i == 6 || i == 26 || i == 27 ||
i == 28 ) {
+                        } else if ( i == 5 || i == 6 || i == 17 || i == 27 ||
i == 28 || i == 29 ) {

I think there is something wrong here. Why did you remove 26? Do you understand
what this part of the code does? It's displaying "Unlimited" for integer
without value. But you want "use global/Default" to be displayed if the rule is
empty.
I am not sure we need this line to change.

4. (not blocker)
Not a bit deal but in tests you can use $builder->build_object instead of
->build, to return a Koha::Object-based object.

-- 
You are receiving this mail because:
You are watching all bug changes.