[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #34 from Andrew Nugged <nugged at gmail.com> ---
We tested once more with Petro: Nick's update works, so it's ok,

I was confused that we might overlap 0 in

    "$rule ? $rule->rule_value : C4::Context->preference..."

but we before "?" checking for RULE as _object_, not rule value (my confusion
:) ), so even if rule_value is 0, object anyway will be truth, so zero
returned, and logic works.

And in the "Default" case in rule, we store "undef", which leads to full rule
absence in DB, so again: checking for the rule as object fails and we falling
back to Default.

All ok with logic, yeah.

-- 
You are receiving this mail because:
You are watching all bug changes.