[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 6 11:49:09 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #39 from Andrew Nugged <nugged at gmail.com> ---
(In reply to Jonathan Druart from comment #38)
> +    return $expire_reserves_charge_rule ?
> $expire_reserves_charge_rule->rule_value :
> C4::Context->preference("ExpireReservesMaxPickUpDelayCharge");
> 
> Is this correct if the rule is "0"?

if the rule has 0 as a stored value but is found,
then $expire_reserves_charge_rule is the object,

in case we saving an empty line to form for that rule item,
it transfers undef to DBIC so even no record is created,
then there's not an object and all, "not found".

(same as I misled myself above, and figured out here:
 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711#c34 )

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list