[Koha-bugs] [Bug 27944] Add new stages to the article request process

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #45 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #18)
> Last question before I really let this go: Should we actually allow includes
> to do [% USE Biblio %] etc. or should we 'use' them already earlier in the
> process, in other words at the top of the template files that call them?

I tried removing the USE-es in biblio-view-menu.inc and this 'random' failure
showed on all files that used it (which I changed by adding the USE).

I noticed that the qa tools just try to load the template and I added a warn on
/usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm (which takes care of
loading those USE):

206             $ok = eval { require "$file.pm" };
207             use Data::Printer colored => 1;
208             p($@);

The errors show up randomly (it was all green the first run :-/) but this is
what $@ says:

Can't locate Koha/Template/Plugin/String.pm in @INC (you may need to install
the Koha::Template::Plugin::String module) (@INC contains: /kohadevbox/koha
/kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1
/usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/kohadevbox/koha_plugin) at
/usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206.

Can't locate Koha/Template/Plugin/JSON/Escape.pm in @INC (you may need to
install the Koha::Template::Plugin::JSON::Escape module) (@INC contains:
/kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1
/usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/kohadevbox/koha_plugin) at
/usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206.

=> This are upstream TT plugins that are looked up in the wrong place

Can't locate Template/Plugin/Biblio.pm in @INC (you may need to install the
Template::Plugin::Biblio module) (@INC contains: /kohadevbox/koha
/kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1
/usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/kohadevbox/koha_plugin) at
/usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206.

=> This is a Koha plugin that is looked up in the wrong place

Maybe a path problem baked into the QA tools? I don't think it is fair that
this issue blocks this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.