[Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #3)
> I'm confused.. I can't seem to get the unit test to fail.. but in real life
> testing it does fail without the fix.

The assignment on L413 should affect the call of GetPreparedLetter on L467.
But only when the notice actually uses data from aqbasket.

It seems to me that we should assign $basketno = $externalid right at the start
of the else block (L366) ?
Using one variable for different types of id's appears to be a bad idea ;)

-- 
You are receiving this mail because:
You are watching all bug changes.