[Koha-bugs] [Bug 28824] Errant variable declaration in C4::Letters

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #7)
> Even when I do:
> 
> -                'aqbasket'      => $basketno,
> +            #    'aqbasket'      => $basketno,
> 
> I still have the basket name in the test output?

Debugging Letters :)
The info is in the $repeat and is filled in when reaching the repeat no
enclosing tags block.

my vendor|John Smith|<<aqbasket.basketname>>|<order>Ordernumber
<<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>>
ordered)</order>my vendor|J
ohn Smith|Named basket|<order>Ordernumber 114 (Silence in the library) (1
ordered)</order>

In that block basketname is replaced. And not via $tables !

This essentially means that the second patch does nothing for the
orderacquistion notice.
The unit test shows that you can fill basketname via $repeat but actually has
no real added value.

FQA

-- 
You are receiving this mail because:
You are watching all bug changes.