[Koha-bugs] [Bug 27944] Add new stages to the article request process

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #48 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #47)
> (In reply to Marcel de Rooy from comment #46)
> >
> > But note also that Agustin still needs to respond to comment41. This is not
> > fixed yet.
> 
> It works for me.

Hmm. I guess you need to explain me :) Or read earlier comments more closely?

The staff interface tells me now Article requests: 1.
If I click on the link, I come in the New tab which lists no requests. The
Pending tab contains one request, Processing 2.

And now the code:
The template shows: <span class="pending-number-link">[%
pending_article_requests | html %]</span>
Hote that pending is not the correct term anymore. These should be New.
mainpage.pl contains:
my $pending_article_requests = Koha::ArticleRequests->search_limited(
    {
        status => Koha::ArticleRequest::Status::Pending,
        $branch ? ( 'me.branchcode' => $branch ) : (),
    }
)->count;
Again, dont be misled by the bad variable names here. We should refer to New.
Could you please explain how this produces the number of New requests on the
main page :) ?

-- 
You are receiving this mail because:
You are watching all bug changes.