[Koha-bugs] [Bug 28872] New: AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

            Bug ID: 28872
           Summary: AcquisitionLog, NewsLog, NoticesLog should use 1/0 for
                    their values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In system preferences, AcquisitionLog, NewsLog,  and NoticesLog are all saving
values of "on" and "off" when they should be "1" and "0."

That means if you change any of these prefs and save new values you end up with
errors on the About page:
Warning System preference 'AcquisitionLog' must be '0' or '1', but is 'on'.
Warning System preference 'NewsLog' must be '0' or '1', but is 'on'.
Warning System preference 'NoticesLog' must be '0' or '1', but is 'on'.

In a little preliminary testing, this seems to mean we default to ALWAYS
logging acquisitions actions, even if it's set to "Don't log." I didn't check
whether the other two are ending up on or off.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.