[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 20 12:40:39 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #1)
> Looks like we need an additional link between the 2 tables aqorders and
> suggestions to achieve that.
> 
> That would make sense, especially when looking at such code:
> 
>          SELECT suggestions.*,
>             U1.surname          AS surnamesuggestedby,
>             U1.firstname        AS firstnamesuggestedby,
>             U1.borrowernumber   AS borrnumsuggestedby
>         FROM suggestions
>             LEFT JOIN borrowers AS U1 ON suggestedby=U1.borrowernumber
>         WHERE biblionumber=?
>         LIMIT 1
> 
> in GetSuggestionInfoFromBiblionumber. It is wrong if there are several
> suggestions on the same bib.
> 
> Hard to know it won't break existing workflows however.

I agree - we should have a real link and not be guessing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list